e5e7221a2c8279fb383d9fc429fe4ee4789b7e41: Merge m-c to inbound.
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 17 May 2013 15:40:53 -0400 - rev 132282
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Merge m-c to inbound.
c3b24901a5184f9b26ae4fc5da1e037b9b17b143: Bug 869536 - Make Marionette use its own tab on Firefox, r=mdas
Jonathan Griffin <jgriffin@mozilla.com> - Fri, 17 May 2013 11:43:52 -0700 - rev 132281
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 869536 - Make Marionette use its own tab on Firefox, r=mdas
8ed13280c8116ed1b09ff4919b0987bf9cb8e9f4: Bug 872853 - Make +"0x" evaluate to NaN. r=evilpie
Jeff Walden <jwalden@mit.edu> - Thu, 16 May 2013 16:29:53 -0700 - rev 132280
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 872853 - Make +"0x" evaluate to NaN. r=evilpie
23741f85220a7a3dcce1c1ca65d44ae7ff2761a7: Bug 872853 - Move StringToNumberType into jsnum.cpp, now that it's not used anywhere else, and remove jsnuminlines.h. r=evilpie
Jeff Walden <jwalden@mit.edu> - Thu, 16 May 2013 16:17:05 -0700 - rev 132279
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 872853 - Move StringToNumberType into jsnum.cpp, now that it's not used anywhere else, and remove jsnuminlines.h. r=evilpie
23d6197df2dd64759dbd719c3c8182453393cbbb: Bug 649570 - |delete window.NaN| should be a TypeError. This got fixed...sometime. Add a a test so we don't regress this in the future. r=sparky
Jeff Walden <jwalden@mit.edu> - Tue, 14 May 2013 12:56:26 -0700 - rev 132278
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 649570 - |delete window.NaN| should be a TypeError. This got fixed...sometime. Add a a test so we don't regress this in the future. r=sparky
5c4392f60d581c4294d42aaff80887cb2b00828e: Bug 871857 - Only expose the Shell function getSelfHostedValue if MOZ_SELFHOSTEDJS is set. r=jwalden
Till Schneidereit <tschneidereit@gmail.com> - Thu, 16 May 2013 16:59:57 -0700 - rev 132277
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 871857 - Only expose the Shell function getSelfHostedValue if MOZ_SELFHOSTEDJS is set. r=jwalden
d14e9efe0b005c4b47234c12cd82e762eb17cb2f: Bug 848530 - Check for moz.build traversal at top of build; r=glandium
Gregory Szorc <gps@mozilla.com> - Fri, 17 May 2013 10:54:56 -0700 - rev 132276
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 848530 - Check for moz.build traversal at top of build; r=glandium One of the first actions an invoked Makefile now does is check to see if *any* moz.build file or Makefile.in is out of date. If so, config.status is executed to rebuild the build backend. Since we always perform this check as part of a build, we no longer need special handling for out of date moz.build files during traversals. This results in the removal of a significant amount of code! Another upside of the change is that if a moz.build file is modified during building, we don't (potentially) modify the build backend from under the in-progress build. Thus the only race condition that remains is if a moz.build is mutated during moz.build reading. This window (a few seconds) is significantly shorter than the time of a full build (minutes). This patch should also enable us to remove empty Makefile.in files without requiring a clobber.
4b3f1fe5c0971bfc6c13a5bd234b2a37896b0a0b: Bug 860957 - Support for invoking non-recursive targets during partial tree builds; r=glandium
Gregory Szorc <gps@mozilla.com> - Fri, 17 May 2013 10:54:53 -0700 - rev 132275
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860957 - Support for invoking non-recursive targets during partial tree builds; r=glandium
c98f7f0305a7c0d4984354779b4791be73003b88: Bug 872772 - Tests. r=gabor
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:44:25 -0700 - rev 132274
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 872772 - Tests. r=gabor
532f418b93516e1c9481991fe5b7bc71f78265f0: Bug 872772 - Fix up lost Xray waivers when wrapping into the content compartment. r=gabor
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:44:25 -0700 - rev 132273
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 872772 - Fix up lost Xray waivers when wrapping into the content compartment. r=gabor
341f9653ff921293c2dc3a38741c4f4fcd1f13b4: Bug 860941 - Remove assertion annotations for the now-removed mArguments assertion. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:20 -0700 - rev 132272
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Remove assertion annotations for the now-removed mArguments assertion. r=jst
017883faccbb8b6497ea585fd83ff21620de6931: Bug 860941 - Tests. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:20 -0700 - rev 132271
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Tests. r=jst We augment the existing showModalDialog tests with test coverage for dialogArguments and returnValue.
6bd149e8edfc61f64b7a66d6aafa799ee85038f5: Bug 860941 - Stop clearing return values on navigation. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:19 -0700 - rev 132270
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Stop clearing return values on navigation. r=jst Since this stuff is a property on the browsing context, this only makes sense as a security check. But now that we're using a DialogValueHolder, the origin checks are taken care of. So we can kill this off.
8634d3597ee8a9a14ce1d07789788cd0e3219e12: Bug 860941 - Use DialogValueHolder for returnValue. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:19 -0700 - rev 132269
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Use DialogValueHolder for returnValue. r=jst The spec currently has returnValue as a DOMString, but this doesn't match reality given my testing. I filed [1] to fix it. Note that nsGlobalModalWindow is already set up to CC mReturnValue. Since we're swapping in another CC-ed container class, we don't need to make any changes here. [1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=21771
af186224869402007bc54ad3aeeecdc0a9aa7fee: Bug 860941 - Make dialogArguments default to |undefined| rather than |null|. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:19 -0700 - rev 132268
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Make dialogArguments default to |undefined| rather than |null|. r=jst This is correct by my reading of the spec. Quoting: The dialogArguments IDL attribute, on getting, must check whether its browsing context's active document's origin is the same as the dialog arguments' origin. If it is, then the browsing context's dialog arguments must be returned unchanged. Otherwise, if the dialog arguments are an object, then the empty string must be returned, and if the dialog arguments are not an object, then the stringification of the dialog arguments must be returned.
e4c145a09a94b954af5f806f2bc3137472a3a121: Bug 860941 - Separate the handling of |dialogArguments| and |arguments|, and use IDL for the |dialogArguments| getter. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:19 -0700 - rev 132267
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Separate the handling of |dialogArguments| and |arguments|, and use IDL for the |dialogArguments| getter. r=jst This patch is bigger than I'd like it to be, but there are a lot of interlocked dependencies and I eventually decided it was easier to just lump it together. The semantics of |showModalDialog|/|window.dialogArguments| (an web-exposed HTML5 feature) and |openDialog|/|window.arguments| (a XUL-proprietary feature) are quite different. The former is essentially a security-checked JSVal, while the latter gets converted into an array. We handled them together in the old world, which led to a lot of confusion and muddled semantics. This patch separates them. This patch also eschews the roundabout resolve hook for dialogArguments in favor of returning them directly from the XPIDL getter. This better matches the behavior in the spec, especially because it allows dialogArguments to live on the outer as they're supposed to, rather than the first inner that happens to end up in the docshell. All in all, this should make this all very straightforward to convert WebIDL when the time comes. The current spec on the origin checks here is pretty fictional, so I've filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=21932 to fix it. This patch should more or less preserve the current security behavior.
688bd6e0dc3a4562a967f53c766a12a3d7ea11ca: Bug 860941 - Remove unnecessary argument cleanup in nsGlobalWindow::DetachFromDocShell. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:18 -0700 - rev 132266
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Remove unnecessary argument cleanup in nsGlobalWindow::DetachFromDocShell. r=jst This function proceeds to invoke CleanUp(), which also cleans this stuff up.
6f1c775378c36bab959ee318a0de0ea8698a9ba2: Bug 860941 - Clarify shutdown invariants in ~nsGlobalWindow. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:18 -0700 - rev 132265
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Clarify shutdown invariants in ~nsGlobalWindow. r=jst While the mArguments invariant should hold for _outers_, it doesn't necessarily hold for inners, so this assertion fires reliably in automation. If mCleanedUp is true then mArguments is definitely null, so let's disentangle this from mArguments and be clearer about the invariants we expect.
76ab368d6b5551a2be95152289cfed26309dde2d: Bug 860941 - Add an explicit flag to track modal content windows. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:18 -0700 - rev 132264
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Add an explicit flag to track modal content windows. r=jst Tracking this with CHROME_MODAL is problematic, because that gets inherited by any dependent windows opened by the modal content window, which may or may not be modal content windows themselves. Thankfully, we have a few free bits lying around.
7bcc1ec6fa87c79452835eacb57c113c542ac873: Bug 860941 - Remove mArgumentsLast. r=jst
Bobby Holley <bobbyholley@gmail.com> - Fri, 17 May 2013 10:43:18 -0700 - rev 132263
Push 24691 by ryanvm@gmail.com at Sat, 18 May 2013 01:41:18 +0000
Bug 860941 - Remove mArgumentsLast. r=jst I'm not sure what it used to do, but it sure doesn't do a damn thing now.
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip