e55f3b87bdf549863c2d6eddb63a1431eb35957b: Backed out changeset d2505c0f1c45 (bug 860941)
Ed Morley <emorley@mozilla.com> - Fri, 17 May 2013 09:08:33 +0100 - rev 132219
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Backed out changeset d2505c0f1c45 (bug 860941)
0cb5afba99886a8b5031e3440f4ff64bd74392d3: Backed out changeset 34c65a615373 (bug 860941)
Ed Morley <emorley@mozilla.com> - Fri, 17 May 2013 09:08:31 +0100 - rev 132218
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Backed out changeset 34c65a615373 (bug 860941)
ab40846d14462cec96f3c4167a523e44713ae2c7: Bug 872864 - Intermittent browser_net_simple-request-data.js | The requestHeaders attachment has an incorrect |headers| property. - Got 6, expected 7 | browser_net_simple-request-details.js | There should be 13 header values displayed in this tabpanel. etc, r=rcampbell
Victor Porof <vporof@mozilla.com> - Fri, 17 May 2013 10:59:04 +0300 - rev 132217
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 872864 - Intermittent browser_net_simple-request-data.js | The requestHeaders attachment has an incorrect |headers| property. - Got 6, expected 7 | browser_net_simple-request-details.js | There should be 13 header values displayed in this tabpanel. etc, r=rcampbell
571f038800a496024aa60e8c356ad72fa4c67cc1: Bug 872323 Ensure places is enabled in social tests now that they rely on places, so that apps which disable places by default have their tests passing. r=mixedpuppy
Mark Banner <bugzilla@standard8.plus.com> - Fri, 17 May 2013 09:51:36 +0200 - rev 132216
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 872323 Ensure places is enabled in social tests now that they rely on places, so that apps which disable places by default have their tests passing. r=mixedpuppy
34c65a6153733154a93b632cf07e81cba4d5df4c: Bug 860941 - Remove assertion annotations for the now-removed mArguments assertion. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:15 -0700 - rev 132215
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Remove assertion annotations for the now-removed mArguments assertion. r=jst
d2505c0f1c452d544f6c796575210362ad1ca2dd: Bug 860941 - Tests. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:15 -0700 - rev 132214
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Tests. r=jst We augment the existing showModalDialog tests with test coverage for dialogArguments and returnValue.
de30d8faf09ad20656e76a945b750c70a548e92f: Bug 860941 - Stop clearing return values on navigation. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:15 -0700 - rev 132213
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Stop clearing return values on navigation. r=jst Since this stuff is a property on the browsing context, this only makes sense as a security check. But now that we're using a DialogValueHolder, the origin checks are taken care of. So we can kill this off.
95006bb32743dc1b4552332a01d2d27bbac6e0ee: Bug 860941 - Use DialogValueHolder for returnValue. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:15 -0700 - rev 132212
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Use DialogValueHolder for returnValue. r=jst The spec currently has returnValue as a DOMString, but this doesn't match reality given my testing. I filed [1] to fix it. Note that nsGlobalModalWindow is already set up to CC mReturnValue. Since we're swapping in another CC-ed container class, we don't need to make any changes here. [1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=21771
90b318fb837541460f88fc164481fabbffe619d3: Bug 860941 - Make dialogArguments default to |undefined| rather than |null|. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:14 -0700 - rev 132211
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Make dialogArguments default to |undefined| rather than |null|. r=jst This is correct by my reading of the spec. Quoting: The dialogArguments IDL attribute, on getting, must check whether its browsing context's active document's origin is the same as the dialog arguments' origin. If it is, then the browsing context's dialog arguments must be returned unchanged. Otherwise, if the dialog arguments are an object, then the empty string must be returned, and if the dialog arguments are not an object, then the stringification of the dialog arguments must be returned.
0ad1a92ca5687dc738293d9ae56052ce23d83e6a: Bug 860941 - Separate the handling of |dialogArguments| and |arguments|, and use IDL for the |dialogArguments| getter. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:14 -0700 - rev 132210
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Separate the handling of |dialogArguments| and |arguments|, and use IDL for the |dialogArguments| getter. r=jst This patch is bigger than I'd like it to be, but there are a lot of interlocked dependencies and I eventually decided it was easier to just lump it together. The semantics of |showModalDialog|/|window.dialogArguments| (an web-exposed HTML5 feature) and |openDialog|/|window.arguments| (a XUL-proprietary feature) are quite different. The former is essentially a security-checked JSVal, while the latter gets converted into an array. We handled them together in the old world, which led to a lot of confusion and muddled semantics. This patch separates them. This patch also eschews the roundabout resolve hook for dialogArguments in favor of returning them directly from the XPIDL getter. This better matches the behavior in the spec, especially because it allows dialogArguments to live on the outer as they're supposed to, rather than the first inner that happens to end up in the docshell. All in all, this should make this all very straightforward to convert WebIDL when the time comes. The current spec on the origin checks here is pretty fictional, so I've filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=21932 to fix it. This patch should more or less preserve the current security behavior.
474792d1fb89fd7cb67f4ac1bdbae16262eafb44: Bug 860941 - Remove unnecessary argument cleanup in nsGlobalWindow::DetachFromDocShell. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:14 -0700 - rev 132209
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Remove unnecessary argument cleanup in nsGlobalWindow::DetachFromDocShell. r=jst This function proceeds to invoke CleanUp(), which also cleans this stuff up.
98594535c1e9898afa17df11144173f5acf3a4e3: Bug 860941 - Clarify shutdown invariants in ~nsGlobalWindow. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:14 -0700 - rev 132208
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Clarify shutdown invariants in ~nsGlobalWindow. r=jst While the mArguments invariant should hold for _outers_, it doesn't necessarily hold for inners, so this assertion fires reliably in automation. If mCleanedUp is true then mArguments is definitely null, so let's disentangle this from mArguments and be clearer about the invariants we expect.
c47a46c92dff6e9c468e6bd9d2e11be224424b96: Bug 860941 - Add an explicit flag to track modal content windows. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:13 -0700 - rev 132207
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Add an explicit flag to track modal content windows. r=jst Tracking this with CHROME_MODAL is problematic, because that gets inherited by any dependent windows opened by the modal content window, which may or may not be modal content windows themselves. Thankfully, we have a few free bits lying around.
70c3a3a743627e8b045b6151bc860ca70afb2a47: Bug 860941 - Remove mArgumentsLast. r=jst
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 May 2013 23:33:13 -0700 - rev 132206
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 860941 - Remove mArgumentsLast. r=jst I'm not sure what it used to do, but it sure doesn't do a damn thing now.
8d46dcc704d72f6970c4fef5efb966a644dfd92f: Bug 859966 - Switch linux builds to gcc 4.7.2. r=gps
Mike Hommey <mh+mozilla@glandium.org> - Fri, 17 May 2013 08:21:45 +0200 - rev 132205
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 859966 - Switch linux builds to gcc 4.7.2. r=gps
b05f7ab3c76a4094928ef104faeb1be2cd7fe533: Bug 861465 - Hide overlay buttons when showing app bars or in fullscreen mode. r=mbrubeck
Frank Yan <fyan@mozilla.com> - Thu, 16 May 2013 22:14:29 -0700 - rev 132204
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 861465 - Hide overlay buttons when showing app bars or in fullscreen mode. r=mbrubeck
693f3c772c0eacb34d5f48a0d97e8ae6c73ff970: Bug 873322 - need handy function for easy getText... testing, r=tbsaunde
Alexander Surkov <surkov.alexander@gmail.com> - Fri, 17 May 2013 15:08:27 +0900 - rev 132203
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 873322 - need handy function for easy getText... testing, r=tbsaunde
f92daaee04ec2091a9acffdf20fa26d782189e67: No bug - Fix indentation. r=trivial DONTBUILD
Benjamin Peterson <benjamin@python.org> - Fri, 17 May 2013 00:20:35 -0500 - rev 132202
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
No bug - Fix indentation. r=trivial DONTBUILD
5a7a5d48931db827559283409d351e4adefd1330: bug 839342. Make metro widget listen for EdgeGestureStarted and EdgeGestureCanceled, in addition to EdgeGestureCompleted. Show the edge UI on EdgeGestureStarted and EdgeGestureCompleted, hide it on EdgeGestureCanceled. This time without bustage! r=bbondy
Tim Abraldes <tabraldes@mozilla.com> - Thu, 16 May 2013 21:22:21 -0700 - rev 132201
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
bug 839342. Make metro widget listen for EdgeGestureStarted and EdgeGestureCanceled, in addition to EdgeGestureCompleted. Show the edge UI on EdgeGestureStarted and EdgeGestureCompleted, hide it on EdgeGestureCanceled. This time without bustage! r=bbondy
3a447f55a84899df08bd4268028291f6835cab12: Bug 872964 - wrong result for getTextBeforeOffset for start word boundary at text length offset, r=tbsaunde
Alexander Surkov <surkov.alexander@gmail.com> - Fri, 17 May 2013 13:06:13 +0900 - rev 132200
Push 24687 by ryanvm@gmail.com at Fri, 17 May 2013 16:44:48 +0000
Bug 872964 - wrong result for getTextBeforeOffset for start word boundary at text length offset, r=tbsaunde
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip