e35e048ef39639d5c5038ade352a12e2957bdf2e: Bug 1509301. Adding contact info to README.md r=ladybenko
Ola Gasidlo <ogasidlo@mozilla.com> - Mon, 26 Nov 2018 12:03:45 +0000 - rev 447963
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1509301. Adding contact info to README.md r=ladybenko Differential Revision: https://phabricator.services.mozilla.com/D12894
7bff5a02441019a61423d4038174e6514cf0c252: Bug 1509651 - Stop flushing style for knowing the UI direction. r=florian
Dão Gottwald <dao@mozilla.com> - Mon, 26 Nov 2018 11:59:04 +0000 - rev 447962
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1509651 - Stop flushing style for knowing the UI direction. r=florian Differential Revision: https://phabricator.services.mozilla.com/D12827
19f0f3b9cf1a589c9c7ed1074c0a513ddbdd9d9a: Bug 1509610 - Set default value for optional openParams parameter. r=Standard8
Dão Gottwald <dao@mozilla.com> - Mon, 26 Nov 2018 10:58:54 +0000 - rev 447961
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1509610 - Set default value for optional openParams parameter. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D12812
2ba86b9e4cc85efd75c3b22e4728135012930e39: Bug 1492810 - Display favicons in UrlbarView results. r=mak
Dão Gottwald <dao@mozilla.com> - Mon, 26 Nov 2018 10:23:50 +0000 - rev 447960
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1492810 - Display favicons in UrlbarView results. r=mak Differential Revision: https://phabricator.services.mozilla.com/D12811
6b3e2ddccf10962e9fdabec9c2dd0d8a9bcffab2: Bug 1509537 - Simplify JSOP_INITHOMEOBJECT, emit JSOP_DUPAT to put the home object on top of the stack. r=arai
Jan de Mooij <jdemooij@mozilla.com> - Mon, 26 Nov 2018 04:44:31 +0000 - rev 447959
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1509537 - Simplify JSOP_INITHOMEOBJECT, emit JSOP_DUPAT to put the home object on top of the stack. r=arai Differential Revision: https://phabricator.services.mozilla.com/D12777
367cea0a5b9f4b31c5ff497f36cfba484c52ebbd: Merge mozilla-central to autoland. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Mon, 26 Nov 2018 11:48:50 +0200 - rev 447958
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Merge mozilla-central to autoland. CLOSED TREE
8e88421b280c2afda62f4ba704ce29701c30549f: Bug 1506547 - Align user-select behavior more with other UAs. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Nov 2018 09:21:37 +0000 - rev 447957
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1506547 - Align user-select behavior more with other UAs. r=mats There's a few subtle behavior changes here, which I'll try to break down in the commit message. The biggest one is the EditableDescendantCount stuff going away. This was added in bug 1181130, to prevent clicking on the non-editable div from selecting the editable div inside. This is problematic for multiple reasons: * First, I don't think non-editable regions of an editable element should be user-select: all. * Second, it just doesn't work in Shadow DOM (the editable descendant count is not kept up-to-date when not in the uncomposed doc), so nested contenteditables behave differently inside vs. outside a Shadow Tree. * Third, I think it's user hostile to just entirely disable selection if you have a contenteditable descendant as a child of a user-select: all thing. WebKit behaves like this patch in the following test-case (though not Blink): https://crisal.io/tmp/user-select-all-contenteditable-descendant.html Edge doesn't seem to support user-select: all at all (no pun intended). But we don't allow to select anything at all which looks wrong. * Fourth, it's not tested at all (which explains how we broke it in Shadow DOM and not even notice...). In any case I've verified that this doesn't regress the editor from that bug. If this regresses anything we can fix it as outlined in the first bullet point above, which should also make us more compatible with other UAs in that test-case. The other change is `all` not overriding everything else. So, something like: <div style="-webkit-user-select: all">All <div style="-webkit-user-select: none">None</div></div> Totally ignores the -webkit-user-select: none declaration in Firefox before this change. This doesn't match any other UA nor the spec, and this patch aligns us with WebKit / Blink. This in turn makes us not need -moz-text anymore, whose only purpose was to avoid this. This also fixes a variety of bugs uncovered by the previous changes, like the SetIgnoreUserModify(false) call in editor being completely useless, since presShell->SetCaretEnabled ended in nsCaret::SetVisible, which overrode it. This in turn uncovered even more bugs, from bugs in the caret painting code, like not checking -moz-user-modify on the right frame if you're the last frame of a line, to even funnier bits where before this patch you show the caret but can't write at all... In any case, the new setup I came up with is that when you're editing (the selection is focused on an editable node) moving the caret forces it to end up in an editable node, thus jumping over non-editable ones. This has the nice effect of not completely disabling selection of -moz-user-select: all elements that have editable descendants (which was a very ad-hoc hack for bug 1181130, and somewhat broken per the above), and also not needing the -moz-user-select: all for non-editable bits in contenteditable.css at all. This also fixes issues with br-skipping like not being able to insert content in the following test-case: <div contenteditable="true"><span contenteditable="false">xyz </span><br>editable</div> If you start moving to the left from the second line, for example. I think this yields way better behavior in all the relevant test-cases from bug 1181130 / bug 1109968 / bug 1132768, shouldn't cause any regression, and the complexity is significantly reduced in some places. There's still some other broken bits that this patch doesn't fix, but I'll file follow-ups for those. Differential Revision: https://phabricator.services.mozilla.com/D12687
f17b7ba6d0aa737d4f69a0fc3206da8c539225e5: Bug 1505147 - nsWindow::OnKeyPressEvent() shouldn't dispatch eKeyDown event when IMContextWrapper::OnKeyEvent() has already dispatched it for the event r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Nov 2018 03:26:39 +0000 - rev 447956
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1505147 - nsWindow::OnKeyPressEvent() shouldn't dispatch eKeyDown event when IMContextWrapper::OnKeyEvent() has already dispatched it for the event r=m_kato Currently, IMContextWrapper::OnKeyEvent() assumes that IME won't synthesize keyboard event asynchronously again in some cases. For example, one of the cases is that user inputs text with a dead key sequence. However, IME may synthesize key event asynchronously only in a few cases even in a dead key sequence. Unfortunately, for not losing a chance to dispatch eKeyDown/eKeyUp event, we need to keep dispatching eKeyDown or eKeyUp event when we receive original event in dead key sequence. However, according to this bug, we need to stop dispatching eKeyDown and eKeyUp events when we receive unexpected async synthesized key event. If IMContextWrapper::OnKeyEvent() needs to return whether it (has already) dispatched an eKeyDown or eKeyUp and whether it was consumed, then, nsWindow can stop dispatching redundant eKeyDown and eKeyUp events. So, this patch makes IMContextWrapper::OnKeyEvent() return KeyHandlingState enum class instead of just a bool value to notify the caller of detail of the event status. And also makes each caller of nsWindow not dispatch eKeyDown nor eKeyUp event when it returns KeyHandlingState::eNotHandledButDispatched or KeyHandlingState::eNotHandledButConsumed. Differential Revision: https://phabricator.services.mozilla.com/D12517
a38ee229fe1b7ab29d3bce205b8c8611e4a8297e: Bug 1507708 - Add default values for aboutdebugging wifi and network features;r=ladybenko
Julian Descottes <jdescottes@mozilla.com> - Fri, 23 Nov 2018 16:51:12 +0000 - rev 447955
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1507708 - Add default values for aboutdebugging wifi and network features;r=ladybenko Differential Revision: https://phabricator.services.mozilla.com/D12444
e9588334915f1358fa47b9747f469285a3b52398: Bug 1380451 - create HTML table caption accessible unconditionally, r=Jamie
Marco Zehe <mzehe@mozilla.com> - Sun, 25 Nov 2018 23:39:52 +0000 - rev 447954
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1380451 - create HTML table caption accessible unconditionally, r=Jamie Creates the HTML Caption accessible from the markup map, but only if it's the first caption. Other caption elements are ignored as before. This also creates caption accessibles for those captions that have been collapsed to zero height and width via CSS. Differential Revision: https://phabricator.services.mozilla.com/D12756
fb45231e386d90110cdc7b93297e609e02c2b2a7: Bug 1497746 - part 6: Add static_assert for preventing TextEditor to grow up again r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Nov 2018 06:33:28 +0000 - rev 447953
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1497746 - part 6: Add static_assert for preventing TextEditor to grow up again r=m_kato TextEditor instance is created per <input> element which has text editor and <textarea> element. Therefore, we should keep TextEditor slim as far as possible. Currently, TextEditor class size is 400 bytes on Win64. So, we should keep 512 bytes border. Differential Revision: https://phabricator.services.mozilla.com/D12404
324232a1330c2a0661973d49f54ab5d29ca30a64: Bug 1497746 - part 5: Make EditorBase not reserve array for its listeners unless listeners are important r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Nov 2018 06:32:34 +0000 - rev 447952
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1497746 - part 5: Make EditorBase not reserve array for its listeners unless listeners are important r=m_kato A lot of listeners are now notified with RefPtr for concrete classes. Therefore, we can reduce size of arrays to listeners without damage for the performance. Differential Revision: https://phabricator.services.mozilla.com/D12403
ceb75e2e0421b36d6d9e680830902d4196e94717: Bug 1497746 - part 4: Move EditorBase::mRangeUpdater to AutoEditActionDataSetter r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Nov 2018 06:31:56 +0000 - rev 447951
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1497746 - part 4: Move EditorBase::mRangeUpdater to AutoEditActionDataSetter r=m_kato Similar to EditorBase::mSavedSel, we can move EditorBase::mRangeUpdater too because of it's referred only when there is AutoEditActionDataSetter instance so that it also does not need to be in the cycle collection. And now, it can be marked as MOZ_STACK_CLASS and remove cycle collection support. Differential Revision: https://phabricator.services.mozilla.com/D12402
465ebb044ee1494d7c2dca9ff04839cc45772b35: Bug 1497746 - part 3: Move EditorBase::mSavedSel into AutoEditActionDataSetter r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Nov 2018 06:31:13 +0000 - rev 447950
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1497746 - part 3: Move EditorBase::mSavedSel into AutoEditActionDataSetter r=m_kato EditorBase::mSavedSel is used only by EditorBase methods which are called only by AutoSelectionRestorer. Additionally, AutoSelectionRestorer requires AutoEditActionDataSetter instance. So, we don't need to keep create for editor instance anymore. And also we don't need to keep it in the cycle collection. Note that SelectionState class is also used by PlaceholderTransaction. Therefore, we cannot make it MOZ_STACK_CLASS. Differential Revision: https://phabricator.services.mozilla.com/D12401
097a6db494774ab5b7311e10e40bd2948009e46e: Bug 1497746 - part 2: Move EditorBase::mDirection to EditorBase::AutoEditActionDataSetter r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Nov 2018 06:30:29 +0000 - rev 447949
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1497746 - part 2: Move EditorBase::mDirection to EditorBase::AutoEditActionDataSetter r=m_kato EditorBase::mDirection is set and clear only when EditorBase::AutoEditActionDataSetter::SetTopLevelEditSubAction(). So, the direction is related to the top level edit sub action, and we can move it into AutoEditActionDataSetter. Note that except EditSubAction::eDeleteSelectedContent, the relation between sub-action and direction is fixed so that this patch checks the relation with MOZ_ASSERT. If we could replace EditSubAction::eDeleteSelectedContent with information of direction, we'd remove the new member of AutoEditActionDataSetter, though. Differential Revision: https://phabricator.services.mozilla.com/D12400
6c108d9038c36d16fb6424a27054454110df7489: Bug 1497746 - part 1: Move EditorBase::mTopLevelEditSubAction to EditorBase::AutoEditActionDataSetter r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Nov 2018 03:53:29 +0000 - rev 447948
Push 35100 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 16:16:10 +0000
Bug 1497746 - part 1: Move EditorBase::mTopLevelEditSubAction to EditorBase::AutoEditActionDataSetter r=m_kato EditorBase::mTopLevelEditSubAction is set only by EditorBase::OnStartToHandleTopLevelEditSubAction() and EditorBase::OnEndToHandleTopLevelEditSubAction() and they are called only by AutoTopLevelEditSubActionNotifier(). So, this is used only in stack when a public method of editor is called. Therefore, we can move it into EditorBase::AutoEditActionDataSetter. Then, we can reduce heap allocation for editor instances. Differential Revision: https://phabricator.services.mozilla.com/D12399
14ae1910a4f5dd1cdea7fcb4855a3aa86ed3731b: Merge inbound to mozilla-central. a=merge
Csoregi Natalia <ncsoregi@mozilla.com> - Mon, 26 Nov 2018 11:47:15 +0200 - rev 447947
Push 35099 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 09:47:34 +0000
Merge inbound to mozilla-central. a=merge
3214fd9390a0cf9e74599014d8c325ea1b7850fc: Bug 1490117 - Rollback WrEpoch if TransactionBuilder does not have ResourceUpdates in RecvEmptyTransaction() r=mattwoodrow
sotaro <sotaro.ikeda.g@gmail.com> - Mon, 26 Nov 2018 16:08:49 +0900 - rev 447946
Push 35099 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 09:47:34 +0000
Bug 1490117 - Rollback WrEpoch if TransactionBuilder does not have ResourceUpdates in RecvEmptyTransaction() r=mattwoodrow
6ee93495fe0c47bdad591490f9a4439cbcb09be5: Bug 1507051 - replace libyuv's README_MOZILLA with moz.yaml; r=jesup
byron jones <glob@mozilla.com> - Fri, 23 Nov 2018 13:00:07 +0000 - rev 447945
Push 35098 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 09:46:18 +0000
Bug 1507051 - replace libyuv's README_MOZILLA with moz.yaml; r=jesup Replace README_MOZILLA with moz.yaml, various fixups for update.py, and create a missing patch file from Bug 1491848. Differential Revision: https://phabricator.services.mozilla.com/D11891
c65a0f1862dd7cbd485b9ea44618155b85156486: Bug 1509227 - Cache selection state with RDL. r=miko
Matt Woodrow <mwoodrow@mozilla.com> - Sun, 25 Nov 2018 22:58:14 +0000 - rev 447944
Push 35098 by ncsoregi@mozilla.com at Mon, 26 Nov 2018 09:46:18 +0000
Bug 1509227 - Cache selection state with RDL. r=miko MozReview-Commit-ID: CmMDBlYzHyN Differential Revision: https://phabricator.services.mozilla.com/D12722
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip