e1242e04253e6969871f10c3e38bb6cd906b2587: Bug 1659589: Remove error event listener that set to stylesheet actor. r=ochameau
Daisuke Akatsuka <daisuke@birchill.co.jp> - Tue, 01 Sep 2020 01:44:28 +0000 - rev 547125
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1659589: Remove error event listener that set to stylesheet actor. r=ochameau Depends on D87047 Differential Revision: https://phabricator.services.mozilla.com/D88531
ad6708adb4cc62da41ae9374681c784e61c1ac9a: Bug 1659589: Implement update method in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 28 Aug 2020 06:27:53 +0000 - rev 547124
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1659589: Implement update method in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers Depends on D87046 Differential Revision: https://phabricator.services.mozilla.com/D87047
e8258610951f6983a786c18f53b509622e31f38f: Bug 1659589: Implement getText in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 28 Aug 2020 06:07:33 +0000 - rev 547123
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1659589: Implement getText in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers Depends on D87044 Differential Revision: https://phabricator.services.mozilla.com/D87045
bc075afd9fdf228987b0f628300a5536edd02561: Bug 1659589: Implement toggleDisabled in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 20 Aug 2020 08:27:47 +0000 - rev 547122
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1659589: Implement toggleDisabled in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers Depends on D87043 Differential Revision: https://phabricator.services.mozilla.com/D87044
bb7ec19eaf346a09e1e4a02abd15f74d6ea1f253: Backed out 20 changesets (bug 1646266) for bustages on TestBaseProfiler.cpp . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Tue, 01 Sep 2020 03:31:28 +0300 - rev 547121
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Backed out 20 changesets (bug 1646266) for bustages on TestBaseProfiler.cpp . CLOSED TREE Backed out changeset 0871a6eb61bb (bug 1646266) Backed out changeset c797da0d5b1b (bug 1646266) Backed out changeset 5e8954913748 (bug 1646266) Backed out changeset 9bc0276c9260 (bug 1646266) Backed out changeset fa6a89f9eba2 (bug 1646266) Backed out changeset 9a1cd7b6c1ca (bug 1646266) Backed out changeset d193a9f84702 (bug 1646266) Backed out changeset ecfc47fc2444 (bug 1646266) Backed out changeset 7ecc9ee961b6 (bug 1646266) Backed out changeset e482a2568f27 (bug 1646266) Backed out changeset 1a17cf6e6b4d (bug 1646266) Backed out changeset 08dd6220f0dd (bug 1646266) Backed out changeset 4189499ea599 (bug 1646266) Backed out changeset df82ad015f84 (bug 1646266) Backed out changeset 1c1501cfa02b (bug 1646266) Backed out changeset 9001175e7475 (bug 1646266) Backed out changeset c25cdf173894 (bug 1646266) Backed out changeset e01bc772d669 (bug 1646266) Backed out changeset 35166588a684 (bug 1646266) Backed out changeset f05f6a52bd7e (bug 1646266)
34ee0403ab1e8dbf3b7cc943a867113f0cefc69e: Bug 1661897 - Add a test. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 01 Sep 2020 00:05:31 +0000 - rev 547120
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1661897 - Add a test. r=botond The new promiseMouseDragEvent function is an async promise-returning copy of the code in dragVerticalScrollbar. Eventually we should just make all this code using async/promise but that's for another day. Differential Revision: https://phabricator.services.mozilla.com/D88894
f83db4b41bf63803df556db29598734457c798ad: Bug 1661897 - Acknowledge pending visual scroll updates for any RSF. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 31 Aug 2020 20:34:34 +0000 - rev 547119
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1661897 - Acknowledge pending visual scroll updates for any RSF. r=botond We set pending visual scroll updates even for RSFs that are on subdocuments, so we should ensure they get acknowledged and cleared on paints. Otherwise the pending visual scroll update can get "stuck" and it affects things that depend on it, such as the drag-selection code. Differential Revision: https://phabricator.services.mozilla.com/D88893
f4a3d1132b74178459d11e42bf7104a958b69964: Bug 1662145, make form interactable when switching to page range all and fix page count for invalid ranges r=mstriemer
Emma Malysz <emalysz@mozilla.com> - Mon, 31 Aug 2020 23:48:15 +0000 - rev 547118
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1662145, make form interactable when switching to page range all and fix page count for invalid ranges r=mstriemer Differential Revision: https://phabricator.services.mozilla.com/D88879
0871a6eb61bb56a2b8e4205ac841cc165f755ca8: Bug 1646266 - Profiler Markers 2.0 tests - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:36:11 +0000 - rev 547117
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - Profiler Markers 2.0 tests - r=gregtatum Differential Revision: https://phabricator.services.mozilla.com/D87260
c797da0d5b1b7d5298ba91dcb16fe11d4807167d: Bug 1646266 - {,Base}ProfilerMarkerTypes.h - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:35:05 +0000 - rev 547116
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - {,Base}ProfilerMarkerTypes.h - r=gregtatum This patch ports existing ProfilerMarkerPayload types to draft struct definitions that may be used with the new markers API. This is just a starting point, they may be changed later on as needed, see meta-bug 1661394. Differential Revision: https://phabricator.services.mozilla.com/D87259
5e8954913748bb4c7faf195a189dbb77783c6849: Bug 1646266 - {BASE_,}PROFILER_MARKER{,_TEXT} - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:34:33 +0000 - rev 547115
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - {BASE_,}PROFILER_MARKER{,_TEXT} - r=gregtatum This is the main public marker API: - `AddMarkerToBuffer` can be used to store a marker to any buffer. This could be useful to code that wants to store markers outside of the default profiler buffers. - `baseprofiler::AddMarker`/`profiler_add_marker` store a marker in the appropriate profiler buffer. - BASE_PROFILER_MARKER and PROFILER_MARKER do the same, but are also defined (and empty) when MOZ_GECKO_PROFILER is not #defined. All these take a name, marker options, a marker type, and the type's expected arguments if any (as expected by the `StreamJSONMarkerData` function). Extra helpers for the most common types: - BASE_PROFILER_MARKER_UNTYPED and PROFILER_MARKER_UNTYPED store a marker with no data payload. - BASE_PROFILER_MARKER_TEXT and PROFILER_MARKER_TEXT store a text marker. `baseprofiler::markers::Text` is an example of how new marker types can be defined. Differential Revision: https://phabricator.services.mozilla.com/D87257
9bc0276c9260026f009789b198c451280e393526: Bug 1646266 - AddMarkerToBuffer - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:34:11 +0000 - rev 547114
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - AddMarkerToBuffer - r=gregtatum Main marker serialization function, which accepts the same arguments (with implicit conversions) as the marker type's `StreamJSONMarkerData(JSONWriter&, ...)` function, and stores them in a ProfileChunkedBuffer after the marker name and options. Differential Revision: https://phabricator.services.mozilla.com/D87255
fa6a89f9eba29f51cc68edc593d4a1e8e1a0766b: Bug 1646266 - Marker Deserialization - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:33:53 +0000 - rev 547113
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - Marker Deserialization - r=gregtatum `DeserializeAfterKindAndStream()` is the main function that extracts all the marker data (past the already-read entry kind), and streams it to JSON using the user-provided `Stream(JSONWriter&, ...)` function in the appropriate marker type definition. It currently requires two external functions to stream the name and the optional backtrace, because these are different between the two profilers. This may change in the future. (Deserialization is implemented before serialization, because the `Deserialize()` function is needed during serialization to get a marker type tag.) Differential Revision: https://phabricator.services.mozilla.com/D87254
9a1cd7b6c1ca2767f93ee147f745d7772fbdd4aa: Bug 1646266 - ProfileBufferEntryKind::Marker - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:33:25 +0000 - rev 547112
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - ProfileBufferEntryKind::Marker - r=gregtatum A new entry kind is needed to serialize the new markers, because they are not encoded the same way. Differential Revision: https://phabricator.services.mozilla.com/D87253
d193a9f847025596f9c8f3457b71c42663252255: Bug 1646266 - NoPayload default type, with specialized empty helper - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:33:07 +0000 - rev 547111
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - NoPayload default type, with specialized empty helper - r=gregtatum `NoPayload` will be mostly used internally when adding markers without payload data. It has an empty specialization of the MarkerTypeHelper (mainly to catch misuses), and the add-marker code will need to have different compile-time paths to handle it. Differential Revision: https://phabricator.services.mozilla.com/D87252
ecfc47fc24441a61da4b64ad5720b14deee81a4d: Bug 1646266 - MarkerType::Stream function helpers - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:32:39 +0000 - rev 547110
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - MarkerType::Stream function helpers - r=gregtatum Marker types will be defined with a simple struct that contains (amongst other things) one `StreamJSONMarkerData(JSONWriter&, ...)` function. This patch introduces a type-traits-like helper to examine that function. This will be used to check the arguments given to the upcoming add-marker function, to serialize and deserialize them. Differential Revision: https://phabricator.services.mozilla.com/D87251
7ecc9ee961b6da3d4a42244f53674b432a2706a2: Bug 1646266 - Deserializers and Tags - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:32:22 +0000 - rev 547109
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - Deserializers and Tags - r=gregtatum This is similar to the existing deserializer table in ProfilerMarkerPayload.*: Each type of marker (except the `NoPayload` one) has its corresponding deserializer in a table, and the index is used as a tag in the serialization buffer. Differential Revision: https://phabricator.services.mozilla.com/D87250
e482a2568f27bcebd55d2eac9390d1275ca15f60: Bug 1646266 - MarkerOptions - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:31:59 +0000 - rev 547108
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - MarkerOptions - r=gregtatum A `MarkerOptions` must be constructed from a MarkerCategory, e.g.: `mozilla::baseprofiler::category::OTHER`. This will be required for all markers. `MarkerOptions` also contains defaulted `MarkerThreadId`, `MarkerTiming`, `MarkerStack`, and `MarkerInnerWindowId`. They may be set by calling `WithOptions()` on the MarkerCategory, e.g.: `PROFILER_MARKER<...>("name", OTHER.WithOptions(MarkerThreadId(otherThread), MarkerStack::Capture()), ...);` Differential Revision: https://phabricator.services.mozilla.com/D87249
1a17cf6e6b4dc8d09ea9dfad05f2afa676093a11: Bug 1646266 - Marker option: MarkerInnerWindowId - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:31:36 +0000 - rev 547107
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - Marker option: MarkerInnerWindowId - r=gregtatum This option can take an inner window id. Differential Revision: https://phabricator.services.mozilla.com/D87248
08dd6220f0dd2c36fe6f254bc19e04c2401d200d: Bug 1646266 - Marker option: MarkerStack - r=gregtatum
Gerald Squelart <gsquelart@mozilla.com> - Mon, 31 Aug 2020 23:31:18 +0000 - rev 547106
Push 37745 by btara@mozilla.com at Tue, 01 Sep 2020 09:45:42 +0000
Bug 1646266 - Marker option: MarkerStack - r=gregtatum This marker option allows three cases: - By default, no stacks are captured. - The caller can request a stack capture, and the add-marker code will take care of it in the most efficient way. - The caller can still provide an existing backtrace, for cases where a marker reports something that happened elsewhere. Differential Revision: https://phabricator.services.mozilla.com/D87247
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip