e0b049ff115f5d4a72c005127c26424c6753b277: Bug 1606447 - Initial landing for cloud replay, r=jlast.
Brian Hackett <bhackett1024@gmail.com> - Fri, 03 Jan 2020 15:57:15 +0000 - rev 508756
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1606447 - Initial landing for cloud replay, r=jlast. Differential Revision: https://phabricator.services.mozilla.com/D58444
d61646919205abae168cab482603ecb4ddbec2ab: Bug 1596766 - Followup, fix a missed instance in the SearchService of switching an array to a string for the locales change. r=daleharvey
Mark Banner <standard8@mozilla.com> - Fri, 03 Jan 2020 15:36:00 +0000 - rev 508755
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1596766 - Followup, fix a missed instance in the SearchService of switching an array to a string for the locales change. r=daleharvey Differential Revision: https://phabricator.services.mozilla.com/D58528
dc16892ca7526c768cf3716288f3fa232a92fc64: Bug 1605854 - Remove uneval/toSource from devtools tests. r=jlast
Tom Schuster <evilpies@gmail.com> - Fri, 03 Jan 2020 15:30:08 +0000 - rev 508754
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1605854 - Remove uneval/toSource from devtools tests. r=jlast For test browser_net_prefs-reload.js, I am not sure about this change firstValue/currentValue seems to be different types numbers, strings, objects. toString is maybe not the best way to compare those values. Differential Revision: https://phabricator.services.mozilla.com/D58313
bbf630f15308464d97bb992c881583d6301ae289: Bug 1605297 - disable browser_policyOverride.js for frequent failures. r=jmaher
Daniel Varga <dvarga@mozilla.com> - Wed, 01 Jan 2020 23:34:25 +0000 - rev 508753
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1605297 - disable browser_policyOverride.js for frequent failures. r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D58421
fdb7d4f7cacb1c22a97b59734d7fcd1fdf12c802: Backed out changeset 7da82c2eea17 (bug 1597488) for chrome failures at layout/xul/test/test_resizer.xhtml on a CLOSED TREE
Coroiu Cristina <ccoroiu@mozilla.com> - Fri, 03 Jan 2020 17:14:49 +0200 - rev 508752
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Backed out changeset 7da82c2eea17 (bug 1597488) for chrome failures at layout/xul/test/test_resizer.xhtml on a CLOSED TREE
048554c9449e103f296b6d66bb265ed370fd4d17: Bug 1605633 - Check if it's a dead wrapper in WeakRef constructor. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 03 Jan 2020 13:01:10 +0000 - rev 508751
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1605633 - Check if it's a dead wrapper in WeakRef constructor. r=jonco Throw error if the wrapped WeakRef is a dead wrapper. Differential Revision: https://phabricator.services.mozilla.com/D58522
2f1189b078103140585f6131fcc4335a12467e3d: bug 1606317: remote: revert "Disable Puppeteer tests in ignorehttpserrors.spec.js which crash the browser." r=remote-protocol-reviewers,whimboo
Andreas Tolfsen <ato@sny.no> - Fri, 03 Jan 2020 13:44:39 +0000 - rev 508750
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
bug 1606317: remote: revert "Disable Puppeteer tests in ignorehttpserrors.spec.js which crash the browser." r=remote-protocol-reviewers,whimboo This reverts the commit: git: d640ab64b993431099cd9205297bfff464d76927 hg: 9f6327c0d8298ec58a6c9f8d51526872d01d765e Differential Revision: https://phabricator.services.mozilla.com/D58503
021ae503f6dbee0ecf92e3729e4a61139b4fd778: bug 1606317: security: allow remote agent to disable security checks; r=keeler
Andreas Tolfsen <ato@sny.no> - Fri, 03 Jan 2020 13:46:00 +0000 - rev 508749
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
bug 1606317: security: allow remote agent to disable security checks; r=keeler The remote agent is an implementation of a subset of the Chromium Remote Debugging Protocol (CDP) for Gecko. For similar reasons as Marionette it needs the ability to call nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData(). It calls this method from remote/domains/parent/Security.jsm which implements the Security.setIgnoreCertificateErrors protocol method. The remote agent is slated to replace Marionette, but there is currently no timeline for this. Differential Revision: https://phabricator.services.mozilla.com/D58435
2cfc768072ca82aa3cf0f2100b4a12478063b3b6: bug 1606317: security: use nsIMarionette.running() for disable security check; r=keeler
Andreas Tolfsen <ato@sny.no> - Fri, 03 Jan 2020 13:46:38 +0000 - rev 508748
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
bug 1606317: security: use nsIMarionette.running() for disable security check; r=keeler It must only be possible to call nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData() when Marionette is actually active, but the MOZ_MARIONETTE environment variable can in theory be set by any user. MOZ_MARIONETTE was introduced to support in-application restarts so that the forked main process knows to re-initialise Marionette. This makes it approximately equivalent to passing the --marionette flag. Because Marionette can be started and stopped at runtime through modifying the marionette.enabled preference, and Marionette never resets MOZ_MARIONETTE, this makes it theoretically possible that a future caller could circumvent this security check. This is however not a security problem at present because the method is only ever called from within testing/marionette/cert.js, which itself is never called unless Marionette indeed is active. Still, it would be safer for this to use nsIMarionette.running() which returns true whenever the Marionette server is listening for connections, and false when the Marionette automation protocol is not enabled. Differential Revision: https://phabricator.services.mozilla.com/D58434
7da82c2eea17d0bef54e5db27f822174ccdb05c9: Bug 1597488 - Fix uses of nsResizerFrame::GetContentToResize in layout/xul/nsResizerFrame.cpp. r=emilio
Tetsuharu OHZEKI <tetsuharu.ohzeki@gmail.com> - Fri, 03 Jan 2020 13:45:46 +0000 - rev 508747
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1597488 - Fix uses of nsResizerFrame::GetContentToResize in layout/xul/nsResizerFrame.cpp. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D58483
84962125a899ae258104b0927890c301d2a367c4: Backed out changeset a1487e1518de (bug 1605854) for ESline failure in gecko/devtools/shared/transport/local-transport.js. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Fri, 03 Jan 2020 15:52:46 +0200 - rev 508746
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Backed out changeset a1487e1518de (bug 1605854) for ESline failure in gecko/devtools/shared/transport/local-transport.js. CLOSED TREE
a1487e1518de2c08551f391d11708e05866edfa8: Bug 1605854 - Remove uneval/toSource from devtools tests. r=jlast
Tom Schuster <evilpies@gmail.com> - Fri, 03 Jan 2020 13:08:26 +0000 - rev 508745
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Bug 1605854 - Remove uneval/toSource from devtools tests. r=jlast For test browser_net_prefs-reload.js, I am not sure about this change firstValue/currentValue seems to be different types numbers, strings, objects. toString is maybe not the best way to compare those values. Differential Revision: https://phabricator.services.mozilla.com/D58313
43bbf560ac63559ffd2bdf9aafe3a62df87dd55d: Backed out 3 changesets (bug 1606317) for build bustage at build/src/security/manager/ssl/nsCertOverrideService.cpp on a CLOSED TREE
Coroiu Cristina <ccoroiu@mozilla.com> - Fri, 03 Jan 2020 15:11:29 +0200 - rev 508744
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
Backed out 3 changesets (bug 1606317) for build bustage at build/src/security/manager/ssl/nsCertOverrideService.cpp on a CLOSED TREE Backed out changeset 9c34a0a40e62 (bug 1606317) Backed out changeset 467db2b310a7 (bug 1606317) Backed out changeset b12669c3ade7 (bug 1606317)
9c34a0a40e623f5d2f8937b7899c62e53d6a65cd: bug 1606317: remote: revert "Disable Puppeteer tests in ignorehttpserrors.spec.js which crash the browser." r=remote-protocol-reviewers,whimboo
Andreas Tolfsen <ato@sny.no> - Fri, 03 Jan 2020 10:16:13 +0000 - rev 508743
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
bug 1606317: remote: revert "Disable Puppeteer tests in ignorehttpserrors.spec.js which crash the browser." r=remote-protocol-reviewers,whimboo This reverts the commit: git: d640ab64b993431099cd9205297bfff464d76927 hg: 9f6327c0d8298ec58a6c9f8d51526872d01d765e Differential Revision: https://phabricator.services.mozilla.com/D58503
467db2b310a73567d69ebd73f5ff52b2dff0a6c8: bug 1606317: security: allow remote agent to disable security checks; r=keeler
Andreas Tolfsen <ato@sny.no> - Fri, 03 Jan 2020 10:16:48 +0000 - rev 508742
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
bug 1606317: security: allow remote agent to disable security checks; r=keeler The remote agent is an implementation of a subset of the Chromium Remote Debugging Protocol (CDP) for Gecko. For similar reasons as Marionette it needs the ability to call nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData(). It calls this method from remote/domains/parent/Security.jsm which implements the Security.setIgnoreCertificateErrors protocol method. The remote agent is slated to replace Marionette, but there is currently no timeline for this. Differential Revision: https://phabricator.services.mozilla.com/D58435
b12669c3ade7c888cdb05956c985ede85864effd: bug 1606317: security: use nsIMarionette.running() for disable security check; r=keeler
Andreas Tolfsen <ato@sny.no> - Fri, 03 Jan 2020 10:16:35 +0000 - rev 508741
Push 36978 by aiakab@mozilla.com at Sat, 04 Jan 2020 09:46:47 +0000
bug 1606317: security: use nsIMarionette.running() for disable security check; r=keeler It must only be possible to call nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData() when Marionette is actually active, but the MOZ_MARIONETTE environment variable can in theory be set by any user. MOZ_MARIONETTE was introduced to support in-application restarts so that the forked main process knows to re-initialise Marionette. This makes it approximately equivalent to passing the --marionette flag. Because Marionette can be started and stopped at runtime through modifying the marionette.enabled preference, and Marionette never resets MOZ_MARIONETTE, this makes it theoretically possible that a future caller could circumvent this security check. This is however not a security problem at present because the method is only ever called from within testing/marionette/cert.js, which itself is never called unless Marionette indeed is active. Still, it would be safer for this to use nsIMarionette.running() which returns true whenever the Marionette server is listening for connections, and false when the Marionette automation protocol is not enabled. Differential Revision: https://phabricator.services.mozilla.com/D58434
5fd4cfacc90ddd975c82ba27fdc56f4187b3f180: Bug 1606899 - Fix 'NameError: global name ...' error which regressed from Bug 1604749. r=tomprince a=releng DONTBUILD
Justin Wood <Callek@gmail.com> - Fri, 03 Jan 2020 22:06:19 +0200 - rev 508740
Push 36977 by apavel@mozilla.com at Fri, 03 Jan 2020 20:22:40 +0000
Bug 1606899 - Fix 'NameError: global name ...' error which regressed from Bug 1604749. r=tomprince a=releng DONTBUILD Differential Revision: https://phabricator.services.mozilla.com//D58646
1fd87ec46d80675d2a8b18b47029f53a28d43a38: Bug 1604482 - Fix TypeScript type error for gIsDarkMode r=gregtatum
Michael Hoffmann <brennan.brisad@gmail.com> - Fri, 03 Jan 2020 12:24:09 +0000 - rev 508739
Push 36976 by malexandru@mozilla.com at Fri, 03 Jan 2020 16:06:42 +0000
Bug 1604482 - Fix TypeScript type error for gIsDarkMode r=gregtatum Differential Revision: https://phabricator.services.mozilla.com/D57649
421a3f911d735003927de1511adbfca3bddf5075: Bug 1606787 - Exclude CSS files from Prettier configuration r=vporof
Julian Descottes <jdescottes@mozilla.com> - Fri, 03 Jan 2020 12:26:41 +0000 - rev 508738
Push 36976 by malexandru@mozilla.com at Fri, 03 Jan 2020 16:06:42 +0000
Bug 1606787 - Exclude CSS files from Prettier configuration r=vporof It seems that the recommended Prettier extension for VSCode automatically formats CSS. I guess this is also true for any editor extension that formats on save. However ./mach lint is not checking CSS formatting issues, and we have not auto-formatted CSS files in the tree. This can lead to unexpected formatting changes for developers using VSCode. Differential Revision: https://phabricator.services.mozilla.com/D58593
48295741798b373e2b0132b5c4873bd521a12961: Bug 1554913 - Remove eslint-disable-next-line complexity from _setupHarTimings r=Honza
Ksenia Berezina <kberezina@mozilla.com> - Fri, 03 Jan 2020 09:58:08 +0000 - rev 508737
Push 36976 by malexandru@mozilla.com at Fri, 03 Jan 2020 16:06:42 +0000
Bug 1554913 - Remove eslint-disable-next-line complexity from _setupHarTimings r=Honza Differential Revision: https://phabricator.services.mozilla.com/D57877
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip