e05e2482ca00a563642db9f21946f3e5144a3d28: Bug 1632123 - Fix browser_dbg-editor-mode.js and enable it r=jlast
Julian Descottes <jdescottes@mozilla.com> - Thu, 23 Apr 2020 06:40:48 +0000 - rev 525558
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1632123 - Fix browser_dbg-editor-mode.js and enable it r=jlast Differential Revision: https://phabricator.services.mozilla.com/D71931
6c6ffa908c06ddd48314ab276b9602e7822c9a7b: Bug 1607984 - P17. Put ParentProcessDocumentChannel behind a pref. r=necko-reviewers,mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 06:33:37 +0000 - rev 525557
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P17. Put ParentProcessDocumentChannel behind a pref. r=necko-reviewers,mattwoodrow We disable it for now, until some remaining failures are sorted out. Differential Revision: https://phabricator.services.mozilla.com/D71875
e973911e67e690485fa46775b1a019bf072bc9d1: Bug 1607984 - P16. Always whitelist file. r=markh
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 00:57:58 +0000 - rev 525556
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P16. Always whitelist file. r=markh This file will be removed in bug 1628752 anyway. Differential Revision: https://phabricator.services.mozilla.com/D70801
28af6418ac16fc60c3a680538dfa36156061c031: Bug 1607984 - P15. Wait for the load to start before setting the event handler. r=Jamie
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 00:58:02 +0000 - rev 525555
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P15. Wait for the load to start before setting the event handler. r=Jamie addA11yLoadEvent gets the contentWindow and wait for the document from that window to fire the load event. Enabling the DocumentChannel for parent process load (or here in non-e10s mode) we have one extra event loop before the load starts. So the window passed to addAllyLoadEvent would have been of the about:blank page. The current code was based on an observable behaviour which was that the load was occuring synchronously. DocumentChannel broke that assumption. Differential Revision: https://phabricator.services.mozilla.com/D70799
9a15a605f91a0d0993fc90880b5ed66c9683ff95: Bug 1607984 - P14. Fix test_bug1339722.html when using PPDC. r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 00:58:05 +0000 - rev 525554
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P14. Fix test_bug1339722.html when using PPDC. r=valentin When starting a load via the ParentProcessDocumentChannel, the event http-on-modify-request will be fired before the DocumentLoadListener has a chance to set the notificationCallback attribute. When using a DocumentChannel, this test will not trigger the expected codepath as the DOMWindowCreated event will be fired once the channel is fully up and running; which in effect is also a fix of the original bug 1339722 Instead we use the document-on-modify-request event when the DocumentChannel is enabled. Differential Revision: https://phabricator.services.mozilla.com/D70011
52566b3564ba8fe9de0aed2f30443765c2f85156: Bug 1607984 - P13. Proxy the first http-on-opening-request event to the DocumentChannel. r=mayhemer,necko-reviewers
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 00:58:07 +0000 - rev 525553
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P13. Proxy the first http-on-opening-request event to the DocumentChannel. r=mayhemer,necko-reviewers Some tests rely on this event to start action. The DocumentChannel had no equivalent. We make the ParentProcessDocumentChannel listen to this event and if it matches the nsIChannel currently in use in the DocumentLoadListener than we emit a similar document-on-modify-request event on the DocumentChannel. Differential Revision: https://phabricator.services.mozilla.com/D70010
142148a95181bf9fb6951fb309a0cfa15a613fe7: Bug 1607984 - P12. Start parent load via DocumentChannel. r=mayhemer,nika,mattwoodrow,necko-reviewers
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 03:29:22 +0000 - rev 525552
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P12. Start parent load via DocumentChannel. r=mayhemer,nika,mattwoodrow,necko-reviewers Add ParentProcessDocumentChannel object. This object is a DocumentChannel that will start a channel load from the parent process via a DocumentChannel. The aim of this task is two-fold. 1- Be consistent on how we handle redirects before continuing the load on the final channel. 2- Prepare to initiate a process switch when needed without having to go via an intermediary content process, saving a process switch. This task will be done in a follow-up task. The behaviour of the ParentProcessDocumentChannel is similar in logic to the DocumentChannelChild/DocumentChannelParent pair. The ParentProcessDocumentChannel sets up a DocumentLoadListener, have it handle the redirects and upon completion continue the load on the final channel. Differential Revision: https://phabricator.services.mozilla.com/D70009
108e2cb6b2a91b64fac5ad2001d2e5583d4b03f5: Bug 1607984 - P11. Don't assume the page will be loaded synchronously. r=zombie
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 00:58:09 +0000 - rev 525551
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P11. Don't assume the page will be loaded synchronously. r=zombie We must wait for the iframe created by extension1 to be fully loaded before we can attempt to send a message to it. So we send a message when it is ready, and suspend the execution until this message is received. Differential Revision: https://phabricator.services.mozilla.com/D70008
77fda525ee12880867cba6ba149be66125fef87b: Bug 1607984 - P10. Wait until OnStopRequest has been called to clear mRequest. ?valentin r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 00:57:40 +0000 - rev 525550
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P10. Wait until OnStopRequest has been called to clear mRequest. ?valentin r=valentin The code assumed that nsJARChannel::RetargetDeliveryTo would have been called synchronously from nsJARChannel::OnStartRequest, which would be true if we weren't using a DocumentChannel. The DocumentLoadListener queue the calls to OnStartRequest until the final redirect. nsJARChannel::RetargetDelivery mRequest member is be set to forward the call. So we need to only reset it once OnStopRequest has been received. Differential Revision: https://phabricator.services.mozilla.com/D70007
980067f3ac1d561434629a8e17f35395952fca67: Bug 1607984 - P9. Implement nsIThreadRetargetableStreamListener in ParentChannelListerner. r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 03:17:25 +0000 - rev 525549
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P9. Implement nsIThreadRetargetableStreamListener in ParentChannelListerner. r=valentin The DocumentLoadListener is setting up a ParentChannelListener to go in between the normal listener->channel chain. ParentChannelListener not implementing nsIThreadRetargetableStreamListener would prevent a nsHtml5StreamParser settings things up so that OnDataAvailable could be sent to a html parser thread off the main thread; improving performance. Differential Revision: https://phabricator.services.mozilla.com/D70006
12b82a39c91001f30d449667069977869c7af7f3: Bug 1607984 - P7. Fix compilation failure in non-unified mode. r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 03:17:12 +0000 - rev 525548
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P7. Fix compilation failure in non-unified mode. r=valentin Differential Revision: https://phabricator.services.mozilla.com/D70004
7657023a763b43809a5c62830b9d8c34c33a6418: Bug 1607984 - P6. Fix test. r=MattN
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 00:57:47 +0000 - rev 525547
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P6. Fix test. r=MattN Following the changes to DocumentChannel the test was failing. With DC, a load may take a few event loops to start. This current test was only waiting for the load to start to the URL about:preferences#privacy-logins and would immediately tear down the window. However, this URL redirects to about:preferences#privacy ; destroying the window midway could cause XML parsing error. So now we wait for the page to fully load, and make sure we've been through both addresses. Differential Revision: https://phabricator.services.mozilla.com/D70003
1ab8758802a6aa0aa3beea9cb7423c381f44f23d: Bug 1607984 - P5. Add missing nsIIdentChannel interface. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 03:16:50 +0000 - rev 525546
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P5. Add missing nsIIdentChannel interface. r=mattwoodrow Regressiong from bug 1607987. This prevented from QueryInterface(Ci.nsIIdentChannel) in JS on the channel. Differential Revision: https://phabricator.services.mozilla.com/D70002
35f22d0817e18feb6e025ce7cb22690e168665e5: Bug 1607984 - P4. Expose SetClassificationFlagsHelper. r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 00:57:49 +0000 - rev 525545
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P4. Expose SetClassificationFlagsHelper. r=valentin Differential Revision: https://phabricator.services.mozilla.com/D70001
b8c6277207d8455afc7b12ee426266a9f17a7364: Bug 1607984 - P3. Fix leak in nsDSURIContentListener. r=smaug
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 00:57:53 +0000 - rev 525544
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P3. Fix leak in nsDSURIContentListener. r=smaug If we were to open the window to close it immediately; we would leak a nsHtml5Parser object. Differential Revision: https://phabricator.services.mozilla.com/D70000
244d3cb006be5e9a953df7b760926f2e0be78baa: Bug 1607984 - P2. Add Redirects/LastVisitInfo getters. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 03:15:26 +0000 - rev 525543
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P2. Add Redirects/LastVisitInfo getters. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D69999
9fc1a237829c1f6784bfdea8c675d16065c69121: Bug 1607984 - P1. Make SerializeRedirectData const. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 Apr 2020 03:15:19 +0000 - rev 525542
Push 37341 by cbrindusan@mozilla.com at Thu, 23 Apr 2020 21:43:09 +0000
Bug 1607984 - P1. Make SerializeRedirectData const. r=mattwoodrow This also removes the need to call SerializeRedirectData to set mRedirectChannelId to the proper value and register the channel. Differential Revision: https://phabricator.services.mozilla.com/D69998
03626342f6e659ac6699a21e30423e2267c1971f: Backed out changeset 779722364805 (bug 1628583) per request a=backout
Noemi Erli <nerli@mozilla.com> - Thu, 23 Apr 2020 17:54:42 +0300 - rev 525541
Push 37340 by nerli@mozilla.com at Thu, 23 Apr 2020 14:55:59 +0000
Backed out changeset 779722364805 (bug 1628583) per request a=backout
47426d145e246fa1924fbda83a8ecb0d25a6f606: Bug 1631713 - Align the maximum memory usage of worklets on workers. r=karlt
Paul Adenot <paul@paul.cx> - Thu, 23 Apr 2020 05:17:04 +0000 - rev 525540
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1631713 - Align the maximum memory usage of worklets on workers. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D71966
73607b44ad6b837ba2de1f4d01fa26b86d81cda0: Bug 1629078 part 2: Make date/time inputs labellable by an ancestor HTML label and expose text-input-type attribute. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 23 Apr 2020 04:48:53 +0000 - rev 525539
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1629078 part 2: Make date/time inputs labellable by an ancestor HTML label and expose text-input-type attribute. r=MarcoZ In order for a form control to be labelled by an ancestor HTML label, its Accessible must return true for isWidget(). Also, HTML AAM says the text-input-type attribute should be exposed. Differential Revision: https://phabricator.services.mozilla.com/D72080
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip