dea9f3038c4d1cad37ac5d9908dbaef42fabecf2: Bug 1321384 - add debuggin assert for Accessible::RemoveChild, r=yzen
Alexander Surkov <surkov.alexander@gmail.com> - Thu, 09 Mar 2017 14:55:54 -0500 - rev 346834
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1321384 - add debuggin assert for Accessible::RemoveChild, r=yzen
ea659450b0dace878800077ba5e40c779535837b: Bug 1345237. Propagate uint32_t deeper into the editor state and text control frame code. r=mystor
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:45 -0500 - rev 346833
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1345237. Propagate uint32_t deeper into the editor state and text control frame code. r=mystor MozReview-Commit-ID: KeUo8My6eBJ
b81ec733e5c2df285e18825368567628ab16fccb: Bug 1345606. setRangeText should mark the text control as dirty. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:36 -0500 - rev 346832
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1345606. setRangeText should mark the text control as dirty. r=ehsan MozReview-Commit-ID: 9le2PoelGei
32e54e6e8c02282fd25debaa4a6cdc296095b515: Bug 1343275 part 2. Use slightly faster APIs for getting the information we want out of a selection when converting it to a text-control selection range. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:17 -0500 - rev 346831
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343275 part 2. Use slightly faster APIs for getting the information we want out of a selection when converting it to a text-control selection range. r=ehsan MozReview-Commit-ID: 6NRoWNqb1pC
6fc55ce02ba5b3d0be98f98b5e788b5586782ca0: Bug 1343275 part 1. Get selection faster in some nsTextEditorState methods. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:10 -0500 - rev 346830
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343275 part 1. Get selection faster in some nsTextEditorState methods. r=ehsan MozReview-Commit-ID: 2v0r3jtua1O
45f9d9f472224dfec18e42061a18552d11be2d2b: Bug 1343037 part 19. Add some tests. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:06 -0500 - rev 346829
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 19. Add some tests. r=ehsan MozReview-Commit-ID: L7LNF2Bfwgk
77c26865ce8ecff1e5d5f60c7fc25ae506ad335f: Bug 1343037 part 18. Implement nsTextEditorState::SetRangeText. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:06 -0500 - rev 346828
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 18. Implement nsTextEditorState::SetRangeText. r=ehsan MozReview-Commit-ID: FEo9yv5iu6U
4c4ec6e6b1683b941423b465fb22a1a66b6fcddf: Bug 1343037 part 17. Remove the now-unused nsITextControlElement::GetSelectionRange. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:06 -0500 - rev 346827
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 17. Remove the now-unused nsITextControlElement::GetSelectionRange. r=ehsan This makes GetSelectionRange non-virtual on HTMLInputElement and HTMLTextareaElement. MozReview-Commit-ID: HhmTHjw8AwW
1d0da4f3c82bcc6a0eeda2c67bbc514d40608821: Bug 1343037 part 16. Implement a version of nsTextEditorState::SetSelectionRange that takes a string for the direction. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:06 -0500 - rev 346826
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 16. Implement a version of nsTextEditorState::SetSelectionRange that takes a string for the direction. r=ehsan MozReview-Commit-ID: E8zYAWolg94
67d29abbbd53a60e0340ec751ced61a397684229: Bug 1343037 part 15. Implement nsTextEditorState::GetSelectionDirection. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:06 -0500 - rev 346825
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 15. Implement nsTextEditorState::GetSelectionDirection. r=ehsan MozReview-Commit-ID: 1bLLYhjmlff
a6833ad9712f8c132d06ed84979405bb7878f884: Bug 1343037 part 14. Implement nsTextEditorState::SetSelectionDirection. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:06 -0500 - rev 346824
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 14. Implement nsTextEditorState::SetSelectionDirection. r=ehsan This introduces two behavior changes: 1) In cached mode, we used to treat unknown selection directions as "none". Now we treat it like "forward", consistently with the "have an editor" mode. 2) Before this change, in cached mode, we did not fire "select" events on selectionDirection changes. MozReview-Commit-ID: 4nBCAm3mAiz
202a7b464808096e788ea3729ff63212f278ee46: Bug 1343037 part 13. Implement nsTextEditorState::SetSelectionEnd. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:05 -0500 - rev 346823
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 13. Implement nsTextEditorState::SetSelectionEnd. r=ehsan This introduces three behavior changes: 1) Before this change, in cached mode, we did not enforce the "start <= end" invariant. 2) Before this change, in cached mode, we did not fire "select" events on selectionEnd changes. 3) Changes the IDL type of HTMLInputElement's selectionEnd attribute to "unsigned long" to match the spec and HTMLTextareaElement. MozReview-Commit-ID: J3Gkhr8VnbS
271e63cd7bfade02da5760265fd54be3139abc50: Bug 1343037 part 12. Implement nsTextEditorState::SetSelectionStart. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:05 -0500 - rev 346822
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 12. Implement nsTextEditorState::SetSelectionStart. r=ehsan This introduces three behavior changes: 1) Before this change, in cached mode, we did not enforce the "start <= end" invariant. 2) Before this change, in cached mode, we did not fire "select" events on selectionStart changes. 3) Changes the IDL type of HTMLInputElement's selectionStart attribute to "unsigned long" to match the spec and HTMLTextareaElement. MozReview-Commit-ID: JM9XXMMPUHM
77c3b36269a4f9848ebfc43db4446cfb3bb93e5b: Bug 1343037 part 11. Implement a SetSelectionRange function on nsTextEditorState. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:05 -0500 - rev 346821
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 11. Implement a SetSelectionRange function on nsTextEditorState. r=ehsan MozReview-Commit-ID: 5xUkcnkptwQ
73198c9c3975dd4a292edd1849a4682e57302e4c: Bug 1343037 part 10. Remove the unused SetSelectionStart/SetSelectionEnd bits on text control frame. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:05 -0500 - rev 346820
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 10. Remove the unused SetSelectionStart/SetSelectionEnd bits on text control frame. r=ehsan MozReview-Commit-ID: G7ODMdAjzxV
5fc2e304113b49b08c2027ac066a34c1d604713c: Bug 1343037 part 9. Simplify the setup around the editor state's GetSelectionDirection function. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:05 -0500 - rev 346819
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 9. Simplify the setup around the editor state's GetSelectionDirection function. r=ehsan Really, there are only two cases we need to worry about. Either IsSelectionCached(), and then our SelectionProperties has the data we want, or not and then we have a non-null mSelCon which has the data we want. MozReview-Commit-ID: AEW9D1zG6sM
b7de9c9c1c31917e36a39fc96fc639d0dd6593af: Bug 1343037 part 8. Get rid of nsIDOMHTMLInputElement's selectionDirection attribute. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:04 -0500 - rev 346818
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 8. Get rid of nsIDOMHTMLInputElement's selectionDirection attribute. r=ehsan MozReview-Commit-ID: FNn4vVCM50s
08b01e3c03f8abeceb1c1fe61b98acee8bb33539: Bug 1343037 part 7. Get rid of nsIDOMHTMLTextareaElement's selectionDirection attribute. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:04 -0500 - rev 346817
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 7. Get rid of nsIDOMHTMLTextareaElement's selectionDirection attribute. r=ehsan MozReview-Commit-ID: EQWxjgTdloR
de068e5a963b8acbed83ac0e0b0824b4d8cbfccc: Bug 1343037 part 6. Simplify the setup around the editor state's GetSelectionRange function. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:04 -0500 - rev 346816
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 6. Simplify the setup around the editor state's GetSelectionRange function. r=ehsan Really, there are only two cases we need to worry about. Either IsSelectionCached(), and then our SelectionProperties has the data we want, or not and then we have a non-null mSelCon which has the data we want. Since we are now using cached selection state a lot more (instead of initializing the editor whenever someone asks for selection state), we need to actually update it more correctly when .value is set. And since we now update the cached selection state for the case when .value has been set (to point to the end of the text), we need to change HTMLInputElement::HasCachedSelection to return false for that case. Otherwise we will always do eager editor init on value set. We handle that by not doing eager init if the cached selection is collapsed. The web platform test changes test the "update on .value set" behavior. They fail without this patch, pass with it. MozReview-Commit-ID: DDU8U4MGb23
23164576aaf5a22dbece9742236abca36ed74079: Bug 1343037 part 5. Make <textarea> behave more like <input type=text> in terms of reset behavior. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 09 Mar 2017 14:44:04 -0500 - rev 346815
Push 31479 by kwierso@gmail.com at Fri, 10 Mar 2017 00:33:39 +0000
Bug 1343037 part 5. Make <textarea> behave more like <input type=text> in terms of reset behavior. r=ehsan In particular this ensures that our ValueChanged() is correctly set to false when we call SetValue() on our editor state with our default value. We will be relying on this very shortly. MozReview-Commit-ID: AIIIHwfQPQE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip