d9543f62a0f3dd632d7242ff8546783f1765e63b: Bug 1416106 - Part 13: Remove extra margin-bottom. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Thu, 15 Feb 2018 13:29:21 +0900 - rev 403929
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 13: Remove extra margin-bottom. r=gl MozReview-Commit-ID: 4NjZ9HKegX1
481dab8f36707756c83796d53ce9ece126202e64: Bug 1416106 - Part 12: Add tests. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Thu, 15 Feb 2018 13:29:12 +0900 - rev 403928
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 12: Add tests. r=gl MozReview-Commit-ID: 6kYdxqwPeKF
d717511990c418ad5bb5df663ffe12295163cfc6: Bug 1416106 - Part 11: Implement keyframe markers. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:13 +0900 - rev 403927
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 11: Implement keyframe markers. r=gl MozReview-Commit-ID: 2hN43aFN9Da
f20d1625e15bd501a5e36a85f9b30544ae35114a: Bug 1416106 - Part 10: Implement easing hit. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:13 +0900 - rev 403926
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 10: Implement easing hit. r=gl MozReview-Commit-ID: 5d6f1dysdxm
5df3265bb6097c870156423561b9d85598e3e83b: Bug 1416106 - Part 9: Set styles to graph. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:13 +0900 - rev 403925
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 9: Set styles to graph. r=gl MozReview-Commit-ID: J44bKeKxdZN
0070a351a4a4512adfe1dc1d68daad620ce63dc1: Bug 1416106 - Part 8: Implement discrete graph. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:13 +0900 - rev 403924
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 8: Implement discrete graph. r=gl MozReview-Commit-ID: HxPLpQTQTiS
b1365cf5d62ba82520e20be02b10d4152c6c04e1: Bug 1416106 - Part 7: Implement color graph. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:12 +0900 - rev 403923
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 7: Implement color graph. r=gl MozReview-Commit-ID: 4ek6LXtsmKc
729b7060c1e7f111e2282c41dc7a89d3ca4b59d2: Bug 1416106 - Part 6: Implement distance graph. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:12 +0900 - rev 403922
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 6: Implement distance graph. r=gl MozReview-Commit-ID: Hlws41Ex7jj
3f449e2f4ef19d2021331354eff65f86e723a3ee: Bug 1416106 - Part 5: Implement base of keyframes graph. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:12 +0900 - rev 403921
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 5: Implement base of keyframes graph. r=gl MozReview-Commit-ID: FpTZvREM35Y
3801cbab320d71ab651a7299b1d198559f31716d: Bug 1416106 - Part 4: Add test for property name component. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:12 +0900 - rev 403920
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 4: Add test for property name component. r=gl MozReview-Commit-ID: En70sbOhcsr
8e8ce20893411b98c784b3b33a64aa7b6f25acb1: Bug 1416106 - Part 3: Implement compositor warning. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:11 +0900 - rev 403919
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 3: Implement compositor warning. r=gl MozReview-Commit-ID: 18qQ1FydML4
1a0183c9ee732d99e1f056a33e121ba891455e18: Bug 1416106 - Part 2: Implement compositor sign to property name. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:11 +0900 - rev 403918
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 2: Implement compositor sign to property name. r=gl MozReview-Commit-ID: v7c6rt6vpl
5371c9a632fc6be31a6e0869e0a78ae4551bbc77: Bug 1416106 - Part 1: Implement base of property name. r=gl
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 14 Feb 2018 23:18:11 +0900 - rev 403917
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1416106 - Part 1: Implement base of property name. r=gl MozReview-Commit-ID: GSPIZG31RhB
37910654ac3141968bbd39d864fdb6d8fb7a6e86: Bug 1435060 - Allow keyword bookmark as search query; r=JanH
Snowrries <allentung5@gmail.com> - Wed, 14 Feb 2018 03:07:13 -0500 - rev 403916
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1435060 - Allow keyword bookmark as search query; r=JanH Function queryExists added to StringUtils to check if a given URL allows for arguments. Tests for said function added to TestStringUtils. Function loadUrlOrKeywordSearch in BrowserApp.java updated to also pass the entire entered string along regardless of whether or not the first words are keyword bookmarks iff there is additional text after the keyword bookmark, and the keyword bookmark does not accept any input arguments MozReview-Commit-ID: 2eyi5Botd3F
117cd9ec7414392ccc3f46ff0a3e2bb217c85316: Bug 1438427 - Fix wrong change from bug 1412722 in RedBlackTree::Remove. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Thu, 15 Feb 2018 14:38:52 +0900 - rev 403915
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1438427 - Fix wrong change from bug 1412722 in RedBlackTree::Remove. r=njn Before bug 1412722, which removed the sentinels, the code looked like: if (rbp_r_c->Right()->Left()->IsBlack()) { At that point in the code, rbp_r_c is the root node of the tree. If rbp_r_c->Right() was the sentinel, ->Right()->Left() would be the sentinel too, and the sentinel is black. Which means the condition would be true. The code after was: if (rbp_r_c->Right() && (!rbp_r_c->Right()->Left() || rbp_r_c->Right()->Left()->IsBlack())) { The second half correctly deals with the case of rbp_r_c->Right()->Left() being the sentinel. But the first half now makes things different: ->Right() being null would correspond to the previous case where it was the sentinel, and the test would not return true in that case when it would have before. When ->Right() is not null, things are normal again. The correct check is to make the branch taken when ->Right() is null. Now, looking under which conditions we may get in that branch wrongly: - The root node's right link must be empty, which means a very small tree. - The comparison between the removed key and the root node must indicate the key is greater than the value of the root node. - There's another case where the comparison result (rbp_r_cmp) can be eGreater, when it is reassigned under one of the branches under the eEqual test, and that branch is only taken when ->Right() on the root node was non-null, which was the non-broken case. So it would seem we can't reach that code when rbp_r_c->Right() is null anyways, so it /should/ practically make no difference. Better safe than sorry, though. It's hard to tell anything from crash stats, because since the templatization in bug 1403444, all crashes fit in one bucket, when there used to be 5 functions before :( While here, add a missing include in rb.h.
8592fd84fc79597063b8ea3b19af8f8528bd02b8: Bug 1429803 - Fix test; r=ochameau
Jan Odvarko <odvarko@gmail.com> - Wed, 14 Feb 2018 18:41:36 +0100 - rev 403914
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1429803 - Fix test; r=ochameau MozReview-Commit-ID: 5O2N7xsMzyh
83a578a1c62dd990167d555e25c17ebe9a722956: Bug 1429803 - Properly populate response header columns; r=rickychien
Jan Odvarko <odvarko@gmail.com> - Thu, 18 Jan 2018 14:55:58 +0100 - rev 403913
Push 33446 by nerli@mozilla.com at Thu, 15 Feb 2018 19:28:20 +0000
Bug 1429803 - Properly populate response header columns; r=rickychien MozReview-Commit-ID: 3FS6QtUS8yB
9b69cc60e5848f2f8802c911fd00771b50eed41f: Merge mozilla-inbound to mozilla-central a=merge
Andreea Pavel <apavel@mozilla.com> - Thu, 15 Feb 2018 12:24:21 +0200 - rev 403912
Push 33445 by apavel@mozilla.com at Thu, 15 Feb 2018 10:27:00 +0000
Merge mozilla-inbound to mozilla-central a=merge
e0ac728caeaa88cddaf54f0bd0936587158151f3: Bug 1428443 - allow panels to override picker functionality when they are active. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 14 Feb 2018 23:55:18 -0500 - rev 403911
Push 33445 by apavel@mozilla.com at Thu, 15 Feb 2018 10:27:00 +0000
Bug 1428443 - allow panels to override picker functionality when they are active. r=pbro MozReview-Commit-ID: 6VE4Y8FYfoN
1980472ad0854bda24d089bcc32d92df0a579c4c: Bug 1438088 - Store a Pref* in each hash table slot instead of a Pref. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Feb 2018 16:30:13 +1100 - rev 403910
Push 33445 by apavel@mozilla.com at Thu, 15 Feb 2018 10:27:00 +0000
Bug 1438088 - Store a Pref* in each hash table slot instead of a Pref. r=erahm. This has two advantages. First, it reduces memory usage, as per the following calculation. 64-bit: - Old sizes: - sizeof(Pref) = 32 - New sizes: - sizeof(PrefEntry) = 16 - sizeof(Pref) = 32 - Change: - -16 per empty slot in the hash table - +16 per used slot - A win if less than half the table slots are used 32-bit - Old sizes: - sizeof(Pref) = 20 - New sizes: - sizeof(PrefEntry) = 8 - sizeof(Pref) = 16 - Change: - -12 per empty slot in the hash table - +4 per used slot in the hash table - A win if table is < 75% full Table size: - The table is currently less than half full: ~3100 used out of 8192 slots. - The table is always <= 75% full, because that's the max load factor (for non-gigantic tables). - Therefore it's a win for both cases. Old sizes, chrome process, 64-bit: > 718,712 B (00.36%) -- preferences > +--262,176 B (00.13%) -- hash-table > +--197,384 B (00.10%) -- callbacks > +--114,688 B (00.06%) -- pref-name-arena > +---92,240 B (00.05%) -- root-branches > +---30,456 B (00.02%) -- string-values > +---21,688 B (00.01%) -- cache-data > +-------80 B (00.00%) -- misc New sizes, chrome process, 64-bit: > 672,568 B (00.41%) -- preferences > +--181,160 B (00.11%) -- callbacks > +--131,104 B (00.08%) -- hash-table # smaller > +--114,688 B (00.07%) -- pref-name-arena > +--101,152 B (00.06%) -- pref-values # new > +---92,240 B (00.06%) -- root-branches > +---30,456 B (00.02%) -- string-values > +---21,688 B (00.01%) -- cache-data > +-------80 B (00.00%) -- misc Old sizes, smallest content process, 64-bit: > 500,712 B (02.89%) -- preferences > +--262,176 B (01.51%) -- hash-table > +--114,688 B (00.66%) -- pref-name-arena > +---62,520 B (00.36%) -- callbacks > +---30,456 B (00.18%) -- string-values > +---17,832 B (00.10%) -- cache-data > +---12,960 B (00.07%) -- root-branches > +-------80 B (00.00%) -- misc New sizes, smallest content process, 64-bit: > 470,792 B (02.70%) -- preferences > +--131,104 B (00.75%) -- hash-table # smaller > +--114,688 B (00.66%) -- pref-name-arena > +--101,152 B (00.58%) -- pref-values # new > +---62,520 B (00.36%) -- callbacks > +---30,456 B (00.17%) -- string-values > +---17,832 B (00.10%) -- cache-data > +---12,960 B (00.07%) -- root-branches > +-------80 B (00.00%) -- misc The "hash-table" values drop by more than the size of the new "pref-values" value. On 64-bit, this reduces memory usage per process by 30--40 KB. On 32-bit, the number is slightly more. The second major advantage of this change is flexibility -- it opens up the possibility of different Pref objects being stored in different way. For example, static Prefs could be stared statically, letting them be shared between processes so long as they don't change (see bug 1437168). MozReview-Commit-ID: KmgbJaoOQ1J
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip