d85096f5d781172cb059ee707838778a2e08bab1: Bug 1027448 - Fix building gfxSurfaceRefCountTest.cpp with system cairo. r=mshal
Mike Hommey <mh+mozilla@glandium.org> - Fri, 20 Jun 2014 17:32:41 +0900 - rev 189750
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1027448 - Fix building gfxSurfaceRefCountTest.cpp with system cairo. r=mshal
2e2d182304f63f2878acab727909ce676bd6a988: Bug 1027440 - Build test plugins when building with --enable-default-toolkit=cairo-gtk3. r=mshal
Mike Hommey <mh+mozilla@glandium.org> - Fri, 20 Jun 2014 17:32:16 +0900 - rev 189749
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1027440 - Build test plugins when building with --enable-default-toolkit=cairo-gtk3. r=mshal
c55157c6286c088c52847cd4f0da48ed120659dc: Bug 1027000 - Allow binary compatibility with libpixman versions between 0.19.2 and 0.25.2 when building against system libpixman. r=jrmuizel
Mike Hommey <mh+mozilla@glandium.org> - Fri, 20 Jun 2014 17:31:58 +0900 - rev 189748
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1027000 - Allow binary compatibility with libpixman versions between 0.19.2 and 0.25.2 when building against system libpixman. r=jrmuizel
c6d2e1d54476790943b5d65c89466c3a0338ac19: Bug 1027645 - Eliminate all nsRenderingContext::AppUnitsPerDevPixel() callers and all non-propagating nsRenderingContext::DeviceContext() callers. r=roc
Jonathan Watt <jwatt@jwatt.org> - Fri, 20 Jun 2014 07:42:30 +0100 - rev 189747
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1027645 - Eliminate all nsRenderingContext::AppUnitsPerDevPixel() callers and all non-propagating nsRenderingContext::DeviceContext() callers. r=roc
55620c684232c453e299d64a4e2d3103c2f0f858: Bug 1026986 Allow to build InstallX11ErrorHandler() at building Qt-build r=karlt
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 20 Jun 2014 14:41:32 +0900 - rev 189746
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1026986 Allow to build InstallX11ErrorHandler() at building Qt-build r=karlt
80a5c49abbc647066b46c9bbb3cebff0420218e8: bug 1019744 - make ICU symbols hidden when compiling ICU as static libraries r=glandium
Trevor Saunders <trev.saunders@gmail.com> - Mon, 16 Jun 2014 16:23:10 -0400 - rev 189745
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
bug 1019744 - make ICU symbols hidden when compiling ICU as static libraries r=glandium
d004e867f67a8d21bf8a700de5e26bd4ebd25256: Bug 977831. Store layer event regions on thebes layer data in appunits relative to the reference frame until we finalize the thebes layer and then convert to layer coordinates. r=roc
Timothy Nikkel <tnikkel@gmail.com> - Thu, 19 Jun 2014 22:56:36 -0500 - rev 189744
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 977831. Store layer event regions on thebes layer data in appunits relative to the reference frame until we finalize the thebes layer and then convert to layer coordinates. r=roc Event regions weren't in a workable state prior to this. They were already stored relative to the reference frame, but in layer pixels. Inside inactive layer managers the scale is always 1 regardless of the scale on the containing thebes layer (which is the scale it will actually be drawn at), and so the event regions did not take into account scale in this situation. Storing the regions in appunits relative to the reference frame means we can just transform to the new reference frame (if it is different) when passing event regions up and out of inactive layer managers. The proper scale will be applied when we apply the event regions to the layer.
2c21b94a7775a22821ebcaf205fa6ef2c07b3598: Bug 961346 - Fix FTP date parsing of midnight for DOS format. r=mcmanus
Kevin Locke <kevin@kevinlocke.name> - Fri, 20 Jun 2014 12:44:41 +0900 - rev 189743
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 961346 - Fix FTP date parsing of midnight for DOS format. r=mcmanus
ab404d8e7d88972908a0ecc8670db51952064479: Bug 1025709 part 13 - Simplify ComputeSuitableScaleForAnimation; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:26 +0900 - rev 189742
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 13 - Simplify ComputeSuitableScaleForAnimation; r=heycam Now that animations and transitions are largely treated alike, we can remove some redundant code in the processing of transform animations in ComputeSuitableScaleForAnimation.
8cc5818e3f83fa380ca8f2e07e497e718e09d14b: Bug 1025709 part 12 - Remove ElementTransitions; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:26 +0900 - rev 189741
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 12 - Remove ElementTransitions; r=heycam This patch replaces all references to ElementTransitions (now that it is empty) with references to the base class, CommonElementAnimationData. It also takes the opportunity to tidy up some of the call sites in nsLayoutUtils since they no longer need to differentiate between animations and transitions.
3af866f895f2a3c9cb59522eed4724158e5641bd: Bug 1025709 part 11 - Make ElementPropertyTransition::ValuePortionFor reuse GetComputedTimingAt; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:26 +0900 - rev 189740
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 11 - Make ElementPropertyTransition::ValuePortionFor reuse GetComputedTimingAt; r=heycam In order to remove redundant code and generally make transitions less special, this patch reworks ValuePortionFor to reuse the existing code for calculation the fractional distance of within the animation interval.
b0b2c12fd058cf45c517642e14fb7bc10f7e74ca: Bug 1025709 part 10 - Move active layer notification out of CanPerformOnCompositorThread to call sites; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:26 +0900 - rev 189739
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 10 - Move active layer notification out of CanPerformOnCompositorThread to call sites; r=heycam A previous patch moved CanPerformOnCompositorThread to CommonElementAnimationData including a FIXME saying that active layer notification should happen at call sites. Now that the code for GetAnimationsForCompositor is common, we can do the active layer notification there.
a4c6f7cb5fe4d445e52d35056452b6f5de363ce4: Bug 1025709 part 9 - Move heavy lifting of GetAnimationsForCompositor from ElementAnimations/ElementTransitions to base class; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:25 +0900 - rev 189738
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 9 - Move heavy lifting of GetAnimationsForCompositor from ElementAnimations/ElementTransitions to base class; r=heycam This patch still leaves ElementAnimations| ElementTransitions::GetAnimationsForCompositor as shortcuts for the method now defined on CommonElementAnimationData.
f34e89ebac60b3c73ca1d9e339e59cc250f967e2: Bug 1025709 part 8 - Move CanPerformOnCompositorThread from ElementAnimations/ElementTransitions to the base class; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:25 +0900 - rev 189737
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 8 - Move CanPerformOnCompositorThread from ElementAnimations/ElementTransitions to the base class; r=heycam
d045b05628df6dd61c2df9a34a30b1e4f2df3c6a: Bug 1025709 part 7 - Move HasAnimationOfProperty from ElementAnimations/ElementTransitions to base class; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:25 +0900 - rev 189736
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 7 - Move HasAnimationOfProperty from ElementAnimations/ElementTransitions to base class; r=heycam This patch moves HasAnimationOfProperty to CommonElementAnimationData. It also takes the chance to start removing some redundancy from nsLayoutUtils / ActiveLayerTracker. Some of this should never have been added in the first place and some could have been removed earlier on but while we're fixing up HasAnimationOfProperty it seems like an appropriate time to fix up its call sites too. Also, since HasAnimationOrTransition actually returns an object, not a bool, we this patch renames it to GetAnimationsOrTransitions.
dde79ba0a596e88c2bf7fee125cdda1a72e5bd27: Bug 1025709 part 6 - Reuse nsAnimationManager::EnsureStyleRuleFor; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:25 +0900 - rev 189735
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 6 - Reuse nsAnimationManager::EnsureStyleRuleFor; r=heycam In a number of places in nsAnimationManager we have the following sequence of calls: CommonElementAnimationData::EnsureStyleRuleFor ElementAnimations::GetEventsAt nsAnimationManager::CheckNeedsRefresh nsAnimationManager::EnsureStyleRuleFor already does exactly that so we should just reuse it. At the same time we rename EnsureStyleRuleFor to UpdateStyleAndEvents since that's a bit more accurate. It's also confusing to have two methods of the same name (but on different objects) that don't exactly correspond in terms of the scope of what they do.
8434b5e208d6c08c3faa15fea510b1b7be8d8c06: Bug 1025709 part 5 - Replace aIsThrottled bool value with an enum; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:25 +0900 - rev 189734
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 5 - Replace aIsThrottled bool value with an enum; r=heycam
31695984cfe220b6634272397fa869e0136168cd: Bug 1025709 part 4 - Move EnsureStyleRuleFor from ElementTransitions and ElementAnimations to CommonElementAnimationData; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:24 +0900 - rev 189733
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 4 - Move EnsureStyleRuleFor from ElementTransitions and ElementAnimations to CommonElementAnimationData; r=heycam Both ElementAnimations and ElementTransitions have an EnsureStyleRuleFor method. The ElementAnimations version is a more general of the ElementTransitions one with the exception that the ElementTransitions version checks for finished transitions. This patch moves the code from ElementAnimations to CommonElementAnimationData with one minor change: adding the checks for finished transitions. The ElementTransitions version is removed. Since the ElementAnimations version contains a second parameter, aIsThrottled, callers of ElementTransitions must include this extra parameter. In a subsequent patch we add an enum for this parameter to make call sites easier to read. The ElementAnimations version also sets the mNeedsRefreshes member so at the same time we move mNeedsRefreshes to CommonElementAnimationData. Furthermore, since the ElementAnimations version which we have adopted returns early if mNeedsRefreshes is false, this patch ensures that when we call EnsureStyleRuleFor from ElementTransitions::WalkTransitionRule, we set mNeedsRefreshes to true first. Another difference to account for is that the ElementTransitions version of EnsureStyleRuleFor *always* sets mStyleRule (even if it doesn't add anything to it) where as the ElementAnimations version only creates the rule when necessary so we need to add a check to ElementTransitions::WalkTransitionRule that mStyleRule is actually set before using it.
2d45653b217d8ec39634202c53a83fe000f1b775: Bug 1025709 part 3 - Move delay calculation to GetComputedTimingAt; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:24 +0900 - rev 189732
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 3 - Move delay calculation to GetComputedTimingAt; r=heycam Now that an animation's delay is part of AnimationTiming--the struct we pass to GetComputedTimingAt--it makes sense to act on it in GetComputedTimingAt. This also happens to bring the procedures here closer to the algorithm definitions in Web Animations. As part of this refactoring, this patch converts ElementAnimation::IsRunningAt to use GetComputedTiming since the previous approach no longer works now that GetLocalTimeAt (nee ElapsedDurationAt) no longer handles delays. This also removes duplicated logic. Also, previously ElapsedDurationAt would assert if called on a finished transition since TimeDuration's - operator wouldn't like the null mStartTime. This patch adds an assertion for this case to GetLocalTimeAt to ease debugging.
458a988940c65bbb1e025c56af23446d6cf6dd96: Bug 1025709 part 2 - Add IsFinished() to ElementAnimation; r=heycam
Brian Birtles <birtles@gmail.com> - Fri, 20 Jun 2014 12:39:24 +0900 - rev 189731
Push 26994 by emorley@mozilla.com at Fri, 20 Jun 2014 16:42:33 +0000
Bug 1025709 part 2 - Add IsFinished() to ElementAnimation; r=heycam One of the main differences in handling a list of transitions vs a list of regular animations is that when we are dealing with a list of transitions we need to check for transitions that have finished and are about to be discarded but need to be retained temporarily to provide correct triggering of subsequent transitions. Such transitions are marked as "removed sentinels" and are ignored for most operations. This patch moves the methods for setting and checking such transitions to the base class ElementAnimation so that we can treat animations and transitions alike without having to downcast or do obscure checks for mStartTime.IsNull() (which equates to checking if the animation is a "removed sentinel" but is not particularly clear). In the process, this patch renames said methods to Is/SetFinishedTransition since hopefully that is a little easier to understand at a glance.
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip