d54f0df5ec70179bbed7ae2aac1b164c21224cf6: Bug 1616174 - Do not create unnecessary compositor window r=nical
sotaro <sotaro.ikeda.g@gmail.com> - Tue, 18 Feb 2020 09:39:23 +0000 - rev 514376
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1616174 - Do not create unnecessary compositor window r=nical compositor window is not necessary for BasicCompositor. Differential Revision: https://phabricator.services.mozilla.com/D63129
1e00af5facbe250e8bb09bce26ec29b39d655fa1: Bug 1543331 - Add a null check before calling mHostResolver->FlushCache() r=dragana
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 17 Feb 2020 22:20:12 +0000 - rev 514375
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1543331 - Add a null check before calling mHostResolver->FlushCache() r=dragana frame #5 of report https://crash-stats.mozilla.org/report/index/4dca6cb1-8d45-4bf5-8836-216810200217 This crash was rather obvious in retrospect, but I missed it because I was looking at the wrong thing. We're not actually crashing in FlushCache, instead mHostResolver is null in nsDNSService::Observe What made it obvious is frame #5 of report https://crash-stats.mozilla.org/report/index/4dca6cb1-8d45-4bf5-8836-216810200217 Included here because crash reports expire: ``` 1 libxul.so nsHostResolver::FlushCache(bool) netwerk/dns/nsHostResolver.cpp:740 2 libxul.so nsDNSService::Observe(nsISupports*, char const*, char16_t const*) netwerk/dns/nsDNSService2.cpp:1132 3 libxul.so nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*) xpcom/ds/nsObserverList.cpp:66 4 libxul.so nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) xpcom/ds/nsObserverService.cpp:295 5 libxul.so DecreasePrivateDocShellCount() docshell/base/nsDocShell.cpp:306 6 libxul.so nsDocShell::Destroy() docshell/base/nsDocShell.cpp:5076 ``` See the code points to this line: https://hg.mozilla.org/releases/mozilla-esr68/annotate/ef373efc995d9350a676c4c231b344d173423e8a/docshell/base/nsDocShell.cpp#l306 As we can see, it emits the "last-pb-context-exited" notification, and nsDNSService tries to call FlushCache. However, it appears this notification may be called after we get the shutdown notification and we null out the pointer. It's unclear why this crash was not noticed before bug 1450893 landed. Depends on D63107 Differential Revision: https://phabricator.services.mozilla.com/D63108
9fbafe41107ef0055c90d02ad7d6d8fdae08749e: Bug 1543331 - clang-format nsDNSService2.cpp r=dragana
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 17 Feb 2020 22:20:55 +0000 - rev 514374
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1543331 - clang-format nsDNSService2.cpp r=dragana Differential Revision: https://phabricator.services.mozilla.com/D63107
eaf48f8ba83ff25e9933aa325b842b0da0845bdc: Bug 1611374 - Disallow nested `Document.execCommand()` calls in Nightly and early Beta r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Sat, 15 Feb 2020 19:17:00 +0000 - rev 514373
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1611374 - Disallow nested `Document.execCommand()` calls in Nightly and early Beta r=smaug Chrome does not allow nested `Document.execCommand()` calls: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/editing/commands/document_exec_command.cc;l=75;drc=301e5d079a1b4c29c5b17574d0470e6db7370acc On the other hand, Safari (and Firefox) allows it. However, it's worthwhile to follow Chrome's behavior. This patch makes `Document::ExecCommand()` return `false` when it's called while running another `Document::ExecCommand()` call on Nightly and early Beta. This is exactly same behavior, and we should watch broken web apps reports for a while before riding this on the train. And this patch sets the pref to `true` when all crash tests under `editor/libeditor/crashtests` which depend on nested calls of `execCommand` run since same things may be reproducible with other DOM APIs. Differential Revision: https://phabricator.services.mozilla.com/D62815
79cc8a9b30e8343205ac0f58f35446509ac6b287: Bug 1591908 - Limit websocket tooltips r=Honza
vtsty.dev <vtsty.dev@gmail.com> - Tue, 18 Feb 2020 10:44:00 +0000 - rev 514372
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1591908 - Limit websocket tooltips r=Honza Differential Revision: https://phabricator.services.mozilla.com/D62876
474d1f64d11af7d878d6654f7a07b26dbf0b7b46: Bug 1616172 - Remove encoding when printing diff in Fluent migration tests r=Pike
Francesco Lodolo (:flod) <flod@lodolo.net> - Tue, 18 Feb 2020 10:00:30 +0000 - rev 514371
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1616172 - Remove encoding when printing diff in Fluent migration tests r=Pike Differential Revision: https://phabricator.services.mozilla.com/D63128
aa36dde06adc25aa494390c30c0203dd7b5390d1: Bug 1614637 - ThreadSanitizer: data race [@ assign_assuming_AddRef] vs. [@ operator bool] in CacheStorageService r=mayhemer
Michal Novotny <michal.novotny@gmail.com> - Mon, 17 Feb 2020 18:44:21 +0000 - rev 514370
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1614637 - ThreadSanitizer: data race [@ assign_assuming_AddRef] vs. [@ operator bool] in CacheStorageService r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D62550
813b494a8388485c900045d829c603d45acdd106: Bug 1615973 - Hide invoke getter popup when evaluating expression. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 17 Feb 2020 14:44:34 +0000 - rev 514369
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1615973 - Hide invoke getter popup when evaluating expression. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D63062
bde7c898937d877132b5d2aaeae022227c9da7af: Bug 1579235 - Part 3 - Abstract some parts of yuv shader logic. r=nical
Glenn Watson <gw@intuitionlibrary.com> - Tue, 18 Feb 2020 08:21:16 +0000 - rev 514368
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1579235 - Part 3 - Abstract some parts of yuv shader logic. r=nical Factor some parts of the YUV brush shader out into a shared yuv.glsl shader include. In future, this shader code will also be referenced by the composite.glsl shader when using the simple (Draw) compositing mode, to composite video surfaces directly into the framebuffer where possible. Differential Revision: https://phabricator.services.mozilla.com/D63123
2b174daed07cadbcdf81bb4e128aad8ac77085ca: Bug 1587031 – Removed unused browser.contentblocking.control-center.ui prefs r=johannh
sviho <svitlanahoncharukk@gmail.com> - Tue, 18 Feb 2020 08:53:43 +0000 - rev 514367
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1587031 – Removed unused browser.contentblocking.control-center.ui prefs r=johannh Differential Revision: https://phabricator.services.mozilla.com/D63017
bcc19bc123696f80466e95fa94d6a150cc654ed9: Bug 1615418 - Use a real client in disconnect aboutdebugging test r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Tue, 18 Feb 2020 08:02:42 +0000 - rev 514366
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1615418 - Use a real client in disconnect aboutdebugging test r=daisuke Depends on D62894 Using a real local client allows to cover more codepaths than using a complete mock here. Differential Revision: https://phabricator.services.mozilla.com/D62891
a0cc5557495d8853a74dfbe275d7a46775cd6032: Bug 1615418 - Do not throw when calling watch/unwatchFront on destroyed Fronts r=daisuke,ochameau
Julian Descottes <jdescottes@mozilla.com> - Tue, 18 Feb 2020 08:02:29 +0000 - rev 514365
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1615418 - Do not throw when calling watch/unwatchFront on destroyed Fronts r=daisuke,ochameau Depends on D62893 The issue here is that we are trying to destroy the workers-listener after the target was destroyed, and calling unwatchFront on a destroyed Front throws. Most of the fronts monitored in workers-listener are handled by the watchFront API, so properly adding onDestroyed handlers fixes some issues. However the rootFront cannot be handled with a similar pattern at the moment. In general, I think making watchFront/unwatchFront safer to call makes sense, but I could also check if the rootFront is already destroyed in workers-listener's destroy Differential Revision: https://phabricator.services.mozilla.com/D62894
b06ca9139a1893478cfa9e5e780cc3879cbab44d: Bug 1615418 - Remove destroyed fronts from devtools workers-listener r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Tue, 18 Feb 2020 08:02:09 +0000 - rev 514364
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1615418 - Remove destroyed fronts from devtools workers-listener r=daisuke This will avoid part of the exceptions thrown when disconnecting a remote runtime. However the rootFront unwatchFront calls will still throw because the root front is already gone at this point Differential Revision: https://phabricator.services.mozilla.com/D62893
824d892121774d1e2137ce3154f15d0b2de7ca0a: Bug 1615418 - Remove FF69 backward compatibility code in devtools workers-listener r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Tue, 18 Feb 2020 08:01:57 +0000 - rev 514363
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1615418 - Remove FF69 backward compatibility code in devtools workers-listener r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D62890
6cb4593d8d8a01cad2f38f17a4d6006d6491a88b: Bug 1592277 - Support class constructors in devtools reps. r=nchevobbe.
Eugene Simakin <simakin.eugene@gmail.com> - Tue, 18 Feb 2020 07:04:01 +0000 - rev 514362
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1592277 - Support class constructors in devtools reps. r=nchevobbe. Differential Revision: https://phabricator.services.mozilla.com/D60557
eae597c03f1f0b4da80dc5e282543ffe8c1e6c63: Backed out changeset fa5ee85e20a5 (bug 1603673) for causing lint failure in GeckoRuntimeSettings.java CLOSED TREE
Noemi Erli <nerli@mozilla.com> - Tue, 18 Feb 2020 08:39:30 +0200 - rev 514361
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Backed out changeset fa5ee85e20a5 (bug 1603673) for causing lint failure in GeckoRuntimeSettings.java CLOSED TREE
fa5ee85e20a511227205a99d4875fcf17b08b3a6: Bug 1603673 - Signal that we support web manifest processing in Fenix r=snorp
Marcos Cáceres <mcaceres@mozilla.com> - Tue, 18 Feb 2020 03:43:48 +0000 - rev 514360
Push 37134 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 16:57:22 +0000
Bug 1603673 - Signal that we support web manifest processing in Fenix r=snorp When enabled, `link.relList.supports("manifest")` will return `true`. Differential Revision: https://phabricator.services.mozilla.com/D58181
5f2e621754148bbf104d9ae8b57a506cb5765e41: Bug 1609675 - Enable a `TS_E_NOLAYOUT` hack for MS-IME even if running on Win10 Build 17643 or later r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 18 Feb 2020 04:59:10 +0000 - rev 514359
Push 37133 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 09:37:36 +0000
Bug 1609675 - Enable a `TS_E_NOLAYOUT` hack for MS-IME even if running on Win10 Build 17643 or later r=m_kato MS-IME should get `TS_E_NOLAYOUT` error correctly when it's running on Win10 Build 17643 or later. However, according to the bug report, MS-IME itself does not handle it correctly. Therefore, we need to enable a hack for MS-IME for Japanese even when `intl.tsf.hack.allow_to_stop_hacking_on_build_17643_or_later` is true. Differential Revision: https://phabricator.services.mozilla.com/D63045
c906f7b0f8dc94f1949c2cf508f8e4d619ccccca: Bug 1616132 - ATTACHED_SHADERS must count non-null slots. r=lsalzman
Jeff Gilbert <jgilbert@mozilla.com> - Tue, 18 Feb 2020 03:21:13 +0000 - rev 514358
Push 37133 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 09:37:36 +0000
Bug 1616132 - ATTACHED_SHADERS must count non-null slots. r=lsalzman It was always returning 2. Differential Revision: https://phabricator.services.mozilla.com/D63110
714d07041daf9496ff4217b84ad18051dfd01626: Backed out changeset 061d47c2c5c7 (bug 1603673) for mozlint failure in /builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java CLOSED TREE
shindli <shindli@mozilla.com> - Tue, 18 Feb 2020 05:39:05 +0200 - rev 514357
Push 37133 by ncsoregi@mozilla.com at Tue, 18 Feb 2020 09:37:36 +0000
Backed out changeset 061d47c2c5c7 (bug 1603673) for mozlint failure in /builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip