d1b2e8a0682284abcafaf7e88cd34a9b299a89d2: Bug 1167452 - Split out nursery weak keys from tenured weak keys r=jonco
Steve Fink <sfink@mozilla.com> - Wed, 29 May 2019 20:47:51 +0000 - rev 476125
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1167452 - Split out nursery weak keys from tenured weak keys r=jonco Differential Revision: https://phabricator.services.mozilla.com/D31953
1566746f179c509d193423c5b5b2328024007a1f: Bug 1167452 - Switch weakmap marking code back from GCCellPtr to plain Cell* r=jonco
Steve Fink <sfink@mozilla.com> - Wed, 29 May 2019 20:46:27 +0000 - rev 476124
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1167452 - Switch weakmap marking code back from GCCellPtr to plain Cell* r=jonco Differential Revision: https://phabricator.services.mozilla.com/D31952
01cf1b9a681c044fcc5f5a303a6fbed0b9cf0f25: Bug 1167452 - Set gcLastSweepGroupIndex earlier (debugging feature) r=jonco
Steve Fink <sfink@mozilla.com> - Wed, 29 May 2019 20:45:56 +0000 - rev 476123
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1167452 - Set gcLastSweepGroupIndex earlier (debugging feature) r=jonco Differential Revision: https://phabricator.services.mozilla.com/D31951
4c4c08d01af4428b8dc2aa8d2066a81bb7e44ab8: Backed out 5 changesets (bug 1523351) for causing build bustage at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h on a CLOSED TREE
Daniel Varga <dvarga@mozilla.com> - Wed, 29 May 2019 23:45:15 +0300 - rev 476122
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Backed out 5 changesets (bug 1523351) for causing build bustage at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefList.h on a CLOSED TREE Backed out changeset 607b23dcc62a (bug 1523351) Backed out changeset b8169dcf0631 (bug 1523351) Backed out changeset 982cd43dc8d9 (bug 1523351) Backed out changeset 053540f0b00a (bug 1523351) Backed out changeset cac2a77abd09 (bug 1523351)
607b23dcc62a132f9ee349901f6faadb66f71299: Bug 1523351 - Part 5: Add LightIndicatorColor dummy functions in other platforms. r=aklotz
Daosheng Mu <daoshengmu@gmail.com> - Tue, 21 May 2019 21:54:22 +0000 - rev 476121
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1523351 - Part 5: Add LightIndicatorColor dummy functions in other platforms. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D31114
b8169dcf06315058ea9f3429e02408c9978b60a5: Bug 1523351 - Part 4: DS4 GamepadTouch and GamepadLightIndicator implementation in Windows. r=aklotz,baku
Daosheng Mu <daoshengmu@gmail.com> - Wed, 29 May 2019 20:25:46 +0000 - rev 476120
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1523351 - Part 4: DS4 GamepadTouch and GamepadLightIndicator implementation in Windows. r=aklotz,baku These should both be blocking reviewers. Differential Revision: https://phabricator.services.mozilla.com/D29291
982cd43dc8d94c0874d10f91e269bec393035cb7: Bug 1523351 - Part 3: Handling GamepadTouch and GamepadLightIndicator events in Gamepad service. r=baku
Daosheng Mu <daoshengmu@gmail.com> - Wed, 22 May 2019 23:02:26 +0000 - rev 476119
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1523351 - Part 3: Handling GamepadTouch and GamepadLightIndicator events in Gamepad service. r=baku Differential Revision: https://phabricator.services.mozilla.com/D29290
053540f0b00a5fa9cd4edd24b11b522e847e9725: Bug 1523351 - Part 2: Add tests for GamepadTouch and GamepadLightIndicator. r=baku
Daosheng Mu <daoshengmu@gmail.com> - Wed, 22 May 2019 05:54:43 +0000 - rev 476118
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1523351 - Part 2: Add tests for GamepadTouch and GamepadLightIndicator. r=baku Differential Revision: https://phabricator.services.mozilla.com/D29289
cac2a77abd09be11842b55ab042e3662e5fa43df: Bug 1523351 - Part 1: GamepadTouch and GamepadLightIndicator WebAPI implementation. r=baku
Daosheng Mu <daoshengmu@gmail.com> - Thu, 23 May 2019 05:36:31 +0000 - rev 476117
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1523351 - Part 1: GamepadTouch and GamepadLightIndicator WebAPI implementation. r=baku Differential Revision: https://phabricator.services.mozilla.com/D20744
b860b13c8eae8d8eeb363c21f2aa3c1430e0301b: Bug 1553467 - [Inactive CSS] Increase the tooltip's visual padding to match the attached mockup. r=pbro
Michael Ratcliffe <mratcliffe@mozilla.com> - Wed, 29 May 2019 12:40:53 +0000 - rev 476116
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1553467 - [Inactive CSS] Increase the tooltip's visual padding to match the attached mockup. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D32140
0a53924e724918efd09679b74fd3f48b737084bd: Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnj
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 27 May 2019 14:56:08 +0200 - rev 476115
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnj We cannot compile with just feature(gecko + debug_assertions), since that's how debug rusttests get compiled and they don't have the refcount logging stuff. We were getting away with it for the pre-existing usage of the style crate, because it wasn't used during any test and presumably the linker didn't complain. But servo_arc is definitely used in tests. Differential Revision: https://phabricator.services.mozilla.com/D32691
0edd8c43147130a2b0d3acbcde5d53d4b4f6aaf4: Bug 1552080 - Add refcount logging to servo_arc. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 May 2019 04:35:34 +0200 - rev 476114
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1552080 - Add refcount logging to servo_arc. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D32173
56befecef4618a1c935f3795c40bac5b4f7ad09a: Bug 1449572 - Bug 1449571 - raptor unit test for pageload timeouts r=perftest-reviewers,rwood
Alexandru Irimovici <alexandru.irimovici@softvision.ro> - Wed, 29 May 2019 19:23:13 +0000 - rev 476113
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1449572 - Bug 1449571 - raptor unit test for pageload timeouts r=perftest-reviewers,rwood Differential Revision: https://phabricator.services.mozilla.com/D32670
4715841d1f78c356c59126fb1ff9f6ba627df8fc: No bug: [taskgraph] Add missing __future__ imports to `taskgraph.util.hg`; r=dustin
Tom Prince <mozilla@hocat.ca> - Fri, 24 May 2019 20:54:46 +0000 - rev 476112
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
No bug: [taskgraph] Add missing __future__ imports to `taskgraph.util.hg`; r=dustin Differential Revision: https://phabricator.services.mozilla.com/D32535
e701b54fa8e4024774db36f90894693e35e38da7: No bug: Remove an unused test transfrom; r=ahal
Tom Prince <mozilla@hocat.ca> - Fri, 24 May 2019 20:56:02 +0000 - rev 476111
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
No bug: Remove an unused test transfrom; r=ahal Differential Revision: https://phabricator.services.mozilla.com/D32534
92d2f8bb690347e87fcc8738e95e896825d4c7be: No bug: [release] Remove an unused index type; r=Callek
Tom Prince <mozilla@hocat.ca> - Tue, 28 May 2019 12:42:19 +0000 - rev 476110
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
No bug: [release] Remove an unused index type; r=Callek Differential Revision: https://phabricator.services.mozilla.com/D32533
de1986c0ec6176677f05237338304bdcbffc84a3: No bug: [release] Remove some unused release kinds and transforms; r=nthomas
Tom Prince <mozilla@hocat.ca> - Mon, 27 May 2019 03:41:13 +0000 - rev 476109
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
No bug: [release] Remove some unused release kinds and transforms; r=nthomas Differential Revision: https://phabricator.services.mozilla.com/D32532
5715b3107ce3c7d0e87f0781a2fb5a38eceb1355: Bug 1552878 - Use cbindgen for filters. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 27 May 2019 12:37:37 +0000 - rev 476108
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1552878 - Use cbindgen for filters. r=jwatt Had to implement some OwnedSlice bits that the canvas code used. Differential Revision: https://phabricator.services.mozilla.com/D31799
388ab8151b4d5e797b6cde9a92a8be7e58836d2b: Bug 1552708 - Use cbindgen for URIs. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 27 May 2019 11:45:12 +0000 - rev 476107
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1552708 - Use cbindgen for URIs. r=heycam This doesn't clean up as much as a whole, but it's a step in the right direction. In particular, it allows us to start using simple bindings for: * Filters * Shapes and images, almost. Need to: * Get rid of the complex -moz- gradient parsing (let layout.css.simple-moz-gradient.enabled get to release). * Counters, almost. Need to: * Share the Attr representation with Gecko, by not using Option<>. * Just another variant should be enough (ContentItem::{Attr,Prefixedattr}, maybe). Which in turn allows us to remove a whole lot of bindings in followups to this. The setup changes a bit. This also removes the double pointer I complained about while reviewing the shared UA sheet patches. The old setup is: ``` SpecifiedUrl * CssUrl * Arc<CssUrlData> * String * UrlExtraData * UrlValueSource * Arc<CssUrlData> * load id * resolved uri * CORS mode. * ... ``` The new one removes the double reference to the url data via URLValue, and looks like: ``` SpecifiedUrl * CssUrl * Arc<CssUrlData> * String * UrlExtraData * CorsMode * LoadData * load id * resolved URI ``` The LoadData is the only mutable bit that C++ can change, and is not used from Rust. Ideally, in the future, we could just use rust-url to resolve the URL after parsing or something, and make it all immutable. Maybe. I've verified that this approach still works with the UA sheet patches (via the LoadDataSource::Lazy). The reordering of mWillChange is to avoid nsStyleDisplay from going over the size limit. We want to split it up anyway in bug 1552587, but mBinding gains a tag member, which means that we were having a bit of extra padding. One thing I want to explore is to see if we can abuse rustc's non-zero optimizations to predict the layout from C++, but that's something to explore at some other point in time and with a lot of care and help from Michael (who sits next to me and works on rustc ;)). Differential Revision: https://phabricator.services.mozilla.com/D31742
849ba4e850449a007e77316d6a2c1038f5143669: Bug 1554498 - Some miscellaneous cleanups while I was going through this code. r=edgar
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 29 May 2019 19:20:37 +0000 - rev 476106
Push 36086 by shindli@mozilla.com at Thu, 30 May 2019 03:47:55 +0000
Bug 1554498 - Some miscellaneous cleanups while I was going through this code. r=edgar Differential Revision: https://phabricator.services.mozilla.com/D32638
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip