d0d6b7a2b75d1bf4559534c9f1551510efc977bd: Bug 1361259. P4 - enforce copy in NonExclusive mode for each listener must get a copy. r=gerald
JW Wang <jwwang@mozilla.com> - Fri, 28 Apr 2017 17:56:57 +0800 - rev 355992
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1361259. P4 - enforce copy in NonExclusive mode for each listener must get a copy. r=gerald MozReview-Commit-ID: Mqt0N2erP6
cf5321dca675249a420ad59b2301a9890f74bd9c: Bug 1361259. P3 - remove unused code. r=gerald
JW Wang <jwwang@mozilla.com> - Fri, 28 Apr 2017 17:18:50 +0800 - rev 355991
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1361259. P3 - remove unused code. r=gerald MozReview-Commit-ID: 5svcAzJfGMS
b8fe34848ac81980de9f5c5c222abc0005309ffd: Bug 1361259. P2 - use NewRunnableMethod() to pass event data to the listener function. r=gerald
JW Wang <jwwang@mozilla.com> - Fri, 28 Apr 2017 16:28:47 +0800 - rev 355990
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1361259. P2 - use NewRunnableMethod() to pass event data to the listener function. r=gerald Note this breaks the MediaEventSource::CopyEvent2 gtest since there is always one copy or move when storing the event data in the runnable created by NewRunnableMethod() even when the listener function takes no arguments at all. We will fix it later. MozReview-Commit-ID: J9T63yxXko2
c8d5c205eeeeb670d2b626f066b4841d00754ace: Bug 1361259. P1 - let ListenerBase inherit RevocableToken. r=gerald
JW Wang <jwwang@mozilla.com> - Fri, 28 Apr 2017 14:18:38 +0800 - rev 355989
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1361259. P1 - let ListenerBase inherit RevocableToken. r=gerald This is needed by P2 where |Listener| must be ref-counted so we can use NewRunnableMethod() to pass event data to the listener function. MozReview-Commit-ID: CpAgOmxcijc
0aaaa82e6013ba6af6ee15a5c036f01e8bdaddb9: Bug 1356104 - (Part 2) Update stylo-failures. r=xidorn
KuoE0 <kuoe0.tw@gmail.com> - Tue, 25 Apr 2017 16:43:48 +0800 - rev 355988
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1356104 - (Part 2) Update stylo-failures. r=xidorn MozReview-Commit-ID: 8WuXXHhmfQ4
da7e654620e61fa405c11ff49977cef93d2cb23d: Bug 1356104 - (Part 1) The implementation inn Gecko of the FFI function `Gecko_GetAppUnitsPerPhysicalInch`. r=xidorn
KuoE0 <kuoe0.tw@gmail.com> - Tue, 25 Apr 2017 16:29:46 +0800 - rev 355987
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1356104 - (Part 1) The implementation inn Gecko of the FFI function `Gecko_GetAppUnitsPerPhysicalInch`. r=xidorn MozReview-Commit-ID: IVmmpQIw0JG
fbc54f707dc421f8132340e45fa2719dbdc9621b: Bug 1361051: rename mozilla::FrameType to mozilla::LayoutFrameType. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 May 2017 19:32:52 +0200 - rev 355986
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1361051: rename mozilla::FrameType to mozilla::LayoutFrameType. r=xidorn This avoids conflicts with mozilla::dom::FrameType. MozReview-Commit-ID: 7aEMbHRaTFk
151963610e799364d0e12af286f6201e5947d625: servo: Merge #16688 - Make stylo support mozmm unit (from KuoE0:make-stylo-support-mozmm-unit); r=xidorn
KuoE0 <kuoe0.tw@gmail.com> - Tue, 02 May 2017 02:27:39 -0500 - rev 355985
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
servo: Merge #16688 - Make stylo support mozmm unit (from KuoE0:make-stylo-support-mozmm-unit); r=xidorn <!-- Please describe your changes on the following line: --> This issue is reported at https://bugzilla.mozilla.org/show_bug.cgi?id=1356104. Mozmm is defined at https://developer.mozilla.org/zh-TW/docs/Web/CSS/length. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1356104](https://bugzilla.mozilla.org/show_bug.cgi?id=1356104) <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because the tests already exist in Gecko. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: f1ae547b9faf82c74f1680b1c5ff456b57d153c2
e1a305a0f6378696b91b0938fef4ec68bd04d05e: Bug 1348381 - Handle VideoFrame::CreateBlackImage returning nullptr. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Fri, 28 Apr 2017 13:58:22 +0200 - rev 355984
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1348381 - Handle VideoFrame::CreateBlackImage returning nullptr. r=jesup MozReview-Commit-ID: LWon0cx5hAK
47debe9bbc713f3a87bffa13ec12d694356c7f9b: Bug 1348381 - Add crashtest. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Fri, 28 Apr 2017 13:49:21 +0200 - rev 355983
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1348381 - Add crashtest. r=jesup MozReview-Commit-ID: Df2tymv7IiY
dfaab9ab88f919932769b0d7a90e716640f6f75e: Bug 1342950 - Assert false, not true, on failure in debug. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Wed, 26 Apr 2017 14:02:09 +0200 - rev 355982
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1342950 - Assert false, not true, on failure in debug. r=jesup MozReview-Commit-ID: EQ9NESBhRdK
632e25ba6de9e5d3d0f6d838c59f44fec52562a1: Bug 1360658 - Forward BundleEvents from WebAppActivity to GeckoApp. r=daleharvey
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 28 Apr 2017 20:48:08 +0200 - rev 355981
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1360658 - Forward BundleEvents from WebAppActivity to GeckoApp. r=daleharvey Otherwise random stuff handled by GeckoApp (e.g. snack bars) won't work inside a WebAppActivity. MozReview-Commit-ID: ElGOPQcqFJS
7f06e5ac97e6bde50a37e4b716facb5e46c15bd6: Backed out changeset e6177d883f37 (bug 1359540) for eslint failures
Carsten "Tomcat" Book <cbook@mozilla.com> - Tue, 02 May 2017 09:25:45 +0200 - rev 355980
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Backed out changeset e6177d883f37 (bug 1359540) for eslint failures
e6177d883f379b7c7472e4b19c5c41af1e4c26b3: Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh
Dan Banner <dbugs@thebanners.uk> - Thu, 27 Apr 2017 17:24:18 +0100 - rev 355979
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh MozReview-Commit-ID: D6qH5XtEtHO
0c2d52112c68ac81d4871cb9862467ca9b3ab1fa: Bug 1360743 - Part 1 - Ignore last selected tab in BrowserApp when opening a new tab through an intent. r=walkingice
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 29 Apr 2017 14:30:03 +0200 - rev 355978
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1360743 - Part 1 - Ignore last selected tab in BrowserApp when opening a new tab through an intent. r=walkingice When there's no more history to go back in an externally opened tab, we background the activity and close that tab. This means that some other tab gets selected instead, which could in theory trigger an activity switch if that tab is of a different type. Because we're leaving the app, we don't want to actually launch a new activity, so now the currently selected tab might not match the last active GeckoApp (e.g. closing the last open Web App tab will select a normal tab). Therefore if the same activity is subsequently resumed again, we need to run the restoreLastSelectedTab() even if the "last active GeckoApp"-check doesn't trigger. For BrowserApp however, this can conflict with session restoring/startup tabs/tabs opened from intents, because in that case we're going to select some other tab, anyway. We already ignore the "last selected tab within this activity" check when doing a full startup, so now we extend this behaviour to cover tabs loaded through onNewIntent() as well. MozReview-Commit-ID: IDistdhwuZ5
8c6b6d197f52360f0c3d9a8277b8e727856ad1ac: Bug 1360743 - Part 0 - Remove unneeded imports. r=walkingice
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 29 Apr 2017 14:21:38 +0200 - rev 355977
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1360743 - Part 0 - Remove unneeded imports. r=walkingice MozReview-Commit-ID: IfgzeaFmfOw
daaac7877e432a0daff8f1e920736e5682100676: Bug 1360699 - Finish CustomTabsActivities when leaving. r=walkingice
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 29 Apr 2017 15:03:41 +0200 - rev 355976
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1360699 - Finish CustomTabsActivities when leaving. r=walkingice Looking again, the original motivation for *not* calling finish(), i.e. avoiding Gecko being unloaded from memory, doesn't quite seem to apply and in any case for custom tabs we *have* to finish() the activity, since we're most probably running within another activity's task. There's also no point in overriding onDone() in SingleTabActivity any more if - we just do the same thing as GeckoApp's default behaviour, and - custom tabs now require a different behaviour anyway. MozReview-Commit-ID: BsP1tMj5DEe
2aaa56ceee09ca3abb950d9e214d76eed9cb4db7: Bug 1355852 - Show Text selection toolbar before Android 5. r=walkingice
Nevin Chen <cnevinchen@gmail.com> - Fri, 28 Apr 2017 18:38:13 +0800 - rev 355975
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1355852 - Show Text selection toolbar before Android 5. r=walkingice MozReview-Commit-ID: 9fnTXxOitag
54ab48204b9e3e2a7da749dd5257ab479c57db19: Bug 1336904 - Add timeouts for Safe Browsing updates r=francois
Thomas Nguyen <tnguyen@mozilla.com> - Mon, 24 Apr 2017 17:51:06 +0800 - rev 355974
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1336904 - Add timeouts for Safe Browsing updates r=francois These timeouts will ensure that we don't block the Safe Browsing update thread for too long when we encounter slow or bad network conditions. MozReview-Commit-ID: AJfR193cTf8
cc40abcbe193c44fce31f172f855db75e9e64c10: Bug 1318339 - [DateTimeInput] Prevent reset button from getting focus. r=mossop
Jessica Jong <jjong@mozilla.com> - Fri, 21 Apr 2017 17:35:43 +0800 - rev 355973
Push 31754 by kwierso@gmail.com at Wed, 03 May 2017 00:28:51 +0000
Bug 1318339 - [DateTimeInput] Prevent reset button from getting focus. r=mossop Reset button should not be tabbable or focusable. MozReview-Commit-ID: IboMKl3n0LY
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip