d058127e0c10fdebb09f3902d49e14835a2f63aa: Bug 1631618 - Make SharedWorkerService be alive until shutdown r=dom-workers-and-storage-reviewers,asuth
Eden Chuang <echuang@mozilla.com> - Fri, 15 May 2020 13:49:39 +0000 - rev 530538
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Bug 1631618 - Make SharedWorkerService be alive until shutdown r=dom-workers-and-storage-reviewers,asuth Using StaticRefPtr instead of a raw pointer for sSharedWorkerService in SharedWorkerService.cpp, and keeping sSharedWorkerService be alive until shutdown by registering sSharedWorkerService to ClearOnShutdown. Since sSharedWorkerService is not raw pointer anymore, SharedWorkerService needs not to inherit from SupportsCheckedUnsafePtr<CheckIf<DiagnosticAssertEnabled>> Differential Revision: https://phabricator.services.mozilla.com/D72379
564493b2e3c6c137e251ef13d02f67f493e485b4: Bug 1637946 - Fold MUnbox(MBox(x), Double) to MToDouble if possible. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 18 May 2020 07:32:49 +0000 - rev 530537
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Bug 1637946 - Fold MUnbox(MBox(x), Double) to MToDouble if possible. r=evilpie This pattern is very common in MIR transpiled from CacheIR. Differential Revision: https://phabricator.services.mozilla.com/D75296
94667ab68f350b5a407f44a6801966077ae58891: Backed out 2 changesets (bug 651482) for causing bitmap reftest failures.
Mihai Alexandru Michis <malexandru@mozilla.com> - Mon, 18 May 2020 10:31:53 +0300 - rev 530536
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Backed out 2 changesets (bug 651482) for causing bitmap reftest failures. CLOSED TREE Backed out changeset 734c4f395eba (bug 651482) Backed out changeset d8cc480c563c (bug 651482)
9af370d53fe662d1bd1f62f04b8f8ae931836427: Bug 1636769 - Make sure code mirror instance exists for the update r=Honza
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 18 May 2020 07:04:30 +0000 - rev 530535
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Bug 1636769 - Make sure code mirror instance exists for the update r=Honza Lets mke sure the code mirror instance exists before trying to update the mode or the text Differential Revision: https://phabricator.services.mozilla.com/D75677
ac9f8166fa65f84f404575292dcbae15affb2827: Bug 1637856 - part 2: Get rid of `WSRunScanner::mNodeArray` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 18 May 2020 06:46:00 +0000 - rev 530534
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Bug 1637856 - part 2: Get rid of `WSRunScanner::mNodeArray` r=m_kato `WSRunScanner` scans around given point in `GetWSNodes()` at construction with using `HTMLEditUtils` methods and caches editable text nodes between `mStartReasonContent` and `mEndReasonContent`. However, it's used only by `GetNextCharPoint()` and `GetPreviousCharPoint()`, and they shouldn't be referred after changing the DOM tree. Therefore, we can scan it directly only when it needs to scan. The patch rewrites `GetNextCharPoint()` and `GetPreviousCharPoint()` without `mNodeArray` and removes `mNodeArray` from its member. This may increase the cost of scanning next/previous text node, but improves the scan performance when it does not treat so wide range and they are called with a point whose container is not a text node. This patch unexpectedly changes the behavior of them, that causes the fix of 2 failures in `insertlinebreak.html` and `insertparagraph.html`. According to debugger, previously GetNextCharPoint()` in `ScanNextVisibleNodeOrBlockBoundaryFrom()` called point at `<br>` element returned no next char, then, `ScanNextVisibleNodeOrBlockBoundaryFrom()` returned end point which is block boundary of `<listing>` element (it is legacy HTML2 element and treated as `<pre>` element internally). Therefore, the inserted `<br>` element was misunderstood as invisible `<br>` at end of a block and inserted another `<br>` element for making it visible. However, the redesigned one fixed this bug with searching correct text node. Therefore, I cannot keep the buggy behavior in the new designed methods. Depends on D75470 Differential Revision: https://phabricator.services.mozilla.com/D75471
3ead0007c8fb0f39dd9953b751a014de834fe87c: Bug 1637856 - part 1: Move `WSRunObject::DeleteRange()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 18 May 2020 05:12:16 +0000 - rev 530533
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Bug 1637856 - part 1: Move `WSRunObject::DeleteRange()` to `HTMLEditor` r=m_kato `WSRunObject::DeleteRange()` removes only text nodes which are stored when `WSRunObject` is created. Although it removes text nodes if it's removed, this patch does not take care about it in the new method. The reason is the following patch will remove `mNodeArray` and anyway DOM tree modifiers can check whether they are in proper position before access if it's needed. Differential Revision: https://phabricator.services.mozilla.com/D75470
734c4f395eba16391772a817a2cccd4a078853af: Bug 651482 - Update documentation. r=tnikkel
wesj <we.j@live.com> - Mon, 18 May 2020 06:15:25 +0000 - rev 530532
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Bug 651482 - Update documentation. r=tnikkel Depends on D75467 Differential Revision: https://phabricator.services.mozilla.com/D75703
d8cc480c563ce2c6cb51cc9225662a3f4aab36b6: Bug 651482 - Allow decoding bitmaps with 52 and 56 byte info headers. r=tnikkel
wesj <we.j@live.com> - Mon, 18 May 2020 06:41:28 +0000 - rev 530531
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Bug 651482 - Allow decoding bitmaps with 52 and 56 byte info headers. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D75467
37e68bff6c62be9e13f75685252445bece3f421c: Bug 1636911. Add mochitest. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 May 2020 06:32:34 +0000 - rev 530530
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Bug 1636911. Add mochitest. r=kats Differential Revision: https://phabricator.services.mozilla.com/D75665
74a83c2492318f6b1a48f7d771b8c5020195de89: Bug 1636911. In ScrollFrameHelper::RestrictToRootDisplayPort don't adjust the root display port by the root scroll frame apz callback transform because it already factors that in. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Mon, 18 May 2020 06:32:34 +0000 - rev 530529
Push 37427 by ncsoregi@mozilla.com at Mon, 18 May 2020 15:24:16 +0000
Bug 1636911. In ScrollFrameHelper::RestrictToRootDisplayPort don't adjust the root display port by the root scroll frame apz callback transform because it already factors that in. r=kats Differential Revision: https://phabricator.services.mozilla.com/D75526
8acda9da4ae71f0b6561cb2021bcb370e18ce80c: Bug 1638458 - Do not use ignoreRootScrollFrame when dispatching a contextmenu event in APZEventState. r=tnikkel
Botond Ballo <botond@mozilla.com> - Mon, 18 May 2020 03:07:12 +0000 - rev 530528
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1638458 - Do not use ignoreRootScrollFrame when dispatching a contextmenu event in APZEventState. r=tnikkel The patch also removes the ignoreRootScrollFrame option from APZCCallbackHelper::DispatchMouseEvent() altogether as it is no longer used. Depends on D75735 Differential Revision: https://phabricator.services.mozilla.com/D75736
661c530ea53aad76a7f5e63bd858dfb429bd8a9d: Bug 1638458 - Remove the ignoreRootScrollFrame parameter of FrameLoader.sendCrossProcessMouseEvent(). r=tnikkel
Botond Ballo <botond@mozilla.com> - Mon, 18 May 2020 03:05:32 +0000 - rev 530527
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1638458 - Remove the ignoreRootScrollFrame parameter of FrameLoader.sendCrossProcessMouseEvent(). r=tnikkel No one is setting this parameter to true any more. Depends on D75734 Differential Revision: https://phabricator.services.mozilla.com/D75735
1e9ee0a46ce7b1a58c64f9ee0c280112be9fed1a: Bug 1638458 - Use layout coordinates when dispatching contextmenu event. r=tnikkel
Botond Ballo <botond@mozilla.com> - Mon, 18 May 2020 03:04:58 +0000 - rev 530526
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1638458 - Use layout coordinates when dispatching contextmenu event. r=tnikkel The patch also documents APZCCallbackHelper::DispatchMouseEvent() as expecting layout coordinates. Differential Revision: https://phabricator.services.mozilla.com/D75734
d682f72b3e16ac82d2e0f4236d32728a2e1f7493: Bug 1635319 Part 6 - Use EmplaceBack instead of AppendElement to append a FrameChildList into an array. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 18 May 2020 01:15:42 +0000 - rev 530525
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1635319 Part 6 - Use EmplaceBack instead of AppendElement to append a FrameChildList into an array. r=mats Using EmplaceBack instead of AppendElement can save us one FrameChildList's copy construction. Differential Revision: https://phabricator.services.mozilla.com/D75657
7c254f778837d27f176e986f34b8f881afff80c6: Bug 1635319 Part 5 - Remove unused FrameChildListIterator and FrameChildListArrayIterator. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 18 May 2020 01:15:40 +0000 - rev 530524
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1635319 Part 5 - Remove unused FrameChildListIterator and FrameChildListArrayIterator. r=mats Differential Revision: https://phabricator.services.mozilla.com/D75656
6ad32df85168cb041275f0146a413811fcb48439: Bug 1635319 Part 4 - Have GetCrossDocChildLists() return an array of ChildList, and use it in range-based for loops instead of FrameChildListArrayIterator. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 18 May 2020 01:06:58 +0000 - rev 530523
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1635319 Part 4 - Have GetCrossDocChildLists() return an array of ChildList, and use it in range-based for loops instead of FrameChildListArrayIterator. r=mats Differential Revision: https://phabricator.services.mozilla.com/D75655
1fd9e4b200d36aeb6f6fa00a7260214519aaadd5: Bug 1635319 Part 3 - Use range-based for loops instead of ChildListIterator in other layout directories. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 18 May 2020 01:12:26 +0000 - rev 530522
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1635319 Part 3 - Use range-based for loops instead of ChildListIterator in other layout directories. r=mats Differential Revision: https://phabricator.services.mozilla.com/D75654
470f297dbe5aeac28f16044d935d3ea7639c2369: Bug 1635319 Part 2 - Use range-based for loops and array iterators instead of ChildListIterator in layout/generic/. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 18 May 2020 01:17:15 +0000 - rev 530521
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1635319 Part 2 - Use range-based for loops and array iterators instead of ChildListIterator in layout/generic/. r=mats Differential Revision: https://phabricator.services.mozilla.com/D75653
d69c34efd6c278194fe7d920d0d0852b60eb7ea2: Bug 1635319 Part 1 - Add nsIFrame::GetChildLists(), and use range-based for loops instead of ChildListIterator in layout/generic/. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 18 May 2020 01:09:34 +0000 - rev 530520
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1635319 Part 1 - Add nsIFrame::GetChildLists(), and use range-based for loops instead of ChildListIterator in layout/generic/. r=mats Differential Revision: https://phabricator.services.mozilla.com/D75652
751209e30850a9f45b27a60d112b5a99f6a999e6: Bug 1626129 - Add more reftests for breaking a table cell. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Sat, 16 May 2020 06:14:02 +0000 - rev 530519
Push 37426 by nerli@mozilla.com at Mon, 18 May 2020 09:39:24 +0000
Bug 1626129 - Add more reftests for breaking a table cell. r=dbaron 2a and 2b are copied from 1a and 1b with "box-decoration-break: clone" added. 3a and 3b are copied from 1a and 1b. They test that the content fit but the table cell's bottom border and padding cannot fit. As of this bug, their rendering matches the block frame's, but 3a can now trigger a "data loss" warning and 3b an assertion in nsTableRowGroupFrame::SplitRowGroup. That might need a deeper look into table's pagination to have a proper fix. Differential Revision: https://phabricator.services.mozilla.com/D72051
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip