c7ae88fd1bd7e1d7d6d622eaa37439b653dc13d2: Bug 1200896 - Make the document blocked by the topmost element in the top layer r=emilio
Sean Feng <sefeng@mozilla.com> - Mon, 10 Aug 2020 18:20:51 +0000 - rev 544137
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1200896 - Make the document blocked by the topmost element in the top layer r=emilio Spec: https://html.spec.whatwg.org/multipage/#blocked-by-a-modal-dialog Differential Revision: https://phabricator.services.mozilla.com/D86227
8b57f059e63e55f28a5001ca732b08064af7a994: Bug 1200896 - Make TopLayerPush to return void r=emilio
Sean Feng <sefeng@mozilla.com> - Fri, 07 Aug 2020 17:13:15 +0000 - rev 544136
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1200896 - Make TopLayerPush to return void r=emilio TopLayerPush has always been returning true, so returning it as a boolean is incorrect. Differential Revision: https://phabricator.services.mozilla.com/D86392
fb03c1e39a43bef192497f65a695506bb05d72ee: Bug 1655751 - Invalidate for CSSOM changes in a more fine-grained way. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 10 Aug 2020 18:00:44 +0000 - rev 544135
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1655751 - Invalidate for CSSOM changes in a more fine-grained way. r=heycam Also, for changes in CSS declarations, like changing cssRules[i].style.color or something, we end up avoiding a lot of the work we were doing. This page still trips us in the sense that they add a stylesheet, then call getBoundingClientRect(), then insert more rules in the stylesheet, which causes us to rebuild a lot of the cascade data. We could try to detect appends to the last stylesheet on the list or something I guess, and avoid rebuilding the cascade data in some cases. Depends on D85615 Differential Revision: https://phabricator.services.mozilla.com/D85616
837f7946e5fbdad679fe7dd96391bdd71da7465f: Bug 1655751 - Fix a silly mistake in which we'd prefer a local name / tag invalidation to an id invalidation. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 10 Aug 2020 18:00:29 +0000 - rev 544134
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1655751 - Fix a silly mistake in which we'd prefer a local name / tag invalidation to an id invalidation. r=heycam ID invalidations should always win. This also prefers invalidations deeper in the subtree to higher up. Differential Revision: https://phabricator.services.mozilla.com/D85615
4462bac0fc59f25feab3764f9e2b9226dc2d22d2: Bug 1655105 - land NSS c06f22733446 UPGRADE_NSS_RELEASE, r=jcj
Kevin Jacobs <kjacobs@mozilla.com> - Mon, 10 Aug 2020 17:59:40 +0000 - rev 544133
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1655105 - land NSS c06f22733446 UPGRADE_NSS_RELEASE, r=jcj 2020-08-07 Kevin Jacobs <kjacobs@mozilla.com> * lib/pki/tdcache.c: Bug 1625791 - Call STAN_GetCERTCertificate to load CERTCertificate trust before caching. r=jcj,keeler When caching certificates, `td->cache->lock` must not be held when taking `slot->isPresentLock`. `add_cert_to_cache` holds then former when calling the sort function in `add_subject_entry`, which will [[ https://searchfox.org/mozilla-central/rev/a3b25e347e2c22207c4b369b99 246e4aebf861a7/security/nss/lib/pki/certificate.c#266 | call ]] `STAN_GetCERTCertificate` -> `fill_CERTCertificateFields` when `cc->nssCertificate` [[ https://searchfox.org/mozilla-central/rev/a3 b25e347e2c22207c4b369b99246e4aebf861a7/security/nss/lib/pki/pki3hack .c#923 | is NULL ]]. There are two problems with this: # `fill_CERTCertificateFields` may end up locking `slot->isPresentLock` (bad ordering, bug 1651564) # The above may happen followed by another attempt to lock `td->cache->lock`(deadlock, this bug). By calling `STAN_GetCERTCertificate` prior to the first lock of `td->cache->lock`, we can prevent the problematic call to `fill_CERTCertificateFields` later on, because `cc->nssCertificate` will already be filled. [c06f22733446] [tip] * gtests/ssl_gtest/ssl_auth_unittest.cc, lib/ssl/ssl3con.c: Bug 1588941 - Send empty client cert msg when signature scheme selection fails. r=mt `ssl3_CompleteHandleCertificateRequest` does essentially two things: 1) Calls the `getClientAuthData` hook for certificate selection, and 2) calls `ssl_PickClientSignatureScheme` to select an appropriate signature scheme when a cert is selected. If the first function returns SECFailure, we default to sending an empty certificate message. If the latter fails, however, this bubbles up as a [[ https://searchfox.org/mozilla-central/rev/56bb74e a8e04bdac57c33cbe9b54d889b9262ade/security/nss/lib/ssl/tls13con.c#26 70 | fatal error ]] (and an assertion failure) on the connection. Importantly, the signature scheme selection can fail for reasons that should not be considered fatal - notably when an RSA-PSS cert is selected, but the token on which the key resides does not actually support PSS. This patch treats the failure to find a usable signature scheme as a "no certificate" response, rather than killing the connection entirely. [41ecb7fe5546] * lib/freebl/Makefile, lib/freebl/freebl_base.gypi, lib/freebl/mpi/mpi_amd64_common.S, lib/freebl/mpi/mpi_amd64_gas.s: Bug 1656981 - Use 64x64->128 multiply and MP_COMBA on x86_64 Mac. r=mt This patch makes two MPI changes for MacOS: 1. Rename `mpi_amd64_gas.s` to `mpi_amd64_common.S` and add defines for macho64, allowing Intel Macs to take advantage of the 64x64->128 multiply code. 2. Define and use `NSS_USE_COMBA` on Intel Macs. Performance results with `rsaperf -n none -p 10 -e -x 65537` (default 2048-bit key): Before: `12629.12 operations/s. one operation every 79 microseconds` With 64x64->128 assembly: `29431.65 operations/s. one operation every 33 microseconds` With MP_COMBA and 64x64->128 assembly: `30332.99 operations/s. one operation every 32 microseconds` [330bdab498a3] * lib/ssl/sslimpl.h: Bug 1656429 - Clang-format fixup, r=bustage [07083076fc92] 2020-08-05 Martin Thomson <mt@lowentropy.net> * gtests/ssl_gtest/ssl_0rtt_unittest.cc, gtests/ssl_gtest/tls_connect.cc, lib/ssl/ssl3exthandle.c, lib/ssl/sslimpl.h, lib/ssl/tls13con.c, lib/ssl/tls13replay.c: Bug 1656429 - Correct RTT estimate used in anti-replay, r=kjacobs This was never a security problem, but the more time that passes between the handshake and sending a ticket, the more likely we are to reject 0-RTT. Eventually, 0-RTT only works if it is delayed in the network by a surprising amount. [b4a1c57eb569] Differential Revision: https://phabricator.services.mozilla.com/D86454
60059f7d5c464eb10d7979cefb4d151bf50b5abf: Bug 1657663: Improve timestamp precision for nsLocalFileUnix r=froydnj,barret
Keefer Rourke <krourke@mozilla.com> - Mon, 10 Aug 2020 17:50:23 +0000 - rev 544132
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1657663: Improve timestamp precision for nsLocalFileUnix r=froydnj,barret This change updates the unix implementation of nsLocalFile Set/GetLastModifiedTime methods to improve the precision of file modification times from a 1 second resolution to a 1 millisecond resolution. Differential Revision: https://phabricator.services.mozilla.com/D86238
d05cab0e15fade1f0ce438dffdb6d3f9325bc4d6: Bug 1658007: Check for shutdown earlier in IOUtils method calls r=barret,Gijs
Keefer Rourke <krourke@mozilla.com> - Mon, 10 Aug 2020 17:51:13 +0000 - rev 544131
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1658007: Check for shutdown earlier in IOUtils method calls r=barret,Gijs Differential Revision: https://phabricator.services.mozilla.com/D86420
154880478deb19ff90d08697d5a3ce4823b375eb: Bug 1657605: Split up IOUtils test suite r=barret,Gijs
Keefer Rourke <krourke@mozilla.com> - Mon, 10 Aug 2020 16:10:40 +0000 - rev 544130
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1657605: Split up IOUtils test suite r=barret,Gijs This change splits the dom/system/tests/test_ioutils.html file into several tests located under dom/system/tests/ioutils. Differential Revision: https://phabricator.services.mozilla.com/D86056
07b454734612a77d891bd9ed9ec55d74769684c2: Bug 1655461: Implement IOUtils::copy method r=barret,Gijs
Keefer Rourke <krourke@mozilla.com> - Mon, 10 Aug 2020 16:00:32 +0000 - rev 544129
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1655461: Implement IOUtils::copy method r=barret,Gijs This change introduces a copy method to the IOUtils interface which acts much like the POSIX `cp` command (with the `-r` flag). The implementations for move and copy would be very similar, so these methods share an implementation. Differential Revision: https://phabricator.services.mozilla.com/D85940
aec28efaf7e996c15357769dcd9686252bead26b: Bug 1654814 - Increase margin-top to subtitle in about:welcome page r=emcminn
Punam Dahiya <punamdahiya@yahoo.com> - Mon, 10 Aug 2020 17:44:17 +0000 - rev 544128
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1654814 - Increase margin-top to subtitle in about:welcome page r=emcminn Differential Revision: https://phabricator.services.mozilla.com/D86468
86f0a25361369ac89eee3be9f13ee539306a745f: Bug 1657242 - Report telemetry for Yellow Screen of Death. r=peterv
Zibi Braniecki <zbraniecki@mozilla.com> - Mon, 10 Aug 2020 17:38:00 +0000 - rev 544127
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1657242 - Report telemetry for Yellow Screen of Death. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D85951
600b0c60d674ecad1372a9a34b83baf163ff259f: Bug 1650486 - guard search-textbox from multiple connectedCallbacks, so that we don't get multiple search icons. r=bgrins
Magnus Melin <mkmelin+mozilla@iki.fi> - Mon, 10 Aug 2020 17:29:09 +0000 - rev 544126
Push 37688 by apavel@mozilla.com at Tue, 11 Aug 2020 03:16:35 +0000
Bug 1650486 - guard search-textbox from multiple connectedCallbacks, so that we don't get multiple search icons. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D86175
ee09cb88af177571304759bc05c760e3d82fd1ed: Bug 1656854 - Part 2: Add a BrowsingContextGroup keepalive to BrowserParent shutdown, r=farre
Nika Layzell <nika@thelayzells.com> - Thu, 06 Aug 2020 14:04:13 +0000 - rev 544125
Push 37687 by apavel@mozilla.com at Mon, 10 Aug 2020 21:36:34 +0000
Bug 1656854 - Part 2: Add a BrowsingContextGroup keepalive to BrowserParent shutdown, r=farre In bug 1652085, I added BrowsingContextGroup keepalives while waiting for replies to the discard message, however that message isn't actually sent to the current owner process. Instead, the BrowsingContext is discarded by the PBrowser being destroyed. This should help ensure we also keep the group alive during normal BrowserParent destruction. Differential Revision: https://phabricator.services.mozilla.com/D85897
d5f1c00144e2e425c9c965a7798b15c053447be0: Bug 1656854 - Part 1: Block subframe creation in discarded BCs, r=farre
Nika Layzell <nika@thelayzells.com> - Thu, 06 Aug 2020 14:03:30 +0000 - rev 544124
Push 37687 by apavel@mozilla.com at Mon, 10 Aug 2020 21:36:34 +0000
Bug 1656854 - Part 1: Block subframe creation in discarded BCs, r=farre This should help catch and/or prevent any cases where we're creating a new subframe at an unfortunate time during `BrowsingContext` or `WindowContext` teardown. Differential Revision: https://phabricator.services.mozilla.com/D85896
2d30adfe2f2798783d41b36059dd4936c14e8f64: Bug 1658274 - Do not record install_stats telemetry event on installs related to addon updates. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Mon, 10 Aug 2020 16:49:22 +0000 - rev 544123
Push 37687 by apavel@mozilla.com at Mon, 10 Aug 2020 21:36:34 +0000
Bug 1658274 - Do not record install_stats telemetry event on installs related to addon updates. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D86536
5ea65e36d41cfc4ec8d33db283edfabf3bd7fd03: Bug 1656048 - Remove linter exception for newtab re: whitelist/blacklist, and fix errors r=andreio
emcminn <emcminn@mozilla.com> - Mon, 10 Aug 2020 16:47:39 +0000 - rev 544122
Push 37687 by apavel@mozilla.com at Mon, 10 Aug 2020 21:36:34 +0000
Bug 1656048 - Remove linter exception for newtab re: whitelist/blacklist, and fix errors r=andreio Differential Revision: https://phabricator.services.mozilla.com/D85931
c2f16161f0299dd0236fd890ac5858069f665c33: Bug 1658221 - Look for llvm-rc in the toolchain search path. r=dmajor
Mike Hommey <mh+mozilla@glandium.org> - Mon, 10 Aug 2020 16:23:45 +0000 - rev 544121
Push 37687 by apavel@mozilla.com at Mon, 10 Aug 2020 21:36:34 +0000
Bug 1658221 - Look for llvm-rc in the toolchain search path. r=dmajor Differential Revision: https://phabricator.services.mozilla.com/D86493
c9872975bb5db34336b45cce538c16296db5f7d4: Bug 1634030: lazify main app menu r=Gijs
Emma Malysz <emalysz@mozilla.com> - Mon, 10 Aug 2020 17:09:55 +0000 - rev 544120
Push 37687 by apavel@mozilla.com at Mon, 10 Aug 2020 21:36:34 +0000
Bug 1634030: lazify main app menu r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D84014
3356b4e765e7598963fe0a62d80d889c221eaae9: Backed out 2 changesets (bug 1642387) for perma failures on browser_errorpage_timeout.js. CLOSED TREE
Razvan Maries <rmaries@mozilla.com> - Mon, 10 Aug 2020 21:04:03 +0300 - rev 544119
Push 37687 by apavel@mozilla.com at Mon, 10 Aug 2020 21:36:34 +0000
Backed out 2 changesets (bug 1642387) for perma failures on browser_errorpage_timeout.js. CLOSED TREE Backed out changeset f09be3d0ab1b (bug 1642387) Backed out changeset 5349b1df5595 (bug 1642387)
682bc156c9719ab66f8ba182999c69210afb1528: Backed out 2 changesets (bug 1639328) for perma failures on test_bug1639328.html and browser_hidden_iframe.js. CLOSED TREE
Razvan Maries <rmaries@mozilla.com> - Mon, 10 Aug 2020 21:02:42 +0300 - rev 544118
Push 37687 by apavel@mozilla.com at Mon, 10 Aug 2020 21:36:34 +0000
Backed out 2 changesets (bug 1639328) for perma failures on test_bug1639328.html and browser_hidden_iframe.js. CLOSED TREE Backed out changeset be370bea0702 (bug 1639328) Backed out changeset 954bf9f3dca5 (bug 1639328)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip