c34adf867751ac343a0945a2899db55f6d4fd03e: Bug 1618595 - Bump Cranelift to b7cfd39b531680217537cfcf5294a22077a0a58d; r=jseward
Benjamin Bouvier <benj@benj.me> - Thu, 30 Apr 2020 11:57:24 +0000 - rev 526948
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1618595 - Bump Cranelift to b7cfd39b531680217537cfcf5294a22077a0a58d; r=jseward Differential Revision: https://phabricator.services.mozilla.com/D73251
45c58c03f69e7cf6f9bb567bdcc0580b31d92ce5: Backed out changeset 07408b255fec (bug 1627434) as requested by whimboo for causing bug 1633366
Stefan Hindli <shindli@mozilla.com> - Thu, 30 Apr 2020 14:54:54 +0300 - rev 526947
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Backed out changeset 07408b255fec (bug 1627434) as requested by whimboo for causing bug 1633366
705c53101ce1361817a0e9912b912a44a446339f: Bug 1540037 - part 6: Move `TextEditor::DeleteSelectionAndCreateElement()` and `TextEditor::DeleteSelectionAndPrepareToCreateNode()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 30 Apr 2020 09:54:55 +0000 - rev 526946
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1540037 - part 6: Move `TextEditor::DeleteSelectionAndCreateElement()` and `TextEditor::DeleteSelectionAndPrepareToCreateNode()` to `HTMLEditor` r=m_kato Both of them are used only by `HTMLEditor` so that we can move them to `HTMLEditor`. Differential Revision: https://phabricator.services.mozilla.com/D72830
f05c7a94b27e201f35c119e5da2accbe8b0ff919: Bug 1582293 - Part 4: Initialize worker prefs correctly. r=asuth
Cameron McCormack <cam@mcc.id.au> - Thu, 30 Apr 2020 09:18:34 +0000 - rev 526945
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1582293 - Part 4: Initialize worker prefs correctly. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D70593
78efb77d861661f5775d2899741dc12fc5169886: Bug 1582293 - Part 3: Support zero values for worker GC prefs. r=asuth
Cameron McCormack <cam@mcc.id.au> - Thu, 30 Apr 2020 09:18:27 +0000 - rev 526944
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1582293 - Part 3: Support zero values for worker GC prefs. r=asuth And while we're touching JSSettings, make it use an nsTArray to store the JS GC settings intead of a C array. Differential Revision: https://phabricator.services.mozilla.com/D70592
4d2567d76d5212fa2b437f9ab00f3c6f79d14ee2: Bug 1582293 - Part 2: Fix interpretation of boolean worker GC prefs. r=asuth
Cameron McCormack <cam@mcc.id.au> - Thu, 30 Apr 2020 09:18:25 +0000 - rev 526943
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1582293 - Part 2: Fix interpretation of boolean worker GC prefs. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D70591
a0e583d1b1ae223450a6d42ea6d9b32cf65bd6d9: Bug 1582293 - Part 1: Fix pref observation code formatting. r=asuth
Cameron McCormack <cam@mcc.id.au> - Thu, 30 Apr 2020 09:18:23 +0000 - rev 526942
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1582293 - Part 1: Fix pref observation code formatting. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D70590
cce6adfec7bebf62111093f00a13a61e6d48cd4b: Bug 1627175 - part 12: Get rid of `HTMLEditor::GetCellFromRange()` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 30 Apr 2020 05:15:38 +0000 - rev 526941
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1627175 - part 12: Get rid of `HTMLEditor::GetCellFromRange()` r=m_kato Even though the method returns only in specific cases, but the result affects only one caller, `HTMLEditor::GetNextSelectedTableCellElement()`. Therefore, we can create new generic utility method, `HTMLEditUtils::GetTableCellElementIfOnlyOneSelected()` and get rid of `HTMLEditor::GetCellFromRange()`. Note that the warnings in `HTMLEditor::GetCellFromRange()` is just noise for any callers. So, this gets rid of the useless spam warnings. Differential Revision: https://phabricator.services.mozilla.com/D72586
bf6d7aa96d2a236ca10a703f44204d2eb424af19: Bug 1627175 - part 11: Create `HTMLEditUtils::GetElementIfOnlyOneSelected()` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 27 Apr 2020 16:44:38 +0000 - rev 526940
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1627175 - part 11: Create `HTMLEditUtils::GetElementIfOnlyOneSelected()` r=m_kato As an alternative of `HTMLEditor::GetCellFromRange()`, this patch creates more generic utility method. Depends on D72296 Differential Revision: https://phabricator.services.mozilla.com/D72585
e30a47ad7b52c26fa5d75aea2af7b22babf65bde: Bug 1621633 - remove no longer used COMPARE_LOCALES_DEFINES. r=Pike
Magnus Melin <mkmelin+mozilla@iki.fi> - Thu, 30 Apr 2020 11:12:36 +0000 - rev 526939
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1621633 - remove no longer used COMPARE_LOCALES_DEFINES. r=Pike Differential Revision: https://phabricator.services.mozilla.com/D73086
ff18fa29d992a97b2bac6340ed004e28f93ccb7f: Bug 1540037 - part 5: Move `EditorBase::JoinNodesWithTransaction()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 30 Apr 2020 09:31:11 +0000 - rev 526938
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1540037 - part 5: Move `EditorBase::JoinNodesWithTransaction()` to `HTMLEditor` r=m_kato It's used only by `HTMLEditor` so that we can move it into `HTMLEditor`. Differential Revision: https://phabricator.services.mozilla.com/D72829
f678ce3e8aa03292f91c90dc8f779bffbc4c4423: Bug 1632726 - part 2: Remove some unused `nsISelectionController` methods r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 27 Apr 2020 06:20:31 +0000 - rev 526937
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1632726 - part 2: Remove some unused `nsISelectionController` methods r=smaug Even in comm-central and BlueGriffon, `nsISelectionController::*ForDelete()` are not used. Therefore, we can remove them safely. Differential Revision: https://phabricator.services.mozilla.com/D72296
3baf6ee966a69224f571b029c6dbc3f3f7f43e1b: Bug 1632726 - part 1: Create utility methods to compute delete range from collapsed selection in `nsFrameSelection` r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 30 Apr 2020 10:05:35 +0000 - rev 526936
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1632726 - part 1: Create utility methods to compute delete range from collapsed selection in `nsFrameSelection` r=smaug Currently, `EditorBase::ExtendSelectionForDelete()` depends on some `nsISelectionController` methods to compute extended range for deletion from collapsed selection. They are implemented by `nsFrameSelection::MoveCaret()` and `nsFrameSelection::TakeFocus()`. Ideally, we should split these methods for computation part and performing part. However, they change selection with updating other selection state, for example, table selection state and bidi information. Therefore, it's impossible to split them with simple code. However, I need to change `EditorBase::ExtendSelectionForDelete()` just return extended range. Therefore, this patch creates `nsFrameSelection::PeekOffsetForCaretMove()` which has the main path in `MoveCaret()` for the `EditorBase` method. Then, `MoveCaret()` and new `nsFrameSelection::CreateRangeExtendedToSomewhere()` share the computation code of expanding normal selection. Finally, this patch wraps `nsFrameSelection::CreateRangeExtendedToSomewhere()` with new public inline methods for `EditorBase`. The following patch will remove no-user methods of `nsISelectionController`. Differential Revision: https://phabricator.services.mozilla.com/D72295
30f462b4fabc3a68fbb2febb17d2313f1999edf3: Bug 1633401 - Remove the TEST-UNEXPECTED-PASS for wpt 'hasStorageAccess.sub.window.html' in non-android builds. r=baku
Tim Huang <tihuang@mozilla.com> - Thu, 30 Apr 2020 10:15:30 +0000 - rev 526935
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1633401 - Remove the TEST-UNEXPECTED-PASS for wpt 'hasStorageAccess.sub.window.html' in non-android builds. r=baku Differential Revision: https://phabricator.services.mozilla.com/D73122
ea3411b110b30709149fddb3bc1b4640ef064876: Bug 1633401 - Make Document.HasStorageAccess fission compatible. r=baku
Tim Huang <tihuang@mozilla.com> - Thu, 30 Apr 2020 09:54:15 +0000 - rev 526934
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1633401 - Make Document.HasStorageAccess fission compatible. r=baku In Document::HasStorageAccess(), we try to get the top-level document. To check if the document is first-party to the top-level document. But, this won't work for Fission since the top-level document could be out-of-process. In this patch, we use broswing context to get the top-level principal to test if the document is thrid-party. If we cannot get the top-level outer window, the top-level document should be cross-origin. So, we know the answer. If the top-level document is available, we check the principal to see if the document is first-party. Differential Revision: https://phabricator.services.mozilla.com/D72664
e9b7a8c2176cb6324617a9d911bcee8451f4fc12: Bug 1632884 - Update bits_client readme after bug 1586996 r=agashlin
David Major <dmajor@mozilla.com> - Tue, 28 Apr 2020 21:40:30 +0000 - rev 526933
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1632884 - Update bits_client readme after bug 1586996 r=agashlin A special winapi is no longer necessary. (I haven't "tested" this change; I merely found this in a search result for winapi-rs.) Differential Revision: https://phabricator.services.mozilla.com/D72402
cef377c2b041c086f1aca472a665daa711e4f81f: Bug 1632098 - P5. Disabling more tests on macos. r=Gijs
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 30 Apr 2020 11:18:01 +0000 - rev 526932
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1632098 - P5. Disabling more tests on macos. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D73238
22b70f279749e1d45dad529b386af8bd37c9c9ed: Bug 1633158 - raise the retries r=Bebe
Tarek Ziadé <tarek@mozilla.com> - Thu, 30 Apr 2020 09:14:02 +0000 - rev 526931
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1633158 - raise the retries r=Bebe This change tries to address the intermittents we get when getting indexed artifacts by raising the retries and how long we pause between retries. Differential Revision: https://phabricator.services.mozilla.com/D73022
27da136bf5a982dd2132c0bef2aaf8807387351f: Bug 1596920 - Don't set selection on dispatching key event if unnecessary. r=geckoview-reviewers,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 28 Apr 2020 14:02:10 +0000 - rev 526930
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1596920 - Don't set selection on dispatching key event if unnecessary. r=geckoview-reviewers,snorp Actually we emulate key event (down, press and up) from replace transaction of `Editable`. When dispatching key press, we always update current caret position. Most situations is the following. 1. Dispatch keypress 2. Dispatch another keypress 3. Receive merged text/selection change result by 1. and 2. 4. Sync shadow (Java's Editable) text with 3.'s result. It means selection is correct position now. 5. Dispatch keypress with correct position. When this issue occurs, the following situation occurs. 1. Dispatch keypress 2. Dispatch another keypress 3. Receive text/selection change result of 1. 4. Sync shadow (Java's Editable) text with 3.'s result. It means selection is old position now. 5. Dispatch another keypress with old position. 6. Receive text/selection change result of 2. 7. Receive text/selection change result of 5. So when dispatching key press, we shouldn't always update selection if unnecessary. Because selection range is already often set before dispatching key press. Differential Revision: https://phabricator.services.mozilla.com/D71179
39acb94eae20f36c4a88523e7d86893cbdb70c29: Bug 1630704 - Merge standalone overrriding methods to nsIFrame r=emilio
Kagami Sascha Rosylight <saschanaz@outlook.com> - Wed, 29 Apr 2020 18:22:50 +0000 - rev 526929
Push 37366 by cbrindusan@mozilla.com at Fri, 01 May 2020 09:42:47 +0000
Bug 1630704 - Merge standalone overrriding methods to nsIFrame r=emilio This patch merges nsFrame methods to nsIFrame, where merging only requires simple signature changes. Differential Revision: https://phabricator.services.mozilla.com/D73070
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip