c0f7c52c5ed777543ebdc1ae6084372cdc3c8894: Bug 1744799 [wpt PR 31935] - [block-in-inline] Add more test for r948826, a=testonly
Koji Ishii <kojii@chromium.org> - Thu, 09 Dec 2021 16:14:21 +0000 - rev 602682
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744799 [wpt PR 31935] - [block-in-inline] Add more test for r948826, a=testonly Automatic update from web-platform-tests [block-in-inline] Add more test for r948826 r948826 crrev.com/c/3318676 fixed a test: tables/mozilla/bugs/bug113235-1.html when BlockInInline is enabled, but the test relies on the parser to chunk at the specific timing. This patch adds a test that always hit the condition by using the `insertBefore` function. Bug: 716930 Change-Id: I1c8ee5d197801d02749d75ec7e03a773207716e5 -- wpt-commits: ad5d26e64d54cd45787df6bcc2d6fc4fcaa77d50 wpt-pr: 31935
6196e4a0499aeb352e392fec2989336a47806fa3: Bug 1744737 [wpt PR 31929] - Correct document order for fixedpos flex item inside abspos legacy flex., a=testonly
Morten Stenshorne <mstensho@chromium.org> - Thu, 09 Dec 2021 16:14:16 +0000 - rev 602681
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744737 [wpt PR 31929] - Correct document order for fixedpos flex item inside abspos legacy flex., a=testonly Automatic update from web-platform-tests Correct document order for fixedpos flex item inside abspos legacy flex. If there's an OOF flex item inside an OOF legacy flex container, and the flex container isn't the containing block for the item (e.g. fixed- positioned inside absolute-positioned), check one extra time when handling them at the containing block. LayoutBlock::PositionedObjects() gets OOFs out of document order upon re-layout on a general basis, if there's a fixed-positioned object inside another OOF, so that we may end up laying out the child before the parent. If, when eventually laying out the parent, we mark the child for layout, we'd never get back to laying it out, and DCHECKs would fail. The only known actual problem with having objects out of document order is precisely what's described above, so the fix is limited to that. Hopefully the legacy engine is removed before we discover any problems with my fix. :-p Bug: 1269228 Change-Id: Ifc212e2b8baa6b9fcf58a5714fa7a8a1139f4b87 -- wpt-commits: 193d9758c4c900b3a80f71e47bc5fd85138d71fa wpt-pr: 31929
ea695e552a05157997aae1d055340381c88b75a9: Bug 1744355 [wpt PR 31887] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Wed, 08 Dec 2021 01:19:48 +0000 - rev 602680
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744355 [wpt PR 31887] - Update wpt metadata, a=testonly wpt-pr: 31887 wpt-type: metadata
6db7cb25d2624c4bf37063c1f92a850ebeadebdf: Bug 1744355 [wpt PR 31887] - Port chrome-only dialog tests to WPT part 3, a=testonly
Joey Arhar <jarhar@chromium.org> - Thu, 09 Dec 2021 16:14:06 +0000 - rev 602679
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744355 [wpt PR 31887] - Port chrome-only dialog tests to WPT part 3, a=testonly Automatic update from web-platform-tests Port chrome-only dialog tests to WPT part 3 Bug: 1240798 Change-Id: Id1e38606a8ec0b59fa5172baa7649d31979267f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315600 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#949223} -- wpt-commits: 96a05d37bd706aec4fe5f089da81b908fcfb08f8 wpt-pr: 31887
4ecae77019052dbc7a66e49eb391d007dfda2060: Bug 1744655 [wpt PR 31925] - [SelectMenu] Mark validity state dirty when needed., a=testonly
Ionel Popescu <iopopesc@microsoft.com> - Thu, 09 Dec 2021 16:13:59 +0000 - rev 602678
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744655 [wpt PR 31925] - [SelectMenu] Mark validity state dirty when needed., a=testonly Automatic update from web-platform-tests [SelectMenu] Mark validity state dirty when needed. This CL ensures that the validity state is marked as dirty when: - options are inserted / removed - selected option's value is changed Bug: 1121840 Change-Id: Ic337243bd609c13b21ef70044545bf1b023448aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319504 Reviewed-by: Dan Clark <daniec@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/main@{#949203} -- wpt-commits: a2d6c3b5c94b7099b51c7d0ac233e70f6584907c wpt-pr: 31925
7cbfd6771c0dfc351a926e1eb4cf8061d30550ca: Bug 1744834 [wpt PR 31945] - serial: Use promise_rejects_exactly instead of catch, a=testonly
Reilly Grant <reillyg@chromium.org> - Thu, 09 Dec 2021 16:13:53 +0000 - rev 602677
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744834 [wpt PR 31945] - serial: Use promise_rejects_exactly instead of catch, a=testonly Automatic update from web-platform-tests serial: Use promise_rejects_exactly instead of catch This change modifies serialPort_writable.https.any.js to use the promise_rejects_exactly helper function instead of manually catching and comparing the exception value. The reason this is better is that it properly triggers a failure if the promise isn't rejected and doesn't accidentally catch other exceptions thrown by the code within the try block. Change-Id: I553ad347fcd12a28b515ffbf937c6867c2ae03fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321318 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#949166} -- wpt-commits: a8903616191234a604d28c845322c0a69ebb5fe3 wpt-pr: 31945
eb29b470150f20ed49afe80ea2ee6388dd905172: Bug 1744792 [wpt PR 31933] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Wed, 08 Dec 2021 01:50:48 +0000 - rev 602676
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744792 [wpt PR 31933] - Update wpt metadata, a=testonly wpt-pr: 31933 wpt-type: metadata
46327b1af9016b2f3285c1a175c7ea10eb462d38: Bug 1744792 [wpt PR 31933] - [selectmenu] Don't run controller code if event was preventDefaulted, a=testonly
Dan Clark <daniec@microsoft.com> - Thu, 09 Dec 2021 16:13:41 +0000 - rev 602675
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744792 [wpt PR 31933] - [selectmenu] Don't run controller code if event was preventDefaulted, a=testonly Automatic update from web-platform-tests [selectmenu] Don't run controller code if event was preventDefaulted If an author does preventDefault on a click or keyboard event, then that event shouldn't trigger <selectmenu> controller code behavior. This can be useful for cases where authors want to nest interactive content (buttons, etc) inside <selectmenu> parts. They may want to preventDefault events handled by the nested content so that the event doesn't bubble up to the outer part and trigger <selectmenu> behavior. Bug: 1121840 Change-Id: Ia2b20b73cc4f9137e2501016c372a4a064aefe6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319507 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#949164} -- wpt-commits: 81f9e818005784368e592ebd4b99b631ceee90c9 wpt-pr: 31933
b81177d399690c9c27ec5a0909e8a16af9a9750b: Bug 1744758 [wpt PR 31930] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Wed, 08 Dec 2021 01:11:12 +0000 - rev 602674
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744758 [wpt PR 31930] - Update wpt metadata, a=testonly wpt-pr: 31930 wpt-type: metadata
0f2a2c8d8975a0070c376391f281493ca824d497: Bug 1744758 [wpt PR 31930] - Add tests for snap-area-overflow, a=testonly
Kevin Ellis <kevers@chromium.org> - Thu, 09 Dec 2021 16:13:32 +0000 - rev 602673
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744758 [wpt PR 31930] - Add tests for snap-area-overflow, a=testonly Automatic update from web-platform-tests Add tests for snap-area-overflow Presently not possible to scroll to the end of a snap-area that overflows the snapport via keyboard or mouse-wheel. See https://github.com/w3c/csswg-drafts/issues/6863 Bug: 1273921 Change-Id: Iad4e711dad997e4448651f278779d373de3b1275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317998 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#949097} -- wpt-commits: c1c6b9a4b3604ed4856b9936c106a7a609d35e3c wpt-pr: 31930
dc570a5bcc14adbcffeeff80ab1bc7bd8416bc21: Bug 1744650 [wpt PR 31924] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Tue, 07 Dec 2021 23:35:53 +0000 - rev 602672
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744650 [wpt PR 31924] - Update wpt metadata, a=testonly wpt-pr: 31924 wpt-type: metadata
b66369f6e07f53373cb43218416c086f6e7c9221: Bug 1744650 [wpt PR 31924] - [FlexNG] Simple single-line row flex fragmentation, a=testonly
Alison Maher <almaher@microsoft.com> - Thu, 09 Dec 2021 16:13:22 +0000 - rev 602671
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744650 [wpt PR 31924] - [FlexNG] Simple single-line row flex fragmentation, a=testonly Automatic update from web-platform-tests [FlexNG] Simple single-line row flex fragmentation Add support for simple single-line row flex fragmentation. Without alignment figured out, the tests aren't as interesting as their single-line column counterparts. However, things will get more interesting when handling break rules in this case. Bug: 660611 Change-Id: Ia04a882ae0b25b624381e1763862c2f8a63caf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318612 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#949074} -- wpt-commits: ffb6ccb302bc9d1774c4ded8af308e107af9e4db wpt-pr: 31924
e354d469da8e0e2c9955594c7dd7d0b033950706: Bug 1744380 [wpt PR 31895] - Make scrollbars-auto-ref.html more precise about which elements/axes need to be scrolled to nondefault positions., a=testonly
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 09 Dec 2021 16:13:15 +0000 - rev 602670
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744380 [wpt PR 31895] - Make scrollbars-auto-ref.html more precise about which elements/axes need to be scrolled to nondefault positions., a=testonly Automatic update from web-platform-tests Make scrollbars-auto-ref.html more precise about which elements/axes need to be scrolled to nondefault positions. Before this commit, scrollbars-auto-ref.html scrolled the "column-reverse" and the "row-reverse" mockups to extreme positions **in both axes**, like this for example: nodes[i].scrollLeft = 10000; nodes[i].scrollTop = 10000; But in fact, only one of those two statements is needed for each node, because only one axis is actually reversed. I think the test is implicitly assuming that the other axis will simply have zero leeway to scroll (which is mostly but not entirely true, see below...), and hence the unnecessary statement is just non-functional and harmless. This assumption doesn't hold up in Firefox; there are parts of this testcase where we've got some room to scroll in *both* axes (which the test does not expect), due to our choices around some undefined-in-CSS behavior regarding intrinsic sizing of overflow:auto elements[1]. This commit addresses this problem by removing the unnecessary statements, and making the reference case strictly scroll in the axis that it needs to. See code comments in the patch for more detail. [1] see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=764076#c7 -- wpt-commits: bb6f7ec5764bb27b8e3c095f3b8f187420433fb2 wpt-pr: 31895
b47a4709e492525f92b3afa1f0816c3a9fe860dc: Bug 1744064 [wpt PR 31847] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Tue, 07 Dec 2021 18:58:53 +0000 - rev 602669
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744064 [wpt PR 31847] - Update wpt metadata, a=testonly wpt-pr: 31847 wpt-type: metadata
7f96b787036eef8f2df80645b8ef1cbd67eee538: Bug 1744064 [wpt PR 31847] - Use webdriver to set permission on getUserMedia calls , a=testonly
Dominique Hazael-Massieux <dom@w3.org> - Thu, 09 Dec 2021 16:13:04 +0000 - rev 602668
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744064 [wpt PR 31847] - Use webdriver to set permission on getUserMedia calls , a=testonly Automatic update from web-platform-tests Use webdriver to set permission on getUserMedia calls (#31847) * Remove fake-ui from chrome wptrunner Rely instead of SetPermission webdriver hook; this allows testing permission denial. * Use webdriver to set permission on getUserMedia calls Rewrite mediacapture-streams using async/await for consistency in the process Move a couple of manual tests back to automated as a result * Catch web driver error more specifically when setting permission per https://github.com/web-platform-tests/wpt/pull/31847#pullrequestreview-824508906 * Rename setPermission in setMediaPermission per https://github.com/web-platform-tests/wpt/pull/31847#issuecomment-987261583 * Limit media capture permissions to what is strictly needed for the test per https://github.com/web-platform-tests/wpt/pull/31847#issuecomment-987261583 * Align quoting styles for script loading -- wpt-commits: 319a0a7580aaee957801545901150a0dabd9e735 wpt-pr: 31847
51e86290a508abd2cdecb73cb981bc7cb642d113: Bug 1744253 [wpt PR 31874] - Anonymous iframe: Fix test about navigation request., a=testonly
Arthur Sonzogni <arthursonzogni@chromium.org> - Thu, 09 Dec 2021 16:12:33 +0000 - rev 602667
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744253 [wpt PR 31874] - Anonymous iframe: Fix test about navigation request., a=testonly Automatic update from web-platform-tests Anonymous iframe: Fix test about navigation request. Navigation requests are different from subresources request. Since tests were failing, I suspected in https://crbug.com/1276354 the IsolationInfo nonce of the navigation was inappropriately passed. ... [2 hours later] ... It turns out the implementation looked correct. The error was in the test. Bug: 1276354 Change-Id: If529d1eeeff7fbd855282d7d7ded854d49025262 Fixed: 1276354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314581 Reviewed-by: Dylan Cutler <dylancutler@google.com> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#948992} -- wpt-commits: 7b5f6517188babd2b0582fa301e4f7bb207b5992 wpt-pr: 31874
9847bc66b7835af7d79a6fcdc976ef841bb38146: Bug 1744206 [wpt PR 31869] - Anonymous iframe: Stop using unpartitioned cookies., a=testonly
Arthur Sonzogni <arthursonzogni@chromium.org> - Thu, 09 Dec 2021 16:12:28 +0000 - rev 602666
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744206 [wpt PR 31869] - Anonymous iframe: Stop using unpartitioned cookies., a=testonly Automatic update from web-platform-tests Anonymous iframe: Stop using unpartitioned cookies. Stop feeding anonymous iframe document with unpartitionned cookies. When the CookiePartitionKey contains a nonce, it is from an anonymous/fenced frame. As a result, we must only take cookies from this CookiePartitionKey and not interact with the unpartitionned ones. A future patch will force every cookies defined from within the anonymous iframe to be partitionned. See: https://bugs.chromium.org/p/chromium/issues/detail?id=1275465 Doc: https://docs.google.com/document/d/1ymsMVb6jo8vwwZj5gQAHakdoY2z_XxtCI6-FkmPFSK8/edit Bug: 1275464 Change-Id: I4b8499bd7b77120363848eb5389eff7d2a8d090e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309641 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/main@{#948943} -- wpt-commits: 61b4fd86c63d7d07f2bde41120c8f0cb31797d9c wpt-pr: 31869
646bda176598b8c0a21c09bcb2d28ef297b0ca7e: Bug 1744493 [wpt PR 31908] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Tue, 07 Dec 2021 21:47:00 +0000 - rev 602665
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744493 [wpt PR 31908] - Update wpt metadata, a=testonly wpt-pr: 31908 wpt-type: metadata
944e7766c9fc7ae1526b020b3e4503193d5f7399: Bug 1744493 [wpt PR 31908] - Use IsSameOriginWith for showPicker cross-origin iframe check, a=testonly
François Beaufort <beaufort.francois@gmail.com> - Thu, 09 Dec 2021 16:12:17 +0000 - rev 602664
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744493 [wpt PR 31908] - Use IsSameOriginWith for showPicker cross-origin iframe check, a=testonly Automatic update from web-platform-tests Use IsSameOriginWith for showPicker cross-origin iframe check This CL changes from IsSameOriginDomainWith to IsSameOriginWith the check for cross-origin iframes when showPicker() is called following spec change[1]. [1] https://github.com/whatwg/html/pull/7319#discussion_r759633854 Change-Id: Ic21ec96e241cad730d6e93a7b635cf9107f48023 Bug: 939561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310677 Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#948890} -- wpt-commits: e6c8eb0800388d8e1e49f46f3454d456a0d7e301 wpt-pr: 31908
6ec1c8b9a68b3d5f6640a39c04449eb3dfbb88d1: Bug 1744484 [wpt PR 31906] - Fix Chrome-specific wpt resize-observer test, a=testonly
Aleks Totic <atotic@chromium.org> - Thu, 09 Dec 2021 16:12:11 +0000 - rev 602663
Push 39080 by mlaza@mozilla.com at Mon, 20 Dec 2021 21:51:27 +0000
Bug 1744484 [wpt PR 31906] - Fix Chrome-specific wpt resize-observer test, a=testonly Automatic update from web-platform-tests Fix Chrome-specific wpt resize-observer test Chrome DCHECKs when testRunner.notifyDone is called from within ResizeObserver callback. Initially, I wanted to fix this inside Chrome's testRunner, but: - the testRunner fix is not trivial - these types of bugs are ResizeObserver callback specific - only occur when DCHECK is turned on This CL fixes the wpt test instead. This is much simpler, and we do not expect this to happen often enough to warrant C++ work. Bug: 1270820, 626703, 1275806 Change-Id: I0fbedb866998829d7b225ec8f09f5bdb4b7c8238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317248 Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/main@{#948824} -- wpt-commits: 99384c14df81e8cfeab1ad020c5d3a9691188404 wpt-pr: 31906
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip