c07c86be0b629345f2afb724f092b08d315cdfa9: Bug 1627300 [wpt PR 22695] - [css-filters] Migrate direct-image-dynamic-filter.html test to WPT, a=testonly
Mario Sanchez Prada <mario@igalia.com> - Mon, 06 Apr 2020 22:02:19 +0000 - rev 523153
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1627300 [wpt PR 22695] - [css-filters] Migrate direct-image-dynamic-filter.html test to WPT, a=testonly Automatic update from web-platform-tests [css-filters] Migrate direct-image-dynamic-filter.html test to WPT Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. In addition, this test uses <html class="reftest-wait"> as described in [1] to replace the code that was depending on testRunner in order to make sure that the screenshot is taking at the right time. Last, the original test relied on a green-256x256.jpg image that is exactly equivalent to the PNG version already in WPT, so this test has been migrated to use that one instead. [1] https://web-platform-tests.org/writing-tests/reftests.html?highlight=reftests#controlling-when-comparison-occurs Bug: 1063749 Change-Id: Idcd76fcf3b1e82fe14be602c120d8c105f5c658a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134258 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#756456} -- wpt-commits: 9d246bdd8dd24f53ba25f76f6a71af515ba9233e wpt-pr: 22695
0ae9796304997fca195066ef4e2fe66a2ea889fa: Bug 1627250 [wpt PR 22687] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 03 Apr 2020 22:54:50 +0000 - rev 523152
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1627250 [wpt PR 22687] - Update wpt metadata, a=testonly wpt-pr: 22687 wpt-type: metadata
98487f8b156a3a1214db926474151b46f0de9361: Bug 1627250 [wpt PR 22687] - [css-filters] Migrate effect-reference-convolve-error.html test to WPT, a=testonly
Abhijeet Kandalkar <abhijeet@igalia.com> - Mon, 06 Apr 2020 22:02:11 +0000 - rev 523151
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1627250 [wpt PR 22687] - [css-filters] Migrate effect-reference-convolve-error.html test to WPT, a=testonly Automatic update from web-platform-tests [css-filters] Migrate effect-reference-convolve-error.html test to WPT Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I458f85e0dbf767df4d858a116348be0de94618e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135649 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#756422} -- wpt-commits: ef1f3389b2ca15b3c815d58ae990044ff21982e3 wpt-pr: 22687
336845ffc8f2e48431c9ea2798b73873c8ebecfd: Bug 1626700 [wpt PR 22614] - Support reverting to/from css-logical properties, a=testonly
Anders Hartvoll Ruud <andruud@chromium.org> - Mon, 06 Apr 2020 22:02:06 +0000 - rev 523150
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1626700 [wpt PR 22614] - Support reverting to/from css-logical properties, a=testonly Automatic update from web-platform-tests Support reverting to/from css-logical properties The properties defined by css-logical (and more generally surrogates) pose a hard problem for 'revert' in the StyleCascade, because declarations such as 'margin-bottom:revert' may actually need to revert to a different property in the previous origin (e.g. margin-block-end). An example is the h1 element, which is styled by html.css using css-logical properties. When the author then reverts using a corresponding physical property, we can't simply look up the cascaded value for that same physical property in the UA origin: we must be aware that the css-logical property won the cascade _at that level_. So when we we're applying an author declaration 'margin-bottom:revert', we have to find the *target property* for the revert, which is either margin-bottom (if that property won the cascade at the target origin), or the corresponding css-logical property. However, to find the target property, we need to know during the application of margin-bottom that a corresponding logical property (surrogate) needs to be taken into account. AutoSurrogateScope was created for this purpose, which sets (and resets) a "current surrogate" field on CascadeResolver. This current surrogate is used when resolving reverts, in order to find the correct target property. Also, we don't control the order in which physical/logical properties are applied. This means we could be applying the physical property first, which is unaware of any logical properties that should have been taken into account for revert. In other words, if we apply 'margin-bottom:revert' without the context of a "current surrogate" set, we'll fall back to unconditionally using margin-bottom as the target property, which may be incorrect if there also exists a logical property we'll get to later. This is why the force-reapply code exists: when both the physical and logical property exists in the cascade, the physical property must be applied (or re-applied) during AutoSurrogateScope, otherwise revert will not behave correctly. Bug: 579788 Change-Id: I864a4c9afdd94f130c42635d28d45c843d5fb617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130850 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756419} -- wpt-commits: a7b84565335bd31cbb265feca05cbef9cb4e999a wpt-pr: 22614
f39192e0d225046867a686d93fa368dfa64ac8a7: Bug 1622532 [wpt PR 22260] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 03 Apr 2020 22:02:04 +0000 - rev 523149
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1622532 [wpt PR 22260] - Update wpt metadata, a=testonly wpt-pr: 22260 wpt-type: metadata
e7688d2242a89c5bf7941fbc67dca7047c8ec4a6: Bug 1622532 [wpt PR 22260] - ImageLoader: Stop storing request KURL in Task, a=testonly
Dominic Farolino <dom@chromium.org> - Mon, 06 Apr 2020 22:01:58 +0000 - rev 523148
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1622532 [wpt PR 22260] - ImageLoader: Stop storing request KURL in Task, a=testonly Automatic update from web-platform-tests ImageLoader: Stop storing request KURL in Task This CL removes |ImageLoader::Task::request_url_| in favor of lazily parsing the image request's absolute URL when ImageLoader::Task is run. Currently ImageLoader::Task stores a KURL |request_url_|, which is a snapshot of the image's absolute URL, parsed relative to the image element's node document at the time ImageLoader::Task is queued. We shouldn't have to store a snapshot of the parsed URL, because the source URL at the time an ImageLoader::Task is run is the same as when the task is queued. The reason we stored a snapshot of the parsed URL is because what *can* change in between when an ImageLoader::Task is queued and run, is the document's base URL, via a `<base>` element. In https://crbug.com/569760 a CL was landed that takes this snapshot, so that if a `<base>` element was dynamically-inserted before the ImageLoader::Task was run, the URL would be unaffected by the addition of the `<base>`. However, the spec is very clear that the parsing of an image request's URL [1] happens after the microtask is run, meaning our snapshot is unnecessary, and incorrect. This CL: - Removes the snapshot - Fixes the associated test - Exports the test to external/wpt so other impls can benefit [1]: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:parse-a-url-2 Bug: 569760,1061685 Change-Id: I8d9e3dbefd27a26626bb930acc809196753c7506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103987 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#756376} -- wpt-commits: 2bba8a47e81d0756a7f4b9718515ff2fd42bde12 wpt-pr: 22260
9efb94044c90498327013e7b9c23b003ec6a35d4: Bug 1627343 [wpt PR 22698] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 03 Apr 2020 21:03:17 +0000 - rev 523147
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1627343 [wpt PR 22698] - Update wpt metadata, a=testonly wpt-pr: 22698 wpt-type: metadata
4841fb927848a5ed75b79e154b863061a87e3726: Bug 1627343 [wpt PR 22698] - Fix css/css-flexbox/reference/flexitem-stretch-range-ref.html, a=testonly
Antonio Gomes <tonikitoo@igalia.com> - Mon, 06 Apr 2020 22:01:49 +0000 - rev 523146
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1627343 [wpt PR 22698] - Fix css/css-flexbox/reference/flexitem-stretch-range-ref.html, a=testonly Automatic update from web-platform-tests Fix css/css-flexbox/reference/flexitem-stretch-range-ref.html After latest syncing up of WPT repository into Mozilla, css/css-flexbox/reference/flexitem-stretch-range.html started failing on Windows with a one-off pixel difference. As per dholbert's insight in [1], this patch adds "box-sizing: border-box" to css/css-flexbox/reference/flexitem-stretch-range-ref.html, so that the reference case behaves similarly to the test case in all platforms. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1626240#c5 -- wpt-commits: 7f2d258fafcc211f61eb4da42b798e5167af8f8c wpt-pr: 22698
4b1c6d633aa1351b384e5651959f9ff0a0c699ce: Bug 1627234 [wpt PR 22684] - [css-filters] Migrate css3/filters/bug419429.html test to WPT, a=testonly
Mario Sanchez Prada <mario@igalia.com> - Mon, 06 Apr 2020 22:01:44 +0000 - rev 523145
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1627234 [wpt PR 22684] - [css-filters] Migrate css3/filters/bug419429.html test to WPT, a=testonly Automatic update from web-platform-tests [css-filters] Migrate css3/filters/bug419429.html test to WPT Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I1d4b9e365ef56f8abfb0fd49c7f60598d11eb41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133935 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756331} -- wpt-commits: aa0b5bce5d73cf26f1040eb4b2f2aced858d75b7 wpt-pr: 22684
76877ca8551a3b04b859b0d46877baef14a62a04: Bug 1626916 [wpt PR 22648] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 03 Apr 2020 20:11:27 +0000 - rev 523144
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1626916 [wpt PR 22648] - Update wpt metadata, a=testonly wpt-pr: 22648 wpt-type: metadata
1471057dd6be72ae1abd6367259675a9bf254020: Bug 1626916 [wpt PR 22648] - [css-filters] Move backdrop-filter-rendering-no-background.html to WPT, a=testonly
Mario Sanchez Prada <mario@igalia.com> - Mon, 06 Apr 2020 22:01:36 +0000 - rev 523143
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1626916 [wpt PR 22648] - [css-filters] Move backdrop-filter-rendering-no-background.html to WPT, a=testonly Automatic update from web-platform-tests [css-filters] Move backdrop-filter-rendering-no-background.html to WPT Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ide9135764534d061d777e3e7f88936a8b768dc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132201 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756291} -- wpt-commits: 05aeebcb3cdcc3c395c65d9b0f4ba384b65fbb83 wpt-pr: 22648
bfd219cd0b6fa8aa1c8566e0e405ec087a97e8a7: Bug 1627252 [wpt PR 22688] - Factor UA-specific behavior out of css/css-flexbox/overflow-auto-006.html, a=testonly
Antonio Gomes <tonikitoo@igalia.com> - Mon, 06 Apr 2020 22:01:31 +0000 - rev 523142
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1627252 [wpt PR 22688] - Factor UA-specific behavior out of css/css-flexbox/overflow-auto-006.html, a=testonly Automatic update from web-platform-tests Factor UA-specific behavior out of css/css-flexbox/overflow-auto-006.html ... back to chromium web_test. The way how 'overflow:auto' elements contribute their scrollbar thickness to their intrinsic size is UA-specific [1]. This CL factors such checks out of css/css-flexbox/overflow-auto-006.html, back into blink specific web_test directory. The new test is t_p/blink/web_tests/css3/flexbox/overflow-auto-intrinsic-size.html Note: The test originated from web_tests/css3/flexbox/flexbox-height-with-overflow-auto.html, and was moved to wpt/css/css-flexbox/flexbox-overflow-auto-002.html in https://crrev.com/c/2120544 and then renamed to overflow-auto-006.html. [1] https://www.w3.org/TR/CSS22/visufx.html#overflow Issue=22580 BUG=1063749 R=robertma@chromium.org Change-Id: Ief1c2861e39a7eb66de3786e399774f647527a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135707 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#756292} -- wpt-commits: 6311c4d6e8c7bdb29ed9b6a51d55f32162c44dd9 wpt-pr: 22688
2595b7bd6d792d45c37d2beb38f0f1ece327c63a: Bug 1626909 [wpt PR 22646] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 03 Apr 2020 17:07:19 +0000 - rev 523141
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1626909 [wpt PR 22646] - Update wpt metadata, a=testonly wpt-pr: 22646 wpt-type: metadata
58b87a594a914e99ffea543aeb7f53723e9eb61c: Bug 1626909 [wpt PR 22646] - [css-filters] Migrate backdrop-filter-rendering.html test to WPT, a=testonly
Mario Sanchez Prada <mario@igalia.com> - Mon, 06 Apr 2020 22:01:22 +0000 - rev 523140
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1626909 [wpt PR 22646] - [css-filters] Migrate backdrop-filter-rendering.html test to WPT, a=testonly Automatic update from web-platform-tests [css-filters] Migrate backdrop-filter-rendering.html test to WPT Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Since there was already a similar test in WPT, this CL also renames that test to adding the -001 suffix to it, so that we can consistently add this new one as a -002 one. Additionally, this CL also adapts a bit the content of that previously existing test in order to contain as much metadata as the one being added now, that is, a link to the original chromium bug, a meta description, links to the same specs pointed also from the newly-added -002 test, and a consistent title. Bug: 1063749 Change-Id: I96781e53d1fa272d094937ff1582baac5b82c1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132161 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#756289} -- wpt-commits: 0e964d5c2f9aa11b2d28d60d42301b5329df6b33 wpt-pr: 22646
8b67dac64bafd33d42ddaee823f070ef75f81556: Bug 1627277 [wpt PR 22691] - Offscreen Canvas 2d WPT tests failing, a=testonly
Dave Tapuska <dtapuska@chromium.org> - Mon, 06 Apr 2020 22:01:17 +0000 - rev 523139
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1627277 [wpt PR 22691] - Offscreen Canvas 2d WPT tests failing, a=testonly Automatic update from web-platform-tests Offscreen Canvas 2d WPT tests failing Like crrev.com/511a3ee88713d1d851e66ea4f3f57e27d9b1cd6a the 2d text tests were failing cause they weren't waiting for the font to be ready. Use the same code I wrote in the other tests for the rest of them. BUG=1066953 Change-Id: If32fb0704a1ed1b0d96d8be1e07c94138fa2f982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135544 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#756281} -- wpt-commits: 00fcedd164f4d38caf42481c6ad27f13d9bff9b3 wpt-pr: 22691
733fe80f053d2a1bec6219d26480cbc9ef4ec52a: Bug 1627267 [wpt PR 22689] - Add missing `crossorigin` relevant mutations tests, a=testonly
Dominic Farolino <dom@chromium.org> - Mon, 06 Apr 2020 22:01:11 +0000 - rev 523138
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1627267 [wpt PR 22689] - Add missing `crossorigin` relevant mutations tests, a=testonly Automatic update from web-platform-tests Add missing `crossorigin` relevant mutations tests This CL adds a few "missing" relevant mutations WPTs; specifically, it exercises going from a valid state, to the state specified by the invalid value default, by setting an img's `crossorigin` attribute to a bogus value. R=fs@opera.com, hiroshige@chromium.org Bug: 1061685 Change-Id: I07166be176925693267c287fde53f4f09b3aeff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135542 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#756271} -- wpt-commits: 67c9dc285d7944c67b78444c0e9ead87cd0e3ae1 wpt-pr: 22689
13be3aec73b886823cb018cffd5041156991ccd8: Bug 1626701 [wpt PR 22615] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 03 Apr 2020 19:55:02 +0000 - rev 523137
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1626701 [wpt PR 22615] - Update wpt metadata, a=testonly wpt-pr: 22615 wpt-type: metadata
62c23adf7d82b35bc474c66b2fd35e666dced8c3: Bug 1626701 [wpt PR 22615] - Implement basic support for 'revert', a=testonly
Anders Hartvoll Ruud <andruud@chromium.org> - Mon, 06 Apr 2020 22:01:03 +0000 - rev 523136
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1626701 [wpt PR 22615] - Implement basic support for 'revert', a=testonly Automatic update from web-platform-tests Implement basic support for 'revert' CascadeMap now holds the cascaded declarations for the user-agent, user, and author origins separately. The 'revert' keyword is resolved to the cascaded value for the target origin before being applied to ComputedStyle. (This can happen recursively up to the kUserAgent origin. Note that 'revert' will not yet work to/from surrogates (css-logical properties), nor in @keyframes. Bug: 579788 Change-Id: I98b40d596867129e486035f9cd9f20e7b7cbe08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130268 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756268} -- wpt-commits: 4a9b8106d499cce5e63e0a8bb59aec27d47717cf wpt-pr: 22615
52837cbaef9a3895580bf5eb9eb7d4fbf8b21697: Bug 1626379 [wpt PR 22576] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 03 Apr 2020 19:23:14 +0000 - rev 523135
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1626379 [wpt PR 22576] - Update wpt metadata, a=testonly wpt-pr: 22576 wpt-type: metadata
3b6f007a9b1138e9ea1fc10139256821e79468a5: Bug 1626379 [wpt PR 22576] - [webauthn] Fix resident key credentials.get() WPT, a=testonly
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> - Mon, 06 Apr 2020 22:00:55 +0000 - rev 523134
Push 37298 by dvarga@mozilla.com at Fri, 10 Apr 2020 02:59:09 +0000
Bug 1626379 [wpt PR 22576] - [webauthn] Fix resident key credentials.get() WPT, a=testonly Automatic update from web-platform-tests [webauthn] Fix resident key credentials.get() WPT (#22576) Fix the empty allowCredentials credentials.get() WPT. The test was expecting the browser to return a non-resident credential with an undefined allowCredentials list (which defaults to empty). Moreover, the test helper itself was failing because it was expecting a credential to be added to the test. Instead, move the test to its own file that sets up the test environment to support resident keys and add rk support to the helper with the isResidentKeyTest flag that avoids appending credentials to allowCredentials. Bug: 875444 Change-Id: I8baefa3a74c2a707227df430712a09935c1fbbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130671 Reviewed-by: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#755344} Co-authored-by: Nina Satragno <nsatragno@chromium.org> -- wpt-commits: 842c83b649783d3f33dc9479738df63cf740f1ad wpt-pr: 22576
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip