bafd5fe6a0597e1224e9a18290210bcf16c4d574: Bug 1420798 - apply the 'ProofOfLock' pattern to MediaCache. r=bechen,gerald
JW Wang <jwwang@mozilla.com> - Wed, 22 Nov 2017 17:14:02 +0800 - rev 393886
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1420798 - apply the 'ProofOfLock' pattern to MediaCache. r=bechen,gerald See comment 0 for the detail. We will replace ReentrantMonitor with Monitor in the future. MozReview-Commit-ID: 63ygEFWXHZd
be664d70c5ddb5761e0d62c2778e19b5acfabbde: Bug 1408310 - Part 5: Use Servo CSS parser for DOMMatrix on Stylo. r=emilio,heycam
Boris Chiou <boris.chiou@gmail.com> - Mon, 27 Nov 2017 14:27:56 +0800 - rev 393885
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1408310 - Part 5: Use Servo CSS parser for DOMMatrix on Stylo. r=emilio,heycam We convert a _simplified_ specified transform list into a gfx matrix by Servo backend. The _simplified_ means DOMMatrix only accepts a transform list without any relative lengths, percentage, or other keywords; otherwise, we throw a SyntaxError DOMException. MozReview-Commit-ID: K8d30W0i60b
d02482644cc1f50aa42399bcae7b8e45a57a6180: Bug 1408310 - Part 4: Store mIsServo into DOMMatrixReadOnly. r=heycam
Boris Chiou <boris.chiou@gmail.com> - Tue, 14 Nov 2017 16:47:07 +0800 - rev 393884
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1408310 - Part 4: Store mIsServo into DOMMatrixReadOnly. r=heycam So we can know which backend we are using. MozReview-Commit-ID: Jfpt82lv0hw
96876638fdc3e1b8c6e980d42f68f821aff5141d: Bug 1408310 - Part 3: Replace DOMMatrixReadOnly::Identity with IsIdentity. r=smaug
Boris Chiou <boris.chiou@gmail.com> - Tue, 21 Nov 2017 16:44:49 +0800 - rev 393883
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1408310 - Part 3: Replace DOMMatrixReadOnly::Identity with IsIdentity. r=smaug According to the spec: https://drafts.fxtf.org/geometry/#dommatrixreadonly, we should use IsIdentity(), to pass most of the test cases. MozReview-Commit-ID: 7qBAmuxwhUn
d5237111097f929b82641431d9e5f799a20385d6: Bug 1408310 - Part 2: Use CSS parser for DOMMatrix::SetMatrixValue. r=baku,heycam
Boris Chiou <boris.chiou@gmail.com> - Tue, 14 Nov 2017 17:41:46 +0800 - rev 393882
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1408310 - Part 2: Use CSS parser for DOMMatrix::SetMatrixValue. r=baku,heycam Now, we use the CSS parser, instead of SVG parser, so we also need to update the tests of DOMMatrix, i.e. we don't support unitless tranform list on CSS parser. MozReview-Commit-ID: 86F992rIa4J
66904bbad7132e6932c6ba74bce21875fb829197: Bug 1408310 - Part 1: Fix nsCSSParser if we fail to parse a transform property. r=heycam
Boris Chiou <boris.chiou@gmail.com> - Mon, 20 Nov 2017 17:18:28 +0800 - rev 393881
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1408310 - Part 1: Fix nsCSSParser if we fail to parse a transform property. r=heycam We have to clean nsCSSParserImpl::mTempData up if the current parsing is failed because this nsCSSParserImpl object may be reused by other nsCSSParers, and the incorrect status may cause assertions. MozReview-Commit-ID: 75h0rHzV1Ua
6dd2a65b4c3e80d69bcc3821869fe209ccf9ccbc: Bug 1414745 - Filter out everything except STATE_IS_NETWORK in nsBrowserStatusFilter::OnStateChange. r=mconley
Samael Wang <freesamael@gmail.com> - Fri, 17 Nov 2017 10:48:37 +0800 - rev 393880
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1414745 - Filter out everything except STATE_IS_NETWORK in nsBrowserStatusFilter::OnStateChange. r=mconley The mFinishedRequests / mTotalRequests counters in nsBrowserStatusFilter has been known buggy for around a decade. With e10s we double filtered in both parent and child processes which makes it worse. There are a few problems with the counters / filter: 1. The ResetMembers() were invoked on each network request starts, which means a iframe document loading followed by the root document loading would also reset the members incorrectly. 2. The filter for non-network request was incorrect. The basic idea seems to be that if `mFinishedRequests == mTotalRequests` and `!isLoadingDocument`, it should be the STOP request right after document loading finishes, and that STOP should be delivered so listener would get symmetric numbers of START / STOP of STATE_IS_REQUEST. However some requests such as imgRequest can start after document loading finishes, in this case the START would be filtered out (since mFinishedRequests != mTotalRequests), but STOP would be delivered to the listener. It's the reason that nsBrowserStatusFilter tend to deliver much more STATE_STOP than STATE_START. 3. When applying the filter on both parent & child side, the above issues often make the mFinishedRequests / mFinishedRequests be unmatched on parent side, eseentially filtered out most non-network requests and make the progressChange based on the counters useless. Firefox no longer shows the ratio of progressChange on the UI (and the number is incorrect anyway with current nsBrowserStatusFilter), and Fennec's progress bar is based on some predefined constants [1] which doesn't rely on progressChange either, so it not necessary to keep calculating a progress number with request counters. In addition, it seems tabbrowser & browser.js mostly only care about STATE_IS_NETWORK, and Fennec has already filtered out everything else [2], it should be safe to only pass STATE_IS_NETWORK to the listener, and we get the benefit of reducing unused IPC messages. [1] https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/mobile/android/base/java/org/mozilla/gecko/Tab.java#111-115 [2] https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/mobile/android/chrome/content/browser.js#4356-4357 MozReview-Commit-ID: 5tUP5SRwDoP
56eb127b17d08d755bb28ecc249da5aaf29bd9c6: servo: Merge #19388 - stylo: Implement Servo_ParseTransformIntoMatrix (from BorisChiou:stylo/dommatrix/parser); r=emilio,heycam
Boris Chiou <boris.chiou@gmail.com> - Mon, 27 Nov 2017 20:13:34 -0600 - rev 393879
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
servo: Merge #19388 - stylo: Implement Servo_ParseTransformIntoMatrix (from BorisChiou:stylo/dommatrix/parser); r=emilio,heycam This is an inter-dependent patch of Bug 1408310. DOMMatrix needs to convert a specified transform list into a matrix, so we rewrite to_transform_3d_matrix by generics for both specified and computed transform lists. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix [Bug 1408310](https://bugzilla.mozilla.org/show_bug.cgi?id=1408310). - [X] These changes do not require tests because we can count on the wpt tests for DOMMatrix on Gecko side. Source-Repo: https://github.com/servo/servo Source-Revision: 823da9e34aacca750942c0fb53a29d6ca16c394d
2d5916de8b6d49a1875aca61bf080f85334265f7: Bug 1420792 -[CID 1422243] Execution cannot reach statement: case 4: in AnnexB::ConvertSampleTo4BytesAVCC. r=jya
James Cheng <jacheng@mozilla.com> - Mon, 27 Nov 2017 11:33:55 +0800 - rev 393878
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1420792 -[CID 1422243] Execution cannot reach statement: case 4: in AnnexB::ConvertSampleTo4BytesAVCC. r=jya We have already early returned by checking nalLenSize == 4. So there is no need to check it again, delete the deadcode. MozReview-Commit-ID: GEcPGHDslON
93b711d898fb7231ce78ef1933d56b6857a1aee3: Bug 1420792 - [CID 1422244] Box::mParent is not initialized in default constructor nor in any functions that it calls. r=jya
James Cheng <jacheng@mozilla.com> - Mon, 27 Nov 2017 11:33:35 +0800 - rev 393877
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1420792 - [CID 1422244] Box::mParent is not initialized in default constructor nor in any functions that it calls. r=jya Set Box::mParent to nullptr as a default value. MozReview-Commit-ID: E14dPzpFtcd
44dbee9aab054d6a974826c015b1378d7a9d1a0a: Backed out 1 changesets (bug 1415029) for failing in browser/components/extensions/test/browser/test-oop-extensions/browser_ext_identity_indication.js r=backout on a CLOSED TREE
shindli <shindli@mozilla.com> - Tue, 28 Nov 2017 05:00:28 +0200 - rev 393876
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Backed out 1 changesets (bug 1415029) for failing in browser/components/extensions/test/browser/test-oop-extensions/browser_ext_identity_indication.js r=backout on a CLOSED TREE Backed out changeset b247a3bf8989 (bug 1415029)
68e71221a043e05807b248d0a4b2a969777c6b64: servo: Merge #19399 - Update WR (rasterize test in transform space, render target optimizations) (from glennw:update-wr-xf-text); r=jdm
Glenn Watson <github@intuitionlibrary.com> - Mon, 27 Nov 2017 18:53:41 -0600 - rev 393875
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
servo: Merge #19399 - Update WR (rasterize test in transform space, render target optimizations) (from glennw:update-wr-xf-text); r=jdm Source-Repo: https://github.com/servo/servo Source-Revision: c93f989e11b954e5cc104502684bd8e3f353d5f3
343c49198f19f7404e6ef885a3bd48841d5b6b13: Bug 1418141: Combine taskcluster win base configs. r=jlund
Tom Prince <mozilla@hocat.ca> - Tue, 31 Oct 2017 21:01:51 -0600 - rev 393874
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1418141: Combine taskcluster win base configs. r=jlund MozReview-Commit-ID: 1CK5xdCUHbq
7e67e0f63dfdbb59482433c9f5e340812f2b11d9: Bug 1418141: Combine taskcluster win64 mozharness configs. r=jlund
Tom Prince <mozilla@hocat.ca> - Tue, 31 Oct 2017 19:16:33 -0600 - rev 393873
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1418141: Combine taskcluster win64 mozharness configs. r=jlund MozReview-Commit-ID: 5KOzNMqn4m8
336caac0487f0db9e2873a4f0ad41fecca383725: Bug 1418141: Combine taskcluster win32 mozharness configs. r=jlund
Tom Prince <mozilla@hocat.ca> - Tue, 31 Oct 2017 17:17:23 -0600 - rev 393872
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1418141: Combine taskcluster win32 mozharness configs. r=jlund MozReview-Commit-ID: ICMryQvdHCz
b247a3bf89891ffbfc011b30884ca7db8cfde137: Bug 1415029 - Use better extension icon in identity block r=johannh
Mark Striemer <mstriemer@mozilla.com> - Mon, 27 Nov 2017 11:36:10 -0600 - rev 393871
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1415029 - Use better extension icon in identity block r=johannh MozReview-Commit-ID: CFTIe9I9mfe
49312413af4e016c74fb5d18531eaa70682dec7a: Bug 1418747 - ContentCacheInParent needs to initialize mPendingCommitLength with 0 when it's created r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 27 Nov 2017 18:51:01 +0900 - rev 393870
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1418747 - ContentCacheInParent needs to initialize mPendingCommitLength with 0 when it's created r=m_kato ContentCacheInParent::mPendingCommitLength is never initialized until it receives eCompositionCommit(AsIs) event from widget or receives the latest content from the remote process when there is a composition. The bug is, immediately after dispatching eCompositionStart and first eCompositionChange event, MS Pinyin tries to query the character at caret, but ContentCacheInParent::HandleQueryContentEvent() tries to resolve related position of an eQueryTextRect event with the uninitialized mPendingCommitLength. Therefore, the query almost always fails and MS Pinyin gives up to show its candidate window. This patch just initializes the member with 0. MozReview-Commit-ID: JyYNqi8hoTa
484a51130a723c03cc57dc6c604c97f2e5d34ef9: servo: Merge #19391 - style: Add a comment about why early properties are early (from emilio:early-props-docs); r=upsuper
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 27 Nov 2017 17:42:50 -0600 - rev 393869
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
servo: Merge #19391 - style: Add a comment about why early properties are early (from emilio:early-props-docs); r=upsuper Source-Repo: https://github.com/servo/servo Source-Revision: df50a9a81cfef5161c0dbb6b47d7d1df2b921bf5
d1535dbb8e806068c5080f3c991c055d80898e7a: Bug 1419148 - Export Screenshots 25.0.0 to Firefox (except translations); r=ianbicking,kmag
Jared Hirsch <ohai@6a68.net> - Mon, 20 Nov 2017 11:06:02 -0800 - rev 393868
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1419148 - Export Screenshots 25.0.0 to Firefox (except translations); r=ianbicking,kmag MozReview-Commit-ID: 2InUwTe8oPa
2b5e9ba6041f0774196c2f7c1e94afa37c45af94: Bug 1419148 - Export Screenshots 25.0.0 to Firefox (translations only); r=ianbicking
Jared Hirsch <ohai@6a68.net> - Mon, 20 Nov 2017 11:04:56 -0800 - rev 393867
Push 32984 by cbrindusan@mozilla.com at Tue, 28 Nov 2017 09:48:29 +0000
Bug 1419148 - Export Screenshots 25.0.0 to Firefox (translations only); r=ianbicking MozReview-Commit-ID: 5vscnPIGDvN
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip