b6e041cfea34b7805a159382f70ec1da792fca8c: Bug 1387143 part 28. Remove nsISelection::AsSelection(). r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:42 -0400 - rev 417456
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 28. Remove nsISelection::AsSelection(). r=mats
d3936f9ef030138e820dd5c72871deaa48fdb145: Bug 1387143 part 27. Remove some unused nsISelection methods. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:42 -0400 - rev 417455
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 27. Remove some unused nsISelection methods. r=mats
51d48d54b078354de5e56a2f9fe8d1dd0a206a91: Bug 1387143 part 26. Remove nsISelection::Modify. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:42 -0400 - rev 417454
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 26. Remove nsISelection::Modify. r=mats
010c98256bf9c602f477a8cb20de68d281c1b664: Bug 1387143 part 25. Remove nsISelection::DeleteFromDocument. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:42 -0400 - rev 417453
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 25. Remove nsISelection::DeleteFromDocument. r=mats
1714b3b0dec5914c2fb32cb26e20c3d0a9d2e8ce: Bug 1387143 part 24. Remove nsISelection::ContainsNode. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:42 -0400 - rev 417452
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 24. Remove nsISelection::ContainsNode. r=mats
cb2fad352e0181674d7e2b4bc42ebea93f4fab5d: Bug 1387143 part 23. Remove nsISelection collapse* methods. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:41 -0400 - rev 417451
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 23. Remove nsISelection collapse* methods. r=mats
13aee20c6c4b00fa2183fa5b7f975f17ce788a86: Bug 1387143 part 22. Remove nsISelection isCollapsed/collapsed bits. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:39 -0400 - rev 417450
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 22. Remove nsISelection isCollapsed/collapsed bits. r=mats
feaacb78a655de78b106c8b1fcd6f5ad6af9c5e7: Bug 1387143 part 21. Remove nsISelection getters for anchor and focus points. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 417449
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 21. Remove nsISelection getters for anchor and focus points. r=mats Instead of copying spec-duplicating comments from nsISelection.idl to Selection.webidl, this just points the latter to the right spec.
7fc2c97cc372ee868693db92409de6571af4f59f: Bug 1387143 part 20. Remove nsISelectionPrivate. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 417448
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 20. Remove nsISelectionPrivate. r=mats
a80dee62407afee16adf2b8093eb468f262cbe68: Bug 1387143 part 19. Remove remaining methods from nsISelectionPrivate. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 417447
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 19. Remove remaining methods from nsISelectionPrivate. r=mats
aa7dc2628f1213f6fb3fb3b45dc681ae7b79abcb: Bug 1387143 part 18. Remove ScrollIntoView bits from nsISelectionPrivate. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 417446
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 18. Remove ScrollIntoView bits from nsISelectionPrivate. r=mats
146396f37e7d030a5b4fb904dc9ccf885f75e252: Bug 1387143 part 17. Remove GetRangesForInterval bits from nsISelectionPrivate. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 417445
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 17. Remove GetRangesForInterval bits from nsISelectionPrivate. r=mats
db8412ba88f25342985edf421e63d09c2428a6ab: Bug 1387143 part 16. Remove nsISelectionPrivate::GetType. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 417444
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 16. Remove nsISelectionPrivate::GetType. r=mats
4d6054f4b7e9494ce6a57c365a4565bd69ab1ad4: Bug 1387143 part 15. Remove nsISelectionPrivate::Get/SetSelectionDirection. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 417443
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 15. Remove nsISelectionPrivate::Get/SetSelectionDirection. r=mats
8bd354b5a5915bf0680ef62a866b1ae96e31a004: Bug 1387143 part 14. Remove nsISelectionPrivate::GetCachedFrameOffset. r=mats.
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 417442
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 14. Remove nsISelectionPrivate::GetCachedFrameOffset. r=mats.
0cc853cc9de3e34e590cb8f58faeb44578a8084e: Bug 1387143 part 13. Remove nsISelectionPrivate::Get/SetCanCacheFrameOffset. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 417441
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 13. Remove nsISelectionPrivate::Get/SetCanCacheFrameOffset. r=mats
70603ce0a11e5aebf35ba69b6b0d92b900525b81: Bug 1387143 part 12. Remove nsISelectionPrivate::Add/RemoveSelectionListener. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 417440
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 12. Remove nsISelectionPrivate::Add/RemoveSelectionListener. r=mats None of the C++ callers of RemoveSelectionListener care about whether the listener was already-added, and the only JS caller is in a test and knows the listener was added. So the behavior change to no-op instead of throwing when trying to remove a nonexistent listener is OK. Furthermore, the removal is null-safe, so there's no point to explicitly failing if null is passed (which it never is). Since content can't directly add selection listeners, we can just use an infallible append instead of returning errors callers don't check for anyway. Also, no one passes null to AddSelectionListener, so we don't have to worry about that part.
dd568f984ca5b3e34d2f5dfc24f6ebfb8b76f941: Bug 1387143 part 11. Support non-XPCOM weakreference on Selection. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 417439
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 11. Support non-XPCOM weakreference on Selection. r=mats This way we don't have to deal with QI to get a Selection out of a weakref. mfbt weakrefs don't have a SizeOfOnlyThis. In any case, the memory used by the weakref itself is pretty minor...
560215a5ceda5097e64fed8b9b544ce700e1807f: Bug 1387143 part 10. Remove toString bits from nsISelection and nsISelectionPrivate. r=mats.
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 417438
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 10. Remove toString bits from nsISelection and nsISelectionPrivate. r=mats.
26a0de789a136f820e45d1eaaf0521b4fd74efbf: Bug 1387143 part 9. Remove nsISelectionPrivate::Get/SetAncestorLimiter. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 417437
Push 33967 by aciure@mozilla.com at Tue, 08 May 2018 22:59:40 +0000
Bug 1387143 part 9. Remove nsISelectionPrivate::Get/SetAncestorLimiter. r=mats
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip