b5e72af686a26cae2d311217a28083b26cfb187d: No bug - Get rid of an import and sync with servo. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 29 Apr 2018 02:26:14 +0200 - rev 416189
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
No bug - Get rid of an import and sync with servo. r=me MozReview-Commit-ID: 5aGNna6ulsM
fb87372128d5fcd92e5ddc0e7d55211c0f4035d7: No bug - sync some changes from servo. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 29 Apr 2018 01:59:00 +0200 - rev 416188
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
No bug - sync some changes from servo. r=me MozReview-Commit-ID: HyRI5CfZh5w
ee0ac8a8f46e105098f953bab0bf08a17fb12fa7: Bug 1434130 part 15 - Remove kCSSRawPredefinedCounterStyles. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416187
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 15 - Remove kCSSRawPredefinedCounterStyles. r=emilio MozReview-Commit-ID: 5aiU0VChbpY
2265aba376c02ec003824714824f57cf1f4996cf: Bug 1434130 part 14 - Remove nsCSSProps::kParseVariantTable. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416186
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 14 - Remove nsCSSProps::kParseVariantTable. r=emilio The parsevariant field is not removed from nsCSSPropList.h since that file is going away soon anyway. MozReview-Commit-ID: 3nRBQtmZRKG
f31672f0c57afb5235859c3ee0123d05f8bfb360: Bug 1434130 part 13 - Use Servo code to back GetCSSValuesForProperty. r=emilio,gl
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416185
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 13 - Use Servo code to back GetCSSValuesForProperty. r=emilio,gl This causes various changes to properties-db.js and also many devtools tests get updated. There are two changes affect multiple tests: * `calc` gets removed from everywhere. We never have it listed in all properties which deserve it, and doing so without much false positive (i.e. properties don't deserve but get it) can be pretty tricky. So they are just removed for now. * The complete color keyword list is no longer included, and instead, "COLOR" is prepended to the list directly. We can probably remove the related code which replaces color keywords with "COLOR" from devtools. Note that, with stylo enabled, the list is already unrelated to what the parsing code uses. We should eventually re-enable the disabled test here after we can get the color list from cssparser in bug 1456715. Other changes to properties-db.js seem to be valid, some of them also affect tests: * `{-webkit-,}align-{content,items,self}` get `first baseline`, `safe`, `unsafe`, and lose `left` and `right`. * `{-moz-,-webkit-,}{animation,transition}{,-timing-function}` has a new `frame` keyword which is a function value in `<timing-function>`. * `{background,{-webkit-,}mask}-position-x` lose `top` and `bottom`, and correspondingly `{background,{-webkit-,}mask}-position-y` lose `left` and `right`. They don't deserve those values. * `{background,{-webkit-,}mask}{,-size}` get `auto`. * `border` shorthand loses `<image>` values as well as other keyword values for `border-image-*` subproperties, because they aren't parsed on the shorthand. * `{-moz-,}border-image{,-width}` get `auto`. * `-moz-context-properties` gets `none`. * `cursor` get some -moz-prefixed values as well as `url`. * `fill` and `stroke` get the color keywords. * `{-webkit-,}filter` get the keywords and function names. * `font` shorthand loses values from many of `font-variant-*` properties because they are not parsed there. * `font-variant` and `font-variant-alternates` get function values of the longhand. * `font-variant-{east-asian,ligatures,numeric}` get `normal`, and `font-variant-ligatures` in addition gets `none`. `font-{feature,variation}-settings` also get `normal`. * `grid` and `grid-template-{areas,columns,rows}` get `none`. * `grid`, `grid-template`, and `grid-template-{columns,rows}` get `auto`, `fit-content`, `minmax`, and `repeat`. * `grid-auto-{columns,rows}` get `auto`, `fit-content` and `minmax`. * `-moz-image-region` gets `auto` and `rect`. * `{-webkit-,}justify-content` lose `baseline`, `last baseline`, and get `safe` and `unsafe`. * `{justify,place}-items` get `first baseline`, `legacy`, `safe`, `unsafe` and lose `auto`. * `{justify,place}-self` and `place-content` get `first baseline`, `safe`, and `unsafe`. * `outline{,-style}` get `hidden`. * `scroll-snap-coordinate` gets `none`, and `scroll-snap-points-{x,y}` gets `none` and `repeat`. * `shape-outside`, `text-emphasis{,-style}` get all the keyword values and function names they deserve. * `stroke-dasharray` gets `none`. * `text-combine-upright` drops `digits` which we never implemented. * `{-moz-,-webkit-,}transform` and `-moz-window-transform` get their transform function list. `accumulatematrix` and `interpolatematrix` aren't real CSS value but they have `#[css(function)]` specified. We should probably remove them at some point. * `will-change` gets `auto`. * All properties accept `<image>` value now gets -webkit-prefixed gradient function names, including * `background{,-image}`, * `{-moz-,-webkit-,}border-image{,-source}`, and * `{-webkit-,}mask{,-image}`. MozReview-Commit-ID: E7Y0CFUFYgW
1baf959951783147c5d1a0321eb6577a0f6c1e09: Bug 1434130 part 12 - Manually implement collect_completion_keywords for some types. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416184
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 12 - Manually implement collect_completion_keywords for some types. r=emilio MozReview-Commit-ID: 6T35uylxgho
b9e4fda9a50f2cc7ab722df3e9549a9b4e653970: Bug 1434130 part 11 - Add some attributes for SpecifiedValueInfo to help deriving more from types. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416183
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 11 - Add some attributes for SpecifiedValueInfo to help deriving more from types. r=emilio MozReview-Commit-ID: IyohSTbUO31
83df94ad2416a8f603acdbdc9fccdfccea90ffba: Bug 1434130 part 10 - Handle keywords for color values. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416182
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 10 - Handle keywords for color values. r=emilio MozReview-Commit-ID: 5GvIHSeQuCX
e615f3f0029a0b7b5d169b9dbf7ea61cc86ccfd6: Bug 1434130 part 9 - Use unified list for TextDecorationLine and implement its SpecifiedValueInfo. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416181
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 9 - Use unified list for TextDecorationLine and implement its SpecifiedValueInfo. r=emilio MozReview-Commit-ID: 2sCnK1AecFk
1fc2da3cfe61153253ff19a6362cd89057f82a92: Bug 1434130 part 8 - Have TextAlign derive ToCss and unship char value from it. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416180
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 8 - Have TextAlign derive ToCss and unship char value from it. r=emilio MozReview-Commit-ID: CXDnyqzjQkq
3575c9c5228555b4e57d448220796d4ab383febc: Bug 1434130 part 7 - Have Parse derive respect #[css(skip)] on variant as well and derive Parse for KeywordSize. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416179
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 7 - Have Parse derive respect #[css(skip)] on variant as well and derive Parse for KeywordSize. r=emilio MozReview-Commit-ID: evSvk1RQGe
30d22ed91462076e8fbcfe78e631567164afda96: Bug 1434130 part 6 - Allow shorthands to specify their own impl of SpecifiedValueInfo and manual impl it for font and border. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416178
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 6 - Allow shorthands to specify their own impl of SpecifiedValueInfo and manual impl it for font and border. r=emilio MozReview-Commit-ID: 3B9OfkWU0Eq
10da0873e0a5874fcd64100a3ce3dc9a49b59452: Bug 1434130 part 5 - Derive ToCss for values::generics::font::KeywordSize. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416177
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 5 - Derive ToCss for values::generics::font::KeywordSize. r=emilio MozReview-Commit-ID: 9ek3PcqYiU3
543c9e49bfe5df7547448a28ebc663ef1620f406: Bug 1434130 part 4 - Use unified lists to impl several bitflag font-variant properties. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416176
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 4 - Use unified lists to impl several bitflag font-variant properties. r=emilio This also changes their ToCss impl to use SequenceWriter instead of checking has_value manually. SpecifiedValueInfo for those types are also implemented in this patch. MozReview-Commit-ID: 23h2VWS417H
cebd5132edfc1f48cba9ebb4561925ed4c710876: Bug 1434130 part 3 - Add SequenceWriter::item_str for writing str items. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416175
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 3 - Add SequenceWriter::item_str for writing str items. r=emilio This will be used in the next patch for font-variant bitflag types. MozReview-Commit-ID: 2IvcsnYBNqA
5edb30a5ac7b2382b6d412ce90817e7bc782d529: Bug 1434130 part 2 - Add collect_values function to SpecifiedValueInfo trait for collecting possible values. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416174
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 2 - Add collect_values function to SpecifiedValueInfo trait for collecting possible values. r=emilio This is the basic structure of the stuff. Following patches will fill the gap between Gecko and Servo on value generating, and finally hook it into InspectorUtils. MozReview-Commit-ID: KNLAfFBiY6e
44c33a20df275d8b7760493b8427f97f01ea3008: Bug 1434130 part 1 - Skip system font variant for ToCss in font subproperties. r=emilio
Xidorn Quan <me@upsuper.org> - Sun, 29 Apr 2018 09:03:31 +1000 - rev 416173
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1434130 part 1 - Skip system font variant for ToCss in font subproperties. r=emilio System font keywords are not a valid value for those properties. The newly-added #[css(skip)] would be reused by deriving algorithm of SpecifiedValueInfo to skip them as well. MozReview-Commit-ID: EmnhkaA9RR5
cd79c351e29628d110cbd01af5fd54edafbedbec: Backed out changeset 1ce48405e58a (bug 1447619) for creating bug 1457257 and bug 1457289 on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Sat, 28 Apr 2018 20:46:51 +0300 - rev 416172
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Backed out changeset 1ce48405e58a (bug 1447619) for creating bug 1457257 and bug 1457289 on a CLOSED TREE
f35994b437e3b0d9e61f74b34de2cf4cb80ab458: Merge mozilla-central to autoland. a=merge on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Sat, 28 Apr 2018 20:41:18 +0300 - rev 416171
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Merge mozilla-central to autoland. a=merge on a CLOSED TREE
6cf6124bbd25db02658997b21bf9cfdc470fdbca: Bug 1457423 - Locate android-{findbugs,lint} artifacts with updated filename. r=nalexander
Hector Zhao <bzhao@mozilla.com> - Fri, 27 Apr 2018 19:25:57 +0800 - rev 416170
Push 33918 by nerli@mozilla.com at Sun, 29 Apr 2018 09:47:13 +0000
Bug 1457423 - Locate android-{findbugs,lint} artifacts with updated filename. r=nalexander MozReview-Commit-ID: 3sVHQr4toaS
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip