b18e834a1dafe9e1b8e36585239027030e3d07e3: bug 1569875: remote: fix link to Prefs.html; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Wed, 14 Aug 2019 14:42:21 +0100 - rev 488058
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
bug 1569875: remote: fix link to Prefs.html; r=me a=doc MANUAL PUSH: doc change DONTBUILD
144fbfb409b72b5849ace2a1e3c199c259f7c1d3: Merge autoland to mozilla-central. a=merge
Brindusan Cristian <cbrindusan@mozilla.com> - Thu, 15 Aug 2019 12:43:29 +0300 - rev 488057
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Merge autoland to mozilla-central. a=merge
26094588b48e14bb39fb838196e8d489b1a4c3ee: Bug 1573886 - Fix backdrop-filter blur errors due to incorrect scaling r=kvark
Connor Brewster <cbrewster@mozilla.com> - Wed, 14 Aug 2019 20:13:06 +0000 - rev 488056
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1573886 - Fix backdrop-filter blur errors due to incorrect scaling r=kvark Differential Revision: https://phabricator.services.mozilla.com/D42013
ed066ea4b64cf7ec8253027ad11bf0f90d12c27b: Bug 1573946 - Remove unused FxA toolbar menu strings r=flod
Vijay Budhram <vbudhram@mozilla.com> - Wed, 14 Aug 2019 19:28:02 +0000 - rev 488055
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1573946 - Remove unused FxA toolbar menu strings r=flod Differential Revision: https://phabricator.services.mozilla.com/D42017
d8ac382b5f1790a5da7e2da12e4e1c92c39bb22b: Bug 1479960 - Add unit tests for shared memory freezing. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:52 +0000 - rev 488054
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Add unit tests for shared memory freezing. r=froydnj Also refactor SharedMemoryBasic::SystemProtect to allow testing cases that are expected to fail. Depends on D26748 Differential Revision: https://phabricator.services.mozilla.com/D26749
86cb672b7000844c4802bc890e7b759e42e0e722: Bug 1536697 - Fix error handling in base::SharedMemory::Map. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:51 +0000 - rev 488053
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1536697 - Fix error handling in base::SharedMemory::Map. r=froydnj If mmap failed, we'd leave the memory_ member variable set to MAP_FAILED, but everything else in this file checks for nullptr (and only nullptr) to test if the pointer is valid. Also, this removes the debug assertion that the mmap succeeded, to allow writing unit tests where we expect it to fail (e.g., for insufficient permissions). Depends on D26747 Differential Revision: https://phabricator.services.mozilla.com/D26748
87737e44c8b7537b159dfa0422ee599f85caf2c3: Bug 1426526 - Remove references to the old Chromium temporary file prefix. r=gsvelto,florian
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:43 +0000 - rev 488052
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1426526 - Remove references to the old Chromium temporary file prefix. r=gsvelto,florian With the removal of the old Chromium file_util code, we should no longer be using temporary files with names starting with "org.chromium.", so the crash reporter and main thread I/O test no longer need to recognize that prefix. Differential Revision: https://phabricator.services.mozilla.com/D34629
f936472f7576d515b673a4e42811a7daf0f3214d: Bug 1426526 - Delete file_util from ex-Chromium IPC source. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:42 +0000 - rev 488051
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1426526 - Delete file_util from ex-Chromium IPC source. r=froydnj Depends on D26746 Differential Revision: https://phabricator.services.mozilla.com/D26747
c3ca7014893cd993088b4e6ad5f333ef7eed10a9: Bug 1479960 - Convert MemMapSnapshot to use frozen shared memory. r=kmag
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:40 +0000 - rev 488050
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Convert MemMapSnapshot to use frozen shared memory. r=kmag Depends on D26745 Differential Revision: https://phabricator.services.mozilla.com/D26746
1fa598bf26998154cfc2c189a2a5f7fb862c7640: Bug 1479960 - Give SharedStringMap a magic number so that all zeroes isn't a valid instance. r=kmag
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:38 +0000 - rev 488049
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Give SharedStringMap a magic number so that all zeroes isn't a valid instance. r=kmag There was a strange bug when converting SharedStringMap to use shared memory: on Android, some tests would fail because a pref wasn't set or there was something wrong with an expected error message. The root cause was that mapping ashmem with MAP_PRIVATE results in all zeroes (see bug 1525803), but that was read as a valid SharedStringMap with length 0. To prevent any possible future issues like that, this patch adds a nonzero magic number to the header. It fits into padding on 64-bit and the cost of setting and checking it should be essentially free. Depends on D26744 Differential Revision: https://phabricator.services.mozilla.com/D26745
0f466f2a18c0fcf9e552ea07158e847f88ca9950: Bug 1479960 - Make AutoMemMap not fstat() the mapped object if it doesn't need to. r=kmag
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:36 +0000 - rev 488048
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Make AutoMemMap not fstat() the mapped object if it doesn't need to. r=kmag One problem with using shared memory instead of files for MemMapSnapshot is that AutoMemMap was trying to use fstat() to obtain the object size; that doesn't work with ashmem on Android and was causing problems with the Mac sandbox, but it's not necessary, because we already know the size. This patch changes it to not do that. Depends on D26743 Differential Revision: https://phabricator.services.mozilla.com/D26744
225411558a4eaa436ef6036eee1513427a156413: Bug 1479960 - Add freezing of IPC shared memory. r=froydnj,kmag
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:34 +0000 - rev 488047
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Add freezing of IPC shared memory. r=froydnj,kmag This allows writing to shared memory and then making it read-only before sharing it to other processes, such that a malicious sandboxed process cannot regain write access. This is currently available only in the low-level base::SharedMemory interface. The freeze operation exposes the common subset of read-only shared memory that we can implement on all supported OSes: with some APIs (POSIX shm_open) we can't revoke writeability from existing capabilies, while for others (Android ashmem) we *must* revoke it. Thus, we require that the writeable capability not have been duplicated or shared to another process, and consume it as part of freezing. Also, because in some backends need special handling at creation time, freezeability must be explicitly requested. In particular, this doesn't allow giving an untrusted process read-only access to memory that the original process can write. Note that on MacOS before 10.12 this will use temporary files in order to avoid an OS security bug that allows regaining write access; those OS versions are no longer supported by Apple (but are supported by Firefox). Depends on D26742 Differential Revision: https://phabricator.services.mozilla.com/D26743
ddfa5ff8106195214d932cedc963fe2f9191c5d0: Bug 1479960 - Fix the main thread I/O tests to handle the IPC shared memory changes. r=florian
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:33 +0000 - rev 488046
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Fix the main thread I/O tests to handle the IPC shared memory changes. r=florian The tests for unexpected main thread I/O had exemptions for the specific paths that were being used for shared memory, which would cause it to fail with the changes in this bug. This patch does two things: 1. On Linux, /dev/shm is always tmpfs (a memory filesystem), so it's not going to cause disk I/O, and it's used by glibc to implement the POSIX standard shm_open API. This allows all /dev/shm paths instead of limiting it to a hard-coded prefix. 2. On MacOS, with the patches in this bug, we'll no longer use temporary files for shared memory on current OS versions, but we still need them on older versions to avoid an OS bug (https://crbug.com/project-zero/1671), and they are backed by disk in this case, so we want to allow only the IPC files. However, the path prefix has changed. Differential Revision: https://phabricator.services.mozilla.com/D34628
6da235c5a77c5fc23b11a7456c588974f1de878c: Bug 1479960 - Clean up shared_memory_posix error handling. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:31 +0000 - rev 488045
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Clean up shared_memory_posix error handling. r=froydnj This uses RAII to handle error-case cleanup in the POSIX backend for SharedMemory::Create, to simplify the complexity that will be added to support freezing. Depends on D26741 Differential Revision: https://phabricator.services.mozilla.com/D26742
bdf7a041928aa4673de020df11c069e0af996d50: Bug 1479960 - Fix max_size in shared_memory_posix. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:29 +0000 - rev 488044
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Fix max_size in shared_memory_posix. r=froydnj The Unix backend for shared memory needs to keep the mapped size to pass to munmap, while the Windows backend doesn't. Currently it's reusing the max_size field, and then zeroing it when it's unmapped, which breaks the freezing use case. This patch uses a dedicated field for that. Depends on D26740 Differential Revision: https://phabricator.services.mozilla.com/D26741
f814f58d43d66df993d9d9d492ec39c1417b1a3d: Bug 1479960 - Get rid of base::SharedMemory::handle. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:22 +0000 - rev 488043
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Get rid of base::SharedMemory::handle. r=froydnj Despite the comment saying not to use the "handle" except as an opaque identifier, it is being used to pass the handle to other OS APIs. Direct access to the handle needs to be controlled to make sure freezing is safe, so this patch replaces that with interfaces that are more explicit about ownership and lifetime. Depends on D26739 Differential Revision: https://phabricator.services.mozilla.com/D26740
16d99c5a8a550366c7785edaeadf67c14d7151f1: Bug 1479960 - Remove SHM_ANON support. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:20 +0000 - rev 488042
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Remove SHM_ANON support. r=froydnj FreeBSD's SHM_ANON is useful for the usual case of shared memory, but it doesn't support freezing. It could be re-added later, but for now it's simplest to remove it (and use named shm instead) while refactoring. Depends on D26738 Differential Revision: https://phabricator.services.mozilla.com/D26739
9b390150ec32771f276b47186e7467bc68d6fb5c: Bug 1573997 - Use correct stride when repainting, r=loganfsmyth.
Brian Hackett <bhackett1024@gmail.com> - Wed, 14 Aug 2019 22:47:51 +0000 - rev 488041
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1573997 - Use correct stride when repainting, r=loganfsmyth. Differential Revision: https://phabricator.services.mozilla.com/D42044
7710c9d9b6b0b2f8f51b0d3d4e9dea3753201b25: Backed out changeset c60ee628dd0e (bug 1571711) for RemoteSandboxBroker related bustages CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Thu, 15 Aug 2019 01:50:01 +0300 - rev 488040
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Backed out changeset c60ee628dd0e (bug 1571711) for RemoteSandboxBroker related bustages CLOSED TREE
77b5eec7b9e5b3f1fdf55bab886cc9391cd8a536: Bug 1573968 - Remove WheelTransaction::Prefs. r=njn
Kristen Wright <kwright@mozilla.com> - Wed, 14 Aug 2019 22:18:59 +0000 - rev 488039
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1573968 - Remove WheelTransaction::Prefs. r=njn All of these prefs are already static prefs, so this removes the varcache pref definitions from WheelTransaction and replaces them with the existing static prefs. Differential Revision: https://phabricator.services.mozilla.com/D42040
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip