b085b41c10ce17ce0315234a48292e14513bca6f: Bug 1587741 - Captive Portal Service should use a new detector when we start again r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 10 Oct 2019 15:26:55 +0000 - rev 497304
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1587741 - Captive Portal Service should use a new detector when we start again r=mayhemer If the captive portal service is disabled then enabled again when in a captive portal, we sometimes don't send the captive-portal-login observer notification because we're reusing the same mCaptiveDetector object, which believes it's already sent it. We should use do_CreateInstance instead of do_GetService for this. Differential Revision: https://phabricator.services.mozilla.com/D48819
624eb2d8080b1e7a19d6207f8232d6a185f65293: Bug 1585684. Fix error message for permission failures when passing a union member. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 09 Oct 2019 09:22:05 +0000 - rev 497303
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1585684. Fix error message for permission failures when passing a union member. r=peterv The new error message is still not great, but it's a lot better than having %s as the description of what's going on. Differential Revision: https://phabricator.services.mozilla.com/D47915
aedc45de64b3e561e8f4ddd9311ac99af5367aff: Bug 1586887: Return WindowProxyHolder rather than BrowsingContext from Window WebIDL getters. r=nika
Kris Maglione <maglione.k@gmail.com> - Fri, 11 Oct 2019 19:32:09 +0000 - rev 497302
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1586887: Return WindowProxyHolder rather than BrowsingContext from Window WebIDL getters. r=nika Differential Revision: https://phabricator.services.mozilla.com/D48429
c0029f42afd2873d7a7f3a5db4b40bfbb3865e18: Bug 1586911: Silence SHEntry assertion after local->remote->local iframe navigation. r=peterv
Kris Maglione <maglione.k@gmail.com> - Fri, 11 Oct 2019 19:32:02 +0000 - rev 497301
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1586911: Silence SHEntry assertion after local->remote->local iframe navigation. r=peterv When we have a parser-created iframe which starts out in-process, transitions to remote, and then transitions back to in-process, we create separate DocShells for the first and last in-process loads. Since both are network-created, and have the same child index, they both try to add themselves as children to their parent's SHistory at the same index. And since the entry for the first DocShell already exists at that index when we try to add the second, that triggers an assertion. This isn't really ideal, but it is expected given the current state of session history under Fission. It should hopefully be solved more gracefully when the Fission-aware session history rewrite is done, but in the mean time, I think we should just ignore the conflict, since it's expected. Differential Revision: https://phabricator.services.mozilla.com/D48437
b1a2422a6fa07aae5e95ebe3ac549548fb62785e: Bug 1568249. Remove all the LegacyQueryInterface machinery from Web IDL. r=edgar
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 07 Oct 2019 13:12:55 +0000 - rev 497300
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1568249. Remove all the LegacyQueryInterface machinery from Web IDL. r=edgar Differential Revision: https://phabricator.services.mozilla.com/D48250
d3f5f69f38a829af852593d2202976e67598d883: Bug 1568883. Remove the QI implementation from Web IDL elements. r=peterv,mossop
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 09 Oct 2019 09:19:32 +0000 - rev 497299
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1568883. Remove the QI implementation from Web IDL elements. r=peterv,mossop The XBL test is being removed because it was the only remaining consumer of xbl's implements="interfacename" in the tree, and was triggering QI on elements for that codepath. I've verified that a try run that MOZ_CRASHes when the C++ binding QueryInterface implementation is invoked is green with these changes. Differential Revision: https://phabricator.services.mozilla.com/D48249
a3d7e24bd090c093fc9822a83402f7c3502a4d5b: Bug 1586926 - Add necessary caller access checks for cross-process Location navigations. r=nika
Kris Maglione <maglione.k@gmail.com> - Thu, 10 Oct 2019 19:36:23 +0000 - rev 497298
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1586926 - Add necessary caller access checks for cross-process Location navigations. r=nika We attempt to enforce the same (approximate) access checks to Location-based navigation that we use for loads that use named targeting (e.g., via window.open), so that a frame that can't be navigated via, e.g., window.open, also can't be navigated via, e.g., window.parent[1].location = url. For the in-process case, this is handled by a somewhat hidden call to CheckLoadingPermissions() in nsDocShell::InternalLoad, where the former checks whether the principal of whatever JS context happens to be on the stack subsumes the principal of the target DocShell or any of its ancestors, and blocks the load if it doesn't. Since there is no JS context on the stack when we call into the DocShell loading code in the cross-process case, the check is simply ignored. So we need to instead do the check in BrowsingContext::LoadURI, where we already have an explicit accessor, and can simply use the standard access checks that we use elsewhere. Differential Revision: https://phabricator.services.mozilla.com/D48443
f9209979c9bfe7c97d13f80fd507cd779af26fd8: Bug 1579940 - Setup WNP for users coming from <70.0 and receiving the 70.0 release, DONTBUILD NPOTB, r=aki, a=release
Jordan Lund <jlund@mozilla.com> - Fri, 11 Oct 2019 19:16:06 +0000 - rev 497297
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1579940 - Setup WNP for users coming from <70.0 and receiving the 70.0 release, DONTBUILD NPOTB, r=aki, a=release Differential Revision: https://phabricator.services.mozilla.com/D49008
daf34421eaa9757d83259fa98db64e475fa9949e: Bug 1587905 - Remove useless variable 'bytesAllocated' declaration & assignation r=sfink
Sylvestre Ledru <sledru@mozilla.com> - Fri, 11 Oct 2019 19:06:41 +0000 - rev 497296
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1587905 - Remove useless variable 'bytesAllocated' declaration & assignation r=sfink Differential Revision: https://phabricator.services.mozilla.com/D48888
31d32668afb5e427b8d50ffca875ee7c7faa4a41: Bug 1584630. Implement missing property use counters for HTMLDocument. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 11 Oct 2019 16:56:36 +0000 - rev 497295
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1584630. Implement missing property use counters for HTMLDocument. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D47504
c5e6477c3a245a97d4c3cdd5d3e406f8abaf94ad: Backed out changeset a8ea98346a87 (bug 1562057) for reftest failures on contain-size-select-elem-002 . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Fri, 11 Oct 2019 21:12:58 +0300 - rev 497294
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Backed out changeset a8ea98346a87 (bug 1562057) for reftest failures on contain-size-select-elem-002 . CLOSED TREE
3d1ed8b2fb91d2df8d01c9023ebc7c89967c7278: Bug 1586593 - dispatch CloseInt on DataChannel Open ACK failure - r=bwc
Nico Grunbaum <na-g@nostrum.com> - Fri, 11 Oct 2019 17:03:23 +0000 - rev 497293
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Bug 1586593 - dispatch CloseInt on DataChannel Open ACK failure - r=bwc Differential Revision: https://phabricator.services.mozilla.com/D48938
6232b11cd533b5bd676b92bb1abe190a94362324: Bug 1585196 - Cleanup LazyScriptCreationData, r=mgaudet
Alok Nikhil <anikhil@cisco.com> - Fri, 11 Oct 2019 15:38:51 +0000 - rev 497292
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Bug 1585196 - Cleanup LazyScriptCreationData, r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D48915
bd59f7b7bb8ac8c2e011391923838c1cd7b35d04: Bug 1583795 - Select the first breached login when breaches are set initially. r=sfoster
Jared Wein <jwein@mozilla.com> - Fri, 11 Oct 2019 17:35:54 +0000 - rev 497291
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Bug 1583795 - Select the first breached login when breaches are set initially. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D48764
12ff69a8f36063cfc440216c21c6bacb53540ffd: Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Edouard Oger <eoger@fastmail.com> - Fri, 11 Oct 2019 17:06:57 +0000 - rev 497290
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D48410
a8ea98346a87402b1c3ad4c892694d0de163a0b3: Bug 1562057: Change size-contained & empty select elements to have the same inline-size. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 11 Oct 2019 16:51:41 +0000 - rev 497289
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Bug 1562057: Change size-contained & empty select elements to have the same inline-size. r=TYLin Per the css-contain specification, size contained elements must be sized as if they were empty. Up until now, we've been handling that by just using "0" as the intrinsic size of some components, but that doesn't actually match the size of a "true" empty select, which has some nonzero width from: (a) the default inline-axis padding on the display frame (added in a rule for the ::-moz-display-comboboxcontrol-frame pseudo, in forms.css). (b) the width (inline-size) of the display frame's "placeholder" space character, which has a small intrinsic width (but which really only exists for *block-axis* sizing and alignment, when no option is selected from the dropdown). This patch addresses issue (a) by explicitly adding the display frame's inline-axis padding to size-contained elements, and it addresses issue (b) by changing to use a zero-width space character in empty select elements. So: as of this patch, size-contained select elements are getting a little wider (to address (a)), and empty select elements are also getting a little skinnier (to address (b)), and they'll end up being the same width. (I chose U+FEFF "zero-width non-breaking-space" since we were previously using a non-breaking space character. I'm not sure if the non-breaking aspect matters, but I figured I'd preserve that to be on the safe side.) Differential Revision: https://phabricator.services.mozilla.com/D48791
dd505f86478140e9876367ab5a6e19c453e792a7: Bug 1576160 - Turn on the display of default private search engine feature for nightly/early beta users. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 11 Oct 2019 07:22:23 +0000 - rev 497288
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Bug 1576160 - Turn on the display of default private search engine feature for nightly/early beta users. r=mak Differential Revision: https://phabricator.services.mozilla.com/D47223
c7f931c95c789a1b997941f16ee53eb5a942f3f1: Bug 1587366 - Fix VRManagerParent::GetVRActiveStatus race condition: Notify VRActiveStatus after a the VREventObserver is created. r=rbarker,daoshengmu
Imanol Fernandez <mortimergoro@gmail.com> - Fri, 11 Oct 2019 15:58:39 +0000 - rev 497287
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Bug 1587366 - Fix VRManagerParent::GetVRActiveStatus race condition: Notify VRActiveStatus after a the VREventObserver is created. r=rbarker,daoshengmu Notify VRActiveStatus after a the VREventObserver is created to prevent the VRManagerParent::GetVRActiveStatus race condition. Call VRManager::Shutdown() when the app goes to background instead of calling it in the foreground event due to the inactivity timer. Differential Revision: https://phabricator.services.mozilla.com/D48678
825cabc4070898ef3f87135e10129e211371ab58: Bug 1586997 - Fix focusing the first input of edit bookmark dialogs. r=mak
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 11 Oct 2019 14:16:42 +0000 - rev 497286
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Bug 1586997 - Fix focusing the first input of edit bookmark dialogs. r=mak Differential Revision: https://phabricator.services.mozilla.com/D48955
c51f3b5c78ad30cbebc0a94419f342a6b5350191: Bug 1587784 - expect the additional onSecurityChange update that comes with a remoteness change in fission in browser_alltabslistener.js, r=dao
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 11 Oct 2019 15:12:22 +0000 - rev 497285
Push 36681 by cbrindusan@mozilla.com at Fri, 11 Oct 2019 21:50:12 +0000
Bug 1587784 - expect the additional onSecurityChange update that comes with a remoteness change in fission in browser_alltabslistener.js, r=dao Differential Revision: https://phabricator.services.mozilla.com/D48853
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip