acb1fa0ef8abd9cc009d8495815026759387fc8c: No bug: [mozharness] Remove unused `graph_selector` config; r=nthomas
Tom Prince <mozilla@hocat.ca> - Thu, 06 Feb 2020 22:33:56 +0000 - rev 512813
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
No bug: [mozharness] Remove unused `graph_selector` config; r=nthomas Differential Revision: https://phabricator.services.mozilla.com/D61613
3a2b9a92fb242491f42623ecdf3b3246f49664ba: No bug: [mozharness] Remove some remaining references to the build/tools repo; r=nthomas
Tom Prince <mozilla@hocat.ca> - Thu, 06 Feb 2020 22:38:12 +0000 - rev 512812
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
No bug: [mozharness] Remove some remaining references to the build/tools repo; r=nthomas Differential Revision: https://phabricator.services.mozilla.com/D61612
7afd7e7e531fc94b30ed47af3957949aaf2e2971: No bug: [mozharness] Stop removing `mach_build_properties.json`; r=nthomas
Tom Prince <mozilla@hocat.ca> - Thu, 06 Feb 2020 22:36:09 +0000 - rev 512811
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
No bug: [mozharness] Stop removing `mach_build_properties.json`; r=nthomas The file is not referenced anywhere else in tree. Differential Revision: https://phabricator.services.mozilla.com/D61611
5d3e1eab99b8bdfba6e53f5615ceba7330138894: No bug: [mozharness] Remove unreferenced `releng_infra_configs` config files; r=nthomas
Tom Prince <mozilla@hocat.ca> - Thu, 06 Feb 2020 22:51:50 +0000 - rev 512810
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
No bug: [mozharness] Remove unreferenced `releng_infra_configs` config files; r=nthomas Differential Revision: https://phabricator.services.mozilla.com/D61610
66d07ba43d6def0cfb7a344e5784aca055856b81: Bug 1557739 - Be more consistent with IPC Transport APIs, r=jld
Nika Layzell <nika@thelayzells.com> - Thu, 06 Feb 2020 22:41:56 +0000 - rev 512809
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1557739 - Be more consistent with IPC Transport APIs, r=jld Differential Revision: https://phabricator.services.mozilla.com/D60285
1d190ee669ee3d1ef14ffd79b001dacdc801994d: Bug 1582832 - Update expectation for closed-attribute.window.html on fission a=test-only
Bogdan Tara <btara@mozilla.com> - Fri, 07 Feb 2020 00:34:51 +0200 - rev 512808
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1582832 - Update expectation for closed-attribute.window.html on fission a=test-only
ec33b0bf8c04ac254af3a491934228f9e50ae070: Bug 1613561 - Remove check_test_env from mozharness configs. r=dmajor
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Feb 2020 16:11:02 +0000 - rev 512807
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1613561 - Remove check_test_env from mozharness configs. r=dmajor This config item hasn't been used in the mozharness code since bug 1575471, and hasn't been useful since gtest and xpcshell tests moved out of `make check`. Differential Revision: https://phabricator.services.mozilla.com/D61776
91db369c965a3316a495dfc013d9884d3f9416dd: Bug 1606018 - Make sure edit context menu also appears on inputs inside shadow trees. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 06 Feb 2020 19:15:17 +0000 - rev 512806
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1606018 - Make sure edit context menu also appears on inputs inside shadow trees. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D61847
c76d8b822e3c503565560f4f73e1ca5d04621e35: Bug 1611701 - Tweak NODE_IS_EDITABLE flag handling for NAC so that it works consistently for <input type=number>. r=bzbarsky,masayuki,whimboo
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Feb 2020 22:15:19 +0000 - rev 512805
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1611701 - Tweak NODE_IS_EDITABLE flag handling for NAC so that it works consistently for <input type=number>. r=bzbarsky,masayuki,whimboo I thought this would fix <input type=number style="user-select: none">, but turns out it doesn't. <input type=number> doesn't have the editor root as a root of the anonymous subtree, so the current hack wouldn't work, as the anon root wouldn't have the editable flag. So tweak the code a bit to handle stuff in a simpler way than setting the flags after the fact, and set the NAC-root flag earlier to avoid the mOuterWrapper->AppendChildTo(root) call forgetting about root's flags. I had to tweak one AccessibleCaret test, but that's because it uses <textarea> with user-select: none, and our behavior there is not particularly sane. It just happened to work because that test-case also had a bunch of contenteditable elements, and we stop matching this rule: https://searchfox.org/mozilla-central/rev/220a3bd6063fcbe5ca50e88dcabdc7dee0aca448/layout/style/contenteditable.css#22 Because the anonymous div now properly matches :-moz-read-write, which made the rule apply and the test work. See comment 4 of this bug. I'll fix this stuff up and add some tests for our behavior here in bug 1611699. I refactored the dragdrop tests to cover more input types, but I ended up not being able to use them because they're dependent on the content. Instead I added an extra test and changed the refactor so that it applies to <input type=search>, as there's layout work going on in bug 558594, and it'd be unfortunate to regress this there too. Differential Revision: https://phabricator.services.mozilla.com/D61094
5a866419f68917aa52ede96a700f94307c6614a5: Bug 1611457 - Respect script blocker in JSWindowActor, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Tue, 04 Feb 2020 18:16:07 +0000 - rev 512804
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1611457 - Respect script blocker in JSWindowActor, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61354
0dad93b4c73d2d11bf4ea7e84a1b1b55a545434d: Bug 1612724 - Part 2: Use NotifyWhenScriptSafe for MediaManager notifications, r=jib
Nika Layzell <nika@thelayzells.com> - Thu, 06 Feb 2020 21:57:52 +0000 - rev 512803
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1612724 - Part 2: Use NotifyWhenScriptSafe for MediaManager notifications, r=jib Differential Revision: https://phabricator.services.mozilla.com/D61601
e39d469b0c0d2cadccc0e2f91b24f95ec55c4a80: Bug 1612724 - Part 1: Add a NotifyWhenScriptSafe helper method to nsIObserverService, r=froydnj
Nika Layzell <nika@thelayzells.com> - Tue, 04 Feb 2020 22:09:34 +0000 - rev 512802
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1612724 - Part 1: Add a NotifyWhenScriptSafe helper method to nsIObserverService, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D61600
8ac8dc6e0638063e97fc5ccb9b14ab0522fbb8f4: Bug 1613013 part 3. Annotate TypeErrors and RangeErrors from WebIDL implementations with the method they come from. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 06 Feb 2020 21:22:32 +0000 - rev 512801
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1613013 part 3. Annotate TypeErrors and RangeErrors from WebIDL implementations with the method they come from. r=peterv Please review the changes to Errors.msg very carefully. I caught a number of mistakes there in self-review (e.g. not renumbering replacement markers correctly when I added {0} to the beginnings of strings), and my confidence that I caught them all is only middling. A few lines (MSG_USELESS_SETTIMEOUT, MSG_TYPEDARRAY_IS_DETACHED, MSG_NOT_SUBMIT_BUTTON) were removed from Errors.msg either because they were already unused or because they either were single-user constant strings or became such in the new setup and we could just use the string version of ThrowTypeError. Differential Revision: https://phabricator.services.mozilla.com/D61523
d396725817cdda2418b4fa43f487f334653067e7: Bug 1613013 part 2. Change ThrowErrorMessage to be templated on the error number. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 06 Feb 2020 20:40:36 +0000 - rev 512800
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1613013 part 2. Change ThrowErrorMessage to be templated on the error number. r=peterv This makes it easier to static_assert correct use. It caught several bugs in the next patch in this stack. I had to disambiguate some calls to the templated ThrowDOMException that are inside the binding_detail namespace, because otherwise they were trying to call teh non-template function of the same name that's declared in binding_detail. Differential Revision: https://phabricator.services.mozilla.com/D61522
c9ac45b91718d501e59fe09f7963ba9413e65512: Bug 1613013 part 1. Annotate DOMExceptions from WebIDL implementations with the method they come from. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 06 Feb 2020 21:16:10 +0000 - rev 512799
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1613013 part 1. Annotate DOMExceptions from WebIDL implementations with the method they come from. r=peterv This adds the name of the interface and method to the beginning of the exception string when reporting the exception from Web IDL codegen, so it's clearer what was called. Some existing error messages are adjusted to not duplicate the information about which method was called. Differential Revision: https://phabricator.services.mozilla.com/D61521
319b53c8e3721449943b9ac01d645c38e888ef91: Bug 1604667 - Handle case where relativesrcdir doesn't exist on Windows r=firefox-build-system-reviewers,mshal
Ricky Stewart <rstewart@mozilla.com> - Wed, 05 Feb 2020 00:06:17 +0000 - rev 512798
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1604667 - Handle case where relativesrcdir doesn't exist on Windows r=firefox-build-system-reviewers,mshal Differential Revision: https://phabricator.services.mozilla.com/D59355
542f59024db299c10db5faecef1b05b57737dfa3: Backed out changeset b0e6dad6ff01 (bug 1606018) for causing failures in BrowsingContext.h
Mihai Alexandru Michis <malexandru@mozilla.com> - Thu, 06 Feb 2020 23:29:07 +0200 - rev 512797
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Backed out changeset b0e6dad6ff01 (bug 1606018) for causing failures in BrowsingContext.h CLOSED TREE
51250763258f4f25aeefbf32259981adebf50645: Backed out changeset c9f4dd3ed78b (bug 1606628) for causing failures in ImageLoader.cpp
Mihai Alexandru Michis <malexandru@mozilla.com> - Thu, 06 Feb 2020 23:19:55 +0200 - rev 512796
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Backed out changeset c9f4dd3ed78b (bug 1606628) for causing failures in ImageLoader.cpp CLOSED TREE
c9f4dd3ed78b916078cbc1ce5028c12e737c2fbf: Bug 1606628 - Remove nsStyleImageRequest. r=tnikkel,heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Feb 2020 20:32:59 +0000 - rev 512795
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1606628 - Remove nsStyleImageRequest. r=tnikkel,heycam This removes nsStyleImageRequest by moving the load state to LoadData instead (where other lazy state like the resolved URL and load id lives). That way we can use cbindgen for more stuff (there's no blocker for using it for all images now), and we can undo the image tracking shenanigans that I had to do in bug 1605803 in nsImageFrame. This removes the mDocGroup member because well, there's no real upside of that now that quantum DOM is not a thing. It also removes the static clones of the image requests, and the need for each computed value instance to have its own request. These were needed because we needed the image loader for the particular document to observe the image changes. But we were also tracking the request -> loader for other purposes. Instead, Now all the images get loaded with GlobalImageObserver as a listener, which looks in the image map and forwards the notification to all the interested loaders instead dynamically. The style value is only responsible to load the image, and no longer tracks / locks it. Instead, the loader does so, via the image tracker. Differential Revision: https://phabricator.services.mozilla.com/D58519
de38640b1c7b8d9d3e35a160f07681ee88c0f6d7: Bug 1593310 - Add support for clearing all messages impressions by a provider in newtab devtools r=emcminn
Punam Dahiya <punamdahiya@yahoo.com> - Thu, 06 Feb 2020 20:20:01 +0000 - rev 512794
Push 37098 by csabou@mozilla.com at Fri, 07 Feb 2020 03:55:51 +0000
Bug 1593310 - Add support for clearing all messages impressions by a provider in newtab devtools r=emcminn Differential Revision: https://phabricator.services.mozilla.com/D59226
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip