ac0d06c0ca9330d5356717094910e977cf8f6c29: Bug 1624080 - Simplify the implementation of HasAuthorSpecifiedRules. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Mar 2020 13:23:42 +0000 - rev 520552
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1624080 - Simplify the implementation of HasAuthorSpecifiedRules. r=heycam This patch computes the author-specified properties during the CSS cascade, and removes the complex rule-tree-based implementation that tries to do the cascade again. This changes behavior in two ways, one of them which is not observable to content, I believe: * revert now re-enables the native styling. This was brought up in https://github.com/w3c/csswg-drafts/issues/4777 and I think it is a bug-fix. This is observable to content, and I'm adding a test for it. * We don't look at inherited styles from our ancestors when `inherit` is specified in a non-author stylesheet. This was introduced for bug 452969 but we don't seem to inherit background anymore for file controls or such. It seems back then file controls used to have a text-field. I audited forms.css and ua.css and we don't explicitly inherit padding / border / background-color into any nested form control. We keep the distinction between border/background and padding, because the later has some callers. I think we should try to align with Chromium in the long run and remove the padding bit. We need to give an appearance to the range-thumb and such so that we can assert that we don't call HasAuthorSpecifiedRules on non-themed stuff. I used a new internal value for that. Differential Revision: https://phabricator.services.mozilla.com/D67722
a5255aaee6ad48974932e064328d8cd11e21bbc0: Bug 1624704 - Part 2 - Remove references to previousResult in UnifiedComplete. r=mak
Harry Twyford <htwyford@mozilla.com> - Wed, 25 Mar 2020 22:40:11 +0000 - rev 520551
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1624704 - Part 2 - Remove references to previousResult in UnifiedComplete. r=mak Differential Revision: https://phabricator.services.mozilla.com/D68099
4d7451d0f3dd971a62446117d3bea8668e5cce02: Bug 1624704 - Part 1 - Remove UrlbarUtils.INSERTMETHOD. r=mak
Harry Twyford <htwyford@mozilla.com> - Wed, 25 Mar 2020 17:09:59 +0000 - rev 520550
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1624704 - Part 1 - Remove UrlbarUtils.INSERTMETHOD. r=mak Differential Revision: https://phabricator.services.mozilla.com/D68098
3b4a8229aacfe0b89aaeb0543b29494c6bd765c2: Bug 1624813 - Update raptor tests to mitm 5.0.1 r=perftest-reviewers,AlexandruIonescu
Florin Strugariu <fstrugariu@mozilla.com> - Thu, 26 Mar 2020 06:46:01 +0000 - rev 520549
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1624813 - Update raptor tests to mitm 5.0.1 r=perftest-reviewers,AlexandruIonescu Differential Revision: https://phabricator.services.mozilla.com/D68170
73d3541cb9700c40059e2e92e72cf151fecc3e7e: Bug 1624298 - Ensure that derived types are right for optimized-away implementations. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Mar 2020 13:04:20 +0000 - rev 520548
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1624298 - Ensure that derived types are right for optimized-away implementations. r=heycam We have this optimization where, for non-generic structs, we generate just a clone / move as the ToComputedValue / ToResolvedValue implementation. This moves the optimization a bit further down, and refines it so that we still generate all the relevant where clauses that make it sound, that is, that all the ToComputedValue implementations of the fields return the same type. Otherwise this wouldn't be sound and the type would need to become generic. We add an escape hatch (no_field_bound) for fields that need to be cloned but which don't implement the trait. This is right now only for the RefPtr<> in the shared font-family list, and a piece of code in PaintWorklet which looks kinda fishy, and probably should be fixed (but we don't ship it in Firefox and there's a pre-existing FIXME for servo, so I punted on it for now). The other thing this patch does is adding a bunch of ToComputedValue / ToResolvedValue implementations that are trivial and were missing. Differential Revision: https://phabricator.services.mozilla.com/D67913
c774a4b050e163551e0706a7f10e3134aa588c93: Bug 1625109 - For `Coverity` review-time analysis add complete analysis output to the artifacts. r=bastien
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 26 Mar 2020 12:52:21 +0000 - rev 520547
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1625109 - For `Coverity` review-time analysis add complete analysis output to the artifacts. r=bastien Differential Revision: https://phabricator.services.mozilla.com/D68350
6b86d0dfff95a0a836ca60cf1691deab8c9d056f: Bug 1303775 - Fix race conditions prevalent with closing captive portal tabs that re-direct to the canonicalURL after successful login/abort. r=johannh,nhnt11
prathiksha <prathikshaprasadsuman@gmail.com> - Thu, 26 Mar 2020 12:43:11 +0000 - rev 520546
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1303775 - Fix race conditions prevalent with closing captive portal tabs that re-direct to the canonicalURL after successful login/abort. r=johannh,nhnt11 Differential Revision: https://phabricator.services.mozilla.com/D65554
18f5ed3410b9db480e5fe20d431ef29dd25056cd: Bug 1624829 - Use FunctionRef for various Enumerate* callbacks. r=edgar
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Mar 2020 12:44:47 +0000 - rev 520545
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1624829 - Use FunctionRef for various Enumerate* callbacks. r=edgar This avoids a bunch of ugly casts and void pointers, without much overhead (unlike std::function or such). Differential Revision: https://phabricator.services.mozilla.com/D68182
9911fb33115594e5bd957b67f1d8b0219efaae9f: Bug 1614443 - added browsertime usage command(--browsertime-help) r=sparky,perftest-reviewers
Myeongjun Go <myeongjun.ko@gmail.com> - Thu, 26 Mar 2020 12:44:08 +0000 - rev 520544
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1614443 - added browsertime usage command(--browsertime-help) r=sparky,perftest-reviewers Differential Revision: https://phabricator.services.mozilla.com/D67985
58c3533fd95a962487b976a4a129dc6e67f7596a: Bug 1618198 part 29 - Implement JSOp::Pos. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Thu, 26 Mar 2020 09:41:50 +0000 - rev 520543
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1618198 part 29 - Implement JSOp::Pos. r=iain Note that JSOp::Pos used to be very hot because it was used to implement the increment and decrement operators, but for BigInt these were changed to use JSOp::ToNumeric. JSOp::Pos is now only used for the +x operator. IonBuilder compiles +x as x * 1, but that results in complexity elsewhere (ICs and CacheIR inlining for example). It's simpler to follow JSOp::ToNumeric/MToNumeric with an MToNumber instruction. The patch adds the most basic implementation of this (still reasonably fast because it checks for numbers inline). This also nicely matches what Baseline does. Differential Revision: https://phabricator.services.mozilla.com/D68192
1bedd35b63bf70e6f4b5db06356fcf62ec6b8328: Bug 1618198 part 28 - Support JSOp::Rest. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Thu, 26 Mar 2020 09:41:50 +0000 - rev 520542
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1618198 part 28 - Support JSOp::Rest. r=iain Also folds MRestCommon into MRest. The MRestCommon base class was added for the PJS version of MRest but PJS was removed a long time ago. Differential Revision: https://phabricator.services.mozilla.com/D68184
d3f2d9592869b925fbefe4ecf90ca62bae5d3c69: Bug 1623858: part 14) Incorporate feedback of part 12. r=smaug
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 26 Mar 2020 12:23:30 +0000 - rev 520541
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1623858: part 14) Incorporate feedback of part 12. r=smaug Forgot to update the review on Phabricator. Differential Revision: https://phabricator.services.mozilla.com/D68333
f733f4c24b29a5e0e27cf3b9420f9ebcfffd75eb: Bug 1624921 [Linux/X11] Use CSD for PIP windows only, r=jhorak
Martin Stransky <stransky@redhat.com> - Thu, 26 Mar 2020 12:08:26 +0000 - rev 520540
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1624921 [Linux/X11] Use CSD for PIP windows only, r=jhorak Differential Revision: https://phabricator.services.mozilla.com/D68330
a5081d4443a95fd506cbe5db2835804f3bdc9a3c: Bug 1624745 [Wayland] Handle error states when wayland surfaces are created, r=jhorak
Martin Stransky <stransky@redhat.com> - Thu, 26 Mar 2020 12:08:03 +0000 - rev 520539
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1624745 [Wayland] Handle error states when wayland surfaces are created, r=jhorak Differential Revision: https://phabricator.services.mozilla.com/D68163
b651ff8263af5acea08f8f89dd71ede756c52d22: Bug 1612377 [Wayland] Update opaque region and widget scale factor when screen DPI changes, r=jhorak
Martin Stransky <stransky@redhat.com> - Thu, 26 Mar 2020 12:12:48 +0000 - rev 520538
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1612377 [Wayland] Update opaque region and widget scale factor when screen DPI changes, r=jhorak - Integrate scale factor setup to moz_container_get_wl_surface() and don't call it explicitly. - No need to set it explicitly at nsWindow::GetWaylandSurface(). - Update client offset when scale changes in CSD mode by UpdateClientOffsetFromCSDWindow(). - Update scale factor/opaque region on EGL immediately. Differential Revision: https://phabricator.services.mozilla.com/D68352
22fa6cbe32988d765925d6286c4694b9968c9cb2: Bug 1612377 [Wayland] Remove moz_container_set_accelerated(), r=jhorak
Martin Stransky <stransky@redhat.com> - Thu, 26 Mar 2020 12:12:40 +0000 - rev 520537
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1612377 [Wayland] Remove moz_container_set_accelerated(), r=jhorak Differential Revision: https://phabricator.services.mozilla.com/D68351
230b51ed8bdf9180651febdc04fa28c6d3e7f3c5: Bug 1620986 - Workers should read multi-value pref. r=bbouvier
Lars T Hansen <lhansen@mozilla.com> - Thu, 26 Mar 2020 11:47:59 +0000 - rev 520536
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1620986 - Workers should read multi-value pref. r=bbouvier Differential Revision: https://phabricator.services.mozilla.com/D68353
229ddddc3a44850a295fa6c8bd0ccfbc8271dde0: Bug 1623055 - Update in-tree browsertime to 8.3.0. r=perftest-reviewers,tarek,AlexandruIonescu
Gregory Mierzwinski <gmierz2@outlook.com> - Thu, 26 Mar 2020 07:58:39 +0000 - rev 520535
Push 37253 by nerli@mozilla.com at Thu, 26 Mar 2020 21:36:52 +0000
Bug 1623055 - Update in-tree browsertime to 8.3.0. r=perftest-reviewers,tarek,AlexandruIonescu This patch updates the in-tree browsertime to v8.3.0. Differential Revision: https://phabricator.services.mozilla.com/D67170
31360ced8ff85ed36e79fc1350b9d1db79457526: Bug 1546375 - Don't append the default namespace for featureless host selectors. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Mar 2020 11:44:01 +0000 - rev 520534
Push 37252 by malexandru@mozilla.com at Thu, 26 Mar 2020 15:34:27 +0000
Bug 1546375 - Don't append the default namespace for featureless host selectors. r=heycam Per the spec it shouldn't match, and the front-end has been bitten by this multiple times. Differential Revision: https://phabricator.services.mozilla.com/D68213
89b2dd9ad7249b730e7c38062b2673edcda56c35: Bug 1624282 - [wpt-sync] Update web-platform-tests to 4045d4941645a57abbb743a4a8a333ee634e0c11, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Mon, 23 Mar 2020 11:45:42 +0000 - rev 520533
Push 37252 by malexandru@mozilla.com at Thu, 26 Mar 2020 15:34:27 +0000
Bug 1624282 - [wpt-sync] Update web-platform-tests to 4045d4941645a57abbb743a4a8a333ee634e0c11, a=testonly MANUAL PUSH: wpt sync bot wpt-head: 4045d4941645a57abbb743a4a8a333ee634e0c11 wpt-type: landing
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip