a6bbb991c0d2d13c34d675df39eec6db9155fbbf: Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Tue, 18 Apr 2017 23:51:05 +0200 - rev 354039
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon. r=adw Favicons migrated from the old store have expiration set to 0. The code is not expecting that, since expiration has always been positive, thus those icons are always considered valid and never replaced. They should instead be considered expired. MozReview-Commit-ID: Cz0JB4IbURA
ecc42c31cc283151f6a452af171045687023cf75: Bug 1356452 - Part 5: Detect hand changing at runtime for OpenVR controllers; r=kip
Daosheng Mu <daoshengmu@gmail.com> - Tue, 18 Apr 2017 15:58:34 +0800 - rev 354038
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1356452 - Part 5: Detect hand changing at runtime for OpenVR controllers; r=kip MozReview-Commit-ID: AR5zpxryIw6
2e29632323c9f4b839b8018599c75091c4f2e0cc: Bug 1356452 - Part 4: Add gamepad set hand function in Gamepad; r=qdot
Daosheng Mu <daoshengmu@gmail.com> - Tue, 18 Apr 2017 15:56:08 +0800 - rev 354037
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1356452 - Part 4: Add gamepad set hand function in Gamepad; r=qdot MozReview-Commit-ID: LrQjMZ6demG
fed55d5486d0c356f40d582447f811c223679f90: Bug 1356452 - Part 3: Support changing gamepad hand property in GamepadManager; r=Lenzak
Daosheng Mu <daoshengmu@gmail.com> - Tue, 18 Apr 2017 15:55:15 +0800 - rev 354036
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1356452 - Part 3: Support changing gamepad hand property in GamepadManager; r=Lenzak MozReview-Commit-ID: KZx2qJqks6f
b425dbaf939443c0c42a8eaf913299e38e0d396b: Bug 1356452 - Part 2: Replace vr:: namespace with ::vr:: in OpenVR; r=kip
Daosheng Mu <daoshengmu@gmail.com> - Tue, 18 Apr 2017 13:04:53 +0800 - rev 354035
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1356452 - Part 2: Replace vr:: namespace with ::vr:: in OpenVR; r=kip MozReview-Commit-ID: uBvQ7hBI4z
45597054d4e8fdbd83a0ea0b5edc21024f000de8: Bug 1356452 - Part 1: Remove assertion for checking VRManager::Get(); r=kip
Daosheng Mu <daoshengmu@gmail.com> - Tue, 18 Apr 2017 12:45:44 +0800 - rev 354034
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1356452 - Part 1: Remove assertion for checking VRManager::Get(); r=kip MozReview-Commit-ID: CMCX9Fq55tS
12f943a6d12c1fa531e2834bf6185f539c1d2072: Bug 1357832 - Update eula.css to use standard css border; r=dao
Frank Serrano <frankanthonyserrano@gmail.com> - Wed, 19 Apr 2017 21:02:17 -0500 - rev 354033
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1357832 - Update eula.css to use standard css border; r=dao We were using -moz-border-*-colors in eula.css before. We no longer need to do that, so we are changing it to use the standard css border MozReview-Commit-ID: KvJ0kigreEt
6941882b6708a70cc3a4c2d7fdd0e8faf713b7bd: Backed out changeset 3507329c5999 (bug 1357555o) for eslint failure in test_expire_migrated_icons.js
Iris Hsiao <ihsiao@mozilla.com> - Thu, 20 Apr 2017 16:23:59 +0800 - rev 354032
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Backed out changeset 3507329c5999 (bug 1357555o) for eslint failure in test_expire_migrated_icons.js
3507329c599976fcf7f7ab17dd9004aaf64a328d: Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Tue, 18 Apr 2017 23:51:05 +0200 - rev 354031
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1357555 - Properly handle an expiration value of 0 when fetching an icon. r=adw Favicons migrated from the old store have expiration set to 0. The code is not expecting that, since expiration has always been positive, thus those icons are always considered valid and never replaced. They should instead be considered expired. MozReview-Commit-ID: Cz0JB4IbURA
3db332e289c95d5f43a6647671bb17206a0472ec: servo: Merge #16531 - Eliminate ScrollRootId (from mrobinson:clip-id); r=glennw
Martin Robinson <mrobinson@igalia.com> - Thu, 20 Apr 2017 01:55:33 -0500 - rev 354030
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
servo: Merge #16531 - Eliminate ScrollRootId (from mrobinson:clip-id); r=glennw Just use WebRender's ClipId directly. This will allow us to create and use ReferenceFrames in the future, if we need to do that. It will also make it easier to have Servo responsible for creating the root scrolling area, which will allow removing some old hacks in the future. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 6e05a903afe81af5a45067dde4f9af26a2ea4be2
27507fdcbacd80ebe2eacb8ce3d8039e93a0e05b: Bug 1355427 - Expectations adjustment followup. r=me
Cameron McCormack <cam@mcc.id.au> - Thu, 20 Apr 2017 17:29:29 +1000 - rev 354029
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1355427 - Expectations adjustment followup. r=me
3864467a616c7ac6e4801b8860ec38177f0d09f7: Bug 1352331 - Swap the cancel and save buttons on edit profile dialog for Windows. r=lchang
Scott Wu <scottcwwu@gmail.com> - Tue, 18 Apr 2017 17:42:03 +0800 - rev 354028
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1352331 - Swap the cancel and save buttons on edit profile dialog for Windows. r=lchang MozReview-Commit-ID: I3kvKClOIIO
368a60db302d15951ca884732014f947dacadf4a: Bug 1357702 - Make eslint-plugin-spidermonkey-js handle paths correct on Windows to avoid Unexpected character issues on ESLint. r=mossop
Mark Banner <standard8@mozilla.com> - Wed, 19 Apr 2017 12:17:14 +0100 - rev 354027
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1357702 - Make eslint-plugin-spidermonkey-js handle paths correct on Windows to avoid Unexpected character issues on ESLint. r=mossop MozReview-Commit-ID: LsQCgBOgceY
7ce95e24c0110c93ec1e4971922be456007bbc27: Bug 1357502 - Change eslint-plugin-mozilla tests to use the mocha test harness to improve the output. r=mossop
Mark Banner <standard8@mozilla.com> - Tue, 18 Apr 2017 20:06:02 +0100 - rev 354026
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1357502 - Change eslint-plugin-mozilla tests to use the mocha test harness to improve the output. r=mossop MozReview-Commit-ID: 1xI0tBpbSgM
8a42c7e1f799ea8c48aaa4166764ce681b9ad523: Bug 1354349 - Use channel.isDocument in ContentParent::TransmitPermissionsFor r=mystor
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 20 Apr 2017 10:15:16 +0800 - rev 354025
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1354349 - Use channel.isDocument in ContentParent::TransmitPermissionsFor r=mystor MozReview-Commit-ID: L9b6UeXJ8o5
b01181410a8a8dcc757f39fad165d22e927ef3c0: Bug 1354349 - Add nsIChannel.isDocument that checks if LOAD_DOCUMENT_URI is set, or if LOAD_HTML_OBJECT_DATA and the channel has the appropriate MIME type r=mcmanus,mystor
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 20 Apr 2017 10:15:06 +0800 - rev 354024
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1354349 - Add nsIChannel.isDocument that checks if LOAD_DOCUMENT_URI is set, or if LOAD_HTML_OBJECT_DATA and the channel has the appropriate MIME type r=mcmanus,mystor MozReview-Commit-ID: K28Opd9JTr2
b06e3d6c2f783a505108f677fa773fc60f2cc2bb: servo: Merge #16472 - Fix namespaces of elements created in XML documents (from cu1t:#14095-fix-xml-doc-namespaces); r=nox
cu1t <umnov.pa@gmail.com> - Thu, 20 Apr 2017 01:01:05 -0500 - rev 354023
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
servo: Merge #16472 - Fix namespaces of elements created in XML documents (from cu1t:#14095-fix-xml-doc-namespaces); r=nox Correctly implement following step of [Dom Document Spec](https://dom.spec.whatwg.org/#dom-document-createelement): > Let namespace be the HTML namespace, if the context object is an HTML document or context object’s content type is "application/xhtml+xml", and null otherwise. Note, this will make following test in `tests/wpt/web-platform-tests/dom/nodes/Document-constructor.html` to fail, so related .ini file added to mark it as such: ``` test(function() { var doc = new Document(); var a = doc.createElement("a"); // In UTF-8: 0xC3 0xA4 a.href = "http://example.org/?\u00E4"; assert_equals(a.href, "http://example.org/?%C3%A4"); }, "new Document(): URL parsing") ``` I'm not very familiar with specs, but from quick look at it, I'm doubtfull that it is valid in the first place. This is an "application/xml" document, so I don't see why it should encode a.href. Firefox also fails that. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14095 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because because there are already tests which were being ignored <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 2d732d829b3fc93938898118ee55ef985ebfc657
488534f69bf5083ce6f898e508da30d6419f7869: Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md. r=heycam
KuoE0 <kuoe0.tw@gmail.com> - Wed, 19 Apr 2017 11:09:35 +0800 - rev 354022
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md. r=heycam MozReview-Commit-ID: GufNFWDyiIq
e531bd57fe8d81369bccc3e648e3151d1384abf3: servo: Merge #16539 - stylo: Properly support -moz-script-size-multiplier, -moz-script-level, and -moz-script-min-size (from Manishearth:stylo-scriptminsize); r=heycam
Manish Goregaokar <manishearth@gmail.com> - Thu, 20 Apr 2017 00:20:41 -0500 - rev 354021
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
servo: Merge #16539 - stylo: Properly support -moz-script-size-multiplier, -moz-script-level, and -moz-script-min-size (from Manishearth:stylo-scriptminsize); r=heycam r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1355427 (copying over the relevant commit message so that it doesn't get lost in the vcssync) scriptlevel is a property that affects how font-size is inherited. If scriptlevel is +1, for example, it will inherit as the script size multiplier times the parent font. This does not affect cases where the font-size is explicitly set. However, this transformation is not allowed to reduce the size below scriptminsize. If this inheritance will reduce it to below scriptminsize, it will be set to scriptminsize or the parent size, whichever is smaller (the parent size could be smaller than the min size because it was explicitly specified). Now, within a node that has inherited a font-size which was crossing scriptminsize once the scriptlevel was applied, a negative scriptlevel may be used to increase the size again. This should work, however if we have already been capped by the scriptminsize multiple times, this can lead to a jump in the size. For example, if we have text of the form: huge large medium small tiny reallytiny tiny small medium huge which is represented by progressive nesting and scriptlevel values of +1 till the center after which the scriptlevel is -1, the "tiny"s should be the same size, as should be the "small"s and "medium"s, etc. However, if scriptminsize kicked it at around "medium", then medium/tiny/reallytiny will all be the same size (the min size). A -1 scriptlevel change after this will increase the min size by the multiplier, making the second tiny larger than medium. Instead, we wish for the second "tiny" to still be capped by the script level, and when we reach the second "large", it should be the same size as the original one. We do this by cascading two separate font sizes. The font size (mSize) is the actual displayed font size. The unconstrained font size (mScriptUnconstrainedSize) is the font size in the situation where scriptminsize never applied. We calculate the proposed inherited font size based on scriptlevel and the parent unconstrained size, instead of using the parent font size. This is stored in the node's unconstrained size and will also be stored in the font size provided that it is above the min size. All of this only applies when inheriting. When the font size is manually set, scriptminsize does not apply, and both the real and unconstrained size are set to the explicit value. However, if the font size is manually set to an em or percent unit, the unconstrained size will be set to the value of that unit computed against the parent unconstrained size, whereas the font size will be set computing against the parent font size. Source-Repo: https://github.com/servo/servo Source-Revision: 7919e591a46274c0d7f3a7c7c99d2643d55d60f1
1f1f3f34d558a8722b7235a369ae3bc497f7f107: Bug 1355427 - Part 3: stylo: Update test expectations; r=heycam
Manish Goregaokar <manishearth@gmail.com> - Thu, 13 Apr 2017 13:25:01 +0800 - rev 354020
Push 31685 by kwierso@gmail.com at Thu, 20 Apr 2017 21:45:29 +0000
Bug 1355427 - Part 3: stylo: Update test expectations; r=heycam MozReview-Commit-ID: AOHzrajCUVz
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip