a5e0f2d09bb4770fddbd9d18eaec12847ad7a3ff: servo: Merge #12497 - Update WR to get fix for texture atlas assert (from glennw:wr-update); r=emilio
Glenn Watson <github@intuitionlibrary.com> - Mon, 18 Jul 2016 18:46:14 -0700 - rev 339319
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12497 - Update WR to get fix for texture atlas assert (from glennw:wr-update); r=emilio <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 877e480c47fabf400cfa2275aada9d6d9c678b9a
ea2007bc86db421ea48c3196ce8568eb1cb1d0e2: servo: Merge #12495 - Implement Runnable trait name method for PauseIfNotInDocumentTask (from ice9js:implement-runnable-for-PauseIfNotInDocumentTask); r=KiChjang
Kuba Birecki <kuba.birecki@crystalplanet.io> - Mon, 18 Jul 2016 13:18:49 -0700 - rev 339318
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12495 - Implement Runnable trait name method for PauseIfNotInDocumentTask (from ice9js:implement-runnable-for-PauseIfNotInDocumentTask); r=KiChjang Implements #12350. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12350. <!-- Either: --> - [X] These changes do not require tests <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 589c6eeb0fc8e10cd82215a287fa23c676898907
3404b060380d06b098ea8ef0fddd7867a618e030: servo: Merge #12361 - Blockify elements in a flex container (from stshine:blockify-flex-item); r=pcwalton
Pu Xingyu <pu.stshine@gmail.com> - Mon, 18 Jul 2016 11:21:04 -0700 - rev 339317
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12361 - Blockify elements in a flex container (from stshine:blockify-flex-item); r=pcwalton <!-- Please describe your changes on the following line: --> The is one of my pull requests that implement basic flexible box layout. As the spec stated in https://drafts.csswg.org/css-flexbox/#flex-items , A inline-level child of a flex container should be converted to its block equivalent, according to CSS2.1 § 9.7. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because flexbox is not actually implemented yet. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: d28f2b89041e8b36e8423eff432ea3c507f0826f
cac4858a2384ddd9b60d0669d2a47467d7c8d0b6: servo: Merge #11727 - Integrate service worker manager thread (from creativcoder:swmanager); r=jdm
Rahul Sharma <rsconceptx@gmail.com> - Mon, 18 Jul 2016 09:50:59 -0700 - rev 339316
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #11727 - Integrate service worker manager thread (from creativcoder:swmanager); r=jdm <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes are part of #11091 <!-- Either: --> - [X] There are tests for these changes at my [gh-pages](https://github.com/creativcoder/gsoc16/tree/gh-pages) branch to test the instantiation of service workers by their manager, but will need to discuss how that would integrate into master. Changes: - Introduces a `ServiceWorkerManager`, which maintains an map of registered service workers as well as a map of active workers keyed by their `scope_url`. - Adds the initialization of ServiceWorkerManager, at the `script::init()`, which makes it available as a single entity listening for requests from different script threads. - Adds a timeout thread in `serviceworkerglobalscope`, which terminates the workers, after a timeout of 60 secs, thereby removing it from the active workers list. - Adds the matching of scope urls, in longest prefix way rather than path structural way, according to [spec](https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#scope-match-algorithm). - Make ServiceWorkerManager, the holder of network sender, instead of script thread, so it can send `CustomResponse`. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 513811f6b40d522bc425c2588320b889614f2973
8758837f89025f4f7e73b9b5db85047abd073271: servo: Merge #12488 - geckolib: Support parsing style="" attributes longer than 255 characters (from heycam:style-len); r=SimonSapin
Cameron McCormack <cam@mcc.id.au> - Mon, 18 Jul 2016 08:48:30 -0700 - rev 339315
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12488 - geckolib: Support parsing style="" attributes longer than 255 characters (from heycam:style-len); r=SimonSapin <!-- Please describe your changes on the following line: --> This just fixes the bindings for a typo in `ServoBindings.h` in Gecko. Corresponding Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1287383 r? @emilio --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: b36a3b2fee3e70c11af2bc24832e65510acb71ec
c15b2ba0f888b3c2286138c856f47205c5146a88: servo: Merge #12400 - Fix Blob type-string (from izgzhen:fix-type-string); r=Manishearth
Zhen Zhang <izgzhen@gmail.com> - Mon, 18 Jul 2016 07:19:49 -0700 - rev 339314
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12400 - Fix Blob type-string (from izgzhen:fix-type-string); r=Manishearth Use a final construction guard over type-string format; and other minor related cleanups r? @Manishearth <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: fa432a5a34866356c4431f18b0790be4cfd2fb3f
2de25a8b8e9996cd18083ad2e59f5bbcdfef90d5: servo: Merge #11890 - Bug 10104 - Only restyle nodes that uses viewport percentage units on viewport size change (from shinglyu:viewport-percent-recalc); r=mbrubeck
Shing Lyu <shing.lyu@gmail.com> - Sun, 17 Jul 2016 20:46:24 -0700 - rev 339313
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #11890 - Bug 10104 - Only restyle nodes that uses viewport percentage units on viewport size change (from shinglyu:viewport-percent-recalc); r=mbrubeck <!-- Please describe your changes on the following line: --> Bug 10104 - Only restyle nodes that uses viewport percentage units on viewport size change --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #10104 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: d87ea67bf2efec45368d3e48634c6c16de7486ff
dfe1e28673f01967eb9156244a4acce2707fa2cc: servo: Merge #12484 - Temporary fix for mach test-{wpt, css} issue with wonky paths (from aravind-pg:mach); r=ConnorGBrewster
Aravind Gollakota <aravindprasant@gmail.com> - Sun, 17 Jul 2016 19:42:10 -0700 - rev 339312
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12484 - Temporary fix for mach test-{wpt, css} issue with wonky paths (from aravind-pg:mach); r=ConnorGBrewster This is just a temporary fix to get `mach test-wpt`, `mach update-manifest` etc. working properly again. A proper fix will likely involve a proper refactoring of the `suite_for_test` function. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12481 - [X] These changes have been tested to work locally r? @ConnorGBrewster cc @jdm <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: f5c60e8c5aec34a1a6ff6c61f1174a7c93158159
e4d6e8f0dbc516b015993510a72dffe06e881c7f: servo: Merge #10618 - Ensure virtualenv activates (from zwn:fix-windows-build); r=larsbergstrom
Zbynek Winkler <zbynek.winkler@gmail.com> - Sun, 17 Jul 2016 15:58:12 -0700 - rev 339311
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #10618 - Ensure virtualenv activates (from zwn:fix-windows-build); r=larsbergstrom Fixes #10595. For more info see #10595 or the commit message. Source-Repo: https://github.com/servo/servo Source-Revision: e7a55ae55ee0091095b8a460b3088440f352dd2e
40d7e6f72ce3dd8fe7c8fc94b2d807bfcfd02763: servo: Merge #12364 - Make textarea scrollable (from kilobtye:textarea); r=jdm
kilobtye <kilobtye@gmail.com> - Sun, 17 Jul 2016 13:52:46 -0700 - rev 339310
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12364 - Make textarea scrollable (from kilobtye:textarea); r=jdm <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #10058 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 8c1be9b07ce2dbdd1fe696e3315bc4528846b419
d757a178f7fcfaf1c91591832020902dd6630bfe: servo: Merge #12480 - Build failing because of unspecified dependency for html5lib (from woshilapin:fix-12480); r=larsbergstrom
Jean SIMARD <woshilapin@tuziwo.info> - Sun, 17 Jul 2016 11:40:19 -0700 - rev 339309
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12480 - Build failing because of unspecified dependency for html5lib (from woshilapin:fix-12480); r=larsbergstrom Trying to simply build `servo`, I've reached a very early error. I cloned the `servo` repo, installed the dependencies specified on the [README](https://github.com/servo/servo#prerequisites). I'm running on a Debian Jessie [`Linux my machine 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt25-2+deb8u3 (2016-07-02) x86_64 GNU/Linux`]. Then I run. ``` ./mach build --dev ``` I only get the following message. ``` Pip failed to execute properly: ``` Looking in already existing issues, the only one I could find is #12062 which is about missing space on hard drive but this doesn't seem to be my problem. I've looked more into the problem and found that pip was having problem. Here is the error message. ``` Downloading from URL https://pypi.python.org/packages/17/ee/99e69cdcefc354e0c18ff2cc60aeeb5bfcc2e33f051bf0cc5526d790c445/html5lib-0.999999999.tar.gz#md5=8578e4e3a341436cb9743a9e4a299239 (from https://pypi.python.org/simple/html5lib/) Running setup.py (path:/tmp/pip-build-mFVe16/html5lib/setup.py) egg_info for package html5lib html5lib requires setuptools version 18.5 or above; please upgrade before installing (you have 5.5.1) Complete output from command python setup.py egg_info: ---------------------------------------- Cleaning up... Command python setup.py egg_info failed with error code 1 in /tmp/pip-build-mFVe16/html5lib Exception information: Traceback (most recent call last): File "/home/woshilapin/Projects/woshilapin/servo/python/_virtualenv/local/lib/python2.7/site-packages/pip/basecommand.py", line 122, in main status = self.run(options, args) File "/home/woshilapin/Projects/woshilapin/servo/python/_virtualenv/local/lib/python2.7/site-packages/pip/commands/install.py", line 290, in run requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle) File "/home/woshilapin/Projects/woshilapin/servo/python/_virtualenv/local/lib/python2.7/site-packages/pip/req.py", line 1230, in prepare_files req_to_install.run_egg_info() File "/home/woshilapin/Projects/woshilapin/servo/python/_virtualenv/local/lib/python2.7/site-packages/pip/req.py", line 326, in run_egg_info command_desc='python setup.py egg_info') File "/home/woshilapin/Projects/woshilapin/servo/python/_virtualenv/local/lib/python2.7/site-packages/pip/util.py", line 716, in call_subprocess % (command_desc, proc.returncode, cwd)) InstallationError: Command python setup.py egg_info failed with error code 1 in /tmp/pip-build-mFVe16/html5lib ``` I found that adding the following line in the file `python/requirements.txt` seems to solve the problem (I've build `servo` without errors and `./mach test-tidy` pass too). ``` setuptools >= 18.5 ``` Since I'm very new to `servo`, I didn't propose a Pull Request because I'm not sure this is right way of fixing it or maybe I'm doing something wrong. But I'd be happy to create the Pull Request if that's a valuable solution. Source-Repo: https://github.com/servo/servo Source-Revision: 0fa10df64ae928bccb05ea7c182eeffbed3af8a8
7e4229d7b11b1b6f586b92861d2f3e27438282ce: servo: Merge #12471 - Cleanup HTMLScriptElement::execute() (from Ms2ger:script-exec); r=nox
Ms2ger <Ms2ger@gmail.com> - Sat, 16 Jul 2016 03:47:27 -0700 - rev 339308
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12471 - Cleanup HTMLScriptElement::execute() (from Ms2ger:script-exec); r=nox Source-Repo: https://github.com/servo/servo Source-Revision: e8fa02a07f3ee8965c022df4e92d5bdb0fccdb0b
147f08f69f65df94bdfbff7f76d0834c200ca2dc: servo: Merge #12470 - Place apis.html in the same place as css-properties.html (from servo:jdm-patch-2); r=Manishearth
Josh Matthews <josh@joshmatthews.net> - Sat, 16 Jul 2016 00:32:21 -0700 - rev 339307
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12470 - Place apis.html in the same place as css-properties.html (from servo:jdm-patch-2); r=Manishearth Right now it's visible at http://doc.servo.org/apis.html, unlike http://doc.servo.org/servo/css-properties.html. Source-Repo: https://github.com/servo/servo Source-Revision: d9b7c060a5ec7a6c0556de371b3e9ed3dc832337
06a3525560321ad6f69dc7ede4035c73f8ef2cde: servo: Merge #12458 - Cleanups in autoarray helper (from Manishearth:style-gecko-only); r=emilio
Manish Goregaokar <manishsmail@gmail.com> - Fri, 15 Jul 2016 22:31:37 -0700 - rev 339306
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12458 - Cleanups in autoarray helper (from Manishearth:style-gecko-only); r=emilio Addresses @emilio's comments from #11851 - Replace gecko_autoarray_longhand with vector_longhand, make it configurable - Allow for empty vectors, use empty vector longhand in box-shadow Source-Repo: https://github.com/servo/servo Source-Revision: a8a6d83d07fa18c870a20113eca45ec16270e142
2f5db0f9f6e0e800de7b5a997428004b91233bdc: servo: Merge #12451 - Generate a list of supported DOM APIs from parsed WebIDLs (from jdm:generate-dom-apis); r=Ms2ger
Josh Matthews <josh@joshmatthews.net> - Fri, 15 Jul 2016 15:13:22 -0700 - rev 339305
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12451 - Generate a list of supported DOM APIs from parsed WebIDLs (from jdm:generate-dom-apis); r=Ms2ger Supplement the existing list of supported CSS properties with an equivalent list of DOM APIs. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because automatic generated documentation Source-Repo: https://github.com/servo/servo Source-Revision: 73ad0b928dd158be1eeba30dd21e67d4b9d82048
a26977fad24652d68810b6936efa2af6a1fc1574: servo: Merge #12464 - Remove fn start_sending_sniffed (from aneeshusa:cleanup-start-sending-sniffed); r=Wafflespeanut
Aneesh Agrawal <aneeshusa@gmail.com> - Fri, 15 Jul 2016 13:22:49 -0700 - rev 339304
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12464 - Remove fn start_sending_sniffed (from aneeshusa:cleanup-start-sending-sniffed); r=Wafflespeanut <!-- Please describe your changes on the following line: --> This function was not used, but more importantly encodes the bad practice of a raw `.unwrap()` and therefore should not be used. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes reference #12462 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they are a cleanup <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 90f1e53fd25dff25d18e9755c5cd1026aa4b21ca
d90b7d6759ec7465e6cf29a5e65c9b4ab954d973: servo: Merge #11841 - Send log messages to the constellation (from asajeffrey:constellation-logging); r=Manishearth
Alan Jeffrey <ajeffrey@mozilla.com> - Fri, 15 Jul 2016 12:22:26 -0700 - rev 339303
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #11841 - Send log messages to the constellation (from asajeffrey:constellation-logging); r=Manishearth <!-- Please describe your changes on the following line: --> Send all warnings and errors to the constellation. Warnings are bufferred up, and included in any subsequent error reports. Errors are reported in the same way as panics. Note that this can't merge yet, as it needs https://github.com/rust-lang-nursery/log/pull/86 to land. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11776 (github issue number if applicable). - [X] These changes do not require tests because we don't test crash reporting. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: a5cd4b95183da4ae9b754d9d4824bd23f4ad7eb8
e66960190602fa8d7dae526888bf7a6dc79012b0: servo: Merge #12441 - Implement referrer policy delivery by header (from aravind-pg:referrer-pol-header); r=jdm
Aravind Gollakota <aravindprasant@gmail.com> - Fri, 15 Jul 2016 11:25:43 -0700 - rev 339302
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12441 - Implement referrer policy delivery by header (from aravind-pg:referrer-pol-header); r=jdm Adds a new `Option<ReferrerPolicy>` field to Document and sets it appropriately in `ScriptThread::load` if a Referrer-Policy header is present. r? @jdm <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11860 - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: b382cc2103180f7dfd8df9c34970a95ed57a2d88
835d778310cbdf9d79394df86babb64cdf542a4e: servo: Merge #12137 - Check for Resources on case sensitive filesystem (from cbrewster:resources_case_sensitive); r=aneeshusa
Connor Brewster <connor.brewster@eagles.oc.edu> - Fri, 15 Jul 2016 10:29:55 -0700 - rev 339301
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12137 - Check for Resources on case sensitive filesystem (from cbrewster:resources_case_sensitive); r=aneeshusa <!-- Please describe your changes on the following line: --> Case where this is needed: http://logs.glob.uno/?c=mozilla%23servo&s=1+Jul+2016&e=1+Jul+2016#c471192 Another option is to make the Resources folder on the mac .app bundle be lower case; however, it is standard to have `Resources` in a .app bundle. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 175340d1461c3474b49f88131b84298b8d097d36
fe21c09a9d2329676f267754758ae954af79b03f: servo: Merge #12461 - Add a keyboard shortcut (Command + Q on Mac or Control + Q on other O… (from andrewdavidmackenzie:enable-quit-keyboard-shortcut); r=ConnorGBrewster
Andrew Mackenzie <andrew@mackenzie-serres.net> - Fri, 15 Jul 2016 09:33:06 -0700 - rev 339300
Push 31307 by gszorc@mozilla.com at Sat, 04 Feb 2017 00:59:06 +0000
servo: Merge #12461 - Add a keyboard shortcut (Command + Q on Mac or Control + Q on other O… (from andrewdavidmackenzie:enable-quit-keyboard-shortcut); r=ConnorGBrewster <!-- Please describe your changes on the following line: --> Added code in window.rs to enqueue the Window::Quit event when the Command/Control + Q keyboard shortcut is detected IF keyboard shortcuts are enabled. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12422 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because there are no tests able to test keyboard shortcuts at the moment <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 6640115c9775e7177f79b1d6aa5fddceeeeb22e2
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip