a1407c6e9785c7b678ccfbbba09aca0f9e0cfffa: Bug 1305230 - Splitting test_fileapi.html and test_fileapi_worker.html in multiple files, r=me
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 09:16:55 +0200 - rev 386128
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1305230 - Splitting test_fileapi.html and test_fileapi_worker.html in multiple files, r=me
6c0e229ac2e85888be179d3126f51ff392b05eea: Bug 1305230 - Splitting test_fileapi_slice in two files, r=qdot
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:42 +0200 - rev 386127
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1305230 - Splitting test_fileapi_slice in two files, r=qdot
e6afe93a22826c75f028ebe252cdc0907905fa5e: Bug 1305230 - Make test_fileapi_slice using promises, r=qdot
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:42 +0200 - rev 386126
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1305230 - Make test_fileapi_slice using promises, r=qdot
f442143b5b90f10b362a8c09137ad7b794465b31: Bug 1305230 - removing fileutils.js from tests when not needed, r=qdot
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:42 +0200 - rev 386125
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1305230 - removing fileutils.js from tests when not needed, r=qdot
856c3889f319b81a38da582967e4a561376f1821: Bug 1305230 - Make test_blobconstructor promise based, r=qdot
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:42 +0200 - rev 386124
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1305230 - Make test_blobconstructor promise based, r=qdot
a7b1484b2367547280e18559dc25205479d23a23: Bug 1400098 - Using common_fileReader.js for test_fileapi in workers, r=qdot
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:42 +0200 - rev 386123
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1400098 - Using common_fileReader.js for test_fileapi in workers, r=qdot
6f968efadcdc0e14007e84b1b36d08351c6ccc9e: Bug 1400098 - test_fileapi.html rewritten using Promises, r=qdot
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:41 +0200 - rev 386122
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1400098 - test_fileapi.html rewritten using Promises, r=qdot
322dbb6b6736339695b8be2f8043ba4c7ee9e140: Bug 1406818 - about:profile uses nsIToolkitProfile.removeInBackground, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:41 +0200 - rev 386121
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1406818 - about:profile uses nsIToolkitProfile.removeInBackground, r=ehsan
eeb89284500e2756eec978be2d4233b3411aa4ca: Bug 1406818 - Introduce nsIToolkitProfile.removeInBackground to remove profile folder in a separate thread, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:41 +0200 - rev 386120
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1406818 - Introduce nsIToolkitProfile.removeInBackground to remove profile folder in a separate thread, r=ehsan
4baaea004689e8f6f4a4d9feff99c98c5378c3ce: Bug 1408170 - Set child correctly in HTMLEditRules::GetPromotedPoint(); r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 12 Oct 2017 23:29:51 -0400 - rev 386119
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1408170 - Set child correctly in HTMLEditRules::GetPromotedPoint(); r=masayuki
6ead77d51be961f578652794a6dced48b8778d2a: Bug 1407480 - Carry valid Rect when calling NotifyInvalidation() in layers-free mode. r=kats
vincentliu <vliu@mozilla.com> - Fri, 13 Oct 2017 13:33:20 +0800 - rev 386118
Push 32676 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:38:18 +0000
Bug 1407480 - Carry valid Rect when calling NotifyInvalidation() in layers-free mode. r=kats
684b9ee0468e6560b00c69231adfe1b7e68d58a4: merge autoland to mozilla-central. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 13 Oct 2017 23:35:51 +0200 - rev 386117
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
merge autoland to mozilla-central. r=merge a=merge MozReview-Commit-ID: 7ph7uT1QwPS
f013760760f227e45493de3f251949dbb23750c2: Bug 1402151, part 9 - Implement gtest for FTP directory listing parsing. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 11:19:33 -0700 - rev 386116
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
Bug 1402151, part 9 - Implement gtest for FTP directory listing parsing. r=michal This test turns the existing stand alone test for the FTP directory listing parser into a gtest. MozReview-Commit-ID: 7n60TfcTXTJ
cef4777d22b61fcd833ef380859f9060a0af7183: Bug 1402151, part 8 - Add an argument to ParseFTPList to return the current time. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 13:27:09 -0700 - rev 386115
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
Bug 1402151, part 8 - Add an argument to ParseFTPList to return the current time. r=michal If the year is omitted from a listing, then the parsing code assumes that the date occurred within the last year. To compute what the year should be, the code thus needs to know what the current year, month and day are. This patch parameterizes ParseFTPList over a function that returns a PRTime. This will allow the gtest to pass in a fixed time. Firefox itself will continue to use PR_Now to get the current time. MozReview-Commit-ID: 8IbVWbUBHYs
90904b0eae64bd077c48abd9cd468a17acb49897: Bug 1402151, part 7 - Add a time zone argument to ParseFTPList. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 11:45:27 -0700 - rev 386114
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
Bug 1402151, part 7 - Add a time zone argument to ParseFTPList. r=michal In a few places, the FTP parser needs to know the time zone and daylight savings time correction, encapsulated in PRTimeParamFn. Before this patch, it would use the time zone of the current machine, which would obviously make automated testing difficult. This patch allows a caller to pass in a PRTimeParamFn, which will allow the gtest to use GMT instead of whatever the local time is. MozReview-Commit-ID: 81R3Zbndr43
8c4e5c96e95f8488534eaa3f1a0768ba6b67a409: Bug 1402151, part 6 - Manual fixups for times in E-EPLF.out. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 12:53:01 -0700 - rev 386113
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
Bug 1402151, part 6 - Manual fixups for times in E-EPLF.out. r=michal After the automatic fixes in the previous patch, a few of the times in late March and early April are still off by an hour. Maybe this was affected by the changes in when daylight savings time or some bug in my conversion script. I have no idea. This patch just fixes the test to match the actual output. MozReview-Commit-ID: IghWfkWfxvi
f60db82364456137ec937b604f78eafaf77e5e86: Bug 1402151, part 5 - Adjust E-EPLF.out from Paris time to GMT. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 12:50:35 -0700 - rev 386112
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
Bug 1402151, part 5 - Adjust E-EPLF.out from Paris time to GMT. r=michal The dates in the input for this file are specified as seconds since Jan 1, 1970 or whenever. The conversion to a normal date depends on the current time zone. The original output seems to have been generated using GMT+1, with adjustments for daylight savings time at the appropriate parts of the year. To make this easier to test, this patch changes all of the times to GMT, without any daylight savings time adjustment. This change was automatically created by the Python script attached to the bug. MozReview-Commit-ID: 3uSAGtJYsMW
427f0784d60c108795c46de9163ba317f6edf6e9: Bug 1402151, part 4 - Fix some FTP parser tests. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 11:26:18 -0700 - rev 386111
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
Bug 1402151, part 4 - Fix some FTP parser tests. r=michal D-WinNT: The parser treats <JUNCTION> without an arrow as junk for some reason. Chrome's FTP directory listing parser doesn't seem to support <JUNCTION> at all, so it can't be too important. I just deleted that from the expected output to match Firefox's current behavior. I also added basic tests for three bugs that were fixed without any tests landed. E-EPLF.out: Add a license to the top. U-WinNT.out: We're not testing junk or comment output, and we don't use the list: prefix, so remove all of those. Also, we now output the proper year (2000 instead of 00, for instance), so fix that in the test output. Finally, the time in the output for this test is formatted differently, for whatever reason, so change it to match the actual output. V-VMS-mix.out: Fix file sizes. File sizes on VMS can only be approximated. When the FTP tests initially landed in 2002, this was handled by not trying. Bug 22299 landed in 2003 and changed our behavior to approximate the size, but the tests were not updated. MozReview-Commit-ID: 1DVfBfHh82y
b866226c10a468bf35d7aebd43971bfd66c2b00b: Bug 1402151, part 3 - Move parse-ftp unit tests into the gtest directory. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 10:58:11 -0700 - rev 386110
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
Bug 1402151, part 3 - Move parse-ftp unit tests into the gtest directory. r=michal This will make them easier to access from a gtest. MozReview-Commit-ID: 3lV4DwTosXT
1878cd54d8a2d10308c149edcfd562632cb00c41: Bug 1402151, part 2 - Clamp the number of blocks for a VMS file. r=michal
Andrew McCreight <continuation@gmail.com> - Thu, 28 Sep 2017 09:32:48 -0700 - rev 386109
Push 32675 by archaeopteryx@coole-files.de at Fri, 13 Oct 2017 21:36:21 +0000
Bug 1402151, part 2 - Clamp the number of blocks for a VMS file. r=michal strtoul returns an |unsigned long|, and clamps the return value to ULONG_MAX if the input is out of range. This means that the value returned for large numbers differs between 32-bit and 64-bit systems. To make testing easier, this patch clamps the return value to UINT32_MAX, ensuring that 32-bit and 64-bit builds of Firefox will be consistent. Explicitly declaring that the intermediate value numBlocks is a uint64_t also avoids (well-defined) integer overflow in the case of a large file. This patch also changes PRId64 to PRIu64, because the value being printed is unsigned. However, this should not make a difference in practice, because, with clamping, the maximum value being printed is |UINT32_MAX * 512|. I also cleaned up the comment that was a little garbled and contained information about both the old and new ways this was handled, and removed some code that has been ifdef'd out for at least 14 years. MozReview-Commit-ID: HELmWmtx24O
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip