a0f255b660ce2d49fc7a07abe7d546c51e12da02: Bug 1496503 - Change the rust panic hook to delegate to Gecko's crash code. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 14 Nov 2018 08:46:51 +0000 - rev 446167
Push 35038 by rmaries@mozilla.com at Wed, 14 Nov 2018 22:12:17 +0000
Bug 1496503 - Change the rust panic hook to delegate to Gecko's crash code. r=froydnj The current rust panic hook keeps a string for the crash reporter, and goes on calling the default rust panic hook, which prints out a crash stack... when RUST_BOOTSTRAP is set *and* when that works. Notably, on both mac and Windows, it only really works for local builds, but fails for debug builds from automation, although on automation itself, we also do stackwalk from crash minidumps, which alleviates the problem. Artifact debug builds are affected, though. More importantly, C++ calls to e.g. MOZ_CRASH have a similar but different behavior, in that they dump a stack trace on debug builds, by default (with exceptions, see below for one). The format of those stack traces is understood by the various fix*stack*py scripts under tools/rb/, that are used by the various test harnesses both on automation and locally. Additionally, the current rust panic hook, as it calls the default rust panic hook, ends up calling abort() on non-Windows platforms, which ends up being verbosely redirected to mozalloc_abort per https://dxr.mozilla.org/mozilla-central/rev/237e4c0633fda8e227b2ab3ab57e417c980a2811/memory/mozalloc/mozalloc_abort.cpp#79 which then calls MOZ_CRASH. Theoretically, /that/ would also print a stack trace, but doesn't because currently the stack trace printing code lives in libxul, and MOZ_CRASH only calls it when compiled from libxul-code, which mozalloc_abort is not part of. With this change, we make the rust panic handler call back into MOZ_CRASH directly. This has multiple advantages: - This is more consistent cross-platforms (Windows is not special anymore). - This is more consistent between C++ and rust (stack traces all look the same, and can all be post-processed by fix*stack*py if need be) - This is more consistent in behavior, where debug builds will show those stack traces without caring about environment variables. - It demangles C++ symbols in rust-initiated stack traces (for some reason that didn't happen with the rust panic handler) A few downsides: - the loss of demangling for some rust symbols. - the loss of addresses in the stacks, although they're not entirely useful - extra empty lines. The first should be fixable later one. The latter two are arguably something that should be consistent across C++ and rust, and should be changed if necessary, independently of this patch. Depends on D11719 Differential Revision: https://phabricator.services.mozilla.com/D11720
963d8ac1cfeed19cc3b18ec991e01eafd4b49f33: Bug 1496503 - Use MOZ_CrashOOL in MOZ_CrashPrintf. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 14 Nov 2018 08:47:21 +0000 - rev 446166
Push 35038 by rmaries@mozilla.com at Wed, 14 Nov 2018 22:12:17 +0000
Bug 1496503 - Use MOZ_CrashOOL in MOZ_CrashPrintf. r=froydnj Because we don't really need all this repetition. Depends on D11718 Differential Revision: https://phabricator.services.mozilla.com/D11719
43e44f8439eca0caa66b6da8d93d1c0a34792bdb: Bug 1496503 - Move MOZ_CrashOOL to Assertions.h. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 14 Nov 2018 08:47:44 +0000 - rev 446165
Push 35038 by rmaries@mozilla.com at Wed, 14 Nov 2018 22:12:17 +0000
Bug 1496503 - Move MOZ_CrashOOL to Assertions.h. r=froydnj Ideally, we'd want the function to stay in Assertions.cpp, but that's only part of MFBT proper, and that doesn't have access to WalkTheStack like MOZ_CRASH has from being in Assertion.h, when included from Gecko code. Moving WalkTheStack to mozglue, putting it close together with MozStackWalk would be prefered, but that causes problems linking MFBT tests (which don't have access to mozglue), and other things. Overall, this was too deep a rabbit hole, and moving MOZ_CrashOOL to Assertions.h is much simpler. Since it's essentially the same as MOZ_CRASH, except it allows non-literal strings, we can make it inlined, and leave it to the compiler to drop the filename argument when it's not used. Differential Revision: https://phabricator.services.mozilla.com/D11718
08e578f6f4ca03ca9a8572a280a3cd937aaa091a: Bug 1501571 - Inform user that FHR must be enabled for 'Product and feature tips' to work; r=geckoview-reviewers,snorp
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 13 Nov 2018 19:21:16 +0000 - rev 446164
Push 35038 by rmaries@mozilla.com at Wed, 14 Nov 2018 22:12:17 +0000
Bug 1501571 - Inform user that FHR must be enabled for 'Product and feature tips' to work; r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D11457
26360851a3ba47f732ac4f9680005aa51037bfe6: Bug 1502116 - web-tooling subtests should be 'score' r=igoldan
Armen Zambrano G. <armenzg@mozilla.com> - Wed, 14 Nov 2018 08:38:59 +0000 - rev 446163
Push 35038 by rmaries@mozilla.com at Wed, 14 Nov 2018 22:12:17 +0000
Bug 1502116 - web-tooling subtests should be 'score' r=igoldan Differential Revision: https://phabricator.services.mozilla.com/D11768
89279cd689a3d382792cc0a7f29445b2cbf320e1: Bug 1506554 part 2 - Actually call cleanupLocaleTests in storage/test/unit/test_locale_collation.js. r=asuth
Jan de Mooij <jdemooij@mozilla.com> - Wed, 14 Nov 2018 07:46:34 +0000 - rev 446162
Push 35038 by rmaries@mozilla.com at Wed, 14 Nov 2018 22:12:17 +0000
Bug 1506554 part 2 - Actually call cleanupLocaleTests in storage/test/unit/test_locale_collation.js. r=asuth The cleanup function was there but never called, as far as I can see. Differential Revision: https://phabricator.services.mozilla.com/D11617
236f09f4709d78fe7f78afd3d65ee463b42378bc: Bug 1507035 - Fix run sizes for size classes >= 16KB on systems with large pages. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 14 Nov 2018 06:58:53 +0000 - rev 446161
Push 35038 by rmaries@mozilla.com at Wed, 14 Nov 2018 22:12:17 +0000
Bug 1507035 - Fix run sizes for size classes >= 16KB on systems with large pages. r=njn Differential Revision: https://phabricator.services.mozilla.com/D11836
b0b856065d5b7ad2996f707e6e797d0d72afd803: Bug 1506516 - Remove now unused arrow.svg after debugger dropped it in Bug 1506688: Also remove it from jar.mn. a=bustage-fix
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 14 Nov 2018 14:39:15 +0200 - rev 446160
Push 35037 by archaeopteryx@coole-files.de at Wed, 14 Nov 2018 12:39:36 +0000
Bug 1506516 - Remove now unused arrow.svg after debugger dropped it in Bug 1506688: Also remove it from jar.mn. a=bustage-fix
7e059804fdf24b67b3e9016fe54dc32f51e33f26: Bug 1506516 - Remove now unused arrow.svg after debugger dropped it in bug 1506688. a=devtools-fix
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 14 Nov 2018 14:21:47 +0200 - rev 446159
Push 35036 by archaeopteryx@coole-files.de at Wed, 14 Nov 2018 12:22:26 +0000
Bug 1506516 - Remove now unused arrow.svg after debugger dropped it in bug 1506688. a=devtools-fix
073045259e75e0c8f7b8ffcd5e4bf72570f98f3e: Merge inbound to mozilla-central a=merge
Coroiu Cristina <ccoroiu@mozilla.com> - Wed, 14 Nov 2018 11:51:31 +0200 - rev 446158
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Merge inbound to mozilla-central a=merge
d3f4d556a89d3e5e72749314a0cf81d942fafc13: Bug 1502280 - followup: Fix non-unified build. r=bustage
Tooru Fujisawa <arai_a@mac.com> - Wed, 14 Nov 2018 14:36:12 +0900 - rev 446157
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Bug 1502280 - followup: Fix non-unified build. r=bustage
9b456742a2cc22f56aac2a4d26063307b85135a6: Bug 1502280 - Remove the case BinTokenReaderBase.errorReporter_ is null. r=Yoric
Tooru Fujisawa <arai_a@mac.com> - Wed, 14 Nov 2018 13:00:34 +0900 - rev 446156
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Bug 1502280 - Remove the case BinTokenReaderBase.errorReporter_ is null. r=Yoric
a4fb56d2819e636de6c7ae756028e537efae48d0: Bug 1497784 - Drop support for lexical declaration in BinAST for now. r=Yoric
Tooru Fujisawa <arai_a@mac.com> - Tue, 30 Oct 2018 09:49:41 +0900 - rev 446155
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Bug 1497784 - Drop support for lexical declaration in BinAST for now. r=Yoric
598f4654a06cb0bc7e1525e61b7d97acd6ba0d51: Bug 1503142 - Check for pending compile error on off-main-thread parsing BinAST. r=Waldo
Tooru Fujisawa <arai_a@mac.com> - Wed, 14 Nov 2018 13:00:33 +0900 - rev 446154
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Bug 1503142 - Check for pending compile error on off-main-thread parsing BinAST. r=Waldo
b90ad12e6e7004e90b903c31c52c847df3bb03de: Bug 1506334 - Add words to en-US dictionary. r=ehsan
Ekanan Ketunuti <ananuti@gmail.com> - Sat, 10 Nov 2018 14:22:18 +0700 - rev 446153
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Bug 1506334 - Add words to en-US dictionary. r=ehsan
c4d4368566b4135bf0ae0c435926ebe525de6d47: bug 1497111 - Remove unnecessarily null'ed out values of PaymentRequest.webidl. r=baku
Eden Chuang <echuang@mozilla.com> - Mon, 12 Nov 2018 17:24:54 +0100 - rev 446152
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
bug 1497111 - Remove unnecessarily null'ed out values of PaymentRequest.webidl. r=baku
93f58abf5d47c32c98db9ff98b7091e2805639b9: Bug 1499253 - fix setting chrome proxy arguments when using playback, r=rwood.
Bob Clary <bclary@bclary.com> - Tue, 13 Nov 2018 19:02:40 -0800 - rev 446151
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Bug 1499253 - fix setting chrome proxy arguments when using playback, r=rwood.
5dd599d4a437e3eef7ea9f3a95439fa1f1f4581f: Bug 1503498 - Simplify ForwardingExternalImage handling in AsyncImagePipelineManager r=aosmond
sotaro <sotaro.ikeda.g@gmail.com> - Wed, 14 Nov 2018 11:40:31 +0900 - rev 446150
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Bug 1503498 - Simplify ForwardingExternalImage handling in AsyncImagePipelineManager r=aosmond
d6eaed759f7d5359b82564f1998a6cce5e28e072: Bug 1504728 - Part 0: Update nsSecureBrowserUIImpl::CheckForBlockedContent() to check for mixed content blocking when the resource is already marked as broken; r=keeler
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 13 Nov 2018 16:43:11 -0500 - rev 446149
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Bug 1504728 - Part 0: Update nsSecureBrowserUIImpl::CheckForBlockedContent() to check for mixed content blocking when the resource is already marked as broken; r=keeler Differential Revision: https://phabricator.services.mozilla.com/D11815
4f1d2f6c1e6ea6c30c7e91a6aa4e2d7ecedfa0a2: Bug 1506721 - Allow compile-only BinAST js shell invocations. (r=arai)
Eric Faust <efausbmo@gmail.com> - Tue, 13 Nov 2018 14:06:43 -0800 - rev 446148
Push 35035 by ccoroiu@mozilla.com at Wed, 14 Nov 2018 09:52:26 +0000
Bug 1506721 - Allow compile-only BinAST js shell invocations. (r=arai)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip