9f71934b98492b939856aafaad37bca20e2c0d11: Bug 1467041 - Default to --enable-release when milestone is beta/release. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 06 Jun 2018 16:13:09 +0900 - rev 421649
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1467041 - Default to --enable-release when milestone is beta/release. r=froydnj --enable-release not being passed means developer options are enabled, which is generally speaking not desirable for builds meant to be shipped. This is somewhat alleviated for Firefox by MOZILLA_OFFICIAL implying --enable-release (as well as MOZ_AUTOMATION), but that doesn't apply to e.g. standalone js builds (even some of the standalone js jobs on our automation don't set MOZ_AUTOMATION for some reason). A reasonable thing to do is just to default builds for release/beta milestones to --enable-release, but still allow --disable-release to enable the developer options.
b43ab3cd2f3b182d0e718940b3ee0090ae8249c8: Merge m-c to autoland. a=merge
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 06 Jun 2018 21:08:49 -0400 - rev 421648
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Merge m-c to autoland. a=merge
553ca5e060470b0724f4e12faa8ac0363ac3401d: Bug 1465784 - Remove unnecessary render step with async-scene-building. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 06 Jun 2018 16:45:06 -0400 - rev 421647
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1465784 - Remove unnecessary render step with async-scene-building. r=sotaro MozReview-Commit-ID: 8iOQHLhlcjA
51f4eaa7c00323836b66396b42cdb41a1306c358: Bug 1253164 - Make nsIFrame allow running async animations once the frame is able able to run animations on the compositor again. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 07 Jun 2018 09:30:33 +0900 - rev 421646
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1253164 - Make nsIFrame allow running async animations once the frame is able able to run animations on the compositor again. r=birtles For example, we don't run transform animations on large frames but once the frame size is small enough we should run transform animations on the frame. MozReview-Commit-ID: DkfB9g2Gcdi
e383e893aa7072c390de439d19f1ca1603f38986: Bug 1432936: Added sanity check for sendonly attribute. r=bwc
Johannes Willbold <j.willbold@mozilla.com> - Mon, 04 Jun 2018 10:05:27 -0700 - rev 421645
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1432936: Added sanity check for sendonly attribute. r=bwc Moved RustSdpAttributeType and renamaed it to SdpAttributeType Replaced the has_extmap_attribute functions by a generic has_attribute function Added a sanity check, that checks for sendonly and if simulcast defines receive options MozReview-Commit-ID: DXAEVu0SRap
033f5f2b2582611b02cf0ee732e3e471d2311aff: Bug 1466606 - Revert "Add diagnostic code.". r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 06 Jun 2018 14:12:25 +0200 - rev 421644
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1466606 - Revert "Add diagnostic code.". r=bryce This reverts commit 4c1f90791492fc441cc600f66ff2d36c7910e905 MozReview-Commit-ID: KbMWKE08vT8
8a711fdf59d088cbc50719646934712714dad436: Bug 1465892 - Re-enable assertions for WR hit-testing codepath. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 01 Jun 2018 09:08:11 -0400 - rev 421643
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1465892 - Re-enable assertions for WR hit-testing codepath. r=botond MozReview-Commit-ID: 489Gyhgf1C5
fbab945ecae7cb7c67b2970336e9e6d24067e6d0: Bug 1467033 - Add minwidth=50 to toolbox-window.xul and toolbox-process-window.xul. r=jdescottes
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 06 Jun 2018 16:04:33 +0900 - rev 421642
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1467033 - Add minwidth=50 to toolbox-window.xul and toolbox-process-window.xul. r=jdescottes This patch will prevent the devtools shrink very narrow width in the case of separated window or browser toolbox. MozReview-Commit-ID: GjMEOHNZ0O6
b08454f26dc56f9dcbeb49452a8404627d307dbb: Bug 1466539 - Change the Android '.PHONY: features' target to 'tools features::' instead of just 'features::', so that built_in_addons.json is actually generated. r=nalexander
Thomas Wisniewski <wisniewskit@gmail.com> - Tue, 05 Jun 2018 21:09:47 -0400 - rev 421641
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1466539 - Change the Android '.PHONY: features' target to 'tools features::' instead of just 'features::', so that built_in_addons.json is actually generated. r=nalexander MozReview-Commit-ID: DIrL3VlJZHM
8a1ad8e3467d72e80d42da3358abe66a6a2a49c7: Bug 1467136 Ensure extension messaging cannot miss the startup event r=kmag
Andrew Swan <aswan@mozilla.com> - Wed, 06 Jun 2018 13:58:43 -0700 - rev 421640
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1467136 Ensure extension messaging cannot miss the startup event r=kmag When a background page has a messaging listener but the background page is started in response to something other than an extension message, we were missing the background "startup" event. Fix that by setting up the listener earlier. MozReview-Commit-ID: Cr58EyCoY6W
90dca0906337973b0ae3158bfc98eae2a0882260: Bug 1460777 - Taskgraph tasks for retrieving remote content; r=dustin, glandium
Gregory Szorc <gps@mozilla.com> - Wed, 06 Jun 2018 14:37:49 -0700 - rev 421639
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1460777 - Taskgraph tasks for retrieving remote content; r=dustin, glandium Currently, many tasks fetch content from the Internets. A problem with that is fetching from the Internets is unreliable: servers may have outages or be slow; content may disappear or change out from under us. The unreliability of 3rd party services poses a risk to Firefox CI. If services aren't available, we could potentially not run some CI tasks. In the worst case, we might not be able to release Firefox. That would be bad. In fact, as I write this, gmplib.org has been unavailable for ~24 hours and Firefox CI is unable to retrieve the GMP source code. As a result, building GCC toolchains is failing. A solution to this is to make tasks more hermetic by depending on fewer network services (which by definition aren't reliable over time and therefore introduce instability). This commit attempts to mitigate some external service dependencies by introducing the *fetch* task kind. The primary goal of the *fetch* kind is to obtain remote content and re-expose it as a task artifact. By making external content available as a cached task artifact, we allow dependent tasks to consume this content without touching the service originally providing that content, thus eliminating a run-time dependency and making tasks more hermetic and reproducible over time. We introduce a single "fetch-url" "using" flavor to define tasks that fetch single URLs and then re-expose that URL as an artifact. Powering this is a new, minimal "fetch" Docker image that contains a "fetch-content" Python script that does the work for us. We have added tasks to fetch source archives used to build the GCC toolchains. Fetching remote content and re-exposing it as an artifact is not very useful by itself: the value is in having tasks use those artifacts. We introduce a taskgraph transform that allows tasks to define an array of "fetches." Each entry corresponds to the name of a "fetch" task kind. When present, the corresponding "fetch" task is added as a dependency. And the task ID and artifact path from that "fetch" task is added to the MOZ_FETCHES environment variable of the task depending on it. Our "fetch-content" script has a "task-artifacts" sub-command that tasks can execute to perform retrieval of all artifacts listed in MOZ_FETCHES. To prove all of this works, the code for fetching dependencies when building GCC toolchains has been updated to use `fetch-content`. The now-unused legacy code has been deleted. This commit improves the reliability and efficiency of GCC toolchain tasks. Dependencies now all come from task artifacts and should always be available in the common case. In addition, `fetch-content` downloads and extracts files concurrently. This makes it faster than the serial application which we were previously using. There are some things I don't like about this commit. First, a new Docker image and Python script for downloading URLs feels a bit heavyweight. The Docker image is definitely overkill as things stand. I can eventually justify it because I want to implement support for fetching and repackaging VCS repositories and for caching Debian packages. These will require more packages than what I'm comfortable installing on the base Debian image, therefore justifying a dedicated image. The `fetch-content static-url` sub-command could definitely be implemented as a shell script. But Python is readily available and is more pleasant to maintain than shell, so I wrote it in Python. `fetch-content task-artifacts` is more advanced and writing it in Python is more justified, IMO. FWIW, the script is Python 3 only, which conveniently gives us access to `concurrent.futures`, which facilitates concurrent download. `fetch-content` also duplicates functionality found elsewhere. generic-worker's task payload supports a "mounts" feature which facilitates downloading remote content, including from a task artifact. However, this feature doesn't exist on docker-worker. So we have to implement downloading inside the task rather than at the worker level. I concede that if all workers had generic-worker's "mounts" feature and supported concurrent download, `fetch-content` wouldn't need to exist. `fetch-content` also duplicates functionality of `mach artifact toolchain`. I probably could have used `mach artifact toolchain` instead of writing `fetch-content task-artifacts`. However, I didn't want to introduce the requirement of a VCS checkout. `mach artifact toolchain` has its origins in providing a feature to the build system. And "fetching artifacts from tasks" is a more generic feature than that. I think it should be implemented as a generic feature and not something that is "toolchain" specific. I think the best place for a generic "fetch content" feature is in the worker, where content can be defined in the task payload. But as explained above, that feature isn't universally available. The next best place is probably run-task. run-task already performs generic, very-early task preparation steps, such as performing a VCS checkout. I would like to fold `fetch-content` into run-task and make it all driven by environment variables. But run-task is currently Python 2 and achieving concurrency would involve a bit of programming (or adding package dependencies). I may very well port run-task to Python 3 and then fold fetch-content into it. Or maybe we leave `fetch-content` as a standalone script. MozReview-Commit-ID: AGuTcwNcNJR
e54687f110b1f63a898905288ad13a8f9cd7206b: Bug 1460777 - Extract GPG keys to standalone files; r=glandium
Gregory Szorc <gps@mozilla.com> - Fri, 11 May 2018 10:38:35 -0700 - rev 421638
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1460777 - Extract GPG keys to standalone files; r=glandium After this change, we consistently import GPG keys from files in the GCC build scripts. MozReview-Commit-ID: BcyvCQoGbMS
306ce49060246247c7ad87521afaf8d70137b9f7: Bug 1466620 - Fix a typo in subprocess/docs/index.rst. r=kmag
Markus Stange <mstange@themasta.com> - Mon, 04 Jun 2018 13:15:46 -0400 - rev 421637
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1466620 - Fix a typo in subprocess/docs/index.rst. r=kmag MozReview-Commit-ID: 6X5J8Vjb3zl
f1bc66e3947d0afdc2a4f14376dee27849283ef7: Bug 1467282 - Stop shipping SimpleServiceDiscovery.jsm on Desktop, and remove unused reference to it. r=jaws
Felipe Gomes <felipc@gmail.com> - Wed, 06 Jun 2018 18:15:21 -0300 - rev 421636
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1467282 - Stop shipping SimpleServiceDiscovery.jsm on Desktop, and remove unused reference to it. r=jaws MozReview-Commit-ID: JgliLwd3OaG
91ef628a1f06e389bde8bc2a34c1bbc76e9b82a3: Bug 1433093: Implemented RsdparsaSdpMediaSection::SetPort. r=dminor
Johannes Willbold <j.willbold@mozilla.com> - Mon, 04 Jun 2018 16:01:43 -0700 - rev 421635
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1433093: Implemented RsdparsaSdpMediaSection::SetPort. r=dminor Add C++/Rust glue code Added set_port function SdpMedia Added unit test: CheckSetPort MozReview-Commit-ID: 6pbbuSxzhqM
c9ae7e47a6eff9aef6a691c638754d2f176ee0ad: Bug 1466971 - Add Blob images, Jexl targets and bug fixes to Activity Stream. r=ursula
Ed Lee <edilee@mozilla.com> - Tue, 05 Jun 2018 14:04:52 -0700 - rev 421634
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1466971 - Add Blob images, Jexl targets and bug fixes to Activity Stream. r=ursula MozReview-Commit-ID: NRTSgzuIzW
486bd3917deebcf6e1120859b111d200142d444d: Bug 1414051 - Move ThreatHit protobuf details to the body. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 19 Feb 2018 16:18:37 -0800 - rev 421633
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1414051 - Move ThreatHit protobuf details to the body. r=gcp Mark that channel as anonymous in order to prevent any cookies from being set here and potentially tie these proxied requests to list updates which will not go through the proxy. Also fix a return code in the case that httpChannel fails to QI. MozReview-Commit-ID: BaRyYRlUbsB
d1119cefd6016e6659cce1959d747eb4cb02e3b2: Bug 1467250 - remove mobile/android/docs/conf.py as it isn't used r=nalexander
Sylvestre Ledru <sledru@mozilla.com> - Wed, 06 Jun 2018 21:33:47 +0200 - rev 421632
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1467250 - remove mobile/android/docs/conf.py as it isn't used r=nalexander MozReview-Commit-ID: AzhXi00HEm9
00f45773f03d8a98b4d426abc758e63853b96819: Bug 1466388 - Android webext popup should not be considered to be the active or highlighted tab r=rpl
Oriol Brufau <oriol-bugzilla@hotmail.com> - Sun, 03 Jun 2018 03:00:39 +0200 - rev 421631
Push 34101 by ccoroiu@mozilla.com at Thu, 07 Jun 2018 09:46:37 +0000
Bug 1466388 - Android webext popup should not be considered to be the active or highlighted tab r=rpl MozReview-Commit-ID: 3WVoR80ICzo
f7fd9b08c0156be5b5cd99de5ed0ed0b98d93051: Backed out changeset a4465713555b (bug 1460989) for causing the Galaxy S8 crash rate to spike.
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 06 Jun 2018 21:07:48 -0400 - rev 421630
Push 34100 by ryanvm@gmail.com at Thu, 07 Jun 2018 01:08:08 +0000
Backed out changeset a4465713555b (bug 1460989) for causing the Galaxy S8 crash rate to spike.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip