9b6303f7accd1c4b74f699c17d4582a57e7917cf: Bug 1562412 - stop using build_signing loader. r=jlorenzo,Callek
Aki Sasaki <asasaki@mozilla.com> - Mon, 16 Dec 2019 09:05:11 +0000 - rev 507166
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1562412 - stop using build_signing loader. r=jlorenzo,Callek Depends on D57189 Differential Revision: https://phabricator.services.mozilla.com/D57190
10024cf3aacab6f98c70e8133b4b894a76e2f728: Bug 1562412 - fix try.yml taskgraph-gen.py r=Callek
Aki Sasaki <asasaki@mozilla.com> - Mon, 16 Dec 2019 13:26:35 +0000 - rev 507165
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1562412 - fix try.yml taskgraph-gen.py r=Callek Differential Revision: https://phabricator.services.mozilla.com/D57189
658162be7bd47204896c556a92242922a322c51c: Bug 1603351 - Add a tsconfig.json file in devtools root folder. r=gregtatum.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 16 Dec 2019 15:21:03 +0000 - rev 507164
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1603351 - Add a tsconfig.json file in devtools root folder. r=gregtatum. This will help VSCode users (jump to definition will work with absolute paths) and opens the door to implementing typescript JS docs. I tested it with absolute and regular paths, with `require` and `from`. Differential Revision: https://phabricator.services.mozilla.com/D56863
bd67a7161d552a4f9bf1ecb0db22524211280a9a: Backed out changeset 5c137b3793a7 (bug 1594931) for failures on test_sdr_preexisting.js. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Mon, 16 Dec 2019 18:52:41 +0200 - rev 507163
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Backed out changeset 5c137b3793a7 (bug 1594931) for failures on test_sdr_preexisting.js. CLOSED TREE
8b4144dc9bbdec5bf3c69171f2bdb31bcada3dd4: Bug 1603224 - Guard against division-by-zero in AsyncPanZoomController::ScrollSnapToDestination(). r=tnikkel
Botond Ballo <botond@mozilla.com> - Sat, 14 Dec 2019 00:24:31 +0000 - rev 507162
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1603224 - Guard against division-by-zero in AsyncPanZoomController::ScrollSnapToDestination(). r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D57179
e10569569d9f02e9dd934984203f2f990c04b190: Bug 1602408 - Increase messaging system cache validity to 5 minutes r=k88hudson
Andrei Oprea <andrei.br92@gmail.com> - Wed, 11 Dec 2019 16:24:49 +0000 - rev 507161
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1602408 - Increase messaging system cache validity to 5 minutes r=k88hudson Differential Revision: https://phabricator.services.mozilla.com/D56747
5d47b43f4ab56e91a353ec0d5553bd45b9c2f321: Bug 1603890 - Include dynamic-process keyed scalars in telemetry pings r=chutten
Drew Willcoxon <adw@mozilla.com> - Mon, 16 Dec 2019 14:01:14 +0000 - rev 507160
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1603890 - Include dynamic-process keyed scalars in telemetry pings r=chutten Differential Revision: https://phabricator.services.mozilla.com/D57183
e51924303b7b1ad280aca7eeded02b3fb690df4f: Backed out changeset 69e62c1d0d53 (bug 1603140) for bustage WasmBaselineCompile.cpp. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Mon, 16 Dec 2019 18:21:38 +0200 - rev 507159
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Backed out changeset 69e62c1d0d53 (bug 1603140) for bustage WasmBaselineCompile.cpp. CLOSED TREE
2d8fdc554f2889e09c089a553b486288dc1b4b21: Bug 1603807 - Don't divide by zero in ClampAndAlignWithPixels. r=botond
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 16 Dec 2019 15:55:22 +0000 - rev 507158
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1603807 - Don't divide by zero in ClampAndAlignWithPixels. r=botond Differential Revision: https://phabricator.services.mozilla.com/D57188
69e62c1d0d539a951f49e0ff967ae2392d161c2c: Bug 1603140 - Multi-value returns in baseline wasm compiler r=lth
Andy Wingo <wingo@igalia.com> - Mon, 16 Dec 2019 15:56:01 +0000 - rev 507157
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1603140 - Multi-value returns in baseline wasm compiler r=lth This patch implements one half of support for multi-value returns in the baseline compiler. The idea is that when you have a function that has stack return values, it will receive an additional synthetic argument: a pointer to the stack results area. The layout of this area is the same as that understood by BaseCompiler::pushBlockResults. When compiling a function that has stack results, the stack result area pointer will come in either in a register or on the stack. If it's on the stack we record that offset and will load a pointer at that offset when returning values. If the pointer is in a register, it gets spilled to the stack after the spilled copies of previous register arguments. When calling a function that has multiple return values, we bump the stack pointer and pass an additional argument to the callee: the pointer to that stack area. After the call, in the baseline compiler, it may be that we need to shuffle any stack results down, because incoming arguments are consumed by the call. Note that support for actually returning multiple values is not yet implemented in this patch; we're just adding infra. Also note that Ion support isn't there yet either. However all tests pass, because no FuncType that has more than one result gets past the validator. Differential Revision: https://phabricator.services.mozilla.com/D56756
1036d6391be280b5c83fc34dabe7b20ce6ff3009: Bug 1565001 - Part 26: Remove generator comprehension test. r=evilpie
André Bargull <andre.bargull@gmail.com> - Mon, 16 Dec 2019 15:43:49 +0000 - rev 507156
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 26: Remove generator comprehension test. r=evilpie Remove the test file because generator comprehensions have been removed a while ago. Differential Revision: https://phabricator.services.mozilla.com/D56943
49f149652d651a292a95af580a4f77a034451345: Bug 1565001 - Part 25: Use assertDeepEq to compare array objects on mandelbrot test. r=evilpie
André Bargull <andre.bargull@gmail.com> - Mon, 16 Dec 2019 14:10:42 +0000 - rev 507155
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 25: Use assertDeepEq to compare array objects on mandelbrot test. r=evilpie The changes in "lib/mandelbrot-results.js" are too large for a normal diff, so this change was split from part 21. Differential Revision: https://phabricator.services.mozilla.com/D56949
303b0a9c0b1bf12526db85c062107648f926e30b: Bug 1565001 - Part 24: Replace additional `toSource` tests. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 20:38:34 +0000 - rev 507154
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 24: Replace additional `toSource` tests. r=evilpie auto-regress/bug713209.js - Replace `toSource` with `toString` on string value for `print` output. baseline/bug1063878.js - Replace `Math.toSource` with `String`, which is also a non-scripted function. basic/bug1141154.js debug/bug1353356.js - Replace `Number.prototype.toSource` with `toString` when called on an Array object. - Both calls ensure a TypeError is thrown for this test. basic/bug728609.js - Replace indirect `toSource` calls with explicit calls. - (The test relied on calling `o.first.toSource` being called when `o.toSource` is called.) gc/bug-1108007.js - Replace `toSource` call on a string value with the direct result. - Based on the stack in the bug report, calling `toSource` is not necessarily required for this test. gc/bug-1439284.js - Replace `Boolean.prototype.toSource` with `toString` when called on a String object. - Both calls ensure a TypeError is thrown for this test. ion/bug1348777.js - Replace `toSource` with `toString` when testing polymorphic calls. ion/bug847412.js ion/bug913749.js xdr/tagged-template-literals-2.js - Replace `toSource` on the (global) object with `JSON.stringify` to emulate object traversal. ion/inlining/TypedObject-ObjectIsTypeDescr-*.js - Replace `toSource` on TypedObjects with a call to `equivalent`. - This should ensure the tests are still valid, because `equivalent` is also calling `ObjectIsTypeDescr`, which is the function under test here. ion/scalar-replacement-bug1138693.js - Also replace `toSource` with `equivalent` in this test, because similar to `toSource`, `equivalent` is also performing a load from a reserved slot. Depends on D56940 Differential Revision: https://phabricator.services.mozilla.com/D56941
90aa16c48a36ebe84a752f84f424bee1ad19e780: Bug 1565001 - Part 23: Make `toSource` tests conditional. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 20:37:39 +0000 - rev 507153
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 23: Make `toSource` tests conditional. r=evilpie These changes handle the following three cases: 1. Regression tests for `toSource` functions. - Added `skip-if` annotation. 2. Contains `toSource` (a few) conformance tests, but also additional conformance tests. - Added `if`-statements to skip the `toSource` bits when `toSource` is not present. 3. Contains many `toSource` conformance tests. - Split the file into two separate files (see asm.js/testBug1147144.js and asm.js/testSource.js). Depends on D56939 Differential Revision: https://phabricator.services.mozilla.com/D56940
478531f112c8125eba875f18459bc3a9836ae442: Bug 1565001 - Part 22: Replace `toSource` with `toString` on function objects. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 20:32:53 +0000 - rev 507152
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 22: Replace `toSource` with `toString` on function objects. r=evilpie - Calling `toSource` is equivalent to calling `toString` on function declarations. - For function expressions, the result of `toString` must be enclosed in parentheses to get the equivalent result when compared to `toSource`. Depends on D56937 Differential Revision: https://phabricator.services.mozilla.com/D56939
796b0e6c15c2ece95ac2fb175239f9eae149eb3b: Bug 1565001 - Part 21: Use assertDeepEq to compare array objects. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:24:43 +0000 - rev 507151
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 21: Use assertDeepEq to compare array objects. r=evilpie `assertDeepEq` allows to compare arrays with nested objects, which isn't possible with `arraysEqual`. Depends on D56936 Differential Revision: https://phabricator.services.mozilla.com/D56937
4aff3495ccd4034a378bd1f43b9e093708acff17: Bug 1565001 - Part 20: Replace remaining `toSource` calls in jstests. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:22:42 +0000 - rev 507150
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 20: Replace remaining `toSource` calls in jstests. r=evilpie RegExp/regress-yarr-regexp.js - Compare arrays using `assertEqArray` instead of using `Array.prototype.toSource`. TypedObject/scalar_types.js TypedObject/size_and_alignment.js - Use the new `describeType` helper (see changes in TypedObject/shell.js) to get a descriptive name for a TypedObject type. TypedObject/shell.js - Add `describeType` helper to mimic the output of `toSource` for TypedObject types. - And use `JSON.stringify` to stringify TypedObject instances. class/superPropBasicCalls.js - Use `toString` instead of `toSource` for class property lookup tests. - Interestingly the test class is already named `toStringTest`. expressions/regress-96526-delelem.js - Call `formatArray` to get the expected output, because the `formatArray` helper generates a slightly different ouput (`"[3, , ]"`) than `Array.prototype.toSource`. extensions/clone-v1-typed-array.js - Use `toString` instead of `toSource` for the `print` output of an `Error` object. extensions/dataview.js - Use `JSON.stringify` to generate a source-like representation of an array of number values. extensions/regress-314874.js - Directly use `expect` and `actual` for the comparison call. extensions/regress-459606.js - Directly use the `toFixed` result for the comparison call. extensions/regress-476414-01.js extensions/regress-476414-02.js - Remove jsfunfuzz clean-up code. jit/regress-452498-01.js - Use `JSON.stringify` to generate a source-like representation of an array of number values. - Additionally fixup the ouput to match the expected string. reflect-parse/Match.js - Use `JSON.stringify` to get a string-representation for error messages. Depends on D56935 Differential Revision: https://phabricator.services.mozilla.com/D56936
82706c3dffc688e55e75cdcfa13541fa21ec22d0: Bug 1565001 - Part 19: Make tests for `toSource` conditional where necessary. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:19:12 +0000 - rev 507149
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 19: Make tests for `toSource` conditional where necessary. r=evilpie Allow these `toSource` specific tests to run even when `toSource` is not defined. Depends on D56934 Differential Revision: https://phabricator.services.mozilla.com/D56935
c75989dc9b7159d008f86238e6b1c0ffebf55d35: Bug 1565001 - Part 18: Add skip-if annotation to `toSource`-only tests. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:16:23 +0000 - rev 507148
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 18: Add skip-if annotation to `toSource`-only tests. r=evilpie These tests can be removed when `toSource` itself is removed. Depends on D56933 Differential Revision: https://phabricator.services.mozilla.com/D56934
d3b05632992ceb50b3e3140dff5d7d8ad61a32c9: Bug 1565001 - Part 17: Move tests which are no longer our extensions into the main test file. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:13:27 +0000 - rev 507147
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 17: Move tests which are no longer our extensions into the main test file. r=evilpie And additionally remove tests for deleted extensions like `Object.prototype.watch`. Depends on D56932 Differential Revision: https://phabricator.services.mozilla.com/D56933
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip