9a2412c232a5897fe21cd5965e350d6665ca2310: Bug 1145201: Fix xpcshell tests not to mix the test's own microtasks with the debuggee's. r=jlast
Jim Blandy <jimb@mozilla.com> - Tue, 12 Feb 2019 08:20:29 +0000 - rev 458925
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1145201: Fix xpcshell tests not to mix the test's own microtasks with the debuggee's. r=jlast Evaluation of debuggee code should always begin with an empty microtask queue. In xpcshell tests, this is not guaranteed, as it is in the web platform. This patch changes those devtools server xpcshell tests that break this rule in a detectable way to run the debuggee code as a separate HTML task. In an actual browser environment, debuggee JavaScript runs as an HTML task. Since HTML requires a microtask checkpoint at the end of each task, this means that a debuggee task begins execution with an empty microtask queue, free of microtasks from other tabs or the browser machinery itself. Hence, while the debugger is pausing debuggee code, it is safe for it to save the debuggee's microtask queue, so that those jobs do not make progress. (Which is fortunate, because it *must* do so, lest the debuggee's microtasks run during the pause!) In an xpcshell test, however, there is no guarantee that debuggee code begins execution with a fresh microtask queue: the test may call `eval` or `evalInSandbox` at any time. If such an evaluation hits a breakpoint, `debugger` statement, etc. that invokes a Debugger hook, supervisory microtasks from the test harness code may be set aside along with the debuggee's microtasks. If the hook code then blocks waiting for those microtasks to run, the test will hang. Differential Revision: https://phabricator.services.mozilla.com/D18904
8df956c34c94173d02cd69594a2a24b76818c23a: Backed out 2 changesets (bug 1522253) for causing ES Lint failure in newInstallPage.js
Noemi Erli <nerli@mozilla.com> - Wed, 13 Feb 2019 19:12:35 +0200 - rev 458924
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Backed out 2 changesets (bug 1522253) for causing ES Lint failure in newInstallPage.js Backed out changeset 5b2aeaf2da17 (bug 1522253) Backed out changeset a091f6b58aba (bug 1522253)
f6c24d795990850a1094b6a4e4c4b1c907f70211: Bug 1527499: Show the profile manager by default in preference to assigning or creating an initial profile. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 13 Feb 2019 14:04:23 +0000 - rev 458923
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1527499: Show the profile manager by default in preference to assigning or creating an initial profile. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D19592
b09a49ab3635a0c4e156e1d255e78281bc13e6c6: Bug 1527412 - Remove swizzling of -[NSView mouseDownCanMoveWindow]. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 11:14:03 +0000 - rev 458922
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1527412 - Remove swizzling of -[NSView mouseDownCanMoveWindow]. r=spohl This was added in bug 476393 in order to work around a problem with the Java plug-in. We no longer support that plug-in. The comment also mentions NSTexturedBackgroundWindowMask which we stopped using in bug 1335191. Differential Revision: https://phabricator.services.mozilla.com/D19558
80265a268c6878d35238be7d3c9135c0fa3e7a99: Bug 1527412 - Make nsChildView::mView a ChildView*, because that's what it is. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 11:14:02 +0000 - rev 458921
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1527412 - Make nsChildView::mView a ChildView*, because that's what it is. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D19556
82aa9a03b71d26790c72a7c2a9b19c0fb7fd936f: Bug 1527412 - Remove unused contextMenu method. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 11:14:02 +0000 - rev 458920
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1527412 - Remove unused contextMenu method. r=spohl This method could only return something non-null in embedding situations, in which our ChildView was a subview of somebody else's NSView that conforms to the mozView protocol. Such a situation hasn't existed for about 10 years. Differential Revision: https://phabricator.services.mozilla.com/D19555
fa484096ffd36c4c0712fa7b880379e1f78171e8: Bug 1527412 - Fix mParentView's type (it doesn't necessarily implement the mozView protocol) and tweak a few comments. r=spohl
Markus Stange <mstange@themasta.com> - Wed, 13 Feb 2019 11:14:02 +0000 - rev 458919
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1527412 - Fix mParentView's type (it doesn't necessarily implement the mozView protocol) and tweak a few comments. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D19554
5b2aeaf2da17571c8003ecf253df6e3c98c44aac: Bug 1522253: about:newinstall should get its configuration via RemotePageManager rather than query params. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 13 Feb 2019 16:57:35 +0000 - rev 458918
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1522253: about:newinstall should get its configuration via RemotePageManager rather than query params. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D19413
a091f6b58aba85ea59443d5ae2f3756caca13ae9: Bug 1522253: Add a standard mechanism for requesting data from the other process. r=Gijs
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 13 Feb 2019 16:57:28 +0000 - rev 458917
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1522253: Add a standard mechanism for requesting data from the other process. r=Gijs As we add more specific methods to RemotePageManager some of them will have to call the main process to get the results. This adds a standard mechanism for doing so. Calling sendRequest will return a promise that is resolved or rejected when the main process responds. Differential Revision: https://phabricator.services.mozilla.com/D19412
b635fbf484e4cbd0e33ac63180e6ea783519ae14: Bug 1500074 - Add metrics test for jsdebugger;r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 13 Feb 2019 15:46:38 +0000 - rev 458916
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1500074 - Add metrics test for jsdebugger;r=ochameau Depends on D19639 Differential Revision: https://phabricator.services.mozilla.com/D19640
785a3ad7dc4f4348a63e2e2f273abe733eb4f6ff: Bug 1500072 - Add metrics test for netmonitor;r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 13 Feb 2019 15:44:43 +0000 - rev 458915
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1500072 - Add metrics test for netmonitor;r=ochameau Depends on D19638 Differential Revision: https://phabricator.services.mozilla.com/D19639
0fb5dc2c565787c0136243b4019ff47845453017: Bug 1500072 - Add browserLoader reference on window when flags.testing is true;r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 13 Feb 2019 15:44:05 +0000 - rev 458914
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1500072 - Add browserLoader reference on window when flags.testing is true;r=ochameau Depends on D19582 Differential Revision: https://phabricator.services.mozilla.com/D19638
ac92eed544e90b63a12f22e9add85f5e388907b8: Bug 1500072 - Add a shared helper to record metrics in tests;r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Wed, 13 Feb 2019 15:43:13 +0000 - rev 458913
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1500072 - Add a shared helper to record metrics in tests;r=ochameau Depends on D19364 Differential Revision: https://phabricator.services.mozilla.com/D19582
9c47d4f6747ab2f9c1972ec432161d4d67b5225d: Bug 1527374: Always remove --allow-downgrade from the command line. r=bzbarsky
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 13 Feb 2019 16:36:02 +0000 - rev 458912
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1527374: Always remove --allow-downgrade from the command line. r=bzbarsky Currently we only check and remove the --allow-downgrade command line argument if the run is actually a downgrade. When we don't the --allow-downgrade argument makes it to Firefox's default command line handler which doesn't know how to handle it and so ignores it and the next argument on the command line. Flipping the ordering of the check makes sure we always remove the argument. Differential Revision: https://phabricator.services.mozilla.com/D19569
6e651b1b00b101795b3bca26d2ff200702db96ae: Bug 1524264 - move noproxy textbox lower to hint as a global effect r=ewright,flod
Junior Hsu <juhsu@mozilla.com> - Wed, 13 Feb 2019 10:46:19 +0000 - rev 458911
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1524264 - move noproxy textbox lower to hint as a global effect r=ewright,flod Differential Revision: https://phabricator.services.mozilla.com/D18981
4441e86d56b9dc2cc560d7b5fde47395e8b0b6c7: Bug 1526328 - Disable Telemetry recording in FUZZING builds. r=janerik
Christian Holler <choller@mozilla.com> - Wed, 13 Feb 2019 16:16:32 +0000 - rev 458910
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1526328 - Disable Telemetry recording in FUZZING builds. r=janerik Differential Revision: https://phabricator.services.mozilla.com/D19359
dbf72abf5597999c462c200a252acf140f71fc98: Bug 1472589 - Fix parent process crash reporting in the Snap package environment. r=ted,jlorenzo
Jed Davis <jld@mozilla.com> - Mon, 11 Feb 2019 13:49:35 +0000 - rev 458909
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1472589 - Fix parent process crash reporting in the Snap package environment. r=ted,jlorenzo 1. The unsetting of LD_LIBRARY_PATH is removed, because it's no longer necessary and interferes with environments where it's necessary to find "system" libraries like GTK; see bug 1472589 comment #1 through #4. 2. The Snap package manifest adds a dependency on the libcurl package, so that the crash reporter can send the report. This uses the GnuTLS variant because we're already pulling in GnuTLS as a dependency of some other packages (FFmpeg and CUPS, but also the non-GnuTLS cURL packages depend on it anyway via OpenLDAP). Differential Revision: https://phabricator.services.mozilla.com/D18625
b3e21f09ee45ff809466feb849158b42fd9c24de: Bug 1516709 support incognito in downloads api r=aswan
Shane Caraveo <scaraveo@mozilla.com> - Wed, 13 Feb 2019 15:20:04 +0000 - rev 458908
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1516709 support incognito in downloads api r=aswan Differential Revision: https://phabricator.services.mozilla.com/D17426
266c1eee61a85d63b69b60793365c37a95af2570: Bug 1518661 - Part 7: Update debugger server to use new getPossibleBreakpoints APIs. r=jlast
Logan Smyth <loganfsmyth@gmail.com> - Wed, 13 Feb 2019 02:31:03 +0000 - rev 458907
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1518661 - Part 7: Update debugger server to use new getPossibleBreakpoints APIs. r=jlast Making use of the new SpiderMonkey APIs for available breakpoints means that the server needs to think a lot less about where it is pausing and allows us to drop the concept of a pause points from the server entirely. It is now up to SpiderMonkey to decide where it will and will not stop when it is stepping. Differential Revision: https://phabricator.services.mozilla.com/D17665
62f3c188b868ae1b50648e010a019bfafd8fb779: Bug 1518661 - Part 6: Ensure that stepOut from inside onPop behaves properly. r=jlast
Logan Smyth <loganfsmyth@gmail.com> - Wed, 13 Feb 2019 02:31:02 +0000 - rev 458906
Push 35551 by shindli@mozilla.com at Wed, 13 Feb 2019 21:34:09 +0000
Bug 1518661 - Part 6: Ensure that stepOut from inside onPop behaves properly. r=jlast The step-out logic currently has a special case to skip pausing onPop when stepping out of the current frame. This logic gets confused if you are already _in_ the onPop of the current frame though, and causes you to also fail to pause onPop in the parent frame. Differential Revision: https://phabricator.services.mozilla.com/D17663
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip