98386363bea5a5a0b08f7f42359d8fcc3fcc4460: Bug 1723950 - Shim more of the stubbed-out Optimizely API in its SmartBlock shim to fix more site breakage; r=denschub,webcompat-reviewers
Thomas Wisniewski <twisniewski@mozilla.com> - Mon, 09 Aug 2021 17:58:12 +0000 - rev 588250
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723950 - Shim more of the stubbed-out Optimizely API in its SmartBlock shim to fix more site breakage; r=denschub,webcompat-reviewers Differential Revision: https://phabricator.services.mozilla.com/D122139
3e910c8b409cb65fa10d620b9c7cfc273ed8eb4b: Bug 1724320 - Collect Open Graph page data. r=mossop
Harry Twyford <htwyford@mozilla.com> - Mon, 09 Aug 2021 17:16:29 +0000 - rev 588249
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1724320 - Collect Open Graph page data. r=mossop Differential Revision: https://phabricator.services.mozilla.com/D121927
824f41098467eef473ccf0edac2a05f853e3c394: Bug 1724492 - Stop using nsIAutocompleteResult in UrlbarProviderPlaces. r=harry
Drew Willcoxon <adw@mozilla.com> - Mon, 09 Aug 2021 17:08:47 +0000 - rev 588248
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1724492 - Stop using nsIAutocompleteResult in UrlbarProviderPlaces. r=harry This will help me fix bug 1723160 by letting me add frecency values to Places result payloads. I tried to keep this simple and only do what was necessary to fix the bug. Of course there's a lot more cleanup we could do, like skip the whole conversion between match objects and UrlbarResults altogether by only creating UrlbarResults in the first place, but I didn't want to scope creep into fixing bug 1717511. Differential Revision: https://phabricator.services.mozilla.com/D122022
904db8e18e53be836d984c7c99ff6559f323b044: Bug 1723158 - Allow heuristic result to be experimentally hidden or not present. r=mak
Drew Willcoxon <adw@mozilla.com> - Mon, 09 Aug 2021 17:07:40 +0000 - rev 588247
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723158 - Allow heuristic result to be experimentally hidden or not present. r=mak This adds `browser.urlbar.experimental.hideHeuristic`. When true, the heuristic is hidden in the view except for the search tip heuristic. This is implemented as part of the larger prototype described in the JIRA ticket (see the bug for a link) and some Slack conversation. There isn't much of a spec in that ticket, and I think that's OK because we'd like to iterate on a prototype and we're not sure yet how exactly the UX should work. For example, should the heuristic always be hidden or only in certain cases? This revision always hides it (except search tips), but it's easy to imagine we'll want to introduce some more sophisticated logic. Or more simply we may want to always show specific types of heuristics, like omnibox, as this revision does for search tips. The implementation works by excluding the heuristic in the view. Each heuristic provider still creates their heuristics. When the view receives the heuristic, instead of adding and selecting it, it calls `input.setResultForCurrentValue()` so that the heuristic is set as the current result. When the user presses enter, the input checks `experimental.hideHeuristic` and whether the current result is a heuristic. Differential Revision: https://phabricator.services.mozilla.com/D121785
9bc32566e1c4dcec6b84b7d584942ee501f8435e: Backed out 2 changesets (bug 1723536, bug 1723198) for causing xpcshell failures on test_SocketScalars.js. CLOSED TREE
Iulian Moraru <imoraru@mozilla.com> - Mon, 09 Aug 2021 20:16:59 +0300 - rev 588246
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Backed out 2 changesets (bug 1723536, bug 1723198) for causing xpcshell failures on test_SocketScalars.js. CLOSED TREE Backed out changeset 16c398716c60 (bug 1723198) Backed out changeset 47c08d2c33f4 (bug 1723536)
d6c955cb5f1a3e44b0e730f3753b7ee1806848b0: Merge mozilla-central to autoland. CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 09 Aug 2021 19:13:59 +0200 - rev 588245
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Merge mozilla-central to autoland. CLOSED TREE
ebc155f68704f11bf3bbc86cdddd691bae4dcea0: Bug 1724583 - restrict fuzzy annotation for 513153-2a.html on Apple Silicon to WebRender. DONTBUILD CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 09 Aug 2021 16:53:23 +0000 - rev 588244
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1724583 - restrict fuzzy annotation for 513153-2a.html on Apple Silicon to WebRender. DONTBUILD CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D122130
d24f037e9e6f5beb32b8a8a6de040f63e6803b2d: Bug 1724582 - restrict fuzzy annotation for dynamic-max-width.html on Apple Silicon to WebRender. DONTBUILD
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 09 Aug 2021 16:55:58 +0000 - rev 588243
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1724582 - restrict fuzzy annotation for dynamic-max-width.html on Apple Silicon to WebRender. DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D122129
db47c2899e2e5944f4e88deca0071d03743320a0: Bug 1724386 - Cache InternalStorageAllowedCheck on inner window. r=timhuang,nika
Paul Zuehlcke <pbz@mozilla.com> - Mon, 09 Aug 2021 16:50:42 +0000 - rev 588242
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1724386 - Cache InternalStorageAllowedCheck on inner window. r=timhuang,nika Differential Revision: https://phabricator.services.mozilla.com/D120833
b8235b350c6c072c85151022aa7926f1d716bd67: Bug 1703356 - Support color-mix() in non-sRGB color spaces r=emilio
Barret Rennie <barret@brennie.ca> - Mon, 09 Aug 2021 16:16:40 +0000 - rev 588241
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1703356 - Support color-mix() in non-sRGB color spaces r=emilio Out of gamut colours are currently clipped into sRGB. Differential Revision: https://phabricator.services.mozilla.com/D120561
f527b152b687694aea2aba0710729aa472ede3cf: Bug 1724719- Ensure IntersectionObserver.observe is O(1), not O(targetCount). r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 09 Aug 2021 16:10:07 +0000 - rev 588240
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1724719- Ensure IntersectionObserver.observe is O(1), not O(targetCount). r=smaug And that IntersectionObserver.unobserve is O(targetCount) worst case, not O(2*targetCount). Differential Revision: https://phabricator.services.mozilla.com/D122119
31f0b3f997a40ce6d68601d3ff8d9a92e93e011e: Bug 1722448 - Implement self.reportError(). r=emilio,smaug
Tom Schuster <evilpies@gmail.com> - Mon, 09 Aug 2021 16:08:59 +0000 - rev 588239
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1722448 - Implement self.reportError(). r=emilio,smaug This is mostly just copying and adjusting code from `AutoJSAPI::ReportException`. Differential Revision: https://phabricator.services.mozilla.com/D121070
abd8ccf71212bc069c92afa6304453acd691cc94: Bug 1722662 - Add tests for autofill rendering. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 09 Aug 2021 15:28:45 +0000 - rev 588238
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1722662 - Add tests for autofill rendering. r=hiro They're not the prettiest, but that's all that needs to happen right now for autofill to work. Depends on D122015 Differential Revision: https://phabricator.services.mozilla.com/D122016
1bcfaa7b4b3f9491ca7d1cdb687ff705af3ebefd: Bug 1722662 - Load SpecialPowers in reftests. r=jgraham,jmaher
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 09 Aug 2021 15:28:45 +0000 - rev 588237
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1722662 - Load SpecialPowers in reftests. r=jgraham,jmaher Depends on D122014 Differential Revision: https://phabricator.services.mozilla.com/D122015
db41a8a3a901532daabbadc5934c9ba49fc2b387: Bug 1722662 - Make :-moz-autofill-preview imply :autofill. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 09 Aug 2021 15:28:45 +0000 - rev 588236
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1722662 - Make :-moz-autofill-preview imply :autofill. r=hiro This is useful so that author rules for :autofill also work for the autofill preview. It also makes the UA sheet in forms.css simpler (otherwise we'd need to tweak the selectors to put :-moz-autofill-preview everywhere we put :autofill). Depends on D122013 Differential Revision: https://phabricator.services.mozilla.com/D122014
72b71bfe6d2cd8e2a85bf9e972c766954819336c: Bug 1722662 - Make Element::{Add,Remove}States handle change notifications correctly. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 09 Aug 2021 15:28:44 +0000 - rev 588235
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1722662 - Make Element::{Add,Remove}States handle change notifications correctly. r=smaug The style system uses the changed bits to compute the old state, so if it's inaccurate it might cause styles to be incorrectly invalidated. This causes issues because with the next patch the autofill jsm calls removeManuallyManagedStates(AUTOFILL), then addManuallyManagedStates(AUTOFILL | AUTOFILL_PREVIEW), and if the input didn't have AUTOFILL before we'd incorrectly detect it as not changing with the next patch. Also make them not virtual anymore since nobody overrides them. An alternative to this would be to assert that we don't yet have the state we're adding (or that we have the state we're removing), and handle it in the callers. But this is a bit more convenient. Differential Revision: https://phabricator.services.mozilla.com/D122013
5fbcd90b2e8f22b92afb30f32c4fb2aa573dfff9: Bug 1723715 part 16 - Move WindowProxy to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:10 +0000 - rev 588234
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 16 - Move WindowProxy to GlobalObjectData. r=jonco This is done last because it requires reordering the initialization code, and we can finally do this now. Differential Revision: https://phabricator.services.mozilla.com/D121996
c820d2e6087ea27bfbd3d6c332ae460abf7f887e: Bug 1723715 part 15 - Move global lexical environment from Realm to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:10 +0000 - rev 588233
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 15 - Move global lexical environment from Realm to GlobalObjectData. r=jonco This adds a few dereferences to the Baseline Interpreter, but is simpler and should be faster for C++ accesses. It also simplifies/unblocks the next patch. Differential Revision: https://phabricator.services.mozilla.com/D121995
61dd98c602d89b40d9602fb9a2e2189d807d2993: Bug 1723715 part 14 - Clean up slot related code a bit. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:09 +0000 - rev 588232
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 14 - Clean up slot related code a bit. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D121994
eeb83afc429e8621acee3a911d698f84a7b8e8f2: Bug 1723715 part 13 - Move builtin constructors to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:09 +0000 - rev 588231
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 13 - Move builtin constructors to GlobalObjectData. r=jonco This replaces the JS_OFF_THREAD_CONSTRUCTOR MagicValue for off-thread constructors with the same placeholder object we use for the prototype. These constructors aren't used by off-thread parsing and handling this another way requires a lot of complexity. With Stencil work the off-thread global will hopefully be removed eventually. Differential Revision: https://phabricator.services.mozilla.com/D121993
f73777bc287765b67d7780a09ae63d7b2419d0d6: Bug 1723715 part 12 - Move some builtin prototypes to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:08 +0000 - rev 588230
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 12 - Move some builtin prototypes to GlobalObjectData. r=jonco Depends on D121991 Differential Revision: https://phabricator.services.mozilla.com/D121992
71d833b689b6a6f4b3c6d91984f3d7e0eef6efa7: Bug 1723715 part 11 - Move eval function to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:08 +0000 - rev 588229
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 11 - Move eval function to GlobalObjectData. r=jonco Depends on D121990 Differential Revision: https://phabricator.services.mozilla.com/D121991
1fbf0da3218011bcafb45fe47270789047f2696f: Bug 1723715 part 10 - Move ThrowTypeError to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:08 +0000 - rev 588228
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 10 - Move ThrowTypeError to GlobalObjectData. r=jonco Depends on D121989 Differential Revision: https://phabricator.services.mozilla.com/D121990
371c84d4007e26d4a38dc05bb43fe5e0c5685022: Bug 1723715 part 9 - Move array shape to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:07 +0000 - rev 588227
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 9 - Move array shape to GlobalObjectData. r=jonco Depends on D121988 Differential Revision: https://phabricator.services.mozilla.com/D121989
348de7b61aa01a054a849497439c1f1d7e4202a1: Bug 1723715 part 8 - Move realm key object to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:07 +0000 - rev 588226
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 8 - Move realm key object to GlobalObjectData. r=jonco Depends on D121987 Differential Revision: https://phabricator.services.mozilla.com/D121988
8556d887ee8b0f2f936aa571bde49daf9ac6fc46: Bug 1723715 part 7 - Move SourceURLsHolder to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:07 +0000 - rev 588225
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 7 - Move SourceURLsHolder to GlobalObjectData. r=jonco Depends on D121986 Differential Revision: https://phabricator.services.mozilla.com/D121987
3cb4aa71f8e8e5f3d69662553840b0a2fda26c65: Bug 1723715 part 6 - Move globalThisResolved to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:06 +0000 - rev 588224
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 6 - Move globalThisResolved to GlobalObjectData. r=jonco Depends on D121985 Differential Revision: https://phabricator.services.mozilla.com/D121986
73f320ef0d12a6fb4b37e4cce6944be2ce6c5f64: Bug 1723715 part 5 - Move ForOfPICChain to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:06 +0000 - rev 588223
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 5 - Move ForOfPICChain to GlobalObjectData. r=jonco Depends on D121984 Differential Revision: https://phabricator.services.mozilla.com/D121985
ed50c6a66971df2b8aac9efd200e02b4abc0780f: Bug 1723715 part 4 - Move intrinsics holder to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:05 +0000 - rev 588222
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 4 - Move intrinsics holder to GlobalObjectData. r=jonco Depends on D121983 Differential Revision: https://phabricator.services.mozilla.com/D121984
1bcb3ef4165f4ae739248ac05b3fbc91d85520a5: Bug 1723715 part 3 - Move RegExpStaticsObject to GlobalObjectData. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Mon, 09 Aug 2021 15:25:05 +0000 - rev 588221
Push 38689 by imoraru@mozilla.com at Mon, 09 Aug 2021 21:33:53 +0000
Bug 1723715 part 3 - Move RegExpStaticsObject to GlobalObjectData. r=jonco RegExpStaticsObject just stores the RegExpStatics. It might be possible to store the RegExpStatics directly in the GlobalObjectData in a follow-up bug. Depends on D121982 Differential Revision: https://phabricator.services.mozilla.com/D121983
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -30 +30 +50 +100 +300 +1000 +3000 +10000 +30000 tip