95fe4a4625fe6d10e43200ceef5df7df0d521dbb: Bug 1461522 - Allow { height: "auto" } in HTMLTooltip setContent and make it the default; r=jdescottes
Brian Birtles <birtles@gmail.com> - Thu, 28 Jun 2018 15:03:57 +0900 - rev 424989
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1461522 - Allow { height: "auto" } in HTMLTooltip setContent and make it the default; r=jdescottes The current default value for height of Infinity has the unfortunate side effect that, when combined with using a XUL wrapper, there will be a large filler element stretching vertically on one side of the tooltip that effectively neuters all content beneath it. While this is probably fine for tooltips that are shown on hover, it is problematic if we want to use this for DevTools menus because it means the user is unable to click anything above/below the menu so long as it is open (which can be particularly problematic once we make HTMLTooltip support the "Disable popup autohide" feature"). Even if we were to decide that clicks outside the tooltip should be consumed anyway we would still have the problem that hover styles don't apply in this "dead" region. As a result, this patch makes the { height: Infinity } behaviour opt-in for those tooltips that really need it. For most uses, however, a height calculated when the tooltip is shown should be sufficient (and later in this patch series we will add a mechanism to HTMLTooltip to explicitly request it recalculate its size and position in response to content changes). This patch introduces the { height: "auto" } mechanism and also reverses the order in which size/position properties are calculated to match the regular manner in which layout is performed: widths first, then heights. MozReview-Commit-ID: 7BeVkxGVhYn
924dcb50f6da454045b6ca91ab20bd913396bec2: Bug 1461522 - Fix some comments in HTMLTooltip.js; r=jdescottes
Brian Birtles <birtles@gmail.com> - Thu, 28 Jun 2018 14:56:30 +0900 - rev 424988
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1461522 - Fix some comments in HTMLTooltip.js; r=jdescottes MozReview-Commit-ID: F01ofl9u5lR
52628cf763c9dcc0907b8bb54ee6ce82e92038a4: Bug 1461522 - Use the currentZoom as opposed to the pref value; r=jdescottes
Brian Birtles <birtles@gmail.com> - Thu, 28 Jun 2018 14:55:48 +0900 - rev 424987
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1461522 - Use the currentZoom as opposed to the pref value; r=jdescottes In a couple of places in DevTools we read back the value of the "devtools.toolbox.zoomValue" pref and take that to be the zoom value. However, at certain zoom levels these two can differ: the pref value representing the ideal zoom and currentZoom giving the actual zoom value in use. This patch makes us use the actual zoom value in the two places where this occurs. Unfortunately, we cannot easily adjust the browser_html_tooltip_zoom.js test for this since it uses a separate XUL document that does not take into account the pref value---as a result that test directly sets the currentZoom on the separate doc and hence this problem won't occur. Instead, this patch adjusts the browser_toolbox_zoom_popup.js test since the toolbox menu positioning uses the same problematic pattern so we can reproduce the bug in the browser_toolbox_zoom_popup.js. (This patch fixes both occurances of this pattern.) At least locally browser_toolbox_zoom_popup.js passes for me with a zoom of 1.5 but fails with a zoom of 1.4. Similarly in my testing of HTMLTooltip, zoom values such as 1.2 and 1.4 often show significant misalignment whilst a zoom of 1.3 or 1.5 is fine. With the code changes in this patch, the test passes with any given zoom factor. (This patch also incidentally replaced isNaN with the more robust Number.isNaN.) MozReview-Commit-ID: JmlRoidARVp
f995e3ff5de49405ece552c954514e568897d23c: Bug 1461522 - Make HTMLTooltip position the arrow correctly in RTL mode; r=jdescottes
Brian Birtles <birtles@gmail.com> - Thu, 28 Jun 2018 14:52:10 +0900 - rev 424986
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1461522 - Make HTMLTooltip position the arrow correctly in RTL mode; r=jdescottes Currently the arrow offset is not correctly positioned in RTL mode as evidenced by the test case included in this patch (which fails without the code changes included in this patch). This patch logicalizes the calculations for positioning the tooltip which fixes this and other issues when using RTL mode and will make it easier to introduce a new "doorhanger" type tooltip later in this patch series. MozReview-Commit-ID: BQXhDHbPTbl
ea72ff9a6e23abf3aa52aaaf06a9ba8b18ca39c7: Bug 1470530 - [wdspec] Refactor "session" fixture for clean-up steps. r=ato
Henrik Skupin <mail@hskupin.info> - Wed, 27 Jun 2018 16:57:51 +0200 - rev 424985
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1470530 - [wdspec] Refactor "session" fixture for clean-up steps. r=ato By using yield for returning the session, there is no need to define all the finalizers. Instead those can be called right after the line with yield. To ease the usage of clean-up all individual clean-up methods are now called by the "cleanup_session" method in the correct order. MozReview-Commit-ID: 1jsLDjEhkQp
bbccc02967d3eabdc30b32f4b33370c2a2a5d936: Bug 1470530 - [wdspec] Move "add_browser_capabilities" fixture under "new_session". r=ato
Henrik Skupin <mail@hskupin.info> - Wed, 27 Jun 2018 16:40:18 +0200 - rev 424984
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1470530 - [wdspec] Move "add_browser_capabilities" fixture under "new_session". r=ato The "add_browser_capabilities" fixture is only used for new session tests, and as such makes sense to only expose the fixture for that specific sub directory. MozReview-Commit-ID: 7FYuz9lVRxH
2732ac33aac97da3f8f6b7d2fd7f8c748edc72fb: Bug 1470530 - [wdspec] Always use the "create_dialog" and "create_window" fixtures. r=ato
Henrik Skupin <mail@hskupin.info> - Wed, 27 Jun 2018 16:29:11 +0200 - rev 424983
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1470530 - [wdspec] Always use the "create_dialog" and "create_window" fixtures. r=ato With the WebDriver session created by the "session" fixture, there is no need anymore to pass a session instance to one of those methods. Instead the appropriate fixture can be used. MozReview-Commit-ID: CaveLEICbXD
1ec59d0783a52165b9d7b8e8c9b57e6ff9fde42b: Bug 1470530 - [wdspec] Allow parametrization of "session" fixture and remove global "new_session" fixture. r=ato
Henrik Skupin <mail@hskupin.info> - Fri, 22 Jun 2018 20:50:23 +0200 - rev 424982
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1470530 - [wdspec] Allow parametrization of "session" fixture and remove global "new_session" fixture. r=ato With this patch the "session" fixture will make use of the new "capabilities" fixture to create WebDriver sessions with custom capabilities. It means the separate "new_session" fixture is no longer needed. Further the "session" fixture will only create a new session when the specified capabilities are different from the requested capabilities of the current session. To make it easier for tests to specify custom capabilities a marker with the same name has been created. It accepts a dict of capabilities as argument, and will then parametrize the current test. MozReview-Commit-ID: 8gQCQTtXs7C
e4190bcbd4ef1b4dc8bb21c265c667cd007326d1: Bug 1470530 - [wptrunner] Correct the warning to error option for pytest. r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 28 Jun 2018 21:42:15 +0200 - rev 424981
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1470530 - [wptrunner] Correct the warning to error option for pytest. r=ato Currently the "--strict" option is used to turn warnings into errors. But even the help content says that, it is not true. Instead this option is only used for markers. To actually turn warnings into errors the "-W error" option would have to be used. More details see: https://github.com/pytest-dev/pytest/issues/2444 MozReview-Commit-ID: AQMwZlwC46w
7efe662a874d20c9b7747c55f15900dc5da8545e: Bug 1467794 - Split TextEditor::DeleteSelectionAsAction() to itself and TextEditor::DeleteSelectionAsSubAction() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 29 Jun 2018 20:16:50 +0900 - rev 424980
Push 34231 by rgurzau@mozilla.com at Wed, 04 Jul 2018 16:28:29 +0000
Bug 1467794 - Split TextEditor::DeleteSelectionAsAction() to itself and TextEditor::DeleteSelectionAsSubAction() r=m_kato TextEditor::DeleteSelectionAsAction() is called even if it's a part of edit action. For example, it's called to prepare for inserting text. For bug 1465702, editor itself and edit rules classes should not call public DeleteSelectionAsAction() directly. Therefore, this patch creates DeleteSelectionAsSubAction() for internal use. Note that this patch adds NS_ASSERTION() to detect wrong caller. However, it cannot distinguish if the call is valid, for example, it's allowed to call DeleteSelectionAsSelection() even if it's handling an edit action but the method is called via mutation event listener. So, we need to allow some assertions with some tests. But unfortunately, 1405747.html uses mutation event listener too many times (about 1,000 times) and the number of assertion isn't stable. Therefore, this patch makes the test stop using the mutation event listener 2nd time since I can reproduce the crash with ESR 52 at the 2nd time. MozReview-Commit-ID: 1TWaypmnoCC
b66f3991034ce4c9e4ea907a64a961bd72f01d7e: Bug 1473331 - fix environment issues when checking node version; r=me, a=bustage
Nathan Froyd <froydnj@mozilla.com> - Wed, 04 Jul 2018 12:09:41 -0400 - rev 424979
Push 34230 by nfroyd@mozilla.com at Wed, 04 Jul 2018 16:10:10 +0000
Bug 1473331 - fix environment issues when checking node version; r=me, a=bustage MozReview-Commit-ID: SGkfho9nvV
a9dc5dc8e2b8513686ad1b1f28c9e4da6de62226: Backed out changeset 9c75cab2e322 (bug 733530) for breaking artifact builds
Bogdan Tara <btara@mozilla.com> - Wed, 04 Jul 2018 14:50:22 +0300 - rev 424978
Push 34229 by btara@mozilla.com at Wed, 04 Jul 2018 11:51:21 +0000
Backed out changeset 9c75cab2e322 (bug 733530) for breaking artifact builds
0c5ad222605bc6579f4e281a30fc55b0634c08e1: Bug 1471028 - fix check for outdated node versions; r=bustage, a=bustage
Nathan Froyd <froydnj@mozilla.com> - Wed, 04 Jul 2018 07:46:08 -0400 - rev 424977
Push 34228 by nfroyd@mozilla.com at Wed, 04 Jul 2018 11:47:10 +0000
Bug 1471028 - fix check for outdated node versions; r=bustage, a=bustage MozReview-Commit-ID: 5OlPH2tUACP
cc3401e78e8bbae22e6dbc854e525ceae4923bcf: Merge inbound to mozilla-central. a=merge
Gurzau Raul <rgurzau@mozilla.com> - Wed, 04 Jul 2018 12:58:33 +0300 - rev 424976
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Merge inbound to mozilla-central. a=merge
ff25e66da36e4c95363e684880085f99d845da2a: Bug 1460022: Part 13 - Update profiler to use revised DLL interceptor interface; r=njn
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 14:23:29 -0600 - rev 424975
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 13 - Update profiler to use revised DLL interceptor interface; r=njn
1cdba0bde1857d2c8611fceaaa5f1d9fc6168ff6: Bug 1460022: Part 12 - Update XPCOM to use revised DLL interceptor interface; r=froydnj
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:52:18 -0600 - rev 424974
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 12 - Update XPCOM to use revised DLL interceptor interface; r=froydnj
c95140bcd817476c28d70fc2f749ae94b4abc3e6: Bug 1460022: Part 11 - Update Win32 nsWindow to work with revised DLL interceptor interface; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:52:01 -0600 - rev 424973
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 11 - Update Win32 nsWindow to work with revised DLL interceptor interface; r=mhowell
9c21c99f6b7703765f86b5860c0d4e5462e7ed2a: Bug 1460022: Part 10 - Update crash reporter to work with revised DLL interceptor interface; r=dmajor
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:51:40 -0600 - rev 424972
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 10 - Update crash reporter to work with revised DLL interceptor interface; r=dmajor
097d82eb192888b55fc00cc6ccba78098afda4cf: Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:51:29 -0600 - rev 424971
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
528b5685d597db2680e356bbd67fc52e575e3853: Bug 1460022: Part 8 - Update DLL blocklist to work with revised DLL interceptor interface; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:51:10 -0600 - rev 424970
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 8 - Update DLL blocklist to work with revised DLL interceptor interface; r=mhowell
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip