954ee70d2de7f2fd8ce72c579b0bd22972079693: Bug 1632203 - Show legible progress bar in high contrast mode. r=mhowell
Adam Gashlin <agashlin@mozilla.com> - Wed, 22 Apr 2020 22:45:07 +0000 - rev 525523
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1632203 - Show legible progress bar in high contrast mode. r=mhowell These styles will produce no change in the layout, and only apply in high contrast mode. Also removed an extra comma that broke parsing in aurora. Differential Revision: https://phabricator.services.mozilla.com/D72070
66a886eef3fd11f34a779758eb38e4245a6f6a65: Bug 1631963: Warn in web console about {sdpSemantics: plan-b} usage. r=bwc,emilio
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 22 Apr 2020 23:15:25 +0000 - rev 525522
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1631963: Warn in web console about {sdpSemantics: plan-b} usage. r=bwc,emilio Differential Revision: https://phabricator.services.mozilla.com/D71835
c39d389d140cdaffd02349f91e78a3a5671dc50c: Bug 1630742 - cmd+click should continue to here. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Thu, 23 Apr 2020 00:07:13 +0000 - rev 525521
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1630742 - cmd+click should continue to here. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D71217
2f06fd7ef8b6fb4ab6964df27a39c2a880644990: Bug 1583696 - Remove XUL grid from toolkit/components/prompts/content/tabprompts.jsm. r=MattN,marionette-reviewers,whimboo
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 22 Apr 2020 23:46:35 +0000 - rev 525520
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1583696 - Remove XUL grid from toolkit/components/prompts/content/tabprompts.jsm. r=MattN,marionette-reviewers,whimboo Differential Revision: https://phabricator.services.mozilla.com/D61442
4509808243f577afe8fd980737183bf7cf2aacf3: Bug 1607984 - P17. Put ParentProcessDocumentChannel behind a pref. r=necko-reviewers,mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 Apr 2020 23:49:38 +0000 - rev 525519
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P17. Put ParentProcessDocumentChannel behind a pref. r=necko-reviewers,mattwoodrow We disable it on Android for now due to unexplained reftest start failures. Differential Revision: https://phabricator.services.mozilla.com/D71875
0cb21bedf65fcf42ac4a68e4757dfb16cf4e5bb5: Bug 1607984 - P16. Always whitelist file. r=markh
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 Apr 2020 13:44:23 +0000 - rev 525518
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P16. Always whitelist file. r=markh This file will be removed in bug 1628752 anyway. Differential Revision: https://phabricator.services.mozilla.com/D70801
4e5d89f682930dbb2d3e2f4659f043a5d2e600d8: Bug 1607984 - P15. Wait for the load to start before setting the event handler. r=Jamie
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 Apr 2020 10:27:31 +0000 - rev 525517
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P15. Wait for the load to start before setting the event handler. r=Jamie addA11yLoadEvent gets the contentWindow and wait for the document from that window to fire the load event. Enabling the DocumentChannel for parent process load (or here in non-e10s mode) we have one extra event loop before the load starts. So the window passed to addAllyLoadEvent would have been of the about:blank page. The current code was based on an observable behaviour which was that the load was occuring synchronously. DocumentChannel broke that assumption. Differential Revision: https://phabricator.services.mozilla.com/D70799
0c0169ed4f045fba65c309f166eebf18a3a12320: Bug 1607984 - P14. Fix test_bug1339722.html when using PPDC. r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 Apr 2020 10:27:26 +0000 - rev 525516
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P14. Fix test_bug1339722.html when using PPDC. r=valentin When starting a load via the ParentProcessDocumentChannel, the event http-on-modify-request will be fired before the DocumentLoadListener has a chance to set the notificationCallback attribute. When using a DocumentChannel, this test will not trigger the expected codepath as the DOMWindowCreated event will be fired once the channel is fully up and running; which in effect is also a fix of the original bug 1339722 Instead we use the document-on-modify-request event when the DocumentChannel is enabled. Differential Revision: https://phabricator.services.mozilla.com/D70011
ce527a6ffba4847fa3bd98a7e1985c9115fdfcb2: Bug 1607984 - P13. Proxy the first http-on-opening-request event to the DocumentChannel. r=mayhemer,necko-reviewers
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 Apr 2020 15:16:10 +0000 - rev 525515
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P13. Proxy the first http-on-opening-request event to the DocumentChannel. r=mayhemer,necko-reviewers Some tests rely on this event to start action. The DocumentChannel had no equivalent. We make the ParentProcessDocumentChannel listen to this event and if it matches the nsIChannel currently in use in the DocumentLoadListener than we emit a similar document-on-modify-request event on the DocumentChannel. Differential Revision: https://phabricator.services.mozilla.com/D70010
63175f596762ca4228f90817d75187be1e16125b: Bug 1607984 - P12. Start parent load via DocumentChannel. r=mayhemer,nika,mattwoodrow,necko-reviewers
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 Apr 2020 10:27:11 +0000 - rev 525514
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P12. Start parent load via DocumentChannel. r=mayhemer,nika,mattwoodrow,necko-reviewers Add ParentProcessDocumentChannel object. This object is a DocumentChannel that will start a channel load from the parent process via a DocumentChannel. The aim of this task is two-fold. 1- Be consistent on how we handle redirects before continuing the load on the final channel. 2- Prepare to initiate a process switch when needed without having to go via an intermediary content process, saving a process switch. This task will be done in a follow-up task. The behaviour of the ParentProcessDocumentChannel is similar in logic to the DocumentChannelChild/DocumentChannelParent pair. The ParentProcessDocumentChannel sets up a DocumentLoadListener, have it handle the redirects and upon completion continue the load on the final channel. Differential Revision: https://phabricator.services.mozilla.com/D70009
107be8f3737d8f1de477f070d335847cec28cde8: Bug 1607984 - P11. Don't assume the page will be loaded synchronously. r=zombie
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:11 +0000 - rev 525513
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P11. Don't assume the page will be loaded synchronously. r=zombie We must wait for the iframe created by extension1 to be fully loaded before we can attempt to send a message to it. So we send a message when it is ready, and suspend the execution until this message is received. Differential Revision: https://phabricator.services.mozilla.com/D70008
d7600d4d3528ad49f609a1af8c31a86de85770fd: Bug 1607984 - P10. Wait until OnStopRequest has been called to clear mRequest. ?valentin r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:13 +0000 - rev 525512
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P10. Wait until OnStopRequest has been called to clear mRequest. ?valentin r=valentin The code assumed that nsJARChannel::RetargetDeliveryTo would have been called synchronously from nsJARChannel::OnStartRequest, which would be true if we weren't using a DocumentChannel. The DocumentLoadListener queue the calls to OnStartRequest until the final redirect. nsJARChannel::RetargetDelivery mRequest member is be set to forward the call. So we need to only reset it once OnStopRequest has been received. Differential Revision: https://phabricator.services.mozilla.com/D70007
e11b1b0ecfbfd26b46a1bb6b8b27fbbf66b68302: Bug 1607984 - P9. Implement nsIThreadRetargetableStreamListener in ParentChannelListerner. r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:15 +0000 - rev 525511
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P9. Implement nsIThreadRetargetableStreamListener in ParentChannelListerner. r=valentin The DocumentLoadListener is setting up a ParentChannelListener to go in between the normal listener->channel chain. ParentChannelListener not implementing nsIThreadRetargetableStreamListener would prevent a nsHtml5StreamParser settings things up so that OnDataAvailable could be sent to a html parser thread off the main thread; improving performance. Differential Revision: https://phabricator.services.mozilla.com/D70006
bed3f6bee79e08a7d0435195d4e6352241ee2feb: Bug 1607984 - P7. Fix compilation failure in non-unified mode. r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:18 +0000 - rev 525510
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P7. Fix compilation failure in non-unified mode. r=valentin Differential Revision: https://phabricator.services.mozilla.com/D70004
abe692da45563e96c9f7e5f3e8e84b506449ccd6: Bug 1607984 - P6. Fix test. r=MattN
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:21 +0000 - rev 525509
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P6. Fix test. r=MattN Following the changes to DocumentChannel the test was failing. With DC, a load may take a few event loops to start. This current test was only waiting for the load to start to the URL about:preferences#privacy-logins and would immediately tear down the window. However, this URL redirects to about:preferences#privacy ; destroying the window midway could cause XML parsing error. So now we wait for the page to fully load, and make sure we've been through both addresses. Differential Revision: https://phabricator.services.mozilla.com/D70003
e02b12515d609cde988a8466475f5cf7a5d6c2dc: Bug 1607984 - P5. Add missing nsIIdentChannel interface. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:23 +0000 - rev 525508
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P5. Add missing nsIIdentChannel interface. r=mattwoodrow Regressiong from bug 1607987. This prevented from QueryInterface(Ci.nsIIdentChannel) in JS on the channel. Differential Revision: https://phabricator.services.mozilla.com/D70002
7a2ef225a41ed5b997444e6a6632bf359ed34bd8: Bug 1607984 - P4. Expose SetClassificationFlagsHelper. r=valentin
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:25 +0000 - rev 525507
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P4. Expose SetClassificationFlagsHelper. r=valentin Differential Revision: https://phabricator.services.mozilla.com/D70001
c173bde5106bbdb988c59c826826ff3545eb198d: Bug 1607984 - P3. Fix leak in nsDSURIContentListener. r=smaug
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:28 +0000 - rev 525506
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P3. Fix leak in nsDSURIContentListener. r=smaug If we were to open the window to close it immediately; we would leak a nsHtml5Parser object. Differential Revision: https://phabricator.services.mozilla.com/D70000
dc8b37e10dc76bd1dc506651528e55a49af2c06a: Bug 1607984 - P2. Add Redirects/LastVisitInfo getters. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:30 +0000 - rev 525505
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P2. Add Redirects/LastVisitInfo getters. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D69999
09a651daf3446f99c867661c0ce0082a70ec808d: Bug 1607984 - P1. Make SerializeRedirectData const. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 15 Apr 2020 15:37:32 +0000 - rev 525504
Push 37339 by nerli@mozilla.com at Thu, 23 Apr 2020 09:52:48 +0000
Bug 1607984 - P1. Make SerializeRedirectData const. r=mattwoodrow This also removes the need to call SerializeRedirectData to set mRedirectChannelId to the proper value and register the channel. Differential Revision: https://phabricator.services.mozilla.com/D69998
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip