95343ed265a38b4cc4de4f12189e97948bfea845: Bug 1499874 - Part 4: Removed closed tabs by ID when using undoCloseTab(). r=esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 23 Dec 2018 18:42:08 +0100 - rev 452824
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1499874 - Part 4: Removed closed tabs by ID when using undoCloseTab(). r=esawin Differential Revision: https://phabricator.services.mozilla.com/D15332
ddfc4bd7728729de8111b38c3724b6e567ec21d0: Bug 1499874 - Part 3: Renumber recently closed tabs from the previous session when automatically restoring. r=esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 23 Dec 2018 17:23:21 +0100 - rev 452823
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1499874 - Part 3: Renumber recently closed tabs from the previous session when automatically restoring. r=esawin We want to remove recently closed tabs from the session store when they get re- stored again, and for that we need something to uniquely identify them. As tab IDs are unique per session only, this means that the tab IDs of recently closed tabs resurrected from the previous session could conflict with tabs that have been freshly opened in the current session. E.g. tab 2 has been closed in a previous session and is now part of the session store's closed tab list. In the current session, a number of tabs are opened again and then what is now the *current* tab 2 is closed as well. The result would be that the session store now has two closed tabs with a tab ID of 2. To avoid that scenario, all recently closed tabs are renumbered with an ID in the negative range at the start of the session. Therefore all tabs originally opened in the current session will have a tab ID >= 0, while all recently closed tabs coming directly from a previous session will have a negative tab ID, < -1. (-1 itself remains the sentinel value for an invalid tab ID). Differential Revision: https://phabricator.services.mozilla.com/D15331
1b2727505f8719b19133cef094dc2526cbd1ca81: Bug 1499874 - Part 2: Remove tab IDs of tabs from the previous session file in the home panel. r=esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 23 Dec 2018 15:45:26 +0100 - rev 452822
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1499874 - Part 2: Remove tab IDs of tabs from the previous session file in the home panel. r=esawin We want to remove recently closed tabs from the list that have been restored again. At the moment this only works if the tab data never leaves Gecko, because in undoCloseTab(), the session store determines the tab data to be removed from its closed tab collection by checking for equality with the tab data that was passed as an argument to undoCloseTab(). So a tab restored through the "Undo" snackbar will be removed from the "Recently closed" list, but a tab restored from the History home panel won't, because in the latter case the tab data will have been serialised and deserialised while travelling back and forth between Gecko and the Android UI. Hence we're going to switch the system to identify tabs through their tab ID instead. If automatic session restoring is turned off, the "Recently closed" home panel also displays all tabs that were open in the previous session. Those tabs aren't coming directly from the session store; instead the Android UI reads them directly from the corresponding file on disk. Therefore, when restoring such a tab we need to make sure that the session store won't attempt to find and remove that tab from its own list of recently closed tabs. To that effect, we therefore simply drop the "tabId" when parsing the "last session" file from disk. Differential Revision: https://phabricator.services.mozilla.com/D15330
75e5aa1db2e189dcc93b0d9bd1d8e65f982d1953: Bug 1499874 - Part 1: Test that restoring a tab removes it from the session store. r=esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 23 Dec 2018 21:42:30 +0100 - rev 452821
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1499874 - Part 1: Test that restoring a tab removes it from the session store. r=esawin Differential Revision: https://phabricator.services.mozilla.com/D15329
89b21137ed17c6be7bef322354ecfed8631390de: Bug 1499874 - Part 0c: Reorder imports according to coding style. r=me, trivial review comment fix
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 07 Jan 2019 21:05:36 +0100 - rev 452820
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1499874 - Part 0c: Reorder imports according to coding style. r=me, trivial review comment fix org.mozilla.* imports come first. Differential Revision: https://phabricator.services.mozilla.com/D15866
87165a9651fd8eb2eb7dea10a5de3f38351e825b: Bug 1499874 - Part 0b: Remove SessionStore.forgetClosedTab(). r=esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 23 Dec 2018 17:45:10 +0100 - rev 452819
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1499874 - Part 0b: Remove SessionStore.forgetClosedTab(). r=esawin Nobody within mobile or toolkit is currently using it. Differential Revision: https://phabricator.services.mozilla.com/D15328
fae88c351d9428322c2fba2fb6ebdb44469c8663: Bug 1499874 - Part 0a: Use abbreviated function syntax for session store. r=esawin
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 23 Dec 2018 17:53:49 +0100 - rev 452818
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1499874 - Part 0a: Use abbreviated function syntax for session store. r=esawin Differential Revision: https://phabricator.services.mozilla.com/D15327
096e9d2bdcb1d7d9ea029de2943f4b41c92cbd5b: Backed out changeset f6f97217b46c (bug 1517136) for build bustage at /security/manager/ssl/nsSecureBrowserUIImpl.cpp on a CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Mon, 07 Jan 2019 21:31:52 +0200 - rev 452817
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Backed out changeset f6f97217b46c (bug 1517136) for build bustage at /security/manager/ssl/nsSecureBrowserUIImpl.cpp on a CLOSED TREE
6b2a8ae7d91e1a4acfefd85379cba3e8962a8b9a: Bug 1518033 - Move nsSVGBoolean and nsSVGInteger to the mozilla namespace r=jwatt
longsonr <longsonr@gmail.com> - Mon, 07 Jan 2019 19:23:13 +0000 - rev 452816
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1518033 - Move nsSVGBoolean and nsSVGInteger to the mozilla namespace r=jwatt
9b9dc72ed3444122f72145872490e75bbe9f3028: Bug 1460619 - Do not run frame request callbacks immediately after updating a VR layer
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Wed, 02 Jan 2019 13:32:09 -0800 - rev 452815
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1460619 - Do not run frame request callbacks immediately after updating a VR layer
a94a05a0a11d5bfb885eac7c0d138d12355a668e: Bug 1486507 - Record telemetry for browser language changes r=rpl,flod,chutten
Mark Striemer <mstriemer@mozilla.com> - Sat, 10 Nov 2018 10:45:23 -0600 - rev 452814
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1486507 - Record telemetry for browser language changes r=rpl,flod,chutten Differential Revision: https://phabricator.services.mozilla.com/D11795
f6f97217b46cbcfecc46d844540ec94f862d9d34: Bug 1517136 - Devirtualize and inline the calls in nsSecureBrowserUIImpl::CheckForBlockedContent(); r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 02 Jan 2019 10:21:49 -0500 - rev 452813
Push 35331 by opoprus@mozilla.com at Tue, 08 Jan 2019 10:16:13 +0000
Bug 1517136 - Devirtualize and inline the calls in nsSecureBrowserUIImpl::CheckForBlockedContent(); r=baku Differential Revision: https://phabricator.services.mozilla.com/D15574
4ad5b70956abbf9c183b1494108273fdbe9ad3a1: Bug 1518374 - Add missing dom:: declaration to PendingAnimationTracker.cpp; r=hiro
Brian Birtles <birtles@gmail.com> - Tue, 08 Jan 2019 06:46:23 +0000 - rev 452812
Push 35330 by opoprus@mozilla.com at Tue, 08 Jan 2019 09:41:12 +0000
Bug 1518374 - Add missing dom:: declaration to PendingAnimationTracker.cpp; r=hiro Depends on D15903 Differential Revision: https://phabricator.services.mozilla.com/D15904
5f9c8df9984b418b75f3934b821b3dcbc3d0dd5d: Bug 1518374 - Fix a bunch of fallout from changes to mozilla::dom::Document; r=hiro
Brian Birtles <birtles@gmail.com> - Tue, 08 Jan 2019 06:45:18 +0000 - rev 452811
Push 35330 by opoprus@mozilla.com at Tue, 08 Jan 2019 09:41:12 +0000
Bug 1518374 - Fix a bunch of fallout from changes to mozilla::dom::Document; r=hiro Bug 1517241 renamed nsIDocument to mozilla::dom::Document but unfortunately in the process it messed up the ordering of includes which, according to the coding style[1], should be alphabetically sorted. Also, in TimingParams.cpp it didn't add the dom::* prefix so when the unified build chunking changes, if the "using namespace mozilla::dom" declaration disappears from the chunk, it will fail to build. [1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#CC_practices Depends on D15902 Differential Revision: https://phabricator.services.mozilla.com/D15903
5d75876949f3865bfc8f07ed5f9a3607461b1318: Bug 1518374 - Move a couple of bool members next to each other in KeyframeEffect.h so they can be packed together; r=hiro
Brian Birtles <birtles@gmail.com> - Tue, 08 Jan 2019 06:43:52 +0000 - rev 452810
Push 35330 by opoprus@mozilla.com at Tue, 08 Jan 2019 09:41:12 +0000
Bug 1518374 - Move a couple of bool members next to each other in KeyframeEffect.h so they can be packed together; r=hiro Depends on D15901 Differential Revision: https://phabricator.services.mozilla.com/D15902
b1f4b8412f62416c82bf0dba41ca7cb7125910e9: Bug 1518374 - Drop unused aEffectSet parameter from EffectCompositor::AllowCompositorAnimationsOnFrame; r=hiro
Brian Birtles <birtles@gmail.com> - Tue, 08 Jan 2019 06:42:56 +0000 - rev 452809
Push 35330 by opoprus@mozilla.com at Tue, 08 Jan 2019 09:41:12 +0000
Bug 1518374 - Drop unused aEffectSet parameter from EffectCompositor::AllowCompositorAnimationsOnFrame; r=hiro Depends on D15900 Differential Revision: https://phabricator.services.mozilla.com/D15901
c19867adc2c78839543c18eecd2c6425e736b894: Bug 1518374 - Mark GetKeyframes and GetTargetComputedStyle as const; r=hiro
Brian Birtles <birtles@gmail.com> - Tue, 08 Jan 2019 06:42:17 +0000 - rev 452808
Push 35330 by opoprus@mozilla.com at Tue, 08 Jan 2019 09:41:12 +0000
Bug 1518374 - Mark GetKeyframes and GetTargetComputedStyle as const; r=hiro Depends on D15899 Differential Revision: https://phabricator.services.mozilla.com/D15900
d497b0f223c9f1836cf320b594964794fd54f4bd: Bug 1518374 - Remove obsolete comment in Animation.h about kNoIndex; r=hiro
Brian Birtles <birtles@gmail.com> - Tue, 08 Jan 2019 06:41:34 +0000 - rev 452807
Push 35330 by opoprus@mozilla.com at Tue, 08 Jan 2019 09:41:12 +0000
Bug 1518374 - Remove obsolete comment in Animation.h about kNoIndex; r=hiro As of bug 1203009 / changeset 37b6deedaab6 and per spec, we no longer reset the animation index when an Animation re-enters the idle state and kNoIndex is no longer defined. Depends on D15898 Differential Revision: https://phabricator.services.mozilla.com/D15899
3ff9725e0c3a53a71fb3af3c1f4fd9f49828fa5b: Bug 1518374 - Shuffle definitions in Animation.h; r=hiro
Brian Birtles <birtles@gmail.com> - Tue, 08 Jan 2019 06:47:43 +0000 - rev 452806
Push 35330 by opoprus@mozilla.com at Tue, 08 Jan 2019 09:41:12 +0000
Bug 1518374 - Shuffle definitions in Animation.h; r=hiro This arranges related declarations by function as opposed to trying to distinguish between functions that are Web-facing and those that are not. The order still corresponds to the order in the spec[1] however. [1] https://drafts.csswg.org/web-animations-1/#the-animation-interface Differential Revision: https://phabricator.services.mozilla.com/D15898
e59729ade65262288e43f679455be1e5da8b13c3: No bug: [try-staging] Update balrog rules to match staging balrog; r=nthomas
Tom Prince <mozilla@hocat.ca> - Tue, 08 Jan 2019 02:04:51 +0000 - rev 452805
Push 35330 by opoprus@mozilla.com at Tue, 08 Jan 2019 09:41:12 +0000
No bug: [try-staging] Update balrog rules to match staging balrog; r=nthomas The staging balrog server got reset to match production, so update the rules to match. Differential Revision: https://phabricator.services.mozilla.com/D15764
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip