9469c37cc124badf9e8cfd29be4469f50a9c2c47: Bug 1499212 - suggest non-ASCII Assign for non-static-const same-char_type array parameters r=dbaron
Karl Tomlinson <karlt+@karlt.net> - Thu, 18 Oct 2018 21:53:33 +0000 - rev 442047
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1499212 - suggest non-ASCII Assign for non-static-const same-char_type array parameters r=dbaron There is no advantage in AssignASCII() for char, and AssignASCII() does not exist for char16_t array and char_type. Similarly for ReplaceASCII and AppendASCII. This AssignLiteral() overload already says it is not only for ASCII. Depends on D8771 Differential Revision: https://phabricator.services.mozilla.com/D8773
386c46fc6e8dce5760f74427c125a63261c4b908: Bug 1499212 Document static storage requirement for same-char_type AssignLiteral overload r=dbaron
Karl Tomlinson <karlt+@karlt.net> - Tue, 16 Oct 2018 21:09:27 +0000 - rev 442046
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1499212 Document static storage requirement for same-char_type AssignLiteral overload r=dbaron Depends on D8770 Differential Revision: https://phabricator.services.mozilla.com/D8771
5463ea36a953009a99dded33078b79f7c45b38aa: Bug 1499212 remove mention of character pointers in docs for Literal methods r=dbaron
Karl Tomlinson <karlt+@karlt.net> - Tue, 16 Oct 2018 21:07:20 +0000 - rev 442045
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1499212 remove mention of character pointers in docs for Literal methods r=dbaron Since https://hg.mozilla.org/mozilla-central/rev/9db7cf4cc385#l13.44 the type system always excludes calls with character pointers and so there is no need to mention this in the comment. The comment for the 8-bit to 16-bit AssignLiteral overload is modified a little to use "char" instead of "character" so as not to imply that anything other than 8-bit char parameters may be provided to that overload. The ReplaceLiteral and InsertLiteral comments are adjusted to use "character" instead of "char" so as not to imply that the method or comment is limited to 8-bit char parameters. Differential Revision: https://phabricator.services.mozilla.com/D8770
0f7592b662e27238b8ebc442fa755e5e891cdef9: Bug 1435871 - Open prefs from Payment Request in a tab. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 19 Oct 2018 05:06:30 +0000 - rev 442044
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1435871 - Open prefs from Payment Request in a tab. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D8497
039f6d65036e99c6ba885de5506a89e722c4e348: Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 19 Oct 2018 05:06:22 +0000 - rev 442043
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D7934
8641e30ebaf4bc3c719d6e0cacbd5b4ac6c0f980: Bug 1435871 - Back out changeset 3f6664786e85 (Bug 1470584) since it's for a windowed dialog. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 19 Oct 2018 05:06:20 +0000 - rev 442042
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1435871 - Back out changeset 3f6664786e85 (Bug 1470584) since it's for a windowed dialog. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D8272
48155e26a841cdf691af533a74c958e566c6e2b5: Bug 1498281: Make flexbox devtools API report actual flex base size (not its min/max-clamped version). r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 18 Oct 2018 23:45:51 +0000 - rev 442041
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1498281: Make flexbox devtools API report actual flex base size (not its min/max-clamped version). r=bradwerth This patch also updates the expectations in the mochitest test_flex_items.html. Before this commit, the test (incorrectly) expected the mainBaseSize API to return some items' *final sizes*, because that's what our implementation did return, up until now. As of this patch, that API will now return the item's actual flex base size, which means the text expectations need to change. I'm also adding a new flex item to the test, to exercise a formerly-untested scenario. And to accommodate this new item, I'm also doubling the width of the flex container to be sure there's plenty of space. Differential Revision: https://phabricator.services.mozilla.com/D8476
b809ef6dba1b6fb18ac5151e44b1afa18e104c94: Merge mozilla-central to autoland. a=merge
Cosmin Sabou <csabou@mozilla.com> - Fri, 19 Oct 2018 07:20:02 +0300 - rev 442040
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Merge mozilla-central to autoland. a=merge
394a1e5544f65e59ea1e12e19f788f50078ddf20: Bug 1486888 - Support XUL broadcasters in non-XUL documents. r=smaug
Brendan Dahl <bdahl@mozilla.com> - Fri, 19 Oct 2018 01:22:46 +0000 - rev 442039
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1486888 - Support XUL broadcasters in non-XUL documents. r=smaug The majority of the XUL broadcaster logic is moved out of XULDocument and into a separate class (XULBroadcastManager). The hookup points for when listeners need to be created and listeners need to be notified is now handled by the XULElement itself and nsDocument. To avoid any overhead, the XULBroadcastManager is only ever created when a document uses a listener. The new approach does have the disadvantage that broadcasting can now only work with XULElements, but going forward we'd like to discontinue this feature and rely on MutationObservers to implement similar things. One test had to be modified to use XUL elements instead of HTML elements because of the reason noted above. Differential Revision: https://phabricator.services.mozilla.com/D8888
b73ac3a4b55d78e5394b77b80b2447b6066e9078: Merge m-c to autoland. a=merge
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 18 Oct 2018 20:51:44 -0400 - rev 442038
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Merge m-c to autoland. a=merge
f972dce0b524da3bb82a07d3c4c04d693941c878: Backed out 2 changesets (bug 1499209)for failing Android geckoview on AccessibilityTest.testCheckbox
arthur.iakab <aiakab@mozilla.com> - Fri, 19 Oct 2018 03:27:20 +0300 - rev 442037
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Backed out 2 changesets (bug 1499209)for failing Android geckoview on AccessibilityTest.testCheckbox Backed out changeset 12527d50a493 (bug 1499209) Backed out changeset 4b8f36f9896b (bug 1499209)
c096376198dfd61024c75345b94c9674b403988b: Backed out changeset b969cbe46b14 (bug 1492656)for Android xpcshell failures on unit/test_CoveragePing.js CLOSED TREE
arthur.iakab <aiakab@mozilla.com> - Fri, 19 Oct 2018 03:12:23 +0300 - rev 442036
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Backed out changeset b969cbe46b14 (bug 1492656)for Android xpcshell failures on unit/test_CoveragePing.js CLOSED TREE
2ce0ac92bee586c4e67a302929e1532ec8831505: Bug 1499542 part 3: Give test_flex_items.html an item that's trivially clamped to small max-size. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 17 Oct 2018 19:15:15 +0000 - rev 442035
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1499542 part 3: Give test_flex_items.html an item that's trivially clamped to small max-size. r=bradwerth Depends on D9018 Differential Revision: https://phabricator.services.mozilla.com/D9019
3ea646bde4de4772a439a31798406287d2be685e: Bug 1499542 part 2: Skip frozen flex items when recording grow-vs-shrink state and deltas. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 17 Oct 2018 18:52:33 +0000 - rev 442034
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1499542 part 2: Skip frozen flex items when recording grow-vs-shrink state and deltas. r=bradwerth Frozen flex items have already been clamped to their min/max sizes, so their size-change isn't a "how much we want to flex" measurement, and it's not useful for determining whether the rest of the line is shrinking. This patch is just adding a `if (!item->IsFrozen())` check around some code, and reindenting that code, and adjusting a few comments. This change is necessary to avoid failing the "GrowthState" assertions, because (for example) a flex item that's clamped to a small max-width could fool us into thinking we're in a "shrinking" state (since its final size is smaller than its base size), even though really we're in a "growth" state and the item was simply clamped. We avoid this problem by skipping (potentially-clamped) frozen items when determining the line's GrowthState. Depends on D8922 Differential Revision: https://phabricator.services.mozilla.com/D9018
52bd865d757c2787845e1bb79ed3936484d6ce3b: Bug 1499542 part 1: Don't do early-freeze of flexible-but-doomed-to-be-clamped flex items, if devtools are active. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 18 Oct 2018 23:44:42 +0000 - rev 442033
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1499542 part 1: Don't do early-freeze of flexible-but-doomed-to-be-clamped flex items, if devtools are active. r=bradwerth We'd like to be able to record the "desired" (pre-clamped) delta size from tentatively flexing for these items. That size would be computed during a loop of the flex layout algorithm -- but we can't do that if we freeze them before we start flexing. So let's bypass this early freeze so they get a chance to compute this tentative size, even though they can never have it. Differential Revision: https://phabricator.services.mozilla.com/D8922
12527d50a493ce5a8c96bd7e6990d751ce9846e6: Bug 1499209 - Send abbreviated source bundles with accessibility events. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 18 Oct 2018 22:54:10 +0000 - rev 442032
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1499209 - Send abbreviated source bundles with accessibility events. r=Jamie Depends on D8778 Differential Revision: https://phabricator.services.mozilla.com/D8779
4b8f36f9896b04d3e10f598383edd019feb1ce73: Bug 1499209 - Refactor AccessibleWrap::ToBundle 1/2. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 18 Oct 2018 22:54:06 +0000 - rev 442031
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1499209 - Refactor AccessibleWrap::ToBundle 1/2. r=Jamie This refactor does a few things: 1. Unifies the composition of the GeckoBundle, so that some tricky edge cases don't need to be implemented twice. 2. Allows us to be more frugal with round trip sync ipc calls. Instead of retrieving everything from the start, only progressivley retrieve what we need. 3. Sets the groundwork for the next patch that will return from this function earlier with a smaller bundle. Differential Revision: https://phabricator.services.mozilla.com/D8778
d0d593bf9772b1eb99547d114c9c6533e87bcd56: Bug 1499809 - l10n bumper should touch a status file on success. r=nthomas
Aki Sasaki <asasaki@mozilla.com> - Thu, 18 Oct 2018 22:05:51 +0000 - rev 442030
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1499809 - l10n bumper should touch a status file on success. r=nthomas Differential Revision: https://phabricator.services.mozilla.com/D9017
b969cbe46b14814c397199ef84db2ed18d252107: Bug 1492656 - move Telemetry Coverage ping in-tree r=janerik
Robert Helmer <rhelmer@mozilla.com> - Thu, 04 Oct 2018 14:15:11 +0000 - rev 442029
Push 34886 by nbeleuzu@mozilla.com at Fri, 19 Oct 2018 13:09:08 +0000
Bug 1492656 - move Telemetry Coverage ping in-tree r=janerik Differential Revision: https://phabricator.services.mozilla.com/D6359
7d74c59053843bd79ed1456e830a760fdf82656b: Merge mozilla-inbound to mozilla-central. a=merge
Cosmin Sabou <csabou@mozilla.com> - Fri, 19 Oct 2018 07:17:09 +0300 - rev 442028
Push 34885 by csabou@mozilla.com at Fri, 19 Oct 2018 04:17:46 +0000
Merge mozilla-inbound to mozilla-central. a=merge
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip