8f6e40f9a0ad9a477e7f7e0d629ca20fdec91996: Bug 1575823 - Enable support for l10n.getString in tests r=Ola
Belén Albeza <balbeza@mozilla.com> - Fri, 23 Aug 2019 09:53:19 +0000 - rev 489563
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1575823 - Enable support for l10n.getString in tests r=Ola - This creates a mock for fluent-l10n module, so we can use `l10n.getString()` in our code and test for it. - This patch also removes unused files `test/fixtures/l10n.js` and `test/fixtures/PluralForm.js` In order to double check the mock works, these two lines can be added to any test: ``` const { l10n } = require("devtools/client/application/src/modules/l10n"); expect(l10n.getString("foo")).toBe("foo"); ``` Differential Revision: https://phabricator.services.mozilla.com/D43050
ea71d4d41dceec656608e9b03b591d5b41f2ac7b: Bug 1574486 - Updated Password Manager to use PermissionManager principal methods. r=MattN
Paul Zuehlcke <pzuhlcke@mozilla.com> - Thu, 22 Aug 2019 22:19:05 +0000 - rev 489562
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1574486 - Updated Password Manager to use PermissionManager principal methods. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D42829
32344abf0490889b22c5c9a26d30ddf4ff3e0fe3: Bug 1561882 - Make sure to dispatch input and change consistently even if the first causes us to get uninited. r=mconley,Gijs
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Aug 2019 10:14:39 +0000 - rev 489561
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1561882 - Make sure to dispatch input and change consistently even if the first causes us to get uninited. r=mconley,Gijs Differential Revision: https://phabricator.services.mozilla.com/D43061
6174156c2fffb3b9a4a497069951ae42e1cbeb9a: Bug 1574852 - part 16: Move `HTMLEditRules::BustUpInlinesAtRangeEndpoints()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 23 Aug 2019 01:28:26 +0000 - rev 489560
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1574852 - part 16: Move `HTMLEditRules::BustUpInlinesAtRangeEndpoints()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D42787
ca7aac654642ea5b4e58e052680f6c3fd7eef635: Bug 1575606, browser_trackingUI_pbmode_exceptions.js' tests should wait for windows to close, r=johannh
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 23 Aug 2019 06:34:26 +0000 - rev 489559
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1575606, browser_trackingUI_pbmode_exceptions.js' tests should wait for windows to close, r=johannh Differential Revision: https://phabricator.services.mozilla.com/D42917
faf2a38a5c062b9c986e1bad3d422e6db9cf498e: Bug 1568461 - Fix subtest alerting for youtube-playback tests r=rwood,perftest-reviewers
Marian Raiciof <mraiciof@mozilla.com> - Fri, 23 Aug 2019 09:28:04 +0000 - rev 489558
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1568461 - Fix subtest alerting for youtube-playback tests r=rwood,perftest-reviewers The alert_on values from the test INI were not being passed into the test settings json via manifest.py, this patch will fix this. Differential Revision: https://phabricator.services.mozilla.com/D43049
c8fcbaade215ecf3cd353b4196787d8c5826527a: Bug 1575584: prevent reading uninitialized variable in `TextEditor::ComputeValueInternal`. r=masayuki
Mirko Brodesser <mbrodesser@mozilla.com> - Fri, 23 Aug 2019 09:25:00 +0000 - rev 489557
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1575584: prevent reading uninitialized variable in `TextEditor::ComputeValueInternal`. r=masayuki The fix here is to first check `NS_FAILED(rv)`, because if that's the case, `cancel` wasn't necessarily set to a value. As best practice I initialized `cancel` and `handled` with default values. Differential Revision: https://phabricator.services.mozilla.com/D43071
a7b4cf929f403e089a769b88865fd25dc2ec5a9d: Bug 1575806 - Cleanup a bit preference-stylesheet-related code. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Aug 2019 23:15:13 +0000 - rev 489556
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1575806 - Cleanup a bit preference-stylesheet-related code. r=heycam Some of it was dead code, another was inlining a not very useful function (and in one case redundant, since EnsureInitialized() happened right after Refresh()). Differential Revision: https://phabricator.services.mozilla.com/D43042
3a2413d91a19af0be169bfd313243e14c296f806: Bug 1574852 - part 15: Move `HTMLEditUtils::GetHighestInlineParent()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 22 Aug 2019 08:47:50 +0000 - rev 489555
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1574852 - part 15: Move `HTMLEditUtils::GetHighestInlineParent()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D42786
f25f7188eaff13c8431823c3c11865e945beee69: Bug 1566443 - Rename folder aboutdebugging-new to aboutdebugging r=remote-debugging-reviewers,daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 23 Aug 2019 08:52:33 +0000 - rev 489554
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1566443 - Rename folder aboutdebugging-new to aboutdebugging r=remote-debugging-reviewers,daisuke Depends on D43029 Differential Revision: https://phabricator.services.mozilla.com/D43025
9425f7a14e310453770686eab5968d42f0b72593: Backed out changeset cace4ffbecb2 (bug 1576030) requested by glandium
Bogdan Tara <btara@mozilla.com> - Fri, 23 Aug 2019 11:36:03 +0300 - rev 489553
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Backed out changeset cace4ffbecb2 (bug 1576030) requested by glandium
6d946d2a7a313e4ccb8aadb4b1a86e78d1e68301: Bug 1575842 - Do not use |ResetTables| when detecting Safe Browing database corruption in GetLookupCache. r=gcp
dlee <dlee@mozilla.com> - Fri, 23 Aug 2019 08:19:18 +0000 - rev 489552
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1575842 - Do not use |ResetTables| when detecting Safe Browing database corruption in GetLookupCache. r=gcp This patch replaces |ResetTables|(clear table's in-memory and on-disk data) with |DeleteTables|(clear table's on-disk data) in GetLookupCache to avoid infinite loop. We can just delete on-disk data when file corruption is detected in |GetLookupCache| without clearing the cache's internal data and refreshing current active caches because in that scenario, the lookup cache failing to read database has not yet added to the active caches list. Differential Revision: https://phabricator.services.mozilla.com/D43181
d8038c9cac36f9a27412e11d6311c8d89d2b821e: Backed out changeset ab25abaafa1b (bug 1566443) for es lint failure on helper-addons.js CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Fri, 23 Aug 2019 11:06:45 +0300 - rev 489551
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Backed out changeset ab25abaafa1b (bug 1566443) for es lint failure on helper-addons.js CLOSED TREE
ab25abaafa1b58b54a7ecf0c0170f3320a2853d4: Bug 1566443 - Rename folder aboutdebugging-new to aboutdebugging r=remote-debugging-reviewers,daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 23 Aug 2019 06:05:15 +0000 - rev 489550
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1566443 - Rename folder aboutdebugging-new to aboutdebugging r=remote-debugging-reviewers,daisuke Depends on D43029 Differential Revision: https://phabricator.services.mozilla.com/D43025
f41a0d88947089263d3a636ee31d278e6117c5ae: Bug 1574852 - part 14: Move `HTMLEditRules::InsertBRElement()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 22 Aug 2019 08:33:28 +0000 - rev 489549
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1574852 - part 14: Move `HTMLEditRules::InsertBRElement()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D42785
b70ad16ea2aedd286a84fe0935a18176a59c61a3: Bug 1563023 - Part 6: Simplify iterations over all client types; r=asuth
Jan Varga <jan.varga@gmail.com> - Fri, 23 Aug 2019 04:48:36 +0000 - rev 489548
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1563023 - Part 6: Simplify iterations over all client types; r=asuth This patch converts index based client type loops to iterator based client type loops. This way the static cast is avoided and the loops are simpler and more readable. Differential Revision: https://phabricator.services.mozilla.com/D38629
b62dd021e1700bed1e51dfcaa5ecc5dcfe1dc399: Bug 1563023 - Part 5: Rationalize Client::TypeToText and Client::TypeFromText methods; r=asuth
Jan Varga <jan.varga@gmail.com> - Fri, 23 Aug 2019 04:49:14 +0000 - rev 489547
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1563023 - Part 5: Rationalize Client::TypeToText and Client::TypeFromText methods; r=asuth This patch makes it easier to create new Client::TypeTo and Client::TypeFrom variations by creating generic reusable helpers. Differential Revision: https://phabricator.services.mozilla.com/D38628
a82e5f008873bfae613dde49f1ef44a439050c5b: Bug 1573090 - Part 3: Run rustfmt on tools/profiler/rust-helper/. r=gerald
Cameron McCormack <cam@mcc.id.au> - Fri, 23 Aug 2019 05:45:23 +0000 - rev 489546
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1573090 - Part 3: Run rustfmt on tools/profiler/rust-helper/. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D43143
9a33b94c2471e4aea327866d4c5dd2d04e18f938: Bug 1573090 - Part 2: Look up ELF symbol tables directly when pre-symbolicating Gecko profiles on Linux. r=gerald
Cameron McCormack <cam@mcc.id.au> - Fri, 23 Aug 2019 05:45:16 +0000 - rev 489545
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1573090 - Part 2: Look up ELF symbol tables directly when pre-symbolicating Gecko profiles on Linux. r=gerald Whereas previously MozDescribeCodeAddress would have handled demangling, we need to explicitly do that from our new GetFunction method. The string we generate is now more useful for the profiler to merge -- having dropped the address in the previous patch, and the file & line number and library in this patch. While we're at it, try to demangle Rust symbols too. Ideally we'd add Rust symbol handling to DemangleSymbol in StackWalk.cpp, but that lives in mozglue, which currently cannot have any Rust crate dependencies. Differential Revision: https://phabricator.services.mozilla.com/D43142
e76bdefd65400dfbb63813067794ffdd97053ed5: Bug 1573090 - Part 1: Use a CodeAddressService when pre-symbolicating Gecko profiles. r=gerald
Cameron McCormack <cam@mcc.id.au> - Fri, 23 Aug 2019 05:45:14 +0000 - rev 489544
Push 36476 by ncsoregi@mozilla.com at Fri, 23 Aug 2019 15:36:51 +0000
Bug 1573090 - Part 1: Use a CodeAddressService when pre-symbolicating Gecko profiles. r=gerald This speeds up pre-symbolication substantially. We add a new class ProfilerCodeAddressService as the next patch will add some functionality. This also changes the format of the string we generate when symbolicating, by dropping the leading address and space if we do have a string that MozDescribeCodeAddress gave us. (We'll change this format again in the next patch.) Differential Revision: https://phabricator.services.mozilla.com/D43141
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip