8e7bb2f3d4d91f12a16a9eeb9e05a00d59af1475: servo: Merge #15524 - stylo: Drop Servo_RestyleWithAddedDeclaration (from BorisChiou:animation/drop_RestyleWithAddedDeclaration); r=Manishearth
Boris Chiou <boris.chiou@gmail.com> - Sun, 12 Feb 2017 23:17:59 -0800 - rev 343170
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
servo: Merge #15524 - stylo: Drop Servo_RestyleWithAddedDeclaration (from BorisChiou:animation/drop_RestyleWithAddedDeclaration); r=Manishearth This is the servo-side change for [bug 1338087](https://bugzilla.mozilla.org/show_bug.cgi?id=1338087). r=@Manishearth --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] `./mach test-stylo` does not report any errors - [X] These changes fix [bug 1338087](https://bugzilla.mozilla.org/show_bug.cgi?id=1338087). - [X] These changes do not require tests because there are existing tests for this in mozilla-central Source-Repo: https://github.com/servo/servo Source-Revision: 61393b08a9a754b6833fc724bd023ce723eae5aa
4b84a317c7517d5be38bd268076bc32611ca8296: servo: Merge #15510 - Rewrite TextEncoder::Encode to use typed array API. Fixes #15504 (from absoludity:master); r=SimonSapin
Michael Nelson <absoludity@gmail.com> - Sun, 12 Feb 2017 13:13:47 -0800 - rev 343169
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
servo: Merge #15510 - Rewrite TextEncoder::Encode to use typed array API. Fixes #15504 (from absoludity:master); r=SimonSapin <!-- Please describe your changes on the following line: --> Rewrite TextEncoder::Encode to use typed array API. Fixes #15504 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15504 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because the existing tests ensure the behaviour has not changed - `./mach test-wpt tests/wpt/web-platform-tests/encoding` <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: a656782075afb1fbc55e3f0f8bdb5a58010f3af3
d2b73aaa759a7d22aabc6d16fa257a7d1ac9638e: servo: Merge #15515 - Remove rustc-serialize from range (from nox:rustc-serialize); r=jdm
Anthony Ramine <n.oxyde@gmail.com> - Sun, 12 Feb 2017 04:55:40 -0800 - rev 343168
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
servo: Merge #15515 - Remove rustc-serialize from range (from nox:rustc-serialize); r=jdm Source-Repo: https://github.com/servo/servo Source-Revision: 89dcbec0ba95eaabb7bf4e5da62a6e7de89feed2
2b147f3dcae89e547ce05bae480389eed1aa45f6: servo: Merge #15514 - fix #15492 (Negative ShapeRadius values should be invalid) (from alon:master); r=emilio
Alon Levy <alon@pobox.com> - Sun, 12 Feb 2017 03:15:36 -0800 - rev 343167
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
servo: Merge #15514 - fix #15492 (Negative ShapeRadius values should be invalid) (from alon:master); r=emilio <!-- Please describe your changes on the following line: --> Address issue #15492 - Negative value in <shape-radius> should be invalid --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15492 (github issue number if applicable). - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 45db39cc0406a90273a5a74738fe94943a57b142
30cd8908e5ffb8fb980bf1485cef330484c0453c: Bug 1339728 - Part 2. Change return value type of nsSVGFilterInstance::ComputeBounds. r=mstange
cku <cku@mozilla.com> - Tue, 14 Feb 2017 10:32:10 +0800 - rev 343166
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1339728 - Part 2. Change return value type of nsSVGFilterInstance::ComputeBounds. r=mstange MozReview-Commit-ID: 6rvcQGJiaW6
d5360d0cfeca42939288e55d5054e580be60365b: Bug 1339728 - Part 1. Remove nsSVGFilterInstance::mFilterSpaceToUserSpaceScale & mUserSpaceBounds r=mstange
cku <cku@mozilla.com> - Mon, 13 Feb 2017 23:14:54 +0800 - rev 343165
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1339728 - Part 1. Remove nsSVGFilterInstance::mFilterSpaceToUserSpaceScale & mUserSpaceBounds r=mstange 1. mUserSpaceBounds & GetFilterSpaceBounds are not used at all. This patch is simply removing mUserSpaceBounds and codes relative to them. 2. GetFilterSpaceBounds is defined but not used. Remove. MozReview-Commit-ID: 7vJmZP4jC5F
903e5550266b8417cab2cbb956ddb15e338b6190: Merge m-c to autoland, a=merge
Wes Kocher <wkocher@mozilla.com> - Wed, 15 Feb 2017 19:17:26 -0800 - rev 343164
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Merge m-c to autoland, a=merge MozReview-Commit-ID: LcH4J3J7fcL
959ce2584a80b5cb29ab425368e9c91c7f93e501: Bug 1338975 - Don't leak MediaCodec exceptions to CodecProxy. r=jchen
John Lin <jolin@mozilla.com> - Tue, 14 Feb 2017 13:43:35 +0800 - rev 343163
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1338975 - Don't leak MediaCodec exceptions to CodecProxy. r=jchen MozReview-Commit-ID: AaouG5McGNb
9137f214b99408af568316c91305131b7c6d8c0e: Bug 1339924 - Remove unneeded [queue] lambda capture - r=dholbert
Gerald Squelart <gsquelart@mozilla.com> - Thu, 16 Feb 2017 10:17:32 +1100 - rev 343162
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1339924 - Remove unneeded [queue] lambda capture - r=dholbert 'queue' is not used inside that lambda, so we can drop it. Another option would have been to simulate its use through `Unused <<`. But I think that it's a useful test, *not* to capture the queue here, to verify that it is correctly captured in the enclosing MozPromise::Then. MozReview-Commit-ID: LUQGPJzDcTb
569c46670744f5d2c0939e7b5cf79b44cb5f8a89: Bug 1339961 - Check for 'debugger' privilege when accessing HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo(). r=kentuckyfriedtakahe,smaug
karo <kkoorts@mozilla.com> - Fri, 10 Feb 2017 08:54:12 +1300 - rev 343161
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1339961 - Check for 'debugger' privilege when accessing HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo(). r=kentuckyfriedtakahe,smaug MozReview-Commit-ID: 5Rhc0Ukn1W4
0af3de0a7fe96fdc1bfd1e526a8b50cfaf114785: Bug 1321570: Remove duplicate tests, r=kmag
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Tue, 24 Jan 2017 14:54:11 -0500 - rev 343160
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1321570: Remove duplicate tests, r=kmag These tests are essentially the same as the tests of the same name in test_ext_storage.js. These tests could maybe be valuable if they were content script tests instead of background script tests, but they aren't, so let's delete them. MozReview-Commit-ID: I7rIR7ecoEZ
98f9763349183966441f448a83f9684412f4ff30: Bug 1321570 - Rewrite KintoServer in tests, r=kmag
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Wed, 11 Jan 2017 13:35:22 -0500 - rev 343159
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1321570 - Rewrite KintoServer in tests, r=kmag Allow individual records to decide whether or not they want to appear in a certain request, and be more explicit with our handling of time, since the client is already tracking this using etag and providing it to us using _since. This allows us to get rid of hacks like `encryptAndAddRecordOnlyOnce` and `addRecordInPast`. While we're here, change the method signatures for `addRecord` to make them more flexible. Also, make the server agnostic about "collections" and instead focus only on records. Conflicts are still something we have to handle explicitly because in order to trigger conflict behavior in the client, they have to appear between two client requests (i.e. within a sync() call). So we don't show them on GET requests but surface them on POST requests. MozReview-Commit-ID: B7aaMTzu268
28fdc9533636fa0f151a7b99246d6ad17b46dbe0: Bug 1321570 - use dependency injection for fxAccounts, r=kmag
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Tue, 10 Jan 2017 16:44:01 -0500 - rev 343158
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1321570 - use dependency injection for fxAccounts, r=kmag Get rid of the ugly hack where test code monkeypatches a singleton to convince the rest of the ExtensionStorageSync code that a fake user is logged in. Instead, take a handle to the fxAccounts service at construction time. Test code can provide any kind of fxAccounts it wants, including one that has a hard-coded user. This provokes a bunch of changes: - ExtensionStorageSync is now no longer a singleton, but a class. You have to instantiate it in order to do anything with it. A global instance extensionStorageSync is provided for use by Sync code as well as WebExtension code. - CryptoCollection is now also a class, and each ExtensionStorageSync instance has its own CryptoCollection. This dependency should maybe also be injected, but for the time being it doesn't provide us any value to do so. - Converting singletons with asynchronous methods to classes is a pain in the neck. We convert async method foo from `foo: Task.async(....)` to `async foo() { .... }`. While we're here, convert KeyRingEncryptionRemoteTransformer#decode to async/await to eliminate a need for `let self = this`. - Update Sync code and WebExtension code to use extensionStorageSync. - There's a cyclic dependency where CryptoCollection#sync depends on ExtensionStorageSync#_syncCollection which depends on CryptoCollection#getKeyRing. As a short-term hack, we now require an ExtensionStorageSync argument to CryptoCollection#sync. - KeyRingEncryptionRemoteTransformer now takes a handle to fxAccounts on construction time as well. Because this is the only EncryptionRemoteTransformer subclass that accesses fxAccounts, we can get rid of the hack where the tests monkeypatch something in the EncryptionRemoteTransformer prototype. - CollectionKeyEncryptionRemoteTransformer now takes a handle to a CryptoCollection, rather than relying on a global one. - A bunch of methods that previously assumed access to fxAccounts now check if fxAccounts is present (i.e. if we're on Android). Strictly speaking, this isn't required by this change, but it helps make certain kinds of failure a little easier to diagnose. - Update tests, including extracting a domain-specific helper method to hide the use of CollectionKeyEncryptionRemoteTransformer. We now no longer monkeypatch in our mock fxaService, but pass it to the test so that it can do whatever it wants with it. We also provide an ExtensionStorageSync instance for convenience. Access to the global cryptoCollection is now done through an ExtensionStorageSync instance. To summarize, we've gone from a situation where a bunch of singletons had implicit dependencies on other singletons in a shared global namespace, to a situation where dependencies are provided explicitly using method/constructor arguments. This highlights some of the dependencies present: - ExtensionStorageSync depends on CryptoCollection and fxAccounts if it needs to sync - Every collection created via openCollection needs a handle to CryptoCollection so it can correctly create its remote transformers - CryptoCollection needs a handle to fxAccounts so it can create its own remote transformer for its special collection Most of this is only possible, or at least much easier, because we no longer try to juggle Sqlite connections but just keep one around forever. However, please note: - CryptoCollection needs a handle to ExtensionStorageSync to actually perform syncing logic because that's where we foolishly put the logic to make requests - There's still a backing Sqlite store which is shared by everything - There's still a singleton tracking contexts that opened extensions which we manage to try to clean contexts up correctly MozReview-Commit-ID: DGIzyRTdYZ1
ca00e2c5420db40a268fd8ebfa20557ebfd6b74c: Bug 1321570 - Move ExtensionStorageSync crypto out of services/sync, r=kmag
Ethan Glasser-Camp <eglassercamp@mozilla.com> - Mon, 13 Feb 2017 15:06:02 -0500 - rev 343157
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1321570 - Move ExtensionStorageSync crypto out of services/sync, r=kmag Since services/sync doesn't ship on Android, this meant conditionally-defining some variables such as `cryptoCollection` and `CollectionKeyEncryptionRemoteTransformer` depending on whether or not we were on Android. However, none of these definitions really rely on functionality that isn't present on Android (although you can't really use them yet either). Move the dependency together with the dependant code so we can simplify a bit. This lets us remove conditional uses of `cryptoCollection` and `CollectionKeyEncryptionRemoteTransformer`. Because the WebExtensions source directory has more stringent eslint rules, we end up reformatting and commenting a bit in addition to moving. MozReview-Commit-ID: 2ddDeymYFNi
96c6b5a11284d663c1ffb8143e325c637f3b5dc2: Bug 1331322 - Allow tagging of pseudo-implementing native anonymous content with the pseudo type at creation time, and eliminate explicit style contexts in nsIAnonymousContentCreator::ContentInfo. r=bholley
cam@mcc.id.au <cam@mcc.id.au> - Fri, 13 Jan 2017 03:21:11 +0000 - rev 343156
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1331322 - Allow tagging of pseudo-implementing native anonymous content with the pseudo type at creation time, and eliminate explicit style contexts in nsIAnonymousContentCreator::ContentInfo. r=bholley MozReview-Commit-ID: LO0t92orjWZ
15877d32de7d9a42fdbe4fa9dd6983dcbf6a0369: Bug 1331322 - Add a flag to indicate that a node is native anonymous content. r=bholley
Bobby Holley <bobbyholley@gmail.com> - Fri, 20 Jan 2017 18:28:46 -0800 - rev 343155
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1331322 - Add a flag to indicate that a node is native anonymous content. r=bholley
841d608704d72e6a4dfbd3ed9db6df45caa40b2c: Bug 1331322 - Move MAY_HAVE_CLASS to mBoolFlags. r=bholley
Bobby Holley <bobbyholley@gmail.com> - Fri, 20 Jan 2017 18:24:41 -0800 - rev 343154
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1331322 - Move MAY_HAVE_CLASS to mBoolFlags. r=bholley This fits a bit better with the other stuff, and allows us to add our new NAC bit with the other NAC related bits, which also happens to be a field that Servo already has easy access to.
02096c5eb029f38432311bd2175ed357092dfd58: Bug 1331322 - Stop using a node bit for HasExplicitBaseURI. r=bholley
Bobby Holley <bobbyholley@gmail.com> - Fri, 20 Jan 2017 18:17:13 -0800 - rev 343153
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Bug 1331322 - Stop using a node bit for HasExplicitBaseURI. r=bholley This is only called during URI resolution, and the proptable bit should make this relatively fast.
d8e8cc9d9b68f6421c331ed015f65e0d2194fdc0: Merge m-c to autoland, a=merge
Wes Kocher <wkocher@mozilla.com> - Wed, 15 Feb 2017 16:33:46 -0800 - rev 343152
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Merge m-c to autoland, a=merge MozReview-Commit-ID: FqToQ9qk7dg
2670e3095f9446ac8f3eb4fd44fa666b9ac0ce47: Backed out changeset 5cc18343abdd (bug 1339748) for failing test_eme_canvas_blocked.html on Linux x64 asan. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 16 Feb 2017 00:57:07 +0100 - rev 343151
Push 31371 by cbook@mozilla.com at Thu, 16 Feb 2017 12:15:11 +0000
Backed out changeset 5cc18343abdd (bug 1339748) for failing test_eme_canvas_blocked.html on Linux x64 asan. r=backout
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip