8acc12cf30b7c311d22bb60a03cfc3fac94bc8c6: Backed out 1 changeset (bug 1381648) on request from flod for wrong placeholders r=backout
shindli <shindli@mozilla.com> - Fri, 10 Nov 2017 16:07:56 +0200 - rev 391208
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Backed out 1 changeset (bug 1381648) on request from flod for wrong placeholders r=backout Backed out changeset bad9f2a1be21 (bug 1381648)
3e7a6e920c6badbaa1b2e08c748d771583e2a47e: Bug 1404917 - Move image preview tooltip to file name and remove preview icon. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 06 Nov 2017 06:31:40 -0800 - rev 391207
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1404917 - Move image preview tooltip to file name and remove preview icon. r=Honza MozReview-Commit-ID: 86YPdHZhCmo
7dcfe8d12d6f4914d2eba8e5dcaab5660d3c6e61: Bug 1404917 - Fetch response content only on-demand. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 26 Oct 2017 09:03:40 -0700 - rev 391206
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1404917 - Fetch response content only on-demand. r=Honza Response content should only be fetched whenever it is strictly needed as it is the response body. A possibly very large string. So, netmonitor UI should only retrieve it when users select the Response Panel or do any other action that require having access to it (like "Copy response" context menu). MozReview-Commit-ID: CtpJ8PKsCsm
3d8a6d24cec9ae98ce8b5b50218c909243d6804b: Bug 1404917 - Use request.mimeType instead of request.responseContent.content.mimeType. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 05 Oct 2017 17:42:51 +0200 - rev 391205
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1404917 - Use request.mimeType instead of request.responseContent.content.mimeType. r=Honza MozReview-Commit-ID: EIaS1CFKzVn
2a26d588efdcd3704f4e8fc5e4570e029b87d4e5: Bug 1416162 - Fix error code for InvalidElementStateException r=jgraham
Peter Major <majorpetya@gmail.com> - Fri, 10 Nov 2017 09:03:00 +0000 - rev 391204
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1416162 - Fix error code for InvalidElementStateException r=jgraham MozReview-Commit-ID: J5nLBJ27xY0
e8385ed6a8d1cdc388385f6a55f2228dd4d7b6b7: Bug 1390289 - whitelist xpi file r=jmaher
Ionut Goldan <igoldan@mozilla.com> - Mon, 06 Nov 2017 17:10:31 +0200 - rev 391203
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1390289 - whitelist xpi file r=jmaher MozReview-Commit-ID: 6RBqG8Oob1a
2a7cfa885b5728f97509be24261edb037f923ae0: merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 10 Nov 2017 15:30:07 +0200 - rev 391202
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
a552df7ea0fdc22b03150110620b444fd73d09de: merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 10 Nov 2017 13:47:59 +0200 - rev 391201
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
411876ddf28886b67b000d93645ce609c6e02148: Bug 1412608 - Fix comment selection color in markup view. r=jdescottes
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 09 Nov 2017 23:06:37 -0500 - rev 391200
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1412608 - Fix comment selection color in markup view. r=jdescottes MozReview-Commit-ID: 9G5efQSPHCf
c413c58c311dc645e947b38670220e8266cc40af: Bug 1411838 - Part 2: Fix non thread-safe objects in VR; r=kip
Daosheng Mu <daoshengmu@gmail.com> - Thu, 09 Nov 2017 10:54:36 +0800 - rev 391199
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1411838 - Part 2: Fix non thread-safe objects in VR; r=kip MozReview-Commit-ID: EzbNWU17qAP
6dbb8758e13cbd92c2e913c052cbf3e6c7c44540: Bug 1411838 - Part 1: Enable WebVR reftest for Windows debug; r=kip
Daosheng Mu <daoshengmu@gmail.com> - Thu, 09 Nov 2017 10:52:22 +0800 - rev 391198
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1411838 - Part 1: Enable WebVR reftest for Windows debug; r=kip MozReview-Commit-ID: A8drAvmATUZ
c7986c821efe5d4d122784da3547299de5086de7: Bug 1392538 - Remove unused onboarding experiments. r=sebastian
Nevin Chen <cnevinchen@gmail.com> - Wed, 13 Sep 2017 12:02:58 +0800 - rev 391197
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1392538 - Remove unused onboarding experiments. r=sebastian MozReview-Commit-ID: 5Xjpz7l1IxP
b4a5450f62bca390a5fdda70e423f021d2a2eb2d: Bug 1382937 - Rewrite Sync's master password functions to use the `nsILoginManagerCrypto` wrappers. r=MattN
Kit Cambridge <kit@yakshaving.ninja> - Mon, 23 Oct 2017 10:40:56 -0700 - rev 391196
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1382937 - Rewrite Sync's master password functions to use the `nsILoginManagerCrypto` wrappers. r=MattN Using `nsISecretDecoderRing` directly bypasses `nsILoginManagerCrypto.uiBusy` and the observer notifications, so other consumers might not be aware we're already showing the dialog. We also bail early if the UI is busy, to avoid showing multiple dialogs. MozReview-Commit-ID: I7xzUWZkyPH
270709ba8f6796dd655b782a80e6ced6eafc5b78: Bug 1416141 - Remove Telemetry VIDEO_EME_PLAY_SUCCESS. r=kikuo
James Cheng <jacheng@mozilla.com> - Fri, 10 Nov 2017 14:49:37 +0800 - rev 391195
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1416141 - Remove Telemetry VIDEO_EME_PLAY_SUCCESS. r=kikuo MozReview-Commit-ID: BtiD2tUmbE9
4e6d62124ec0c017f219f47a91e5e7bc8320fa98: Bug 1415409 - Make == operator of RangeBoundaryBase compare mRef and mOffset more carefully r=catalinb
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 08 Nov 2017 13:35:00 +0900 - rev 391194
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1415409 - Make == operator of RangeBoundaryBase compare mRef and mOffset more carefully r=catalinb Currently, RangeBoundaryBase can store either only mRef or mOffset. However, == operator of RangeBoudaryBase still compares mRef simply. However, if one has only mRef and the other has only mOffset, it returns false. This patch makes == operator checks if both mOffset have been set. If so, this checks both mOffset.value() and mRef are matched. However, if mRef of only one of them is nullptr, this doesn't make it check mRef because computing mRef needs some cost and initializing mRef from the other fixes the referring child stronger. If the user of the operator sets only mOffset and wait DOM tree changes, computing mRef may break such callers. If one has only mRef and the other has only mOffset, this patch makes it compute mRef. This is not the best behavior, perhaps. However, there is no way to compare these instances. If this becomes a problem, we should make it create temporary instance, but it'll waste runtime cost. So, let's avoid using this approach for now. Finally, making it check both mRef simply. MozReview-Commit-ID: 4nsW5SYDTiZ
ad1fdeb7cbb8c0b53905a1b9428efd6560e9559e: Bug 1416065 - Ensure that override dirty rects are properly removed from frames r=mattwoodrow
Miko Mynttinen <mikokm@gmail.com> - Fri, 10 Nov 2017 01:32:29 +0100 - rev 391193
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1416065 - Ensure that override dirty rects are properly removed from frames r=mattwoodrow MozReview-Commit-ID: 8uLgDFxl5MV
5fd62ef74ab1513563db32f2fbc27ae1c81cc734: Bug 1415231 - Add crash tests for a regression of bug 1406482 which has been fixed by bug 1415509 r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 10 Nov 2017 10:58:33 +0900 - rev 391192
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1415231 - Add crash tests for a regression of bug 1406482 which has been fixed by bug 1415509 r=m_kato This crash test can cause crash before landing the patches for bug 1415509. So, let's take this for regression test. MozReview-Commit-ID: 652wi49e720
4595412072652bfacc390e2df827a849a95ffca9: Bug 1415800 - part 5: Redesign HTMLEditRules::FindNearSelectableNode() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 10 Nov 2017 01:35:10 +0900 - rev 391191
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1415800 - part 5: Redesign HTMLEditRules::FindNearSelectableNode() r=m_kato First, the method name is not correct. It tries to find an editable node near the given DOM point. Therefore, it should be FindNearEditableNode(). Next, the implementation did something odd. E.g., in the first |if| block, when |nearNode| is nullptr, it returns nullptr. However, following |if| block does something only when |nearNode| is nullptr. So, we can get rid of the second |if| block. Then, nobody will change aDirection. So, we can make it not a reference now. Similarly, in |while| block, if |nearNode| becomes nullptr, it returns error. However, following block checks if |nearNode| is NOT nullptr. So, we can get rid of this |if| statement and outdent its block. Additionally, |curNode| isn't necessary. It only increments the refcount redundantly. So, we can get rid of it. Finally, FindNearEditableNode() can return found node directly instead of error code because error code doesn't make sense. Not found an editable node is not illegal. And also it can take EditorRawDOMPoint instead of a set of container, child and offset of the child in the container. MozReview-Commit-ID: CTI581PhJMd
682cda40a8594f96303a56295f739dec96cc04ea: Bug 1415800 - part 4: Redesign HTMLEditor::GetNextHTMLNode() same as similar to EditorBase::GetNext*() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 10 Nov 2017 00:12:22 +0900 - rev 391190
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1415800 - part 4: Redesign HTMLEditor::GetNextHTMLNode() same as similar to EditorBase::GetNext*() r=m_kato HTMLEditor::GetNextHTMLNode() should be redesigned as HTMLEditor::GetNextEditableHTMLNode(nsINode&), HTMLEditor::GetNextEditableHTMLNodeInBlock(nsINode&), HTMLEditor::GetNextEditableHTMLNode(const EditorRawDOMPoint&) and HTMLEditor::GetNextEditableHTMLNodeInBlock(const EditorRawDOMPoint&). Same as GetPreviousEditableHTMLNode*(), we don't need the methods to find non-editable nodes too. MozReview-Commit-ID: JjZauCMblp4
ed0dad4054fa2facb0ee0a5259e4c76dd22fc689: Bug 1415800 - part 3: Redesign HTMLEditor::GetPriorHTMLNode() as similar to EditorBase::GetPrevious*() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Nov 2017 23:31:59 +0900 - rev 391189
Push 32866 by ryanvm@gmail.com at Fri, 10 Nov 2017 21:06:07 +0000
Bug 1415800 - part 3: Redesign HTMLEditor::GetPriorHTMLNode() as similar to EditorBase::GetPrevious*() r=m_kato HTMLEditor::GetPriorHTMLNode() methods are similar to EditorBase::GetPriorNode() which was redesigned with the previous patch. So, it should be redesigned as HTMLEditor::GetPreviousEditableHTMLNode(nsINode&), HTMLEditor::GetPreviousEditableHTMLNode(const EditorRawDOMPoint&), HTMLEditor::GetPreviousEditableHTMLNodeInBlock(nsINode&) and HTMLEditor::GetPreviousEditableHTMLNodeInBlock(const EditorRawDOMPoint&). Note that HTMLEditor::GetPriorHTMLNode() are always return editable node. So, we don't need to create non-editable node methods for them. Although, I don't like the word "HTMLNode" because this can return SVG element or something too. The additional feature of those methods is just checking given node is in active editing host. So, they are for HTML editor, but not returning only HTML nodes. However, I have no better idea with shorter name. MozReview-Commit-ID: 3J4IaBOFjzj
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip