888ca78cd6ec646830527888a11bbeb793feb5f3: servo: Merge #18602 - style: Make sure to not run any style invalidation in an unstyled children only traversal (from emilio:invalidation-unstyled-only); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 21:16:43 -0500 - rev 382562
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
servo: Merge #18602 - style: Make sure to not run any style invalidation in an unstyled children only traversal (from emilio:invalidation-unstyled-only); r=bholley Bug: 1402472 Reviewed-by: bholley MozReview-Commit-ID: IFPA7LJpvsZ Source-Repo: https://github.com/servo/servo Source-Revision: 5a6b90b14ff709eab41493a05c8235c522d35250
7f9883dd37feac26fb95b629ad1010107f04603c: Bug 1400936: Crashtests. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:12:33 +0200 - rev 382561
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1400936: Crashtests. r=bholley MozReview-Commit-ID: 6Q07StWSog Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
dba974e6b1b4ecf1d0ee788e0279fd2b9f410b75: Bug 1400936: Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:05:47 +0200 - rev 382560
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1400936: Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r=bholley This is the actual fix, and makes sure that the state is consistent even if we notify of state changes on a parent during unbind. We potentially do a bit more work than needed given we set the document as the root in that case instead of the parent which could potentially be the root itself, but that's not a huge deal I think, given these cases are rare. If this happens to be a perf problem, we may want to just drop the root during UnbindFromTree if aNullParent == true and the root is a descendant of `this`. MozReview-Commit-ID: A9d2igM0hMr Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
9ef85da5aea4dfa3a22436fe4386a7bd25183cbe: Bug 1400936: Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:59 +0200 - rev 382559
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1400936: Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r=bholley This is the reason similar assertion failures can't be reproduced with elements and stuff like fieldset and form validity changes. nsBindingManager::ContentRemoved calls SetXBLInsertionParent, which clears all the Servo data from the subtree eagerly, which is a waste when the actual binding parent is the same (null). MozReview-Commit-ID: A5wLKfD4OTL Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
6a25312a3cb123e4697a47336211d5275275d9b7: Bug 1400936: Remove dumb null check. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:30 +0200 - rev 382558
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1400936: Remove dumb null check. r=bholley MozReview-Commit-ID: CLs2UcA8DF9 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
08e7d627c2017392af5ba26086e682a61cbc88dd: Bug 1401706: Crashtest. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 04:10:22 +0200 - rev 382557
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1401706: Crashtest. r=me MozReview-Commit-ID: Jf0n4f4kMhl
c7f9baa225ff2850aba5275306654c1d7ff6109d: Bug 1401706: Remove redundant UpdateValueDisplay call. r=Ehsan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 14:48:02 +0200 - rev 382556
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1401706: Remove redundant UpdateValueDisplay call. r=Ehsan This was just moved from the old code, but we always call that function in CreateAnonymousContent, so no need to. MozReview-Commit-ID: 1zqmQM2KdpW Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
d327d1b7324df429cf5c54e0a519ecb7a9b6bee6: Bug 1401706: Remove redundant boolean members from nsTextControlFrame. r=Ehsan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:41 +0200 - rev 382555
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1401706: Remove redundant boolean members from nsTextControlFrame. r=Ehsan MozReview-Commit-ID: Ka81vlPMa88 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2ccf0d54c0f95d017e369828fdb902d2cbcf4aef: Bug 1401706: Remove unused macro. r=Ehsan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:30 +0200 - rev 382554
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1401706: Remove unused macro. r=Ehsan MozReview-Commit-ID: EsvdnJkapgP Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
89e5fc708a1d08d97efe187064d8d2f213ac8425: Bug 1401706: Move ownership of editor anon content to nsTextControlFrame. r=Ehsan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 02:18:30 +0200 - rev 382553
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1401706: Move ownership of editor anon content to nsTextControlFrame. r=Ehsan MozReview-Commit-ID: 4QpbarX5dvf Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
d6a4660a684ee56c01f2ba7e91783d9a56f032aa: Bug 1401179 - Add snackbar for bookmark add/remove actions on newtab. r=mcomella
Chenxia Liu <liuche@mozilla.com> - Fri, 22 Sep 2017 18:08:07 -0700 - rev 382552
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1401179 - Add snackbar for bookmark add/remove actions on newtab. r=mcomella MozReview-Commit-ID: 7DzoyDSWmVq
20527b1071a3acec8e035b9722d5a196aad17964: Bug 1402005: Add telemetry for Learn More clicks. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Fri, 22 Sep 2017 17:32:03 -0700 - rev 382551
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1402005: Add telemetry for Learn More clicks. r=liuche MozReview-Commit-ID: GA4UBZ4fpK6
a3fa131f4e0f9dbe1887e0e89e0ec4567f96e527: Bug 1402005: Add a learn more link to Top Sites. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Fri, 22 Sep 2017 17:04:53 -0700 - rev 382550
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1402005: Add a learn more link to Top Sites. r=liuche Explanation of our motivations are added in code comments. In testing locally, the link I was sent to was: - https://support.mozilla.org/1/mobile/58.0a1/Android/en-US/activity-stream Existing code does not use a referrer so I didn't add one: http://searchfox.org/mozilla-central/rev/56ad02e34d0d36ca4d5ccaa885d26aff270b8ff7/mobile/android/base/java/org/mozilla/gecko/preferences/LinkPreference.java#44 MozReview-Commit-ID: GTY1ku07uWy
6cb6f41aea0965c254a2ddf6489e9b32e54d5a61: Bug 1402285 - Don't try to cache pseudo styles with an unstyled originating element. r=emilio
Bobby Holley <bobbyholley@gmail.com> - Fri, 22 Sep 2017 16:09:18 -0700 - rev 382549
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1402285 - Don't try to cache pseudo styles with an unstyled originating element. r=emilio MozReview-Commit-ID: C4JNZFtYHBH
4c191b4e631f2f6f672598d70359438d18d05884: Bug 1401992 - Mark some tests as passing on android. r=me
Bobby Holley <bobbyholley@gmail.com> - Fri, 22 Sep 2017 17:20:31 -0700 - rev 382548
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1401992 - Mark some tests as passing on android. r=me MozReview-Commit-ID: HJuIX5VXBm5
d05d93a25235ef79fd99165aae66be720eb89703: Bug 1402102 - Remove nsIDOMHTMLObjectElement; r=bz
Kyle Machulis <kyle@nonpolynomial.com> - Fri, 22 Sep 2017 17:05:12 -0700 - rev 382547
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1402102 - Remove nsIDOMHTMLObjectElement; r=bz Removes the nsIDOMHTMLObjectElement XPCOM interface, replacing it with HTMLObjectElement and FromContent conversion usage. MozReview-Commit-ID: dmsjSO97uh
fdf60b8a81c511548eb603817089a23ccd494d27: Bug 1401992 - Make the reftest less flakey. r=me
Bobby Holley <bobbyholley@gmail.com> - Fri, 22 Sep 2017 17:06:00 -0700 - rev 382546
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1401992 - Make the reftest less flakey. r=me We don't need the video controls to be painted. MozReview-Commit-ID: AXsM8Q1vJm4
7f3101566d6fc77216dd8e01e962b48fedaa18e8: Bug 1402529 - Fix broken story dismissing, unintended telemetry and bug fixes to Activity Stream. r=dmose
Ed Lee <edilee@mozilla.com> - Fri, 22 Sep 2017 16:13:36 -0700 - rev 382545
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1402529 - Fix broken story dismissing, unintended telemetry and bug fixes to Activity Stream. r=dmose MozReview-Commit-ID: F0mYjCJcg0u
fd4b9c72b832951abf946c050d4760c8d0b4944c: Bug 1402210 - Add payment UI documentation and do minor code cleanup. r=marcosc
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 21 Sep 2017 21:35:24 -0700 - rev 382544
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1402210 - Add payment UI documentation and do minor code cleanup. r=marcosc MozReview-Commit-ID: Cpn5mKcEZGo
5870f25b4a832dccf8277548eaa83c8d80edc4a6: Bug 1401718: adapt to xcode's new non-ascii license error r=gps
Philip Jenvey <pjenvey@underboss.org> - Fri, 22 Sep 2017 14:58:28 -0700 - rev 382543
Push 32561 by archaeopteryx@coole-files.de at Sat, 23 Sep 2017 09:36:26 +0000
Bug 1401718: adapt to xcode's new non-ascii license error r=gps avoid unicode conversion (since unicode_literals is in use) MozReview-Commit-ID: AfgzAWsjRp
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip