8740667be31ef2258b4910d7df2cbba28776472a: Bug 1633797 - Make callers of `EditorBase::DeleteSelectionWithTransaction()` stop calling it if selection is collapsed but the caller tries to delete non-collapsed range r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 07 May 2020 01:23:21 +0000 - rev 528538
Push 37389 by dluca@mozilla.com at Thu, 07 May 2020 08:52:31 +0000
Bug 1633797 - Make callers of `EditorBase::DeleteSelectionWithTransaction()` stop calling it if selection is collapsed but the caller tries to delete non-collapsed range r=m_kato Our editor's deletion code removes nodes step-by-step. Therefore, even when somebodies call `DeleteSelectionWithTransaction()` for removing non-collapsed ranges, they may have already removed all contents in the range. In such case, all callers shouldn't call `DeleteSelectionWithTransaction()`. This makes `test_bug1425997.html` allow to run nexted `execCommand`. It'll be disabled even in the release channel, but we should keep testing it for detecting bug of edge cases (like this bug). Note that all crashtests which test nested `execCommand` calls run with allowing it with the pref for same reason. Differential Revision: https://phabricator.services.mozilla.com/D73402
ceee88ee8a92abe0a39d068299ba0d7a3a1be087: Bug 1633904 - add tag 'mediacontrol' for related test configs. r=bryce
alwu <alwu@mozilla.com> - Wed, 06 May 2020 21:16:38 +0000 - rev 528537
Push 37389 by dluca@mozilla.com at Thu, 07 May 2020 08:52:31 +0000
Bug 1633904 - add tag 'mediacontrol' for related test configs. r=bryce This patch will do : - add tag `mediacontrol` in media control related `ini` files. The advantage of doing so : - to run all tests in one simple command, `$./mach mochitest --tag mediacontrol` Differential Revision: https://phabricator.services.mozilla.com/D72959
98040184b6c03a9c0ebebda7ec5c6c6dd1903800: Bug 1625696 - Update winchecksec and build/use it natively for Linux. r=dmajor
Mike Hommey <mh+mozilla@glandium.org> - Thu, 07 May 2020 00:34:36 +0000 - rev 528536
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1625696 - Update winchecksec and build/use it natively for Linux. r=dmajor Now that upstream winchecksec builds and works natively on Linux, use that. That should solve the random crashes under Wine. If random crashes still happen, it will be easier to debug anyways. We bump to the last version that doesn't use vcpkg because vcpkg makes things more difficult. Differential Revision: https://phabricator.services.mozilla.com/D73405
b251328e237f57bb2cfe21d167cefa22704bc3b6: Bug 1635664 - Don't capture the output from sdkmanager in ensure_android_packages. r=rstewart
Mike Hommey <mh+mozilla@glandium.org> - Thu, 07 May 2020 00:08:16 +0000 - rev 528535
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1635664 - Don't capture the output from sdkmanager in ensure_android_packages. r=rstewart We always print the output when there is no error. In case of error, we stick the output in the thrown exception, but nothing actually prints that out. It's simpler to just let the subprocess print its own output instead of capturing it, so that important error messages are not hidden in the case of failure. Differential Revision: https://phabricator.services.mozilla.com/D74004
6da1d9c3a9c2822cf85de9c559d58cce81a167ef: Backed out changeset 0c1494c8c04a (bug 1629575) by alaskanemily's request
Bogdan Tara <btara@mozilla.com> - Thu, 07 May 2020 03:07:20 +0300 - rev 528534
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Backed out changeset 0c1494c8c04a (bug 1629575) by alaskanemily's request
a9823bc9e6f8124061da5c2c990859e53026a320: Merge mozilla-central to autoland.
Cosmin Sabou <csabou@mozilla.com> - Thu, 07 May 2020 02:33:29 +0300 - rev 528533
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Merge mozilla-central to autoland.
0c1494c8c04a3fd2f0a275c7b770f8b2dbee9f47: Bug 1629575 - Fix incorrect grid template size in the line name map r=mats
Emily McDonough <emcdonough@mozilla.com> - Wed, 06 May 2020 22:20:09 +0000 - rev 528532
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1629575 - Fix incorrect grid template size in the line name map r=mats This only occurred when a grid with a repeat with multiple values was used. Differential Revision: https://phabricator.services.mozilla.com/D71242
924f613d68ab1f0e11956d76524b54cdda45a2fe: Bug 1630038 - remove HPKP entirely r=kjacobs,bbeurdouche
Dana Keeler <dkeeler@mozilla.com> - Wed, 06 May 2020 22:57:50 +0000 - rev 528531
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1630038 - remove HPKP entirely r=kjacobs,bbeurdouche This removes processing of HTTP Public Key Pinning headers, remotely modifying pinning information, and using cached pinning information, all of which was already disabled in bug 1412438. Static pins that ship with the browser are still enforced. Differential Revision: https://phabricator.services.mozilla.com/D73352
f4e543221ab15694444722072859dd38f257aa30: Bug 1635803 - Make sure <cstdlib> is included before mozalloc.h, to work around bug 1635968. r=gerald
Markus Stange <mstange@themasta.com> - Wed, 06 May 2020 22:57:05 +0000 - rev 528530
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1635803 - Make sure <cstdlib> is included before mozalloc.h, to work around bug 1635968. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D74154
4d6584d65e8ac934bdb31e8afadf10549a8040fa: Backed out changeset 6e34a3e2c5c5 (bug 1625249) for browser_test_hittest_svg_over_iframe.js failures CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Thu, 07 May 2020 01:59:26 +0300 - rev 528529
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Backed out changeset 6e34a3e2c5c5 (bug 1625249) for browser_test_hittest_svg_over_iframe.js failures CLOSED TREE
b8156e1ef0c5b72a88ed32176cc2e8028c72b660: Bug 1635338 - profiler_is_locked_on_current_thread() now also checks for the buffer lock - r=gregtatum,canaltinova
Gerald Squelart <gsquelart@mozilla.com> - Wed, 06 May 2020 12:45:40 +0000 - rev 528528
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1635338 - profiler_is_locked_on_current_thread() now also checks for the buffer lock - r=gregtatum,canaltinova profiler_is_locked_on_current_thread() is used to help users avoid calling `profiler_...` functions when the profiler may already have a lock in place, which would prevent a 2nd recursive lock (resulting in a crash or a never-ending wait). So we must return `true` for any of: - The main profiler mutex, used by most functions, and/or - The buffer mutex, used directly in some functions without locking the main mutex, e.g., marker-related functions. Differential Revision: https://phabricator.services.mozilla.com/D73789
3b31d60ad78fa4f0c481e8d65443b3b9c3f05671: Bug 1635338 - ProfileChunkedBuffer::IsThreadSafeAndLockedOnCurrentThread - r=gregtatum,canaltinova
Gerald Squelart <gsquelart@mozilla.com> - Wed, 06 May 2020 12:44:44 +0000 - rev 528527
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1635338 - ProfileChunkedBuffer::IsThreadSafeAndLockedOnCurrentThread - r=gregtatum,canaltinova Expose `ProfileChunkedBuffer`'s mutex (if present), so that potential callers can avoid recursive calls that would lock or crash. Differential Revision: https://phabricator.services.mozilla.com/D73788
903b6c75896bdd88e2ec382beac307f52edb095c: Bug 1635338 - baseprofiler::profiler_is_locked_on_current_thread - r=gregtatum,canaltinova
Gerald Squelart <gsquelart@mozilla.com> - Wed, 06 May 2020 12:44:22 +0000 - rev 528526
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1635338 - baseprofiler::profiler_is_locked_on_current_thread - r=gregtatum,canaltinova Mimic Gecko Profiler's `profiler_is_locked_on_current_thread()` in Base Profiler. Differential Revision: https://phabricator.services.mozilla.com/D73787
93c3511b9b23b794402eb74a7125c7e480bc94a2: Bug 1635338 - BaseProfilerMutex::IsLockedOnCurrentThread - r=gregtatum,canaltinova
Gerald Squelart <gsquelart@mozilla.com> - Wed, 06 May 2020 12:42:37 +0000 - rev 528525
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1635338 - BaseProfilerMutex::IsLockedOnCurrentThread - r=gregtatum,canaltinova Make `BaseProfilerMutex::mOwningThreadId` non-optional, and use it in `IsLockedOnCurrentThread()`, which is similar to the one in Gecko Profiler. Add related `BaseProfilerMaybeMutex::IsActivatedAndLockedOnCurrentThread()`. Differential Revision: https://phabricator.services.mozilla.com/D73786
302c30b598b0ed12b212c19f86256723dd362835: Bug 1633628 - Vender: Don't use ClearView if we previously used dual source blending on Intel gen6. r=jrmuizel
Jeff Gilbert <jgilbert@mozilla.com> - Wed, 06 May 2020 22:04:28 +0000 - rev 528524
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1633628 - Vender: Don't use ClearView if we previously used dual source blending on Intel gen6. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D74137
6e2d679c71681402c99bc6263e003d56aed9313c: Bug 1635941 - Drop debug printf. r=boris
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 06 May 2020 21:21:46 +0000 - rev 528523
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1635941 - Drop debug printf. r=boris Differential Revision: https://phabricator.services.mozilla.com/D74141
431fb8a2c110a3866dacd3279cb704d2007be402: Bug 1631123 - Correct SourceExtent diagram r=tcampbell DONTBUILD
Matthew Gaudet <mgaudet@mozilla.com> - Tue, 05 May 2020 21:11:47 +0000 - rev 528522
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1631123 - Correct SourceExtent diagram r=tcampbell DONTBUILD These updated diagrams were verified using the patch below, which prints sources and relevant offsets inside of fullyInitFromStencil. ``` diff --git a/js/src/vm/JSScript.cpp b/js/src/vm/JSScript.cpp --- a/js/src/vm/JSScript.cpp +++ b/js/src/vm/JSScript.cpp @@ -4326,6 +4326,37 @@ bool JSScript::fullyInitFromStencil(JSCo script->assertValidJumpTargets(); #endif + if (compilationInfo.sourceObject->source()->hasSourceText()) { + // Get the substring out of the source + auto str = compilationInfo.sourceObject->source()->substring( + cx, script->extent_.toStringStart, script->extent_.toStringEnd); + + uint32_t sourceStartOffset = + script->extent_.sourceStart - script->extent_.toStringStart; + uint32_t sourceEndOffset = + script->extent_.sourceEnd - script->extent_.toStringStart; + fprintf(stderr, "sourceStart: %ud, sourceEnd: %ud\n", sourceStartOffset, + sourceEndOffset); + { + JS::AutoCheckCannotGC nogc(cx); + js::Fprinter out(stderr); + JSString::dumpChars(str->latin1Chars(nogc), str->length(), out); + out.printf("\n "); // the ' ' is for the opening quote, to make sure the + // computed carats align. + } + + for (uint32_t i = 0; i < str->length() + 2; i++) { + if (i == sourceStartOffset) { + fprintf(stderr, "^"); + } else if (i == sourceEndOffset) { + fprintf(stderr, "$"); + } else { + fprintf(stderr, "."); + } + } + fprintf(stderr, "\n"); + } + if (coverage::IsLCovEnabled()) { if (!coverage::InitScriptCoverage(cx, script)) { return false; ``` Depends on D73928 Differential Revision: https://phabricator.services.mozilla.com/D73929
5e62e5abf6166e59bf9a9a33ed13c549fa5ad0e0: Bug 1628761 - Document expectation for lineno and column of SourceExtent r=tcampbell DONTBUILD
Matthew Gaudet <mgaudet@mozilla.com> - Tue, 05 May 2020 21:10:09 +0000 - rev 528521
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1628761 - Document expectation for lineno and column of SourceExtent r=tcampbell DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D73928
e3bc9f1bde6e18ff859e34b80397e33d6c23dd8f: Bug 1632794 - Bare bones about:processes;r=fluent-reviewers,florian,Pike
David Teller <dteller@mozilla.com> - Wed, 06 May 2020 20:11:55 +0000 - rev 528520
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1632794 - Bare bones about:processes;r=fluent-reviewers,florian,Pike This is a very first iteration of about:processes, so that people who actually need the tool can start using it immediately and provide feedback. Differential Revision: https://phabricator.services.mozilla.com/D72617
7c7b3e6357ec3fe4881a13879e2654f632521a7f: Bug 1632794 - Expose full remoteType through ChromeUtils.requestProcInfo;
David Teller <dteller@mozilla.com> - Wed, 06 May 2020 20:11:55 +0000 - rev 528519
Push 37388 by csabou@mozilla.com at Thu, 07 May 2020 04:06:39 +0000
Bug 1632794 - Expose full remoteType through ChromeUtils.requestProcInfo; The current `type` field doesn't expose all information such as the origin. Let's fix this. Differential Revision: https://phabricator.services.mozilla.com/D72616
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip