873b1116d7750d14455709cce4e6c024e105000e: Bug 1620297 - Make the range background size fixed. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 07 Mar 2020 09:57:42 +0000 - rev 517440
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1620297 - Make the range background size fixed. r=mstange Otherwise the rendering of stuff like: <input type=range style="height: 300px"> Makes no sense. So this is closer to other widgets, and also happens to fix the only test which is a real regression from non-native widget :) Depends on D65673 Differential Revision: https://phabricator.services.mozilla.com/D65674
77b8ab8bef35f5d7942c7386495547ee74b497fb: Bug 1620297 - Add support for vertical range inputs. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 07 Mar 2020 09:58:30 +0000 - rev 517439
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1620297 - Add support for vertical range inputs. r=mstange This _almost_ fixes layout/reftests/forms/input/range/auto-size.html. It still fails because of the variable-width track size :/ Differential Revision: https://phabricator.services.mozilla.com/D65673
06602be6d7b323aa09a144c9b33f2803b3ef1b45: Bug 1620479 - Annotate reftests with native theme enabled. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 07 Mar 2020 10:07:59 +0000 - rev 517438
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1620479 - Annotate reftests with native theme enabled. r=mstange Most of them are straight-forward. Some fuzziness due to Skia around rounded corners still. Some tests that already fail in other widgets as expected. This is enough to green up reftests (but not WPT, yet) on Android, both with and without WR enabled. Nothing too concerning, all-in-all. Differential Revision: https://phabricator.services.mozilla.com/D65667
296cb55bfa55d21f23b07808eb2e1eea91d19a7d: Bug 1620476 - Fix a test that makes assumptions about the padding of a textarea. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 06 Mar 2020 21:41:58 +0000 - rev 517437
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1620476 - Fix a test that makes assumptions about the padding of a textarea. r=mstange The test is duplicated in two places, so four files to change. The padding in the non-native theme is just big enough so that the textarea overlaps the float. In other themes the textarea overflows, but not enough to hit the float. Differential Revision: https://phabricator.services.mozilla.com/D65663
901e8667e88faccb7cb228da84c59a695fe7f0df: Bug 1619008: Switch emitCallSiteObject() to use the ObjLiteral writer. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Sat, 07 Mar 2020 09:10:14 +0000 - rev 517436
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619008: Switch emitCallSiteObject() to use the ObjLiteral writer. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D65806
df129d747ed533dc9972a5ba9876211ccd70f38b: Bug 1619010: Switch iteratorResultShape() to use the ObjLiteral writer. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Sat, 07 Mar 2020 09:06:57 +0000 - rev 517435
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619010: Switch iteratorResultShape() to use the ObjLiteral writer. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D65789
9e1b60eda95fd18dbae6908070ca7c11f21a55eb: Bug 1619007 - Part 13: Add missing BigInt property key handling. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 21:40:09 +0000 - rev 517434
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 13: Add missing BigInt property key handling. r=mgaudet This case was missed in bug 1605835. Depends on D65787 Differential Revision: https://phabricator.services.mozilla.com/D65788
5e52daafbbed8468b4ccbd7559196aa379b65c8d: Bug 1619007 - Part 12: Remove unused class-body support from isPropertyListObjLiteralCompatible. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 21:27:52 +0000 - rev 517433
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 12: Remove unused class-body support from isPropertyListObjLiteralCompatible. r=mgaudet Depends on D65786 Differential Revision: https://phabricator.services.mozilla.com/D65787
6c8fa3e00997cc77f60fc5bb6068c50f32e1bcad: Bug 1619007 - Part 11: Remove unused uint32_t operand space from JSOp::NewInit. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 21:20:46 +0000 - rev 517432
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 11: Remove unused uint32_t operand space from JSOp::NewInit. r=mgaudet After part 10 we no longer perform an in-place update from `JSOp::NewInit` to `JSOp::NewObject`, so the extra operand space for `JSOp::NewInit` isn't needed anymore. Depends on D65781 Differential Revision: https://phabricator.services.mozilla.com/D65786
44fe840e94ff9c4c4aee67b148ed5ddecb47b83e: Bug 1619007 - Part 10: Remove no longer used replaceNewInitWithNewObject method. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 21:11:59 +0000 - rev 517431
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 10: Remove no longer used replaceNewInitWithNewObject method. r=mgaudet Depends on D65777 Differential Revision: https://phabricator.services.mozilla.com/D65781
8b170b754a5bb744debc0beebe1fb0fda3c8b07c: Bug 1619007 - Part 9: Don't manually inline emitAtomOp with an atom index. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 21:11:36 +0000 - rev 517430
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 9: Don't manually inline emitAtomOp with an atom index. r=mgaudet Depends on D65776 Differential Revision: https://phabricator.services.mozilla.com/D65777
e8579166fcbf00a406e9a5cba520281c2738806f: Bug 1619007 - Part 8: Use ObjLiteral to create the destructuring rest exclusion set. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 21:09:50 +0000 - rev 517429
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 8: Use ObjLiteral to create the destructuring rest exclusion set. r=mgaudet Use the ObjLiteral writer for the destructuring rest exclusion set when all property keys are simple atoms, i.e. `ObjectPropertyName` or `StringExpr`. Also supports `MutateProto` aka "__proto__", because "__proto__" doesn't have any special meaning in object destructuring patterns. Number and BigInt property keys stay unsupported for the fast-path and computed property names also need to take the slow path, because their value isn't known at parse time. Depends on D65775 Differential Revision: https://phabricator.services.mozilla.com/D65776
201ec4cf9a1e88380865fdea4d476b44e5419cf9: Bug 1619007 - Part 7: Remove unused `type` parameter from emitPropertyListObjLiteral. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 20:29:37 +0000 - rev 517428
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 7: Remove unused `type` parameter from emitPropertyListObjLiteral. r=mgaudet Depends on D65774 Differential Revision: https://phabricator.services.mozilla.com/D65775
2b7d03a2ea2cb381de8c98ec900d1f166c3ea450: Bug 1619007 - Part 6: Prefer emplaceBack instead of append when adding elements to IdValueVector. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 20:28:02 +0000 - rev 517427
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 6: Prefer emplaceBack instead of append when adding elements to IdValueVector. r=mgaudet Depends on D65773 Differential Revision: https://phabricator.services.mozilla.com/D65774
b906552a9959a48f163246910ab379d9c7615ed3: Bug 1619007 - Part 5: Simplify while loop exit condition. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 20:27:31 +0000 - rev 517426
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 5: Simplify while loop exit condition. r=mgaudet Depends on D65772 Differential Revision: https://phabricator.services.mozilla.com/D65773
bbccf2268360b8c9cb84730516441e5b4da8f76e: Bug 1619007 - Part 4: Return plain Value from InterpretObjLiteralValue. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 20:26:08 +0000 - rev 517425
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 4: Return plain Value from InterpretObjLiteralValue. r=mgaudet We can directly return `JS::Value` from InterpretObjLiteralValue instead of passing it indirectly through a `MutableHandleValue`. Depends on D65771 Differential Revision: https://phabricator.services.mozilla.com/D65772
c5b5f5a316f2eab8bfd7b34b6a7007e22a485dda: Bug 1619007 - Part 3: Call NewPlainObjectWithProperties instead of reimplementing it. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 20:24:40 +0000 - rev 517424
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 3: Call NewPlainObjectWithProperties instead of reimplementing it. r=mgaudet Depends on D65769 Differential Revision: https://phabricator.services.mozilla.com/D65771
de425cf4b2ac5db2b3d58f29624025b278c9318d: Bug 1619007 - Part 2: Remove unnecessary is<T> tests when directly followed by as<T>. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 20:21:35 +0000 - rev 517423
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 2: Remove unnecessary is<T> tests when directly followed by as<T>. r=mgaudet The standard convention is to omit a `is<T>` test when it is directly followed by `as<T>`, because `as<T>` is also testing for `is<T>`. Depends on D65768 Differential Revision: https://phabricator.services.mozilla.com/D65769
7fb3fd9172c5339ccde9d26483d021c02b68e08c: Bug 1619007 - Part 1: Remove unnecessary manual stack depth adjustment. r=cfallin
André Bargull <andre.bargull@gmail.com> - Fri, 06 Mar 2020 20:31:00 +0000 - rev 517422
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1619007 - Part 1: Remove unnecessary manual stack depth adjustment. r=cfallin The preceding `JSOp::{Object,NewObject,NewObjectWithGroup,NewArrayCopyOnWrite}` opcode already performs the correct stack depth adjustment. Differential Revision: https://phabricator.services.mozilla.com/D65768
5a2f9aebd4f021acd2e1a211088ca2a42e8fcfab: Bug 1602323. Mark a few reftests as passing with fission now.
Timothy Nikkel <tnikkel@gmail.com> - Sat, 07 Mar 2020 07:13:05 +0000 - rev 517421
Push 37190 by aciure@mozilla.com at Sat, 07 Mar 2020 21:33:39 +0000
Bug 1602323. Mark a few reftests as passing with fission now. I forgot to mark them passing when I landed the patches that fixed them. Differential Revision: https://phabricator.services.mozilla.com/D65860
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip