84bac01f3a351b774a556dbc47c3305a62e54153: Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 16:42:57 +0100 - rev 431924
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r=Grisha As a final step, these can be merged as well. The same reasoning as in the previous patch applies with regards to additional functionality that isn't (yet) used by webextensions. MozReview-Commit-ID: Ezx2mQY0s85
98ed7d6f8a7ab6b35f7ee73e6f0f7db4393ecf2f: Bug 1414084 - Part 7 - Use one set of functions for managing MenuItems in the UI. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 14:17:03 +0100 - rev 431923
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 7 - Use one set of functions for managing MenuItems in the UI. r=Grisha The original add-on functions have some additional capabilities regarding e.g. checkboxes, disabling the menu, etc. that right now aren't required for Webextensions (yet?), but in that case they will simply not be used - in any case BrowserActions.jsm controls what functionality is actually exposed to add-ons. MozReview-Commit-ID: DPT8gV2gb6q
261e4bb6efd87af390d0575f2623e379f979341b: Bug 1414084 - Part 6 - Use only one list to store menu items added from Gecko. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 23 Mar 2018 19:58:18 +0100 - rev 431922
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 6 - Use only one list to store menu items added from Gecko. r=Grisha Now that the UI code for handling both the old NativeWindow API and Web- extensions is more or less the same and both are using the same MenuItemInfo class, there's no longer any real need to keep items added through the two APIs in separate lists - in fact doing so makes it harder to preserve the ordering of menu items if the activity and its menu are destroyed and need to be re- created later on from the stored lists of MenuItemInfos. MozReview-Commit-ID: KlJdvO9WhhY
b6e63d47b9bbafb1bb58571d8abb8906d7a6977a: Bug 1414084 - Part 5 - Unify menu click event handling. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 14:24:15 +0100 - rev 431921
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 5 - Unify menu click event handling. r=Grisha Now that both Webextensions and the NativeWindow API manage their onClick call- back handling by UUID, we can start using the same EventDispatcher message for both. MozReview-Commit-ID: J3RRXrwPdTI
c82c7117206fc5310f9a05b41e80c8d3d58b5542: Bug 1414084 - Part 4 - Move menu item ID generation into the UI. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 15:43:27 +0100 - rev 431920
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 4 - Move menu item ID generation into the UI. r=Grisha Since the NativeWindow API now only uses UUIDs as well when dealing with its consumers, we can leave generation of the menu to the Android UI code of Firefox. MozReview-Commit-ID: 1qDLDnePfFE
d2aa38b39fa086df117be768e0b8f57ea361ffdc: Bug 1414084 - Part 3 - Store NativeWindow menu callbacks by UUID. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:33:42 +0100 - rev 431919
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 3 - Store NativeWindow menu callbacks by UUID. r=Grisha MozReview-Commit-ID: 7nEhAUxOIsW
9fc1c87f952f325a19ee5f41849381aaa534b500: Bug 1414084 - Part 2 - Use UUIDs for the NativeWindow menu API, too. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:26:16 +0100 - rev 431918
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 2 - Use UUIDs for the NativeWindow menu API, too. r=Grisha At the moment, the code for handling of JS-created main menu items is more or less duplicated between the old NativeWindow API and Webextensions, with the only real difference being that the former communicates directly via menu item IDs, while the latter uses UUIDs for messaging between Gecko and the UI. By switching the NativeWindow API to using UUIDs as well, we will be able to start unifying this code again. As for backward compatibility - the return value of NativeWindow.menu.add is valid for the current session only, so no migration is necessary - the return value of NativeWindow.menu add was already effectively only an opaque value which only had real meaning for subsequent calls to menu.add, menu.update and menu.remove, so it shouldn't really matter whether we return a plain numeric ID or an UUID in string form - old-style add-ons are now unsupported for better or for worse and our one in- tree caller won't have any problems with this change MozReview-Commit-ID: HdRNhrx1pu7
65a6e2ffdbaefb0356bad502edfe03df52f102cd: Bug 1414084 - Part 1 - No longer track MenuItemInfo "added" data. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:49:31 +0100 - rev 431917
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 1 - No longer track MenuItemInfo "added" data. r=Grisha We no longer use that value anywhere, so we can just stop keeping track of it. MozReview-Commit-ID: D1IgX1t8SKI
74feab038c3375df282b291682e0b1244c202f00: Bug 1414084 - Part 0 - Cleanups. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 25 Feb 2018 20:53:01 +0100 - rev 431916
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 0 - Cleanups. r=Grisha MozReview-Commit-ID: B3ZGN2X8JXH
5a85654da581748b68bdf88aebcebf8bf4a47117: Bug 1481882 - Load customElements.js in chrome XHTML documents;r=mossop
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 16 Aug 2018 16:26:16 +0000 - rev 431915
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1481882 - Load customElements.js in chrome XHTML documents;r=mossop This provides support for using XUL elements in chrome XHTML documents, including the experimental xhtml browser window (browser.xhtml). Differential Revision: https://phabricator.services.mozilla.com/D3432
3567e433384608b2df9c8b0124afa595edd2c3dc: Bug 1483910: Clear seenTabIcon on pagehide so subsequent loads attempt to load the root favicon. r=kmag
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 16 Aug 2018 17:29:57 +0000 - rev 431914
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1483910: Clear seenTabIcon on pagehide so subsequent loads attempt to load the root favicon. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D3534
d3c6ea00c0bd57c71d257191dbaa40c192ba1e26: Bug 1482299 - Replace libxul.mk with OBJDIR_PP_FILES. r=ted,firefox-build-system-reviewers
Chris Manchester <cmanchester@mozilla.com> - Wed, 15 Aug 2018 14:04:00 +0000 - rev 431913
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1482299 - Replace libxul.mk with OBJDIR_PP_FILES. r=ted,firefox-build-system-reviewers Differential Revision: https://phabricator.services.mozilla.com/D3371
62c11588e3abb4ea5dba0849f29a9204dff46823: Bug 1483831 - Add a localFields option r=glasserc
Mathieu Leplatre <mathieu@mozilla.com> - Thu, 16 Aug 2018 16:50:07 +0000 - rev 431912
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1483831 - Add a localFields option r=glasserc Differential Revision: https://phabricator.services.mozilla.com/D3524
87200a03eb5a8b37b829aabd2799b6f5ab4cb4fe: No bug: [mozharness] Remove no-op code block in repackage code. r=Callek
Tom Prince <mozilla@hocat.ca> - Thu, 16 Aug 2018 16:59:59 +0000 - rev 431911
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
No bug: [mozharness] Remove no-op code block in repackage code. r=Callek Differential Revision: https://phabricator.services.mozilla.com/D3528
0c42a54600831e65a4fb0bfdefdaa67324d78510: Bug 1483401 - Fix scrollable area for the payment request page-body. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 16 Aug 2018 16:33:05 +0000 - rev 431910
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1483401 - Fix scrollable area for the payment request page-body. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D3374
237d45421fb53b69dca38c25baaff15f6a7ef5aa: Bug 1470942 - part 2: Upload geckoview to maven repository via beetmover r=mtabara
Johan Lorenzo <jlorenzo@mozilla.com> - Thu, 16 Aug 2018 16:23:15 +0000 - rev 431909
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1470942 - part 2: Upload geckoview to maven repository via beetmover r=mtabara Depends on D2420 Differential Revision: https://phabricator.services.mozilla.com/D2421
056aaefaffac83e68417a62a048b046ab5e20f58: Bug 1470942 - part 1: Craft zip archive of maven artifacts r=jchen
Johan Lorenzo <jlorenzo@mozilla.com> - Thu, 16 Aug 2018 15:45:13 +0000 - rev 431908
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1470942 - part 1: Craft zip archive of maven artifacts r=jchen Same as https://phabricator.services.mozilla.com/D2031 but keeps the old maven artifacts exposed. Differential Revision: https://phabricator.services.mozilla.com/D2420
3c2f920f1a2d73d710f18360dc9cd723121d3b42: Bug 1455078: Refactor test to run in code in page r=ochameau,asuth
Yaron Tausky <ytausky@mozilla.com> - Thu, 16 Aug 2018 16:18:30 +0000 - rev 431907
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1455078: Refactor test to run in code in page r=ochameau,asuth This test runs code in the frame script, which has system privileges. Even though it trips the security tests as it is, it's not clear whether that should be the case or not. By running the code in the page itself, the expected behavior is governed by the service workers spec and is thus well defined. Differential Revision: https://phabricator.services.mozilla.com/D3323
a4b1382784fada28d5fa9b0d0b08607ee1ca82a1: Bug 1477273 - Followup to ensure correct pref in test
Dale Harvey <dale@arandomurl.com> - Thu, 16 Aug 2018 07:58:00 +0300 - rev 431906
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1477273 - Followup to ensure correct pref in test MozReview-Commit-ID: BPXRlxdpRYf
3d98e379dc389fce823507040d3ce2a77970fb35: Bug 1483527: Change fieldset block-end & inline-axis padding to match other browsers. r=emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 16 Aug 2018 14:54:39 +0000 - rev 431905
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1483527: Change fieldset block-end & inline-axis padding to match other browsers. r=emilio This mirrors the web-platform-tests change at https://github.com/whatwg/html/commit/6058e914c1077c7215a63ab658745fa096b1d35c According to that commit, WebKit/Chromium/EdgeHTML all have the behavior that we're switching to here. Differential Revision: https://phabricator.services.mozilla.com/D3429
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip