8024fcefe8b13d215211cbfe09f979998f3c5217: Bug 1550633 - part7 : change ready state to 'FAILED_TO_LOAD' and dispatch 'error' event when we have no 'src' or have an empty url. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:37 +0000 - rev 475256
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part7 : change ready state to 'FAILED_TO_LOAD' and dispatch 'error' event when we have no 'src' or have an empty url. r=jya `Failed to load` [1] indicates that the text track was enabled, but when the user agent attempted to obtain it, this failed in some way. According to the spec [2], if fetching fails for any reason (network error, the server returns an error code, CORS fails, etc), or if URL is the empty string, then queue a task to first change the text track readiness state to `failed to load` and then fire an event named `error` at the track element. And spec [3] also mention that, if the track URL changes so that it is no longer equal to URL while fetching is ongoing, we also need to change the text track readiness state to`failed to load` and dispatch `error`. [1] https://html.spec.whatwg.org/multipage/media.html#text-track-readiness-state [2] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load [3] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load-3 Differential Revision: https://phabricator.services.mozilla.com/D31556
224eadc5ef27bdcd41375742314c8360464173b7: Bug 1550633 - part6 : clear track's cues list whenever track element's src attribute set, changed or removed. r=jya,baku
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:40 +0000 - rev 475255
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part6 : clear track's cues list whenever track element's src attribute set, changed or removed. r=jya,baku According to the spec [1], we should empty track's cue list whenever a track element has its src attribute set, changed, or removed. [1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:attr-track-src Differential Revision: https://phabricator.services.mozilla.com/D31552
26c3c521ce27aa67922a0a0ed1f4b6d3272e902a: Bug 1550633 - part5 : modify and enable test 'track-mode-not-changed-by-new-track.html'. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:03:42 +0000 - rev 475254
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part5 : modify and enable test 'track-mode-not-changed-by-new-track.html'. r=jya In `honor user preferences for automatic text track selection` [1], we would set `did-perform-automatic-track-selection` flag to true [2], and then we won't execute automatic track selection anymore [3]. It means that we would only do automatic track selection one time, and then user has to enable newly added track explicitly by changing its mode. In this test, we have done the automatic track selection when we added the `metadata` track to media element's text track list, so we won't run it again, even if the newly added track has `default` attribute. Therefore, we have to enable the `caption` track explicitly. In addition, add the missing `event` parameter for the function `trackAdded()`. [1] https://html.spec.whatwg.org/multipage/media.html#honor-user-preferences-for-automatic-text-track-selection [2] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:did-perform-automatic-track-selection-2 [3] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:did-perform-automatic-track-selection Differential Revision: https://phabricator.services.mozilla.com/D31375
def294ad0efb614102f890e85b5b8f9c1e0cf2d7: Bug 1550633 - part4 : no need to run text track selection in stable state. r=bzbarsky
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:04:58 +0000 - rev 475253
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part4 : no need to run text track selection in stable state. r=bzbarsky According to spec [1], it doesn't mention that we have to run text track selection in stable state, it just said "the user agent must queue a task to run the following steps". [1] https://html.spec.whatwg.org/multipage/media.html#honor-user-preferences-for-automatic-text-track-selection Differential Revision: https://phabricator.services.mozilla.com/D31374
b15cc6e689e79f87439d0163e7f7bb1964ad23bc: Bug 1550633 - part3 : add debug log to show track's kind. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:05:00 +0000 - rev 475252
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part3 : add debug log to show track's kind. r=jya Showing track's kind in debug log is helpful. Differential Revision: https://phabricator.services.mozilla.com/D31373
be178934cbbba786670417e9a1090713cc4ebc05: Bug 1550633 - part2 : maybe start loading resource when the track's mode changes. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:05:02 +0000 - rev 475251
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part2 : maybe start loading resource when the track's mode changes. r=jya According to the spec [1], the user agent must start the track processing model when text track has its text track mode changed. [1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:start-the-track-processing-model Differential Revision: https://phabricator.services.mozilla.com/D31372
9893ccf1f8ad07ae7a1c8a69b089ef5b3f99d6ed: Bug 1550633 - part1 : HTMLTrackElement should not load resource when its text track is disable. r=jya
alwu <alwu@mozilla.com> - Thu, 23 May 2019 09:05:04 +0000 - rev 475250
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1550633 - part1 : HTMLTrackElement should not load resource when its text track is disable. r=jya According to the spec step2 [1], we should not load resource for the track element which text track is disabled. [1] https://html.spec.whatwg.org/multipage/media.html#start-the-track-processing-model Differential Revision: https://phabricator.services.mozilla.com/D31371
9ab833800af2dc539e24bbe64189867726585ecf: Bug 1549776 - Add taskcluster jobs for running wrench on Android. r=jrmuizel
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 19:31:06 +0000 - rev 475249
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Add taskcluster jobs for running wrench on Android. r=jrmuizel Also docs for running the same thing locally. Differential Revision: https://phabricator.services.mozilla.com/D32015
83eafb86df0f1439dfb262761c73c0316ebfdaec: Bug 1549776 - Add a script to run wrench reftests on an Android emulator. r=gbrown
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 17:02:49 +0000 - rev 475248
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Add a script to run wrench reftests on an Android emulator. r=gbrown This adds an android_emulator_wrench.py script that uses mozharness to control the Android emulator, and run the wrench reftests. It has an associated wrench.py config script which is similar to existing android config scripts. The android_emulator_wrench script is structured a little differently from other android mozharness scripts, mostly for two reasons: 1) I tried hard to make it locally runnable by developers, using ./mach python. This allows develpers to more easily reproduce the setup that runs in automation, and does so without duplicating a lot of code. 2) I also tried to make the script use fewer of what I consider to be "opaque" mozharness features, like the actions list which can run hard-to-find preflight and postflight functions. Instead of treating mozharness like a framework and filling in some functions for it to invoke as part of it's grand plan, I treat it more like a library and specifically the functions I want in the order that I want, which makes it easier for novice developers to debug problems. As part of writing this script I extracted a few helper functions and made some minor changes to existing android/adb mozharness machinery, but these are all simple refactorings and should introduce no functional change. Differential Revision: https://phabricator.services.mozilla.com/D32014
f1bf5f2b37a8aa5b318955bfd4ce656f6e30198a: Bug 1549776 - Disable more reftests due to failures on Android. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:30:22 +0000 - rev 475247
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Disable more reftests due to failures on Android. r=gw Differential Revision: https://phabricator.services.mozilla.com/D32013
91aef90259cc471c1d05de637d312454ed90aba4: Bug 1549776 - Disable some reftests on debug Android. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:30:18 +0000 - rev 475246
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Disable some reftests on debug Android. r=gw These tests cause panics in debug mode because of the extra GL error checking. Tests that are disabled are annotated with the failing GL call. Differential Revision: https://phabricator.services.mozilla.com/D32012
a08b3b243d9dfe3a9bd51130de4ec941cee421ae: Bug 1549776 - Disable some reftests on Android. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:30:08 +0000 - rev 475245
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Disable some reftests on Android. r=gw Differential Revision: https://phabricator.services.mozilla.com/D32011
8f4f4cc896abda8635f1f8259c35c408c1c6b8ab: Bug 1549776 - Ensure debug wrench aborts on panic. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:30:04 +0000 - rev 475244
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Ensure debug wrench aborts on panic. r=gw This makes it so that when running reftests, wrench actually terminates after a panic rather than just hanging. Termination is detectable and so we can clean up properly instead of waiting until some other layer hits a timeout. Differential Revision: https://phabricator.services.mozilla.com/D32010
743a0b35f1cbaef8fbebc8244121250e51d8bdea: Bug 1549776 - Fix path to artifact. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 15:29:55 +0000 - rev 475243
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1549776 - Fix path to artifact. r=gw Typo when I first landed this, but nothing relied on it so it didn't matter. Differential Revision: https://phabricator.services.mozilla.com/D32009
d63dc26dba151d1a5668df7a29561136c7e8da09: Bug 1553845 - turn on all talos/raptor jobs for osx 10.14. r=gbrown
Joel Maher <jmaher@mozilla.com> - Thu, 23 May 2019 15:23:47 +0000 - rev 475242
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1553845 - turn on all talos/raptor jobs for osx 10.14. r=gbrown turn on all talos/raptor jobs for osx 10.14. Differential Revision: https://phabricator.services.mozilla.com/D32334
9b60f95e81dae91129af4eb80863010cedf4ca57: Bug 1547795 - Hide Picture-in-Picture toggle on videos where its probably more annoying than not. r=JSON_voorhees
Mike Conley <mconley@mozilla.com> - Thu, 23 May 2019 18:49:10 +0000 - rev 475241
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1547795 - Hide Picture-in-Picture toggle on videos where its probably more annoying than not. r=JSON_voorhees This makes our video controls bindings check on loadedmetadata events whether or not to display the toggle. Differential Revision: https://phabricator.services.mozilla.com/D32365
f3534b56753ed9d04b018bd6b0549923775e5661: Bug 1492305 - Fix LibSecret unlocking & NSS return values r=keeler,MattN
Kevin Jacobs <kjacobs@mozilla.com> - Wed, 22 May 2019 18:25:59 +0000 - rev 475240
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1492305 - Fix LibSecret unlocking & NSS return values r=keeler,MattN This fixes issues with the NSS and LibSecret keystore not correctly rejecting unlocking of the key store. Updated for dynamic loading of LibSecret and a bug workaround added elsewhere (updated green try below) Depends on D9969. Differential Revision: https://phabricator.services.mozilla.com/D7713
aaee3b838d53cb52e978b811ea9e744ba79c0e99: Bug 1552422 - correct Balrog scope for comm-esrXX branches. r=tomprince
Rob Lemley <rob@thunderbird.net> - Tue, 21 May 2019 21:16:57 +0000 - rev 475239
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1552422 - correct Balrog scope for comm-esrXX branches. r=tomprince Copying fix from THUNDERBIRD_60_VERBRANCH on mozilla-esr60. https://hg.mozilla.org/releases/mozilla-esr60/rev/eae0435135ad6713bf9d776f71b7d7cc3e01756d Differential Revision: https://phabricator.services.mozilla.com/D31584
7eaaa8f90abd04fd6bedfd8e0dbd8fcba5027c0a: Bug 1546432 - Move DocumentL10n to use mozILocalization. r=smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 21 May 2019 19:22:36 +0000 - rev 475238
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1546432 - Move DocumentL10n to use mozILocalization. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D31554
53386b4a7e83865eb8a1206c1c096f978a9a4b31: Bug 1546432 - Add basic Mutations tests. r=smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 21 May 2019 19:22:29 +0000 - rev 475237
Push 36058 by aciure@mozilla.com at Fri, 24 May 2019 03:53:25 +0000
Bug 1546432 - Add basic Mutations tests. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D31553
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip