7faea94fc428190c0e7a5187ecd16306bce5ad1a: Bug 1677640 - disable cron based windows7 chrome/chromium perf tests. r=sparky
Joel Maher <jmaher@mozilla.com> - Wed, 10 Feb 2021 19:05:26 +0000 - rev 566870
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1677640 - disable cron based windows7 chrome/chromium perf tests. r=sparky disable cron based windows7 chrome/chromium perf tests Differential Revision: https://phabricator.services.mozilla.com/D104728
6aee476f800f45afcd8c956972c54d7c919b6b0a: Bug 1691150: Mark checkbox-minimum-size.html as expected pass on macOS with the non-native theme turned on. r=emilio
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Wed, 10 Feb 2021 18:36:49 +0000 - rev 566869
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1691150: Mark checkbox-minimum-size.html as expected pass on macOS with the non-native theme turned on. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D104285
b4948157d9613ee528a624af4bd0521674ea0dbd: Bug 1690370 - Remove race condition on BodyConsumer::mShuttingDown r=dom-worker-reviewers,sg
Eden Chuang <echuang@mozilla.com> - Wed, 10 Feb 2021 18:34:40 +0000 - rev 566868
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1690370 - Remove race condition on BodyConsumer::mShuttingDown r=dom-worker-reviewers,sg According to [[ https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/dom/base/BodyConsumer.h#132 | the comment on BodyConsumer::mShuttingDown declaration]], it is designed to be accessed on the main thread only. However, the [[ https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/dom/base/BodyConsumer.cpp#299-304 | callback of StrongWorkerRef::Create in BodyConsumer::Create ]] could access BodyConsumer::mShuttingDown on any thread. The patch removes the direct accessing the mShuttingDown in the callback since calling BodyConsumer::ShutDownMainThreadConsuming() will set mShuttingDown as true. Differential Revision: https://phabricator.services.mozilla.com/D104528
6ca1de7bf8a613f667098874cee78e516ad267ed: Bug 1691502: Don't attempt to invalidate table cache on outlines r=eeejay
Morgan Reschenberg <mreschenberg@mozilla.com> - Wed, 10 Feb 2021 18:29:36 +0000 - rev 566867
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1691502: Don't attempt to invalidate table cache on outlines r=eeejay Differential Revision: https://phabricator.services.mozilla.com/D104432
ce88b75e5b6c6cca0a4adc919f2fafdb40c89389: Bug 1648813: Wait for AXLoadComplete on spawned tab based on label r=eeejay
Morgan Reschenberg <mreschenberg@mozilla.com> - Wed, 10 Feb 2021 18:29:02 +0000 - rev 566866
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1648813: Wait for AXLoadComplete on spawned tab based on label r=eeejay Differential Revision: https://phabricator.services.mozilla.com/D104553
63167d041bb4f68e77e46ed6e941003e131ecc8e: Bug 1690750 - Simplify OpenSearchEngine to only allow loading engines from protocols where users can load them from. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 10 Feb 2021 18:12:08 +0000 - rev 566865
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1690750 - Simplify OpenSearchEngine to only allow loading engines from protocols where users can load them from. r=mak The urls where an OpenSearch engine can be loaded from are already limited in LinkHandlerChild. This is cleaning up and simplifying what the OpenSearchEngine allows, and as a result allows the load path handling to be greatly simplified. The test changes are due to no longer allowing chrome or file protocols. For future, we probably want to move away from OpenSearch for most of these, but the changes will make it easier to find the places to update. Differential Revision: https://phabricator.services.mozilla.com/D104010
eb2907b5ef3e545fa9c53893347eeffc476688c9: Bug 1691749 - Simplify self-hosting stencil initialization. r=nbp
Ted Campbell <tcampbell@mozilla.com> - Wed, 10 Feb 2021 17:59:32 +0000 - rev 566864
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1691749 - Simplify self-hosting stencil initialization. r=nbp Now that `CompilationStencilSet` is gone, it is possible to use a single instantiation call for both parse and xdr-decode of self-hosting. Also use a UniquePtr here since in the future this will be shared on the runtime. Differential Revision: https://phabricator.services.mozilla.com/D104542
5dbd804e3a4d47880dde12713198b4cc4681adae: Bug 1691793 - set prefers-contrast to more when accessibilityDisplayShouldIncreaseContrast setting is set to true. r=morgan
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 10 Feb 2021 17:52:56 +0000 - rev 566863
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1691793 - set prefers-contrast to more when accessibilityDisplayShouldIncreaseContrast setting is set to true. r=morgan Differential Revision: https://phabricator.services.mozilla.com/D104562
933da04d9b3fbd322413f021673d418919116506: Bug 1689951 - [devtools] Display notification for screenshot warnings and error messages. r=jdescottes.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 10 Feb 2021 17:49:22 +0000 - rev 566862
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1689951 - [devtools] Display notification for screenshot warnings and error messages. r=jdescottes. This patch make the warning and error messages visible when such messages were emitted, for the RDM screenshot button, the toolbar screenshot button and the inspector screenshot node context menu entry. In the case of the toolbar screenshot button in the browser toolbox, we also display the saved messages so users have a way to know where the file was saved. We don't do anything more for `:screenshot` command in the console, as the messages are already displayed directly in the console output. Tests are added for the different use case. The RDM one is a bit different as we can't have a viewport taller than 9999px, so we bump the dpr to make capture-screenshot downsize it (as such image would be too big). We take this opportunity to fix the `takeNodeScreenshot` helper, which was adding a "load" event listener after setting the src on an image, which can lead to races. Differential Revision: https://phabricator.services.mozilla.com/D104058
2f2fe1dadc7e799e8c073d817581336ab7289bb5: Backed out changeset e3a59a1dc7ca (bug 1691184) for causing bustages in bug1691184.js CLOSED TREE
Noemi Erli <nerli@mozilla.com> - Wed, 10 Feb 2021 21:11:49 +0200 - rev 566861
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Backed out changeset e3a59a1dc7ca (bug 1691184) for causing bustages in bug1691184.js CLOSED TREE
c8ae9ee1d319be1dcee40a594f41b439022ab114: Bug 1692006 - Disable test_arraybufferinputstream_large.html for TSan. r=necko-reviewers DONTBUILD
Jan de Mooij <jdemooij@mozilla.com> - Wed, 10 Feb 2021 17:42:58 +0000 - rev 566860
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1692006 - Disable test_arraybufferinputstream_large.html for TSan. r=necko-reviewers DONTBUILD I added this test recently in bug 1674777. It allocates a huge ArrayBuffer and TSan doesn't like that, we had the same issue with JS shell tests for this. Differential Revision: https://phabricator.services.mozilla.com/D104726
2525abfe33bdd033a23c5a6d0f38d5cce61eab97: Bug 1691433 - Remove check for updates option from application menus r=mconley,jaws,fluent-reviewers
Bernard Igiri <bigiri@mozilla.com> - Wed, 10 Feb 2021 17:39:14 +0000 - rev 566859
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1691433 - Remove check for updates option from application menus r=mconley,jaws,fluent-reviewers Removing Check For Updates button from menu. Differential Revision: https://phabricator.services.mozilla.com/D104548
f9f92a3d32a37c036705765d4bd095c7e6d40866: Bug 1690597 - Unexpire HDR telemetry. r=chutten
Jeff Muizelaar <jmuizelaar@mozilla.com> - Wed, 10 Feb 2021 17:05:54 +0000 - rev 566858
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1690597 - Unexpire HDR telemetry. r=chutten This is just general system information, I can't think of a reason why we'd want it to expire. Differential Revision: https://phabricator.services.mozilla.com/D103917
a71cb2eafb03c63d8357fc2f3dbaba4bf14561fb: Bug 1691478 - Fix detecting existing search shortcuts. r=mikedeboer
Dão Gottwald <dao@mozilla.com> - Wed, 10 Feb 2021 17:19:29 +0000 - rev 566857
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1691478 - Fix detecting existing search shortcuts. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D104714
4ffa8b3b68e8a87658c036f948b30b66c18a3d98: Bug 52821 - Add a pref to disable the quit application shortcut. r=Gijs
Tom Schuster <evilpies@gmail.com> - Wed, 10 Feb 2021 17:02:57 +0000 - rev 566856
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 52821 - Add a pref to disable the quit application shortcut. r=Gijs browser.quitShortcut.disabled=true will disable the Ctrl + Q shortcut on all platforms. Differential Revision: https://phabricator.services.mozilla.com/D104189
d94de995a62b8d4f65c1a8f759320cf6f6bf30bf: Bug 1691345 - Check that focused child doc is a descendant of caller's doc. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Wed, 10 Feb 2021 17:01:22 +0000 - rev 566855
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1691345 - Check that focused child doc is a descendant of caller's doc. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D104546
2cd494905b896c854351d4d3b8b327d04644976d: Bug 1686523, remove home button if proton is enabled and the button hasn't been used r=mstriemer,mconley
Emma Malysz <emalysz@mozilla.com> - Wed, 10 Feb 2021 16:58:53 +0000 - rev 566854
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1686523, remove home button if proton is enabled and the button hasn't been used r=mstriemer,mconley Differential Revision: https://phabricator.services.mozilla.com/D103796
8ef970eae3d15bd78af6458148060b3a56485407: Bug 1690438 - Add telemetry for zero byte loads in nsJARChannel::Open r=zbraniecki
Kershaw Chang <kershaw@mozilla.com> - Wed, 10 Feb 2021 16:47:13 +0000 - rev 566853
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1690438 - Add telemetry for zero byte loads in nsJARChannel::Open r=zbraniecki Differential Revision: https://phabricator.services.mozilla.com/D104404
e3a59a1dc7ca7f173667e390ef78433abcc8a95d: Bug 1691184: Recompile if necessary before retrying interrupted regexp r=mgaudet
Iain Ireland <iireland@mozilla.com> - Wed, 10 Feb 2021 16:45:51 +0000 - rev 566852
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1691184: Recompile if necessary before retrying interrupted regexp r=mgaudet If an interrupt occurs during regexp execution, we return up the stack to RegExpShared::execute to handle it, then try again. Normally it's safe (if slow) to GC and discard jitcode at this point, because we can fall back to interpreted bytecode (which is not discarded). However, if the input string is long enough, then we [jump straight to compilation without producing bytecode](https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/js/src/vm/RegExpObject.cpp#590-596). In that case, when we resume, we will have neither bytecode nor jitcode, and end up dereferencing a null pointer. The fix is to recompile after handling the interrupt. In addition to fixing the crash, forcing compilation here should improve our chance of eventual success (compared to resuming in the regexp interpreter). Differential Revision: https://phabricator.services.mozilla.com/D104479
0f27a332d47fb58f2bfe334e136f71a608e2816a: Bug 1688136: Make range analysis more conservative after truncated node bails out r=nbp,jandem
Iain Ireland <iireland@mozilla.com> - Wed, 10 Feb 2021 16:45:25 +0000 - rev 566851
Push 38191 by btara@mozilla.com at Thu, 11 Feb 2021 05:02:45 +0000
Bug 1688136: Make range analysis more conservative after truncated node bails out r=nbp,jandem If an addition of integer values overflows, we will transpile a CacheIR stub containing a `DoubleAddResult`. In this testcase, after some optimization, we have MIR that looks like: ``` 17 phi toDouble15:Double add10:Double 22 add phi17:Double phi17:Double [double] ... 24 truncatetoint32 add22:Double ``` Range analysis sees that the only consumer of `add22` is a truncation, and truncates the add to Int32. When we overflow again and bail out, we don't make any changes to the CacheIR, because it already handles the overflow case. We end up in a bailout loop. This patch fixes the problem by marking every truncated instruction with `TruncateKind::TruncateAfterBailout` as `BailoutKind::EagerTruncation`. If the instruction bails out, `FinishBailoutToBaseline` will invalidate the script and set the `hadEagerTruncationBailout` flag. When we recompile, that flag will prevent range analysis from truncating any instructions with `TruncateKind::TruncateAfterBailout`. Differential Revision: https://phabricator.services.mozilla.com/D102949
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip