7fad4bfcc1deeaf461387c9f792f450186afd4ad: Backed out changeset 4ff8006a80f5 (bug 1557123) for causing a spike in wpts and wpts reftests intermittents.
Cosmin Sabou <csabou@mozilla.com> - Thu, 06 Jun 2019 04:48:26 +0300 - rev 477050
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Backed out changeset 4ff8006a80f5 (bug 1557123) for causing a spike in wpts and wpts reftests intermittents.
71a2dcd8ac121236cb39798dbd40d867b1737218: Bug 1556137 - Fix a memory leak by allocating memory statically r=sfink
Paul Bone <pbone@mozilla.com> - Thu, 06 Jun 2019 01:41:47 +0000 - rev 477049
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1556137 - Fix a memory leak by allocating memory statically r=sfink Differential Revision: https://phabricator.services.mozilla.com/D33596
4a1e7d5a5b449e60ef39d8e67e2b5cb54d3d389d: Bug 1519954 - Pick binaries from mach bootstrap first on local developer builds. r=nalexander
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Jun 2019 01:22:21 +0000 - rev 477048
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1519954 - Pick binaries from mach bootstrap first on local developer builds. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D33884
d57670df353e6d6ca69d88f7415a011c2db43b5d: Backed out 13 changesets (bug 1492121) for valgrind bustage
Noemi Erli <nerli@mozilla.com> - Thu, 06 Jun 2019 04:01:24 +0300 - rev 477047
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Backed out 13 changesets (bug 1492121) for valgrind bustage Backed out changeset e707f1890820 (bug 1492121) Backed out changeset 90aeaad4a4de (bug 1492121) Backed out changeset 2ffb6ccca437 (bug 1492121) Backed out changeset 4215fefb6ef3 (bug 1492121) Backed out changeset b54b813c4c6c (bug 1492121) Backed out changeset 46f57504c087 (bug 1492121) Backed out changeset a3fe26927b31 (bug 1492121) Backed out changeset 39c486afacec (bug 1492121) Backed out changeset bf1731627e07 (bug 1492121) Backed out changeset 77e7b13c6237 (bug 1492121) Backed out changeset 1f10b50f758f (bug 1492121) Backed out changeset db1506f94d0d (bug 1492121) Backed out changeset 72c4026e9455 (bug 1492121)
eca88f6069a7859a93bf064f8274a4df919091c0: Bug 1557164 - Don't use integrated assembler with clang on mips*. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 06 Jun 2019 00:46:18 +0000 - rev 477046
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1557164 - Don't use integrated assembler with clang on mips*. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D33865
778464d9aac88b896b1f6901d1e7c6c6572f5929: Bug 1549267 Part 2 - Improve comments in LayoutConstants.h. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Thu, 06 Jun 2019 00:04:19 +0000 - rev 477045
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1549267 Part 2 - Improve comments in LayoutConstants.h. r=mats Differential Revision: https://phabricator.services.mozilla.com/D31697
23bbfebbe5834c6d6f9f4ae175c6b525ce4acfa6: Bug 1549267 Part 1 - Remove NS_INTRINSICSIZE and NS_AUTOHEIGHT. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Tue, 04 Jun 2019 23:41:20 +0000 - rev 477044
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1549267 Part 1 - Remove NS_INTRINSICSIZE and NS_AUTOHEIGHT. r=mats This patch is generated by the following steps. 1) Manually delete NS_INTRINSICSIZE and NS_AUTOHEIGHT in LayoutConstants. 2) Run the following script. ``` #!/bin/bash function rename() { find .\ -type f\ ! -path "./obj*"\ ! -path "./.git"\ ! -path "./.hg"\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -e "s/$1/$2/g" "{}" \; } rename NS_INTRINSICSIZE NS_UNCONSTRAINEDSIZE rename NS_AUTOHEIGHT NS_UNCONSTRAINEDSIZE ``` 3) ./mach clang-format Differential Revision: https://phabricator.services.mozilla.com/D31696
e707f1890820c707eb43e7195f26e3ef2fb7571b: Bug 1492121 - Use BaseProfiler in XRE_Init{Parent,Child}Process() - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:43:01 +0000 - rev 477043
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Use BaseProfiler in XRE_Init{Parent,Child}Process() - r=njn Differential Revision: https://phabricator.services.mozilla.com/D31934
90aeaad4a4ded5c992f7265e8435ddaa4ff005ce: Bug 1492121 - Use BaseProfiler in nsBrowserApp.cpp's main() - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:42:59 +0000 - rev 477042
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Use BaseProfiler in nsBrowserApp.cpp's main() - r=njn Start using BaseProfiler in Firefox main(), before&after XPCOM runs. Also added a BaseProfiler label around Gecko Profiler init/shutdown (so that samples may be ignored if user is only interested in non-XPCOM profiling). Main process name changed to "Main Thread (Base Profiler)", so as not to confuse the front-end, and show where this thread comes from. Differential Revision: https://phabricator.services.mozilla.com/D31933
2ffb6ccca437052c211d195428e0e84f2e7d0e1a: Bug 1492121 - Gecko Profiler integrates BaseProfiler startup profiled threads - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:42:01 +0000 - rev 477041
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Gecko Profiler integrates BaseProfiler startup profiled threads - r=njn If MOZ_BASE_PROFILER_STARTUP and MOZ_PROFILER_STARTUP are set, this will integrate a pre-XPCOM startup profile into the main profile. It is stored as separate threads (in a single JSON string that is moved around), which will appear as a new track under the main process. Only adding threads from BaseProfiler means a better integration with Gecko Profiler profiles, and is more efficient: Less code, and a smaller memory footprint. Differential Revision: https://phabricator.services.mozilla.com/D31932
4215fefb6ef3e7747c94bfe260a3929a3c0d829c: Bug 1492121 - Run BaseProfiler's InitializeWin64ProfilerHooks once from either profiler - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:41:40 +0000 - rev 477040
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Run BaseProfiler's InitializeWin64ProfilerHooks once from either profiler - r=njn Running identical (but separate) InitializeWin64ProfilerHooks in both profilers confuses the DLL interceptor and the 2nd one crashes because of unexpected opcodes introduced by the 1st one. If MOZ_BASE_PROFILER is defined, Gecko Profiler will use that implementation of InitializeWin64ProfilerHooks instead of its own; and that code also has a guard so that it effectively only run once even if called from both profilers. Differential Revision: https://phabricator.services.mozilla.com/D31931
b54b813c4c6c82093a26edfa81af80ebc6314cd3: Bug 1492121 - Enclosing BaseProfiler in namespace mozilla::baseprofiler - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:41:26 +0000 - rev 477039
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Enclosing BaseProfiler in namespace mozilla::baseprofiler - r=njn This prevents potential name clashes between the two profilers. Differential Revision: https://phabricator.services.mozilla.com/D31930
46f57504c0874c4594a52dc60b5e0df29ab404cb: Bug 1492121 - Added "BASE" to all public macros - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:41:01 +0000 - rev 477038
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Added "BASE" to all public macros - r=njn E.g., AUTO_PROFILER_INIT -> AUTO_BASE_PROFILER_INIT. This will allow #including BaseProfiler.h anywhere as needed, without clashing with Gecko Profiler macros. Differential Revision: https://phabricator.services.mozilla.com/D31929
a3fe26927b31c10234e8906b71f0004c178ce241: Bug 1492121 - Rename env-vars MOZ_PROFILER_* to MOZ_BASE_PROFILER_* - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:40:47 +0000 - rev 477037
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Rename env-vars MOZ_PROFILER_* to MOZ_BASE_PROFILER_* - r=njn Notice the extra 'BASE' in the env-var names. This is to control BaseProfiler separately from the Gecko Profiler. Differential Revision: https://phabricator.services.mozilla.com/D31928
39c486afacec3cdf3f8d37d34eabf27887ae0806: Bug 1492121 - Enable Base Profiler by default on Linux and Mac - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:40:28 +0000 - rev 477036
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Enable Base Profiler by default on Linux and Mac - r=njn Android not implemented yet. Windows not working yet when packaged, so disabled by default, but may be enabled locally by uncommenting `#define MOZ_BASE_PROFILER` where indicated in BaseProfiler.h. Differential Revision: https://phabricator.services.mozilla.com/D31927
bf1731627e0714683a5664d2118eb3ed16010cd8: Bug 1492121 - TestBaseProfiler - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:40:09 +0000 - rev 477035
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - TestBaseProfiler - r=njn Simple test program that exercises the most important APIs of BaseProfiler. (Including checking that macros work even when BaseProfiler is not enabled.) Differential Revision: https://phabricator.services.mozilla.com/D31926
77e7b13c6237fdded3e33fb664962cef2a636a95: Bug 1492121 - All necessary changes to make baseprofiler build - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:39:53 +0000 - rev 477034
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - All necessary changes to make baseprofiler build - r=njn Almost-mechanical changes include: - Removed unneeded/incompatible #includes and functions (any JS- or XPCOM- dependent). - Use std::string for strings and nsIDs. - Use thin wrappers around mozilla::detail::MutexImpl for mutexes. - Use hand-rolled AddRef&Release's for ref-counted classes -- could not use mfbt/RefCounted.h because of bug 1536656. - Added some platform-specific polyfills, e.g.: MicrosecondsSince1970(). - Only record the main thread by default. - Logging controlled by env-vars MOZ_BASE_PROFILER_{,DEBUG_,VERBOSE_}LOGGING. This now builds (with --enable-base-profiler), but is not usable yet. Differential Revision: https://phabricator.services.mozilla.com/D31924
1f10b50f758f54902e7423f4de0da9c0e0c2944b: Bug 1492121 - MOZ_BASE_PROFILER may be defined in BaseProfiler.h to enable Base Profiler - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:39:28 +0000 - rev 477033
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - MOZ_BASE_PROFILER may be defined in BaseProfiler.h to enable Base Profiler - r=njn Added baseprofiler to mozglue/moz.build, so it will be built. However all cpp files are dependent on `MOZ_BASE_PROFILER`, which is currently not #defined by default (in public/BaseProfiler.h). Added mozglue/mozprofiler to js/src/make-source-package.sh, because mozglue/moz.build now refers to it. Differential Revision: https://phabricator.services.mozilla.com/D33258
db1506f94d0d2eec4c1955ee27a68ad77d84329e: Bug 1492121 - Copy mozglue/baseprofiler in make-source-package.sh - r=sfink
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:39:09 +0000 - rev 477032
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Copy mozglue/baseprofiler in make-source-package.sh - r=sfink Added mozglue/mozprofiler to js/src/make-source-package.sh, because mozglue/moz.build will refer to it unconditionally. Note that if MOZ_GECKO_PROFILER and MOZ_BASE_PROFILER are not defined, no actual code will be generated. Differential Revision: https://phabricator.services.mozilla.com/D33789
72c4026e9455c66a01fe06763c36115f4edc6813: Bug 1492121 - Copy most of Gecko Profiler code to mozglue/baseprofiler - r=njn
Gerald Squelart <gsquelart@mozilla.com> - Wed, 05 Jun 2019 23:38:55 +0000 - rev 477031
Push 36115 by shindli@mozilla.com at Thu, 06 Jun 2019 09:29:49 +0000
Bug 1492121 - Copy most of Gecko Profiler code to mozglue/baseprofiler - r=njn Almost-straight copy of a subset of files from tools/profiler to mozglue/baseprofiler. Some minor changes first: - Reduced moz.build to only mention actually-copied files. - Headers in 'public' prefixed with "Base" (to distinguish them from their originals, in case they later get #included from the same units). - Also copied profiling categories from js/src/vm/GeckoProfiler.cpp to ProfilingCategory.cpp, and copied js/src/vm/ProfilingStack.cpp, and their respective headers -- as they are needed for a significant part of the profiler API, and are not strictly js-specific. baseprofiler not yet added to parent mozglue/moz.build, so it won't be built yet. Differential Revision: https://phabricator.services.mozilla.com/D31923
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip