7b69b606bb29b260d42eea8365ddae86207324b7: Bug 1543315 - part 12: Mark nsIPresShell::DoScrollContentIntoView() as MOZ_CAN_RUN_SCRIPT r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 23 Apr 2019 01:34:26 +0000 - rev 470448
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1543315 - part 12: Mark nsIPresShell::DoScrollContentIntoView() as MOZ_CAN_RUN_SCRIPT r=smaug Now, we can mark `DoScrollContentIntoView()` as `MOZ_CAN_RUN_SCRIPT` and move it from `nsIPresShell` to `PresShell` with a member. Differential Revision: https://phabricator.services.mozilla.com/D28321
7d67598c90435110cb0ee046e14750306f1d32f6: Bug 1543315 - part 11: Mark nsIPresShell::ScrollContentIntoView() as MOZ_CAN_RUN_SCRIPT r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 23 Apr 2019 01:34:24 +0000 - rev 470447
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1543315 - part 11: Mark nsIPresShell::ScrollContentIntoView() as MOZ_CAN_RUN_SCRIPT r=smaug This patch marks `ScrollContentIntoView()` as `MOZ_CAN_RUN_SCRIPT` and changing some callers of them to guarantee thar their parent callers are also safe. Additionally, this patch moves it from `nsIPresShell` to `PresShell` because all callers can refer `PresShell` directly. Unfortunately, this patch changes a lot of methods in autocomplete and satchel since this patch needs to mark some interface methods as `can_run_script` and they are called each other. This means that autocomplete module is really sensitive like editor module. Perhaps, autocomplete and satchel should do scroll asynchronously and unmark some of them as `MOZ_CAN_RUN_SCRIPT` again. Differential Revision: https://phabricator.services.mozilla.com/D28320
3d921a5274f511f3da58cc0499239299f092ad96: Bug 1543315 - part 10: Mark nsIPresShell::GoToAnchor() and nsIPresShell::ScrollToAnchor() as MOZ_CAN_RUN_SCRIPT r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 23 Apr 2019 01:27:47 +0000 - rev 470446
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1543315 - part 10: Mark nsIPresShell::GoToAnchor() and nsIPresShell::ScrollToAnchor() as MOZ_CAN_RUN_SCRIPT r=smaug Next, we should mark `PresShell::ScrollContentIntoView()` as `MOZ_CAN_RUN_SCRIPT` because it's used widely. This patch marks its `PresShell` users, `GoToAnchor()` and `ScrollToAnchor()`, as `MOZ_CAN_RUN_SCRIPT`. Additionally, this patch moves them from `nsIPresShell` to `PresShell` because all callers refers `PresShell` directly. Differential Revision: https://phabricator.services.mozilla.com/D28319
2ef93e029730573bc86953be52d93e6b73198c9d: Bug 1535792 - Disabled test test_richtext2.html on Linux32 debug r=jmaher
Razvan Maries <rmaries@mozilla.com> - Sun, 21 Apr 2019 14:28:48 +0000 - rev 470445
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1535792 - Disabled test test_richtext2.html on Linux32 debug r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D28291
651ac84f173e7b18984b6cdab69b8eeff0e7a738: Bug 1518793 Add Microsoft Office to tp6 r=AlexandruIonescu
Florin Strugariu <fstrugariu@mozilla.com> - Mon, 22 Apr 2019 15:39:00 +0000 - rev 470444
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1518793 Add Microsoft Office to tp6 r=AlexandruIonescu Differential Revision: https://phabricator.services.mozilla.com/D27663
e2cc745b30eb60235080c0fbc422762f4f2d0f82: Bug 1533681 - Disable browser_siteData.js on Win and Linux (debug) r=jmaher
Narcis Beleuzu <nbeleuzu@mozilla.com> - Mon, 22 Apr 2019 11:37:07 +0000 - rev 470443
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1533681 - Disable browser_siteData.js on Win and Linux (debug) r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D28316
02a9bf38ebf276bcd4950a7ff6286e8688da15b3: Backed out 2 changesets (bug 1536121) for Reftest failures
Dorel Luca <dluca@mozilla.com> - Tue, 23 Apr 2019 10:05:14 +0300 - rev 470442
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Backed out 2 changesets (bug 1536121) for Reftest failures Backed out changeset 0fc395a2ac71 (bug 1536121) Backed out changeset 430032511561 (bug 1536121)
74175527c5eab80b079b60a97b227e5ec5721c66: Bug 1541357 - Change the argument order of table.grow to be spec-compliant. r=lth
Julian Seward <jseward@acm.org> - Mon, 22 Apr 2019 08:51:04 +0000 - rev 470441
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1541357 - Change the argument order of table.grow to be spec-compliant. r=lth We implemented table.grow with an initializer argument before there was a spec for it, and the draft spec now takes the arguments in the opposite order of what we have, to follow table.fill and memory.fill: we should pop the delta first, then the init value, ie in the high-level notation, the init value is the first argument and the delta the second. This corresponds to the last two arguments of the fill instructions, which are initializer value and length. This commit fixes both the implementation and test cases: it swaps the order of the 'initial value' and 'delta' arguments. Differential Revision: https://phabricator.services.mozilla.com/D27887
0b0a2b12bd0502a0743917abdd29109c2b2cdbfd: Bug 1528052 - Suppress resize events until the initial paint has finished on mobile. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 04:14:55 +0000 - rev 470440
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1528052 - Suppress resize events until the initial paint has finished on mobile. r=botond Differential Revision: https://phabricator.services.mozilla.com/D28172
0f774c6d8ac396b6241fb27cfd6e7cad88c4b3ba: Bug 1545172 - Enable recording of metrics into pre-account ecosystem ping/store r=janerik
Leif Oines <loines@mozilla.com> - Mon, 22 Apr 2019 17:50:05 +0000 - rev 470439
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1545172 - Enable recording of metrics into pre-account ecosystem ping/store r=janerik Differential Revision: https://phabricator.services.mozilla.com/D27949
0fc395a2ac7155ffece75daf20d103144374fbfe: Bug 1536121 - rearchitect the webrender display-list. r=gw
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 23 Apr 2019 02:32:50 +0000 - rev 470438
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1536121 - rearchitect the webrender display-list. r=gw disclaimer: this isn't an *amazing* cleanup, but more of a major step that unlocks the ability to do more minor cleanups and refinements. There's some messy things and inconsistencies here and there, but we can hopefully iron them out over time. 1. The primary change here is to move from struct { common_fields, enum(specific_fields) } to enum (maybe_common_fields, specific_fields) most notably this drops the common fields from a ton of things that don't need them PopXXX, SetXXX, ClipChain, etc. 2. Additionally some types have had some redundant states shaved off, for instance, rect no longer has *both* bounds and a clip_rect, as the intersection of the two can be used. This was done a bit conservatively as some adjustments will need to be done to the backend to fully eliminate some states, and this can be done more incrementally. 2.5. As a minor side-effect of 2, we now early-reject some primitives whose bounds and clip_rect are disjoint. 3. A HitTest display item has been added, which is just a Rect without color. In addition to the minor space wins from this, this makes it much easier to debug display lists 4. Adds a bunch of comments to the display list, making it easier to understand things. The end result of all these changes is a significantly smaller and easier to understand display list. Especially on pages like gmail which have so many clip chains. However this ultimately just makes text an even greater percentage of pages (often 70-80%). Differential Revision: https://phabricator.services.mozilla.com/D27439
43003251156190b170a66b2c213d94d7d02cbf10: Bug 1536121 - cleanup display list code a little bit to prep for refactor. r=gw
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 23 Apr 2019 02:32:48 +0000 - rev 470437
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1536121 - cleanup display list code a little bit to prep for refactor. r=gw * make all enums repr(u8) (compiler bug blocking this long fixed) * add display list stats feature * remove cache markers (abandoned design) * don't always push empty SetFilters before PushStackingContext * remove dead pub methods Differential Revision: https://phabricator.services.mozilla.com/D25845
6f0320a8555580db1b9c8cc7e2c7452b30bc157b: Bug 1546038 - Include scroll-margin areas into snap area. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 03:58:57 +0000 - rev 470436
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1546038 - Include scroll-margin areas into snap area. r=botond This patch also renames `targetRect` to `snapArea` to represent it more accurately. Differential Revision: https://phabricator.services.mozilla.com/D28307
3e3a2ecafdaafb3ef75009b7662be7e84451d70b: Bug 1546158: Add option to mscom::EnsureMTA to forcibly dispatch events to its thread; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Tue, 23 Apr 2019 02:17:17 +0000 - rev 470435
Push 35906 by aciure@mozilla.com at Tue, 23 Apr 2019 22:14:56 +0000
Bug 1546158: Add option to mscom::EnsureMTA to forcibly dispatch events to its thread; r=Jamie In sandboxed processes with Win32k lockdown, when we initialize COM using an MTA on a background thread, the main thread is automatically initialized by the COM runtime as having an implicit MTA. This is fine, except for the fact that if we want to enqueue any work that needs to operate specifically on the EnsureMTA thread, it won't happen. This patch adds a flag to EnsureMTA's constructor that ensures that, even if the current thread is in an MTA (implicit or otherwise), we still forcibly enqueue the closure specifically to the EnsureMTA thread. Differential Revision: https://phabricator.services.mozilla.com/D28391
831918f009f63596fde1e532cc0f026d2e53cf78: Backed out changeset e85cb54e5944 (bug 1546046) complementary backout after 1470880 was backed out CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Tue, 23 Apr 2019 06:55:29 +0300 - rev 470434
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Backed out changeset e85cb54e5944 (bug 1546046) complementary backout after 1470880 was backed out CLOSED TREE
291b093ea26a97f55d0388a134f18dc50184192d: Backed out changeset 6fea732af766 (bug 1539984) for browser_PanelMultiView_keyboard.js failures CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Tue, 23 Apr 2019 06:41:42 +0300 - rev 470433
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Backed out changeset 6fea732af766 (bug 1539984) for browser_PanelMultiView_keyboard.js failures CLOSED TREE
42c76408a8bdeea672dc5144c103cb34fe850b5f: Bug 1544198 - Test cases for the root element. r=jfkthame
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:14:37 +0000 - rev 470432
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Test cases for the root element. r=jfkthame These test cases intentionally check only Y-axis scroll position since horizontal scroll on the root element has been broken, e.g. bug 1102175 or bug 1260054. Differential Revision: https://phabricator.services.mozilla.com/D27988
52410914b543300394f6b98c8dd6e3d73fb84780: Bug 1544198 - Use the proper frame to get scroll-snap-type value on the root element. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:16:02 +0000 - rev 470431
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Use the proper frame to get scroll-snap-type value on the root element. r=botond Now scroll-snap-type property on body element doesn't affect scroll position so that scrollTo-scrollBy-snaps.html is needed to be modified to specify scroll-snap-type on html. Differential Revision: https://phabricator.services.mozilla.com/D27987
5b413410d2c5f93ca4240a3c4608a1182d53a2d2: Bug 1544198 - Split ScrolLFrameHelper::ComputeScrollSnapInto into two functions. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:12:38 +0000 - rev 470430
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Split ScrolLFrameHelper::ComputeScrollSnapInto into two functions. r=botond The one is for the scroll snap module v1 implementation, the other is for the old scroll snap implementation. Now both functions have the same pieces of code to get scroll-snap-type values, but for v1 implemention in the next commit we will use GetFrameForScrollSnap() to get the value instead. Differential Revision: https://phabricator.services.mozilla.com/D27986
530a3f39ecbd096436a8cf38d1d73068ff1fbcb8: Bug 1544198 - Factor out the function to get the frame for scroll-snap-type and scroll-padding. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:12:24 +0000 - rev 470429
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Factor out the function to get the frame for scroll-snap-type and scroll-padding. r=botond Differential Revision: https://phabricator.services.mozilla.com/D27985
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip