7a5a3cbc9b5be32af3b7666930e87aa33bc63981: Bug 1599416 - Part 14: Remove TypedObject::isAttached because it always returns true. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 14:12:23 +0000 - rev 504050
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 14: Remove TypedObject::isAttached because it always returns true. r=mgaudet As demonstrated in the last patch, OutlineTypedObjects always have an attached datum, which means `TypedObject::isAttached` always returns true for any TypedObject. The two new assertions in `OutlineTypedObject::obj_trace` have been added so it's easier to see that `owner_` is nullptr iff `data_` is nullptr. Differential Revision: https://phabricator.services.mozilla.com/D54718
8fee074100ca84c0a883b8f404c2d7628a09a584: Bug 1599416 - Part 13: Make OutlineTypedObject::attach and createUnattached private methods. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:58:26 +0000 - rev 504049
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 13: Make OutlineTypedObject::attach and createUnattached private methods. r=mgaudet `OutlineTypedObject::attach` is only called when creating a new OutlineTypedObject. By making the two `attach` functions and `createUnattached[WithClass]` private methods, we can enforce only OutlineTypedObjects with attached data are exposed to the user. This is in preparation for the next patch. Differential Revision: https://phabricator.services.mozilla.com/D54717
12b167e83eddd8a1542ccbca9c8b404e37dbc847: Bug 1599416 - Part 12: Fold AttachTypedObject into NewOpaqueTypedObject. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:58:16 +0000 - rev 504048
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 12: Fold AttachTypedObject into NewOpaqueTypedObject. r=mgaudet `AttacheTypedObject` is only ever called directly after `NewOpaqueTypedObject`, so we can merge both functions similar to the existing `NewDerivedTypedObject` function. This is in preparation of the next two patches. Differential Revision: https://phabricator.services.mozilla.com/D54716
27b601310b36bd37243a4b0e8600533d1f052e68: Bug 1599416 - Part 11: Remove constant parameters. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:58:09 +0000 - rev 504047
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 11: Remove constant parameters. r=mgaudet The `length` parameter is always `1`. Differential Revision: https://phabricator.services.mozilla.com/D54715
f98095b88847ac5ce7693dde47d1ff28528cce9a: Bug 1599416 - Part 10: Simplify TypedObject::isAttached. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:58:05 +0000 - rev 504046
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 10: Simplify TypedObject::isAttached. r=mgaudet - Instead of testing for `InlineTransparentTypedObject` and `InlineOpaqueTypedObject` separately, we can directly test for `InlineTypedObject`. - Because the ArrayBuffer of an `OutlineTypedObject` can never be detached, we don't need to test for it. Differential Revision: https://phabricator.services.mozilla.com/D54714
039c220b566646e5c1d6c55a47be7cd941012786: Bug 1599416 - Part 9: Remove tracking for TypedObjects with detached buffers. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:56:51 +0000 - rev 504045
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 9: Remove tracking for TypedObjects with detached buffers. r=mgaudet Because ArrayBuffers used for TypedObjects can never be detached, we can remove a couple of additional functions which are no longer used. Differential Revision: https://phabricator.services.mozilla.com/D54713
17f3a6b3c21ff6daae1b330dd09a8f95e99e8c55: Bug 1599416 - Part 8: Remove view tracking for TypedObjects. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:56:16 +0000 - rev 504044
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 8: Remove view tracking for TypedObjects. r=mgaudet `ArrayBufferObject::detach` expects all views are `ArrayBufferViewObject`, which means detaching an ArrayBuffer used for TypedObjects already crashes anyway. Instead let's change `ArrayBufferObject::addView` and `ABO::setFirstView` to only accept `ArrayBufferViewObject` and then remove the `addView` call in `OutlineTypedObject::attach`. Additionally introduce `ABO::createForTypedObject` as the single function which can call `ABO::setHasTypedObjectViews` to mark an ArrayBufferObject as being used for TypedObjects. Differential Revision: https://phabricator.services.mozilla.com/D54712
fc9e0fa219ac42a448daba7a7dcb7a41088bdcf3: Bug 1599416 - Part 7: Remove unused lazyArrayBuffers table. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:55:52 +0000 - rev 504043
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 7: Remove unused lazyArrayBuffers table. r=mgaudet Entries are never added to `lazyArrayBuffers` resp. `lazyArrayBuffers` isn't even allocated anymore. Differential Revision: https://phabricator.services.mozilla.com/D54711
8c36a33102d51e75ddbdc7133285cf5528783332: Bug 1599416 - Part 6: Remove unused TypedObject functions. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:55:32 +0000 - rev 504042
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 6: Remove unused TypedObject functions. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D54710
c49111d0a4401afa51ac2a32f090a80e9ab228cd: Bug 1599416 - Part 5: Remove unused TypedObject::GetByteOffset function. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:55:04 +0000 - rev 504041
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 5: Remove unused TypedObject::GetByteOffset function. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D54709
10f7acca7244341a84f8f307bc7f0317fc7810d0: Bug 1599416 - Part 4: Remove unused ObjectIsTransparentTypedObject function. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:54:39 +0000 - rev 504040
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 4: Remove unused ObjectIsTransparentTypedObject function. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D54708
ca3152f19e29658490445939940c4cd288e1620f: Bug 1599416 - Part 3: Remove unused ObjectIsOpaqueTypedObject function. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:54:15 +0000 - rev 504039
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 3: Remove unused ObjectIsOpaqueTypedObject function. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D54707
ade7361b947cc69d2b4f530082b851aa8fbb99f3: Bug 1599416 - Part 2: Remove unused SetTypedObjectOffset function. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:53:48 +0000 - rev 504038
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 2: Remove unused SetTypedObjectOffset function. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D54706
1f76130b2caecc112b703b369b4d0f55a115e2f6: Bug 1599416 - Part 1: Remove unused OutlineTypedObject::notifyBufferDetached method. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:53:12 +0000 - rev 504037
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1599416 - Part 1: Remove unused OutlineTypedObject::notifyBufferDetached method. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D54705
432a6d44236d2f6f5efd083fd14e0a1a0a34aa9e: Bug 1593832: Enforce XFO and frame-ancestors in parent process if fission is enabled and in content if running in regular mode until we can determine whether a load results in a download in the parent process. r=bzbarsky,jkt
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 27 Nov 2019 14:26:38 +0000 - rev 504036
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1593832: Enforce XFO and frame-ancestors in parent process if fission is enabled and in content if running in regular mode until we can determine whether a load results in a download in the parent process. r=bzbarsky,jkt Differential Revision: https://phabricator.services.mozilla.com/D53955
3bd3398c2f0c4a7853dec584457f4b71773718db: Bug 1596718 - Part 4: Add LIsNullOrUndefinedAndBranch to fuse LIsNullOrUndefined and LTestIAndBranch. r=jandem
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 14:09:55 +0000 - rev 504035
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1596718 - Part 4: Add LIsNullOrUndefinedAndBranch to fuse LIsNullOrUndefined and LTestIAndBranch. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D53175
412b06699b9655dcd184986658329c138c431250: Bug 1596718 - Part 3: Handle MIsNullOrUndefined in improveTypesAtTest to remove null/undefined from the typeset. r=jandem
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 14:06:20 +0000 - rev 504034
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1596718 - Part 3: Handle MIsNullOrUndefined in improveTypesAtTest to remove null/undefined from the typeset. r=jandem Remove resp. add null/undefined to the typeset in improveTypesAtTest for MIsNullOrUndefined. That way operations on the coalesce expression can be further optimised. For example `a += obj.prop ?? 0` where `obj.prop` is either an Int32 or null/undefined can now be optimised to use Int32 addition, because both possible right-hand side values are now typed as Int32. Differential Revision: https://phabricator.services.mozilla.com/D53174
3cb7dba63a754c6fea38f7d5f368d7ee0b5da9ee: Bug 1596718 - Part 2: Don't emit unreachable tests in CodeGenerator::visitIsNullOrUndefined. r=jandem
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:46:19 +0000 - rev 504033
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1596718 - Part 2: Don't emit unreachable tests in CodeGenerator::visitIsNullOrUndefined. r=jandem We don't need to test for null/undefined if that type was never observed. Differential Revision: https://phabricator.services.mozilla.com/D53173
b449f05b67559d744d0571e8b0485dc2d66924bc: Bug 1596718 - Part 1: Add MIsNullOrUndefined::foldsTo to omit unreachable tests. r=jandem
André Bargull <andre.bargull@gmail.com> - Wed, 27 Nov 2019 13:46:14 +0000 - rev 504032
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1596718 - Part 1: Add MIsNullOrUndefined::foldsTo to omit unreachable tests. r=jandem Fold away MIsNullOrUndefined when the input is definitely null/undefined resp. never null/undefined. Differential Revision: https://phabricator.services.mozilla.com/D53172
6dbf8f2cd4fd2d04dc4810e180363a341ac1d506: Bug 1596888 - (remote) vendor Puppeteer to 8b49dc6
Maja Frydrychowicz <mjzffr@gmail.com> - Wed, 27 Nov 2019 14:38:28 +0000 - rev 504031
Push 36855 by aiakab@mozilla.com at Wed, 27 Nov 2019 21:56:55 +0000
Bug 1596888 - (remote) vendor Puppeteer to 8b49dc6 Differential Revision: https://phabricator.services.mozilla.com/D54941
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip