7a1f17f3f10b0223dca6d87ce874e95fa08e21ae: Bug 1730712: Remove redundant `__PYVENV_LAUNCHER__` purge r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Wed, 17 Nov 2021 20:54:26 +0000 - rev 599490
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1730712: Remove redundant `__PYVENV_LAUNCHER__` purge r=ahal As of bug 1686168, `__PYVENV_LAUNCHER__` is purged when Mach starts running. Since `MozSiteManager` is only used by Mach, its internal purging of the environment variable is redundant. Differential Revision: https://phabricator.services.mozilla.com/D129690
6086617710c163bebb596d3034c2560588407d20: Bug 1730712: Remove unused `exe_info_path` from `VirtualenvManager` r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Wed, 17 Nov 2021 20:54:25 +0000 - rev 599489
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1730712: Remove unused `exe_info_path` from `VirtualenvManager` r=ahal The information about the Python executable is now stored with other details in the JSON metadata file we put in each virtualenv. Differential Revision: https://phabricator.services.mozilla.com/D129689
0dd570bbd878b90d78bcd3e71daeae081c80d73c: Bug 1730712: Ensure virtualenv up-to-date before activation r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Wed, 17 Nov 2021 20:54:25 +0000 - rev 599488
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1730712: Ensure virtualenv up-to-date before activation r=ahal Rather than requiring that consumers remember to `ensure()` before calling `activate()`, we can do so automatically during activation. There isn't a valid use case in which we want obsolete virtualenvs to be activateable. Usages of `MozSiteManager` have been updated accordingly. Differential Revision: https://phabricator.services.mozilla.com/D129688
ff557ad3fd388eb3ceec03bc61ccfedfaada0149: Bug 1730712: Inline virtualenv `create()` function r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Wed, 17 Nov 2021 20:54:24 +0000 - rev 599487
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1730712: Inline virtualenv `create()` function r=ahal `create()` was only called from one place, and had more complex logic than necessary. Related to this change, `check=True` is used rather than asserting the return code. Differential Revision: https://phabricator.services.mozilla.com/D129687
08ecc92e06e82c5ada0cab3b4ba48d4f79296b99: Bug 1730712: Contain virtualenv metadata file management inside of class r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Wed, 17 Nov 2021 20:54:24 +0000 - rev 599486
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1730712: Contain virtualenv metadata file management inside of class r=ahal `MozVirtualenvMetadata` only needs to know the virtualenv it's operating on - the knowledge of its internal metadata filename should not have to be exposed. Differential Revision: https://phabricator.services.mozilla.com/D129686
5fc6520fe15583bca071813f4a3d9711e30809b8: Bug 1730712: Split on-disk venv logic from `MozSiteManager` r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Wed, 17 Nov 2021 20:54:23 +0000 - rev 599485
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1730712: Split on-disk venv logic from `MozSiteManager` r=ahal The current inheritance-based separation between "general venv details" (`VirtualenvHelper`) and moz site details (`MozSiteManager`) has caused `MozSiteManager` to care about too many details. This patch splits things apart a little more: * The term `VirtualenvHelper` isn't _super_ useful, rename it to `PythonVenv` to show that it represents a Python virtualenv. * Move on-disk virtualenv logic (`activate_path` location, `site-packages` location, `pip install` behaviour) into a contained `MozVirtualenv` class. * Port the inheritance to a "composition" model instead. Differential Revision: https://phabricator.services.mozilla.com/D129685
8867abf5bb2f0deb679ddf55a6cf0511d8dea3a0: Bug 1730712: Update "Moz site" terminology r=ahal
Mitchell Hentges <mhentges@mozilla.com> - Wed, 17 Nov 2021 20:54:23 +0000 - rev 599484
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1730712: Update "Moz site" terminology r=ahal The existing terminology had two issues: * `VirtualenvManager` wasn't always associated with an on-disk `virtualenv`: for example, when running in automation, Mach "activates" a `VirtualenvManager`, updating its import scope, but without ever creating an on-disk `virtualenv`. * An upcoming patch splits the `VirtualenvManager` class, pulling "on-disk virtualenv-handling functions" from the project-wide interface for managing Python's import scope. After some good discussion with Ahal, I think we've struck the terminology that handles this distinction well: we'll call the "import scope"-handling part the "site", and we'll continue to call on-disk virtualenvs (and their representative classes) as, well, virtualenvs. Differential Revision: https://phabricator.services.mozilla.com/D130391
682c9e208b68705fc92222d380d7a6311297c51f: Bug 1741503 - Remove special handoff ID in MacUserActivityUpdater. r=mstange
Harry Twyford <htwyford@mozilla.com> - Wed, 17 Nov 2021 20:49:10 +0000 - rev 599483
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1741503 - Remove special handoff ID in MacUserActivityUpdater. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D131415
614e075b0863be3d8127d3f9db1dd3a1fcda4c3c: Bug 1741564 - Add icu4x dir in config/external/moz.build. r=platform-i18n-reviewers,gregtatum
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Wed, 17 Nov 2021 20:22:45 +0000 - rev 599482
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1741564 - Add icu4x dir in config/external/moz.build. r=platform-i18n-reviewers,gregtatum Differential Revision: https://phabricator.services.mozilla.com/D131327
b72647a71c3dfff8157e9b35ac6107ad99d397fe: Bug 1737089 - Replace size() with empty(). r=sylvestre
Tawah Peggy <tawahpeggy98@gmail.com> - Wed, 17 Nov 2021 19:58:15 +0000 - rev 599481
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1737089 - Replace size() with empty(). r=sylvestre SanitizeRenderer.cpp: The empty method should be used to check for emptiness instead of the size method. Differential Revision: https://phabricator.services.mozilla.com/D131054
72ff13b5fc7e1f65180e69f9b9618b5ad6ef4dc9: Bug 1687592 - Don't cache mRefreshDriver between L10nMutation observer calls. r=nordzilla,mstange
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 17 Nov 2021 19:54:18 +0000 - rev 599480
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1687592 - Don't cache mRefreshDriver between L10nMutation observer calls. r=nordzilla,mstange Differential Revision: https://phabricator.services.mozilla.com/D131278
8c4b7f8d83d34f5d5b7750a1de9993a2fd8d05f7: Bug 1741492 - Update IOUtils migration guide for new openFileForSyncReading API. r=barret
Markus Stange <mstange.moz@gmail.com> - Wed, 17 Nov 2021 19:49:53 +0000 - rev 599479
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1741492 - Update IOUtils migration guide for new openFileForSyncReading API. r=barret Differential Revision: https://phabricator.services.mozilla.com/D131273
3d5da81134070c6c3c430f8094c0aa363f1a8708: Bug 1741377: Add a check to verify the successful dispatch of the nsThread shutdown ack event. r=xpcom-reviewers,nika
Jens Stutte <jstutte@mozilla.com> - Wed, 17 Nov 2021 19:25:28 +0000 - rev 599478
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1741377: Add a check to verify the successful dispatch of the nsThread shutdown ack event. r=xpcom-reviewers,nika Differential Revision: https://phabricator.services.mozilla.com/D131220
b159a403dcffa33f5c5ba97be928f16f74bbbd88: Bug 1740567 Update JetStream2 benchmark to run against autoland. r=perftest-reviewers,sparky
andrej <aglavic@mozilla.com> - Wed, 17 Nov 2021 19:20:12 +0000 - rev 599477
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1740567 Update JetStream2 benchmark to run against autoland. r=perftest-reviewers,sparky Differential Revision: https://phabricator.services.mozilla.com/D130920
ecd1106aeeffb2cda7b0ac69dabf4674f7a39776: Bug 1741531 - Print RENDERER in DEBUG builds once per process. r=gfx-reviewers,lsalzman
Jeff Gilbert <jdashg@gmail.com> - Wed, 17 Nov 2021 19:17:36 +0000 - rev 599476
Push 38987 by smolnar@mozilla.com at Thu, 18 Nov 2021 03:49:37 +0000
Bug 1741531 - Print RENDERER in DEBUG builds once per process. r=gfx-reviewers,lsalzman Differential Revision: https://phabricator.services.mozilla.com/D131314
580e44ff9279ba88e3d4294621269ff8f4f23c20: Bug 1741235 - Merge the 'Firefox Front-End' and 'Firefox Platform' profiler presets, r=julienw,fluent-reviewers,nbaumgardner,kpatenio.
Florian Quèze <florian@queze.net> - Wed, 17 Nov 2021 18:37:43 +0000 - rev 599475
Push 38986 by smolnar@mozilla.com at Wed, 17 Nov 2021 21:41:26 +0000
Bug 1741235 - Merge the 'Firefox Front-End' and 'Firefox Platform' profiler presets, r=julienw,fluent-reviewers,nbaumgardner,kpatenio. Differential Revision: https://phabricator.services.mozilla.com/D131158
8b8063ff6d190dd75b87c743174f13f9bda6f223: Bug 1738129 - fix Save Link As... for PDF files to show save dialog with downloads improvements pref enabled. r=Gijs,mtigley
Katherine Patenio <kpatenio@mozilla.com> - Wed, 17 Nov 2021 18:35:44 +0000 - rev 599474
Push 38986 by smolnar@mozilla.com at Wed, 17 Nov 2021 21:41:26 +0000
Bug 1738129 - fix Save Link As... for PDF files to show save dialog with downloads improvements pref enabled. r=Gijs,mtigley Differential Revision: https://phabricator.services.mozilla.com/D131310
220f3305e900ec52f872a63b204f6a3b71f0e7d4: Bug 1671252 - Move Windows accent border to #navigator-toolbox. r=Gijs
Emilio Cobos Alvarez <emilio@mozilla.com> - Wed, 17 Nov 2021 18:30:17 +0000 - rev 599473
Push 38986 by smolnar@mozilla.com at Wed, 17 Nov 2021 21:41:26 +0000
Bug 1671252 - Move Windows accent border to #navigator-toolbox. r=Gijs This works correctly. On the root it seems we hit this codepath: https://searchfox.org/mozilla-central/rev/df18dd52da04ee2bad434b0ba2d9fcb196d4d15e/layout/xul/nsBoxFrame.cpp#514-525 And end up with an slightly-bigger-than-needed box. I haven't dug into what changing this may entail, but given the root frame is special anyways (because it affects window constraints etc) it's probably safer to do this. Differential Revision: https://phabricator.services.mozilla.com/D131421
3a3c8e058d2f25ef7e8df30b825781539b4fa16b: Backed out changeset c859ac601495 (bug 1737157) for causing xpc failures in glean/tests/xpcshell/test_FOGPrefs. CLOSED TREE
Sandor Molnar <smolnar@mozilla.com> - Wed, 17 Nov 2021 20:21:26 +0200 - rev 599472
Push 38986 by smolnar@mozilla.com at Wed, 17 Nov 2021 21:41:26 +0000
Backed out changeset c859ac601495 (bug 1737157) for causing xpc failures in glean/tests/xpcshell/test_FOGPrefs. CLOSED TREE
30ef1f19b746c3e44ef3c9069c83e916d94f9387: Bug 1740089 - Fall back to frame (accentcolor) to determine toolbar theme. r=desktop-theme-reviewers,harry
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Nov 2021 18:05:19 +0000 - rev 599471
Push 38986 by smolnar@mozilla.com at Wed, 17 Nov 2021 21:41:26 +0000
Bug 1740089 - Fall back to frame (accentcolor) to determine toolbar theme. r=desktop-theme-reviewers,harry Depends on D130669 Differential Revision: https://phabricator.services.mozilla.com/D130670
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip