78d93dade802d5a285fe718284310a397be97acb: Bug 1510460 - Record the current WindowGlobal on ChromeBrowsingContext, r=farre
Nika Layzell <nika@thelayzells.com> - Tue, 27 Nov 2018 15:03:05 -0500 - rev 449372
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1510460 - Record the current WindowGlobal on ChromeBrowsingContext, r=farre Differential Revision: https://phabricator.services.mozilla.com/D13156
7e23a1b903356b3bdfbf1844bee62513969b93a6: Bug 1509362 - Don't crash when constructing actor during content shutdown, r=jld
Nika Layzell <nika@thelayzells.com> - Thu, 22 Nov 2018 13:40:32 -0500 - rev 449371
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1509362 - Don't crash when constructing actor during content shutdown, r=jld When shutting down a content process, we call `Close` on the `IToplevelProtocol`. This causes the MessageChannel to be `Close`-ed, which in turn sends a `GOODBYE_MESSAGE`: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/ipc/glue/MessageChannel.cpp#2852 This message is intercepted on the I/O thread in the content process, before any code is informed in content, and used to set the `mChannelState` property to `ChannelClosing`: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/ipc/glue/MessageChannel.cpp#1176 Once this state has been set, which is performed as soon as the message is received, whether or not other messages have been processed yet, no messages can be sent back to the parent process. This is usually what causes the 'Too late to send/recv' message spam in the console, as we're still trying to send messages at this time. Usually this is fine - the message send fails, but we gracefully recover, and the process begins shutting down like normal. Unfortunately, child actor constructors currently have code automatically generated in them which causes a process crash if the send fails. As it's impossible for the main thread to know that the channel has been closed ahead of time (due to this happening out-of-band), we can then cause random content process crashes during shutdown due to actor construction. Unfortunately, we can't just destroy the actor, as our caller may (and often do) depend on the actor reference they gave us still being valid after calling Send*Constructor. Fortunately, if a message send failed, it means we're in the process of being shut down. This patch handles this by ignoring ctor send errors, and treating them like messages which successfully were queued to send, but got lost due to the other side hanging up. The actor will be gracefully destroyed in DestroySubtree when its manager is destroyed. Differential Revision: https://phabricator.services.mozilla.com/D12695
9fe159adaef4b0ab58cf16969f70a75e4ef2e546: Bug 1500950 - Expose rootFrameLoader on WindowGlobalParent, r=farre
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 19:39:02 -0400 - rev 449370
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1500950 - Expose rootFrameLoader on WindowGlobalParent, r=farre This attribute was not exposed due to Bug 1489301. Differential Revision: https://phabricator.services.mozilla.com/D9404
622d4bf1c0efe87d3128bc89903cb515487d69f4: Bug 1500949 - Include innerWindowId/outerWindowId in PWindowGlobal, r=farre
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 16:04:00 -0400 - rev 449369
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1500949 - Include innerWindowId/outerWindowId in PWindowGlobal, r=farre This will be useful as both an ID for PWindowGlobal, as well as a mechanism for taking advantage of already synchronized information. As an example, LoadInfo objects contain the inner window IDs of the window requesting the load, which can now be used to obtain a reference to the corresponding WindowGlobalParent in the parent process. Differential Revision: https://phabricator.services.mozilla.com/D9396
8f8c74fb660dd36cf873f9aa82c3487aea951876: Bug 1500948 - Expose BrowsingContext on nsFrameLoader objects, r=farre
Nika Layzell <nika@thelayzells.com> - Fri, 19 Oct 2018 20:02:37 -0400 - rev 449368
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1500948 - Expose BrowsingContext on nsFrameLoader objects, r=farre This should make BrowsingContext more usable by making it much easier to obtain for a given frame or browser. BrowsingContext and nsFrameLoader should have the same lifetime. Differential Revision: https://phabricator.services.mozilla.com/D9395
b4617d90fd5527c145b5a11d11553b22eaae15f6: Bug 1500944 - Part 2: Expose WindowGlobal actors to Chrome JS, r=farre
Nika Layzell <nika@thelayzells.com> - Fri, 19 Oct 2018 19:02:56 -0400 - rev 449367
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1500944 - Part 2: Expose WindowGlobal actors to Chrome JS, r=farre This serves 2 purposes: 1. Provides an object corresponding to an inner window which Chrome JS can hold onto. 2. Provides the object to JS which Chrome JS per-window actors will be attached to. 3. Provides useful information to Chrome JS in the parent process. Differential Revision: https://phabricator.services.mozilla.com/D9394
3978df88b38b739e0e2754436b9e29bac82e5cc1: Bug 1500944 - Part 1: Store the set of active WindowGlobalParent objects in ChromeBrowsingContext, r=farre
Nika Layzell <nika@thelayzells.com> - Fri, 19 Oct 2018 18:00:59 -0400 - rev 449366
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1500944 - Part 1: Store the set of active WindowGlobalParent objects in ChromeBrowsingContext, r=farre This allows getting the set of all window globals for a given browsing context. This is less useful at the moment as the active window global is not exposed as such. That will be added as a follow-up. Differential Revision: https://phabricator.services.mozilla.com/D9393
7a1bb48d843f4396e6d95f3cdda5dd7c70292974: Bug 1487249 - Part 3: Add the WindowGlobal actor representing a single window global, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Wed, 29 Aug 2018 18:21:25 -0400 - rev 449365
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1487249 - Part 3: Add the WindowGlobal actor representing a single window global, r=bzbarsky This actor can be used for communicating with individual frames, without depending on walking the tree in the content process. This is not yet complete. No tests have been written for it, the WindowGlobalParent objects need to be exposed to chrome JS, and a form of JS actors should be installed under them. In addition, BrowsingContextChrome objects should be updated to allow access to the current WindowGlobalParent in that context. Differential Revision: https://phabricator.services.mozilla.com/D4623
ba592aebdba2586dd7dd36b7940912fc5cdf5357: Bug 1487249 - Part 2: Add a new PInProcess actor to manage intra-thread actors, r=mccr8
Nika Layzell <nika@thelayzells.com> - Wed, 29 Aug 2018 18:18:04 -0400 - rev 449364
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1487249 - Part 2: Add a new PInProcess actor to manage intra-thread actors, r=mccr8 This will be useful as a basis for asynchronous actors which would like to exist both when crossing the process boundary (managed by PContent), and when displaying an in-process window. Differential Revision: https://phabricator.services.mozilla.com/D4622
a6604d042a9661b0eedd27f3a2095a56a5097ba5: Bug 1487249 - Part 1: Allow MessageChannel objects to be created within a thread, r=mccr8
Nika Layzell <nika@thelayzells.com> - Wed, 29 Aug 2018 18:00:05 -0400 - rev 449363
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1487249 - Part 1: Allow MessageChannel objects to be created within a thread, r=mccr8 To create a more generic interface for interacting both within the main thread of the parent process and between the parent and child processes, it would be nice to support IPDL actors within the main thread of the parent process. This requires the underlying MessageChannel actor to support intra-thread links. This change adds support for intra-thread links to the underlying MessageChannel object using ThreadLink, and an extra boolean flag. Differential Revision: https://phabricator.services.mozilla.com/D4620
84c1e131a7fa6ff30388ecf0a08d51479fe2c5a5: Bug 1511963 - Fix reference in contain-layout-suppress-baseline-002.html r=emilio
Manuel Rego Casasnovas <rego@igalia.com> - Tue, 04 Dec 2018 04:24:00 +0200 - rev 449362
Push 35159 by csabou@mozilla.com at Wed, 05 Dec 2018 10:20:00 +0000
Bug 1511963 - Fix reference in contain-layout-suppress-baseline-002.html r=emilio It was pointing to contain-layout-suppress-baseline-001-ref.html but the correct one is contain-layout-suppress-baseline-002-ref.html.
f1f136ea674c759c22ad7c13b547ca08bd25b147: Backed out 2 changesets (bug 1508726) as requested by whimboo for TestMarionette.test_application_update_disabled permafails.
Cosmin Sabou <csabou@mozilla.com> - Wed, 05 Dec 2018 09:49:46 +0200 - rev 449361
Push 35158 by csabou@mozilla.com at Wed, 05 Dec 2018 10:19:05 +0000
Backed out 2 changesets (bug 1508726) as requested by whimboo for TestMarionette.test_application_update_disabled permafails. Backed out changeset 5c59407599f6 (bug 1508726) Backed out changeset 766ba8a6c875 (bug 1508726)
49bd1dd914a4a9d8c8b546dc503b6ae715d6e98c: Backed out 6 changesets (bug 1504756) for wpt failures on webdriver/tests/execute_script/promise.py
Cosmin Sabou <csabou@mozilla.com> - Wed, 05 Dec 2018 08:33:46 +0200 - rev 449360
Push 35158 by csabou@mozilla.com at Wed, 05 Dec 2018 10:19:05 +0000
Backed out 6 changesets (bug 1504756) for wpt failures on webdriver/tests/execute_script/promise.py Backed out changeset d808b528532a (bug 1504756) Backed out changeset 30d345cce5be (bug 1504756) Backed out changeset a8ea6d01fbe1 (bug 1504756) Backed out changeset ba627a1b61dc (bug 1504756) Backed out changeset c90e4b2e1b28 (bug 1504756) Backed out changeset 04da1f01afba (bug 1504756)
38b4e8f428f7f41feca673ee8833733f27a37460: Backed out 2 changesets (bug 1504659) for browser_scroll.js failures CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Wed, 05 Dec 2018 06:57:03 +0200 - rev 449359
Push 35158 by csabou@mozilla.com at Wed, 05 Dec 2018 10:19:05 +0000
Backed out 2 changesets (bug 1504659) for browser_scroll.js failures CLOSED TREE Backed out changeset bcebb3fd72d3 (bug 1504659) Backed out changeset 1dbe3852e298 (bug 1504659)
bcebb3fd72d3cec5ce1cb7478d7f7aeb3cffca09: Bug 1504659 Part 2: Add tests of viewport RDM scroll behavior, with and without touch simulation. r=gl
Brad Werth <bwerth@mozilla.com> - Wed, 05 Dec 2018 02:48:46 +0000 - rev 449358
Push 35158 by csabou@mozilla.com at Wed, 05 Dec 2018 10:19:05 +0000
Bug 1504659 Part 2: Add tests of viewport RDM scroll behavior, with and without touch simulation. r=gl Differential Revision: https://phabricator.services.mozilla.com/D13174
1dbe3852e298dd4bc918c3139ee8ef2ee4e1da96: Bug 1504659 Part 1: Make RefreshVisualViewportSize allow non-APZ zooming, and call it during RefreshViewportSize. r=botond
Brad Werth <bwerth@mozilla.com> - Wed, 05 Dec 2018 02:55:25 +0000 - rev 449357
Push 35158 by csabou@mozilla.com at Wed, 05 Dec 2018 10:19:05 +0000
Bug 1504659 Part 1: Make RefreshVisualViewportSize allow non-APZ zooming, and call it during RefreshViewportSize. r=botond Differential Revision: https://phabricator.services.mozilla.com/D13173
269d79ff36b604dd349b76b756dd1883baa35244: Backed out 2 changesets (bug 1512052)for causing build bustages CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Wed, 05 Dec 2018 05:47:39 +0200 - rev 449356
Push 35158 by csabou@mozilla.com at Wed, 05 Dec 2018 10:19:05 +0000
Backed out 2 changesets (bug 1512052)for causing build bustages CLOSED TREE Backed out changeset 4773a3f46c22 (bug 1512052) Backed out changeset 2f48c5afbe57 (bug 1512052)
5d3409288ae324ded0a1f76c9c3332c774ddf311: Backed out changeset 38acabd3b5b8 (bug 1507360) for causing tasks that run in docker to fail CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Wed, 05 Dec 2018 04:39:31 +0200 - rev 449355
Push 35158 by csabou@mozilla.com at Wed, 05 Dec 2018 10:19:05 +0000
Backed out changeset 38acabd3b5b8 (bug 1507360) for causing tasks that run in docker to fail CLOSED TREE
4773a3f46c225d5c62f1773e68bf3f907c1ac30e: Bug 1512052 - Add more .eslintrc.js files for test directories. r=mossop
Mark Banner <standard8@mozilla.com> - Tue, 04 Dec 2018 22:27:35 +0000 - rev 449354
Push 35158 by csabou@mozilla.com at Wed, 05 Dec 2018 10:19:05 +0000
Bug 1512052 - Add more .eslintrc.js files for test directories. r=mossop Depends on D13745 Differential Revision: https://phabricator.services.mozilla.com/D13746
2f48c5afbe570e3ce027c45b03fc88a6d0fe1312: Bug 1512052 - Update some directories in .eslintignore, and correct a few .eslintrc.js files. r=mossop
Mark Banner <standard8@mozilla.com> - Tue, 04 Dec 2018 22:27:02 +0000 - rev 449353
Push 35158 by csabou@mozilla.com at Wed, 05 Dec 2018 10:19:05 +0000
Bug 1512052 - Update some directories in .eslintignore, and correct a few .eslintrc.js files. r=mossop Differential Revision: https://phabricator.services.mozilla.com/D13745
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip